91595 2012-07-18 00:17:32 -0700 [Texmap] Make TextureMapperLayer clip m_state.needsDisplayRect with the layerRect. 2012-07-18 08:13:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 dongseong.hwang webkit-unassigned mrobinson noam skyul oldest_to_newest 672066 0 dongseong.hwang 2012-07-18 00:17:32 -0700 Currently, TextureMapperLayer creates a imageBuffer as big as m_state.needsDisplayRect. The size of m_state.needsDisplayRect can be bigger than the size of the layerRect, so we may consumed the memory more than the size of the layerRect. This patch makes TextureMapperLayer save the memory. 672068 1 152948 dongseong.hwang 2012-07-18 00:19:40 -0700 Created attachment 152948 Patch 672071 2 dongseong.hwang 2012-07-18 00:23:50 -0700 When I tested in http://www.satine.org/research/webkit/snowleopard/snowstack.html , m_state.needsDisplayRect was {m_location = {m_x = 97623, m_y = 20744}, m_size = {m_width = 43797, m_height = 26438}} and WebKit crashed. I don't know why RenderLayerBacking notifies too big dirtyRect to GraphicsLayer. 672390 3 152948 skyul 2012-07-18 08:13:45 -0700 Comment on attachment 152948 Patch Clearing flags on attachment: 152948 Committed r122975: <http://trac.webkit.org/changeset/122975> 672391 4 skyul 2012-07-18 08:13:54 -0700 All reviewed patches have been landed. Closing bug. 152948 2012-07-18 00:19:40 -0700 2012-07-18 08:13:44 -0700 Patch bug-91595-20120718161920.patch text/plain 2081 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDAxZjFjMGNlYmY3ODhm ODFlNmQzM2M3OGQ4YzVjOTZhYjA1ZTYwNS4uNjU4ZTA2NzA2YjBkOWUzNGI1YWRlNDBhNTAxMDBl MTcxMTAzZDBjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTE4ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIFtUZXhtYXBd IE1ha2UgVGV4dHVyZU1hcHBlckxheWVyIGNsaXAgbV9zdGF0ZS5uZWVkc0Rpc3BsYXlSZWN0IHdp dGggdGhlIGxheWVyUmVjdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkxNTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW50ZXJuYWwgcmV2aWV3IGJ5IEt3YW5nIFl1bCBTZW8uCisKKyAgICAgICAgQ3Vy cmVudGx5LCBUZXh0dXJlTWFwcGVyTGF5ZXIgY3JlYXRlcyBhbiBJbWFnZUJ1ZmZlciBhcyBiaWcg YXMKKyAgICAgICAgbV9zdGF0ZS5uZWVkc0Rpc3BsYXlSZWN0IGlmIG1fc3RhdGUubmVlZHNEaXNw YWx5IGlzIGZhbHNlLiBUaGUgc2l6ZSBvZgorICAgICAgICBtX3N0YXRlLm5lZWRzRGlzcGxheVJl Y3QgY2FuIGJlIGJpZ2dlciB0aGFuIHRoZSBzaXplIG9mIHRoZSBsYXllclJlY3QsIHNvIHdlIG1h eQorICAgICAgICBjb25zdW1lIG1vcmUgbWVtb3J5IHRoYW4gdGhlIHNpemUgb2YgdGhlIGxheWVy UmVjdC4gSXQgZXZlbiBjYW4gY2F1c2UgY3Jhc2ggaWYKKyAgICAgICAgbV9zdGF0ZS5uZWVkc0Rp c3BsYXlSZWN0IGlzIHRvbyBiaWcuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1Rl eHR1cmVNYXBwZXJMYXllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJlTWFwcGVyTGF5 ZXI6OnVwZGF0ZUJhY2tpbmdTdG9yZSk6CisKIDIwMTItMDctMTcgIEh1YW5nIERvbmdzdW5nICA8 bHV4dGVsbGFAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgTWFrZSBDU1MgYm94IG1vZGVsIGJh Y2tncm91bmQsIGJvcmRlciBhbmQgbWFzayBiZSBkZWNvZGVkIGJ5IHBhcmFsbGVsIGltYWdlIGRl Y29kZXJzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJMYXllci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAppbmRleCBjZGQ0OTUyMDE3MzhlYTYy MWFiNjU4MTMyM2UzZjFjYzhmMDEwZGZmLi5jZjg4MDA5YmUyNjRhNDU1ZmIzMzZlMmViMTQ0ZDQz YTk4ZmZkOWI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckxheWVyLmNwcApAQCAtMTA4LDcgKzEwOCw5 IEBAIHZvaWQgVGV4dHVyZU1hcHBlckxheWVyOjp1cGRhdGVCYWNraW5nU3RvcmUoVGV4dHVyZU1h cHBlciogdGV4dHVyZU1hcHBlciwgR3JhcGhpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAg ICBJbnRSZWN0IGRpcnR5UmVjdCA9IGVuY2xvc2luZ0ludFJlY3QobV9zdGF0ZS5uZWVkc0Rpc3Bs YXkgPyBsYXllclJlY3QoKSA6IG1fc3RhdGUubmVlZHNEaXNwbGF5UmVjdCk7CisgICAgSW50UmVj dCBkaXJ0eVJlY3QgPSBlbmNsb3NpbmdJbnRSZWN0KGxheWVyUmVjdCgpKTsKKyAgICBpZiAoIW1f c3RhdGUubmVlZHNEaXNwbGF5KQorICAgICAgICBkaXJ0eVJlY3QuaW50ZXJzZWN0KGVuY2xvc2lu Z0ludFJlY3QobV9zdGF0ZS5uZWVkc0Rpc3BsYXlSZWN0KSk7CiAgICAgaWYgKGRpcnR5UmVjdC5p c0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAo=