91587 2012-07-17 23:26:17 -0700 REGRESSION(r122345): HTMLCollection::length() sometimes returns a wrong value 2012-07-18 01:16:51 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 91335 91571 1 rniwa rniwa andersca kling koivisto ojan webkit.review.bot oldest_to_newest 672021 0 rniwa 2012-07-17 23:26:17 -0700 Due to a bug in HTMLCollection::itemBeforeOrAfterCachedItem, HTMLCollection::length may return a wrong value (1 less than the actual length) sometimes on any port that uses V8 bindings or Objective-C bindings. This problem doesn't reproduce with JSC bindings because we call length() first and that sets the correct cached value. http://code.google.com/p/chromium/issues/detail?id=137488 672030 1 152939 rniwa 2012-07-17 23:39:08 -0700 Created attachment 152939 Fixes the bug 672036 2 152941 rniwa 2012-07-17 23:44:52 -0700 Created attachment 152941 Updated for ToT 672043 3 152943 rniwa 2012-07-17 23:50:59 -0700 Created attachment 152943 Fixed per benjaminp's comment on IRC 672046 4 152943 benjamin 2012-07-17 23:54:12 -0700 Comment on attachment 152943 Fixed per benjaminp's comment on IRC offsetOfLastItem + 1 seems reasonable :) 672053 5 rniwa 2012-07-18 00:00:18 -0700 *** Bug 91413 has been marked as a duplicate of this bug. *** 672111 6 152943 webkit.review.bot 2012-07-18 01:16:44 -0700 Comment on attachment 152943 Fixed per benjaminp's comment on IRC Clearing flags on attachment: 152943 Committed r122930: <http://trac.webkit.org/changeset/122930> 672112 7 webkit.review.bot 2012-07-18 01:16:51 -0700 All reviewed patches have been landed. Closing bug. 152939 2012-07-17 23:39:08 -0700 2012-07-17 23:44:48 -0700 Fixes the bug bug-91587-20120717233908.patch text/plain 4466 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjkyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA3LTE3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEyMjM0NSk6 IEhUTUxDb2xsZWN0aW9uOjpsZW5ndGgoKSBzb21ldGltZXMgcmV0dXJucyBhIHdyb25nIHZhbHVl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTU4Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWcg d2FzIGNhdXNlZCBieSBteSBkb3VjaGV5IGNvZGUgdGhhdCBzZXQgdGhlIGxlbmd0aCBjYWNoZSB0 byBiZSB0aGUgKm9mZnNldCoKKyAgICAgICAgb2YgdGhlIGxhc3QgaXRlbSBpbiBhIEhUTUxDb2xs ZWN0aW9uLiBDbGVhcmx5LCB0aGUgbGVuZ3RoIG9mIGEgY29sbGVjdGlvbiB0aGF0IGNvbnRhaW5z CisgICAgICAgIHRoZSBsYXN0IGl0ZW0gYXQgb2Zmc2V0IG4gaXMgbiArIDEuIEZpeGVkIHRoYXQu CisKKyAgICAgICAgQWxzbyByZW1vdmVkIHRoZSBjYWxsIHRvIHNldExlbmd0aENhY2hlIGluIEhU TUxDb2xsZWN0aW9uOjpsZW5ndGggc2luY2UgaXQgbXVzdCBoYXZlIHNldAorICAgICAgICBieSBw cmV2aW91cyBjYWxscyB0byBpdGVtQmVmb3JlT3JBZnRlckNhY2hlZEl0ZW0gYWxyZWFkeS4gVGhp cyB3aWxsIGFsbG93IHVzIHRvIGNhdGNoCisgICAgICAgIHJlZ3Jlc3Npb25zIGxpa2UgdGhpcyBp biBwb3J0cyB0aGF0IHVzZSBKU0MgYmluZGluZ3MgYXMgd2VsbC4KKworICAgICAgICBUZXN0OiBm YXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS5odG1sCisKKyAgICAgICAg KiBodG1sL0hUTUxDb2xsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb2xsZWN0 aW9uOjpsZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENvbGxlY3Rpb246Oml0ZW1CZWZv cmVPckFmdGVyQ2FjaGVkSXRlbSk6CisKIDIwMTItMDctMTcgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2ViIEluc3BlY3Rvcjog Zm9sbG93dXAgZml4IGZvciByMTIyOTIwLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M Q29sbGVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29s bGVjdGlvbi5jcHAJKHJldmlzaW9uIDEyMjY4NikKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TENvbGxlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDgsOCArMzA4LDggQEAgdW5zaWdu ZWQgSFRNTENvbGxlY3Rpb246Omxlbmd0aCgpIGNvbnN0CiAgICAgZG8gewogICAgICAgICBvZmZz ZXQrKzsKICAgICB9IHdoaWxlIChpdGVtQmVmb3JlT3JBZnRlckNhY2hlZEl0ZW0ob2Zmc2V0KSk7 CisgICAgQVNTRVJUKGlzTGVuZ3RoQ2FjaGVWYWxpZCgpKTsKIAotICAgIHNldExlbmd0aENhY2hl KG9mZnNldCk7CiAgICAgcmV0dXJuIG9mZnNldDsKIH0KIApAQCAtMzgxLDcgKzM4MSw3IEBAIEVs ZW1lbnQqIEhUTUxDb2xsZWN0aW9uOjppdGVtQmVmb3JlT3JBZnQKICAgICAgICAgfQogICAgIH0K IAotICAgIHNldExlbmd0aENhY2hlKGN1cnJlbnRPZmZzZXQpOworICAgIHNldExlbmd0aENhY2hl KGN1cnJlbnRPZmZzZXQgKyAxKTsKIAogICAgIHJldHVybiAwOwogfQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMTIyOTIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTItMDctMTcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTIyMzQ1KTogSFRNTENvbGxlY3Rpb246Omxlbmd0aCgp IHNvbWV0aW1lcyByZXR1cm5zIGEgd3JvbmcgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiB0ZXN0LiBJdCBvbmx5IGZh aWxzIG9uIENocm9taXVtIHBvcnQgYmVmb3JlIHRoZSBwYXRjaCBpcyBhcHBsaWVkIGJlY2F1c2Ug SlNDIGJpbmRpbmcgY29kZQorICAgICAgICBoYXMgYSBidWcgKD8pIHRoYXQgaXQgYWx3YXlzIGNo ZWNrcyBpbmRleCA+IGxlbmd0aCgpIHRvIHRocm93IGFuIGV4Y2VwdGlvbiBiZWZvcmUgYWNjZXNz aW5nIGFuIGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24uCisKKyAgICAgICAgKiBmYXN0L2RvbS9odG1s Y29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZG9tL2h0bWxjb2xsZWN0aW9uLWxlbmd0aC1hZnRlci1pdGVtLmh0bWw6IEFkZGVk LgorCiAyMDEyLTA3LTE3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggYW4gYXNzZXJ0aW9uIGZhaWx1cmUgaW4gQ2FsZW5kYXJQaWNrZXJFbGVtZW50Ojpo b3N0SW5wdXQoKS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2h0bWxjb2xsZWN0aW9uLWxl bmd0aC1hZnRlci1pdGVtLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgt YWZ0ZXItaXRlbS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOSBAQAorVGhp cyB0ZXN0cyBhY2Nlc3NpbmcgdGhlIGxlbmd0aCBhZnRlciBhY2Nlc3NpbmcgKGxlbmd0aCArIDEp LXRoIGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24gZG9lc24ndCBjYWNoZSBhIHdyb25nIGxlbmd0aC4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgY2hpbGRyZW4gPSBjb250YWlu ZXIuY2hpbGRyZW47IGNoaWxkcmVuLmxlbmd0aCBpcyAwCitQQVNTIGNvbnRhaW5lci5hcHBlbmRD aGlsZChzcGFuKTsgY2hpbGRyZW5bMV07IGNoaWxkcmVuLmxlbmd0aCBpcyAxCitQQVNTIGNvbnRh aW5lci5yZW1vdmVDaGlsZChzcGFuKTsgY2hpbGRyZW4ubGVuZ3RoIGlzIDAKKwpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9kb20vaHRtbGNvbGxlY3Rpb24tbGVuZ3RoLWFmdGVyLWl0ZW0uaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgt YWZ0ZXItaXRlbS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vaHRt bGNvbGxlY3Rpb24tbGVuZ3RoLWFmdGVyLWl0ZW0uaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4u L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitkZXNj cmlwdGlvbigiVGhpcyB0ZXN0cyBhY2Nlc3NpbmcgdGhlIGxlbmd0aCBhZnRlciBhY2Nlc3Npbmcg KGxlbmd0aCArIDEpLXRoIGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24gZG9lc24ndCBjYWNoZSBhIHdy b25nIGxlbmd0aC4iKTsKKwordmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J2RpdicpOwordmFyIHNwYW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJyk7Cit2YXIg Y2hpbGRyZW47CitzaG91bGRCZSgiY2hpbGRyZW4gPSBjb250YWluZXIuY2hpbGRyZW47IGNoaWxk cmVuLmxlbmd0aCIsICIwIik7CitzaG91bGRCZSgiY29udGFpbmVyLmFwcGVuZENoaWxkKHNwYW4p OyBjaGlsZHJlblsxXTsgY2hpbGRyZW4ubGVuZ3RoIiwgIjEiKTsKK3Nob3VsZEJlKCJjb250YWlu ZXIucmVtb3ZlQ2hpbGQoc3Bhbik7IGNoaWxkcmVuLmxlbmd0aCIsICIwIik7CisKKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgo= 152941 2012-07-17 23:44:52 -0700 2012-07-17 23:50:54 -0700 Updated for ToT bug-91587-20120717234451.patch text/plain 4466 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjkyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA3LTE3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEyMjM0NSk6 IEhUTUxDb2xsZWN0aW9uOjpsZW5ndGgoKSBzb21ldGltZXMgcmV0dXJucyBhIHdyb25nIHZhbHVl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTU4Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWcg d2FzIGNhdXNlZCBieSBteSBkb3VjaGV5IGNvZGUgdGhhdCBzZXQgdGhlIGxlbmd0aCBjYWNoZSB0 byBiZSB0aGUgKm9mZnNldCoKKyAgICAgICAgb2YgdGhlIGxhc3QgaXRlbSBpbiBhIEhUTUxDb2xs ZWN0aW9uLiBDbGVhcmx5LCB0aGUgbGVuZ3RoIG9mIGEgY29sbGVjdGlvbiB0aGF0IGNvbnRhaW5z CisgICAgICAgIHRoZSBsYXN0IGl0ZW0gYXQgb2Zmc2V0IG4gaXMgbiArIDEuIEZpeGVkIHRoYXQu CisKKyAgICAgICAgQWxzbyByZW1vdmVkIHRoZSBjYWxsIHRvIHNldExlbmd0aENhY2hlIGluIEhU TUxDb2xsZWN0aW9uOjpsZW5ndGggc2luY2UgaXQgbXVzdCBoYXZlIHNldAorICAgICAgICBieSBw cmV2aW91cyBjYWxscyB0byBpdGVtQmVmb3JlT3JBZnRlckNhY2hlZEl0ZW0gYWxyZWFkeS4gVGhp cyB3aWxsIGFsbG93IHVzIHRvIGNhdGNoCisgICAgICAgIHJlZ3Jlc3Npb25zIGxpa2UgdGhpcyBp biBwb3J0cyB0aGF0IHVzZSBKU0MgYmluZGluZ3MgYXMgd2VsbC4KKworICAgICAgICBUZXN0OiBm YXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS5odG1sCisKKyAgICAgICAg KiBodG1sL0hUTUxDb2xsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb2xsZWN0 aW9uOjpsZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENvbGxlY3Rpb246Oml0ZW1CZWZv cmVPckFmdGVyQ2FjaGVkSXRlbSk6CisKIDIwMTItMDctMTcgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2ViIEluc3BlY3Rvcjog Zm9sbG93dXAgZml4IGZvciByMTIyOTIwLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M Q29sbGVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29s bGVjdGlvbi5jcHAJKHJldmlzaW9uIDEyMjkyMSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TENvbGxlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjQsOCArMzI0LDggQEAgdW5zaWdu ZWQgSFRNTENvbGxlY3Rpb246Omxlbmd0aCgpIGNvbnN0CiAgICAgZG8gewogICAgICAgICBvZmZz ZXQrKzsKICAgICB9IHdoaWxlIChpdGVtQmVmb3JlT3JBZnRlckNhY2hlZEl0ZW0ob2Zmc2V0KSk7 CisgICAgQVNTRVJUKGlzTGVuZ3RoQ2FjaGVWYWxpZCgpKTsKIAotICAgIHNldExlbmd0aENhY2hl KG9mZnNldCk7CiAgICAgcmV0dXJuIG9mZnNldDsKIH0KIApAQCAtMzk3LDcgKzM5Nyw3IEBAIEVs ZW1lbnQqIEhUTUxDb2xsZWN0aW9uOjppdGVtQmVmb3JlT3JBZnQKICAgICAgICAgfQogICAgIH0K IAotICAgIHNldExlbmd0aENhY2hlKGN1cnJlbnRPZmZzZXQpOworICAgIHNldExlbmd0aENhY2hl KGN1cnJlbnRPZmZzZXQgKyAxKTsKIAogICAgIHJldHVybiAwOwogfQpJbmRleDogTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNp b24gMTIyOTIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTItMDctMTcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTIyMzQ1KTogSFRNTENvbGxlY3Rpb246Omxlbmd0aCgp IHNvbWV0aW1lcyByZXR1cm5zIGEgd3JvbmcgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiB0ZXN0LiBJdCBvbmx5IGZh aWxzIG9uIENocm9taXVtIHBvcnQgYmVmb3JlIHRoZSBwYXRjaCBpcyBhcHBsaWVkIGJlY2F1c2Ug SlNDIGJpbmRpbmcgY29kZQorICAgICAgICBoYXMgYSBidWcgKD8pIHRoYXQgaXQgYWx3YXlzIGNo ZWNrcyBpbmRleCA+IGxlbmd0aCgpIHRvIHRocm93IGFuIGV4Y2VwdGlvbiBiZWZvcmUgYWNjZXNz aW5nIGFuIGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24uCisKKyAgICAgICAgKiBmYXN0L2RvbS9odG1s Y29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZG9tL2h0bWxjb2xsZWN0aW9uLWxlbmd0aC1hZnRlci1pdGVtLmh0bWw6IEFkZGVk LgorCiAyMDEyLTA3LTE3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBGaXggYW4gYXNzZXJ0aW9uIGZhaWx1cmUgaW4gQ2FsZW5kYXJQaWNrZXJFbGVtZW50Ojpo b3N0SW5wdXQoKS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2h0bWxjb2xsZWN0aW9uLWxl bmd0aC1hZnRlci1pdGVtLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9m YXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgt YWZ0ZXItaXRlbS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOSBAQAorVGhp cyB0ZXN0cyBhY2Nlc3NpbmcgdGhlIGxlbmd0aCBhZnRlciBhY2Nlc3NpbmcgKGxlbmd0aCArIDEp LXRoIGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24gZG9lc24ndCBjYWNoZSBhIHdyb25nIGxlbmd0aC4K KworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywg Zm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgY2hpbGRyZW4gPSBjb250YWlu ZXIuY2hpbGRyZW47IGNoaWxkcmVuLmxlbmd0aCBpcyAwCitQQVNTIGNvbnRhaW5lci5hcHBlbmRD aGlsZChzcGFuKTsgY2hpbGRyZW5bMV07IGNoaWxkcmVuLmxlbmd0aCBpcyAxCitQQVNTIGNvbnRh aW5lci5yZW1vdmVDaGlsZChzcGFuKTsgY2hpbGRyZW4ubGVuZ3RoIGlzIDAKKwpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9kb20vaHRtbGNvbGxlY3Rpb24tbGVuZ3RoLWFmdGVyLWl0ZW0uaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgt YWZ0ZXItaXRlbS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vaHRt bGNvbGxlY3Rpb24tbGVuZ3RoLWFmdGVyLWl0ZW0uaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwxOCBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4u L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitkZXNj cmlwdGlvbigiVGhpcyB0ZXN0cyBhY2Nlc3NpbmcgdGhlIGxlbmd0aCBhZnRlciBhY2Nlc3Npbmcg KGxlbmd0aCArIDEpLXRoIGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24gZG9lc24ndCBjYWNoZSBhIHdy b25nIGxlbmd0aC4iKTsKKwordmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo J2RpdicpOwordmFyIHNwYW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJyk7Cit2YXIg Y2hpbGRyZW47CitzaG91bGRCZSgiY2hpbGRyZW4gPSBjb250YWluZXIuY2hpbGRyZW47IGNoaWxk cmVuLmxlbmd0aCIsICIwIik7CitzaG91bGRCZSgiY29udGFpbmVyLmFwcGVuZENoaWxkKHNwYW4p OyBjaGlsZHJlblsxXTsgY2hpbGRyZW4ubGVuZ3RoIiwgIjEiKTsKK3Nob3VsZEJlKCJjb250YWlu ZXIucmVtb3ZlQ2hpbGQoc3Bhbik7IGNoaWxkcmVuLmxlbmd0aCIsICIwIik7CisKKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgo= 152943 2012-07-17 23:50:59 -0700 2012-07-18 01:16:44 -0700 Fixed per benjaminp's comment on IRC bug-91587-20120717235059.patch text/plain 4517 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjkyMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA3LTE3ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEyMjM0NSk6 IEhUTUxDb2xsZWN0aW9uOjpsZW5ndGgoKSBzb21ldGltZXMgcmV0dXJucyBhIHdyb25nIHZhbHVl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTU4Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBidWcg d2FzIGNhdXNlZCBieSBteSBkb3VjaGV5IGNvZGUgdGhhdCBzZXQgdGhlIGxlbmd0aCBjYWNoZSB0 byBiZSB0aGUgKm9mZnNldCoKKyAgICAgICAgb2YgdGhlIGxhc3QgaXRlbSBpbiBhIEhUTUxDb2xs ZWN0aW9uLiBDbGVhcmx5LCB0aGUgbGVuZ3RoIG9mIGEgY29sbGVjdGlvbiB0aGF0IGNvbnRhaW5z CisgICAgICAgIHRoZSBsYXN0IGl0ZW0gYXQgb2Zmc2V0IG4gaXMgbiArIDEuIEZpeGVkIHRoYXQu CisKKyAgICAgICAgQWxzbyByZW1vdmVkIHRoZSBjYWxsIHRvIHNldExlbmd0aENhY2hlIGluIEhU TUxDb2xsZWN0aW9uOjpsZW5ndGggc2luY2UgaXQgbXVzdCBoYXZlIHNldAorICAgICAgICBieSBw cmV2aW91cyBjYWxscyB0byBpdGVtQmVmb3JlT3JBZnRlckNhY2hlZEl0ZW0gYWxyZWFkeS4gVGhp cyB3aWxsIGFsbG93IHVzIHRvIGNhdGNoCisgICAgICAgIHJlZ3Jlc3Npb25zIGxpa2UgdGhpcyBp biBwb3J0cyB0aGF0IHVzZSBKU0MgYmluZGluZ3MgYXMgd2VsbC4KKworICAgICAgICBUZXN0OiBm YXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS5odG1sCisKKyAgICAgICAg KiBodG1sL0hUTUxDb2xsZWN0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDb2xsZWN0 aW9uOjpsZW5ndGgpOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENvbGxlY3Rpb246Oml0ZW1CZWZv cmVPckFmdGVyQ2FjaGVkSXRlbSk6CisKIDIwMTItMDctMTcgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2ViIEluc3BlY3Rvcjog Zm9sbG93dXAgZml4IGZvciByMTIyOTIwLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M Q29sbGVjdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQ29s bGVjdGlvbi5jcHAJKHJldmlzaW9uIDEyMjkyMSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TENvbGxlY3Rpb24uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMjQsOCArMzI0LDggQEAgdW5zaWdu ZWQgSFRNTENvbGxlY3Rpb246Omxlbmd0aCgpIGNvbnN0CiAgICAgZG8gewogICAgICAgICBvZmZz ZXQrKzsKICAgICB9IHdoaWxlIChpdGVtQmVmb3JlT3JBZnRlckNhY2hlZEl0ZW0ob2Zmc2V0KSk7 CisgICAgQVNTRVJUKGlzTGVuZ3RoQ2FjaGVWYWxpZCgpKTsKIAotICAgIHNldExlbmd0aENhY2hl KG9mZnNldCk7CiAgICAgcmV0dXJuIG9mZnNldDsKIH0KIApAQCAtMzk3LDcgKzM5Nyw4IEBAIEVs ZW1lbnQqIEhUTUxDb2xsZWN0aW9uOjppdGVtQmVmb3JlT3JBZnQKICAgICAgICAgfQogICAgIH0K IAotICAgIHNldExlbmd0aENhY2hlKGN1cnJlbnRPZmZzZXQpOworICAgIHVuc2lnbmVkIG9mZnNl dE9mTGFzdEl0ZW0gPSBjdXJyZW50T2Zmc2V0OworICAgIHNldExlbmd0aENhY2hlKG9mZnNldE9m TGFzdEl0ZW0gKyAxKTsKIAogICAgIHJldHVybiAwOwogfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTIy OTIxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEs MTYgQEAKKzIwMTItMDctMTcgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgUkVHUkVTU0lPTihyMTIyMzQ1KTogSFRNTENvbGxlY3Rpb246Omxlbmd0aCgpIHNvbWV0 aW1lcyByZXR1cm5zIGEgd3JvbmcgdmFsdWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTkxNTg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiB0ZXN0LiBJdCBvbmx5IGZhaWxzIG9u IENocm9taXVtIHBvcnQgYmVmb3JlIHRoZSBwYXRjaCBpcyBhcHBsaWVkIGJlY2F1c2UgSlNDIGJp bmRpbmcgY29kZQorICAgICAgICBoYXMgYSBidWcgKD8pIHRoYXQgaXQgYWx3YXlzIGNoZWNrcyBp bmRleCA+IGxlbmd0aCgpIHRvIHRocm93IGFuIGV4Y2VwdGlvbiBiZWZvcmUgYWNjZXNzaW5nIGFu IGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24uCisKKyAgICAgICAgKiBmYXN0L2RvbS9odG1sY29sbGVj dGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZG9tL2h0bWxjb2xsZWN0aW9uLWxlbmd0aC1hZnRlci1pdGVtLmh0bWw6IEFkZGVkLgorCiAy MDEyLTA3LTE3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBG aXggYW4gYXNzZXJ0aW9uIGZhaWx1cmUgaW4gQ2FsZW5kYXJQaWNrZXJFbGVtZW50Ojpob3N0SW5w dXQoKS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL2h0bWxjb2xsZWN0aW9uLWxlbmd0aC1h ZnRlci1pdGVtLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Rv bS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXItaXRlbS1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXIt aXRlbS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsOSBAQAorVGhpcyB0ZXN0 cyBhY2Nlc3NpbmcgdGhlIGxlbmd0aCBhZnRlciBhY2Nlc3NpbmcgKGxlbmd0aCArIDEpLXRoIGl0 ZW0gaW4gSFRNTENvbGxlY3Rpb24gZG9lc24ndCBjYWNoZSBhIHdyb25nIGxlbmd0aC4KKworT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1MgY2hpbGRyZW4gPSBjb250YWluZXIuY2hp bGRyZW47IGNoaWxkcmVuLmxlbmd0aCBpcyAwCitQQVNTIGNvbnRhaW5lci5hcHBlbmRDaGlsZChz cGFuKTsgY2hpbGRyZW5bMV07IGNoaWxkcmVuLmxlbmd0aCBpcyAxCitQQVNTIGNvbnRhaW5lci5y ZW1vdmVDaGlsZChzcGFuKTsgY2hpbGRyZW4ubGVuZ3RoIGlzIDAKKwpJbmRleDogTGF5b3V0VGVz dHMvZmFzdC9kb20vaHRtbGNvbGxlY3Rpb24tbGVuZ3RoLWFmdGVyLWl0ZW0uaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9odG1sY29sbGVjdGlvbi1sZW5ndGgtYWZ0ZXIt aXRlbS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vaHRtbGNvbGxl Y3Rpb24tbGVuZ3RoLWFmdGVyLWl0ZW0uaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxOCBA QAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jl c291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitkZXNjcmlwdGlv bigiVGhpcyB0ZXN0cyBhY2Nlc3NpbmcgdGhlIGxlbmd0aCBhZnRlciBhY2Nlc3NpbmcgKGxlbmd0 aCArIDEpLXRoIGl0ZW0gaW4gSFRNTENvbGxlY3Rpb24gZG9lc24ndCBjYWNoZSBhIHdyb25nIGxl bmd0aC4iKTsKKwordmFyIGNvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2Rpdicp OwordmFyIHNwYW4gPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJyk7Cit2YXIgY2hpbGRy ZW47CitzaG91bGRCZSgiY2hpbGRyZW4gPSBjb250YWluZXIuY2hpbGRyZW47IGNoaWxkcmVuLmxl bmd0aCIsICIwIik7CitzaG91bGRCZSgiY29udGFpbmVyLmFwcGVuZENoaWxkKHNwYW4pOyBjaGls ZHJlblsxXTsgY2hpbGRyZW4ubGVuZ3RoIiwgIjEiKTsKK3Nob3VsZEJlKCJjb250YWluZXIucmVt b3ZlQ2hpbGQoc3Bhbik7IGNoaWxkcmVuLmxlbmd0aCIsICIwIik7CisKKzwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgo=