91586 2012-07-17 23:25:08 -0700 Build fix for r122870. Comparison of unsigned expression >= 0 is always true. 2012-07-18 01:49:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 89039 P2 Normal --- 0 dongseong.hwang webkit-unassigned dino haraken skyul webkit.review.bot oldest_to_newest 672020 0 dongseong.hwang 2012-07-17 23:25:08 -0700 Build fix for r122870. Comparison of unsigned expression >= 0 is always true. r122870 is Bug 89039. 672022 1 152937 dongseong.hwang 2012-07-17 23:26:54 -0700 Created attachment 152937 Patch 672025 2 dongseong.hwang 2012-07-17 23:29:15 -0700 Debug build failed on Qt with the following text. MacroExpander.cpp:129:9: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] 672056 3 152937 webkit.review.bot 2012-07-18 00:05:01 -0700 Comment on attachment 152937 Patch Rejecting attachment 152937 from review queue. skyul@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 672069 4 skyul 2012-07-18 00:20:07 -0700 (In reply to comment #3) > (From update of attachment 152937 [details]) > Rejecting attachment 152937 [details] from review queue. > > skyul@company100.net does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. > > - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. > > - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Oops. I wanted to land the patch unreviewed because this is a simple build fix. What happens when the flag is r-, cq+? 672121 5 haraken 2012-07-18 01:24:16 -0700 (In reply to comment #4) > Oops. I wanted to land the patch unreviewed because this is a simple build fix. In that case you can land the patch manually by './Tools/Scripts/webkit-patch land'. (If you do not have a committer permission, feel free to ping committers in IRC.) 672124 6 152937 webkit.review.bot 2012-07-18 01:26:40 -0700 Comment on attachment 152937 Patch Rejecting attachment 152937 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: patch file(s). patching file Source/ThirdParty/ANGLE/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp Hunk #1 FAILED at 126. 1 out of 1 hunk FAILED -- saving rejects to file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13273445 672126 7 dongseong.hwang 2012-07-18 01:29:15 -0700 (In reply to comment #5) > (In reply to comment #4) > > Oops. I wanted to land the patch unreviewed because this is a simple build fix. > > In that case you can land the patch manually by './Tools/Scripts/webkit-patch land'. (If you do not have a committer permission, feel free to ping committers in IRC.) Thank you for kind instruction. I'm not committer, so I'll ping committers. :) 672128 8 dongseong.hwang 2012-07-18 01:33:18 -0700 (In reply to comment #6) > (From update of attachment 152937 [details]) > Rejecting attachment 152937 [details] from commit-queue. > > Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 > > Last 500 characters of output: > patch file(s). > patching file Source/ThirdParty/ANGLE/ChangeLog > Hunk #1 succeeded at 1 with fuzz 3. > patching file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp > Hunk #1 FAILED at 126. > 1 out of 1 hunk FAILED -- saving rejects to file Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp.rej > > Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ > > Full output: http://queues.webkit.org/results/13273445 Did I have some mistake about Changelog? I want someone to help. 672134 9 haraken 2012-07-18 01:45:09 -0700 (In reply to comment #8) > Did I have some mistake about Changelog? I want someone to help. Looks like this patch is already landed by somebody. Your patch was rejected due to conflict. 672135 10 dongseong.hwang 2012-07-18 01:48:34 -0700 (In reply to comment #9) > (In reply to comment #8) > > Did I have some mistake about Changelog? I want someone to help. > > Looks like this patch is already landed by somebody. Your patch was rejected due to conflict. Absolutely, Bug 89039. I'll close this bug as duplicated. 672136 11 dongseong.hwang 2012-07-18 01:49:21 -0700 *** This bug has been marked as a duplicate of bug 89039 *** 152937 2012-07-17 23:26:54 -0700 2012-07-18 01:26:40 -0700 Patch bug-91586-20120718152634.patch text/plain 1420 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggZDJhOGJiMzVjODZmZmQ3MjllZmY1ZTNiNTcxNzhmMzUyY2I3ZTc2Zi4uYmI0MDE3NDZmYzI2 ZmM4NTAyOTZlMzI2MzA4NjNlYzY0YWI0Y2FjMCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTE3ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxh QGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIEJ1aWxkIGZpeCBmb3IgcjEyMjg3MC4gQ29tcGFy aXNvbiBvZiB1bnNpZ25lZCBleHByZXNzaW9uID49IDAgaXMgYWx3YXlzIHRydWUuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTU4NgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL2NvbXBpbGVyL3By ZXByb2Nlc3Nvci9uZXcvTWFjcm9FeHBhbmRlci5jcHA6CisgICAgICAgIChwcDo6TWFjcm9FeHBh bmRlcjo6dW5nZXRUb2tlbik6CisKIDIwMTItMDctMTcgIE1heCBWdWpvdmljICA8bXZ1am92aWNA YWRvYmUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBBTkdMRSBpbiBXZWJLaXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21waWxlci9wcmVwcm9jZXNzb3IvbmV3L01h Y3JvRXhwYW5kZXIuY3BwIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVyL3By ZXByb2Nlc3Nvci9uZXcvTWFjcm9FeHBhbmRlci5jcHAKaW5kZXggNDE1NGQ0M2M3NDM3OTBmM2U1 ZDYzZDMxYTViN2NlZjM2NzE1MDI0Yi4uZmU1YTdhZThjNjUyZTcyZmUxNjZiZWY4ZTI5NDBkZTM4 YzIwZjYxZSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbXBpbGVy L3ByZXByb2Nlc3Nvci9uZXcvTWFjcm9FeHBhbmRlci5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvc3JjL2NvbXBpbGVyL3ByZXByb2Nlc3Nvci9uZXcvTWFjcm9FeHBhbmRlci5jcHAK QEAgLTEyNiw3ICsxMjYsNiBAQCB2b2lkIE1hY3JvRXhwYW5kZXI6OnVuZ2V0VG9rZW4oY29uc3Qg VG9rZW4mIHRva2VuKQogICAgIHsKICAgICAgICAgTWFjcm9Db250ZXh0KiBjb250ZXh0ID0gbUNv bnRleHRTdGFjay5iYWNrKCk7CiAgICAgICAgIGNvbnRleHQtPnVuZ2V0KCk7Ci0gICAgICAgIGFz c2VydChjb250ZXh0LT5pbmRleCA+PSAwKTsKICAgICAgICAgYXNzZXJ0KGNvbnRleHQtPnJlcGxh Y2VtZW50c1tjb250ZXh0LT5pbmRleF0gPT0gdG9rZW4pOwogICAgIH0KICAgICBlbHNlCg==