91580 2012-07-17 22:21:25 -0700 [WK2][EFL] Add a common code using Color instead of QColor 2012-07-18 03:31:29 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 youngtaeck.song webkit-unassigned gyuyoung.kim hausmann lucas.de.marchi noam webkit.review.bot oldest_to_newest 671963 0 152917 youngtaeck.song 2012-07-17 22:21:25 -0700 Created attachment 152917 patch This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation. drawBorder's argument is QColor. So add a common code using Color to be used by Efl. 671969 1 webkit.review.bot 2012-07-17 22:23:58 -0700 Attachment 152917 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 671976 2 152924 youngtaeck.song 2012-07-17 22:28:02 -0700 Created attachment 152924 patch miss bug number 672083 3 152924 hausmann 2012-07-18 00:33:38 -0700 Comment on attachment 152924 patch View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review > Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149 > +#if PLATFORM(QT) > textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform); > +#else > + textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform); > +#endif I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :) 672138 4 152962 youngtaeck.song 2012-07-18 01:55:55 -0700 Created attachment 152962 Patch 672143 5 youngtaeck.song 2012-07-18 01:58:24 -0700 (In reply to comment #3) > (From update of attachment 152924 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review > > > Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149 > > +#if PLATFORM(QT) > > textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(), transform); > > +#else > > + textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(), transform); > > +#endif > > I think it would be better to _replace_ the use of QColor with Color (and either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can :) Thank you for kind review. There is no Color::red in Color.h. So I used Color(0xFF, 0, 0). 672195 6 152962 webkit.review.bot 2012-07-18 03:31:24 -0700 Comment on attachment 152962 Patch Clearing flags on attachment: 152962 Committed r122941: <http://trac.webkit.org/changeset/122941> 672196 7 webkit.review.bot 2012-07-18 03:31:29 -0700 All reviewed patches have been landed. Closing bug. 152917 2012-07-17 22:21:25 -0700 2012-07-17 22:29:18 -0700 patch drawBorder.diff text/plain 1666 youngtaeck.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkMmE5YzQ0Li5hMDU2YWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMTcgIFlvdW5nVGFlY2sgU29uZyAgPHlvdW5ndGFlY2suc29uZ0BzYW1zdW5n LmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFkZCBhIGNvbW1vbiBjb2RlIHVzaW5nIENvbG9y IGluc3RlYWQgb2YgUUNvbG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHBhdGNoIGlzIGEgc3Vic2V0IG9mIEVmbCdzIFVJX1NJREVfQ09NUE9TSVRJTkcg aW1wbGVtZW50YXRpb24uCisgICAgICAgIGRyYXdCb3JkZXIncyBhcmd1bWVudCBpcyBRQ29sb3Iu IFNvIGFkZCBhIGNvbW1vbiBjb2RlIHVzaW5nIENvbG9yIHRvIGJlIHVzZWQgYnkgRWZsLgorCisg ICAgICAgICogVUlQcm9jZXNzL3RleG1hcC9MYXllckJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAg IChXZWJLaXQ6OkxheWVyQmFja2luZ1N0b3JlOjpwYWludFRvVGV4dHVyZU1hcHBlcik6CisKIDIw MTItMDctMTcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4K IAogICAgICAgICBbRUZMXSBSZXBsYWNlIDAgYnkgTlVMTCBpbiBwdWJsaWMgaGVhZGVycyBkb2N1 bWVudGF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvdGV4bWFwL0xh eWVyQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy90ZXhtYXAvTGF5 ZXJCYWNraW5nU3RvcmUuY3BwCmluZGV4IDk2N2YwNzUuLjMzMzA4Y2YgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy90ZXhtYXAvTGF5ZXJCYWNraW5nU3RvcmUuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy90ZXhtYXAvTGF5ZXJCYWNraW5nU3RvcmUuY3BwCkBA IC0xNDEsNyArMTQxLDEyIEBAIHZvaWQgTGF5ZXJCYWNraW5nU3RvcmU6OnBhaW50VG9UZXh0dXJl TWFwcGVyKFRleHR1cmVNYXBwZXIqIHRleHR1cmVNYXBwZXIsIGNvbnN0CiAgICAgICAgIHN0YXRp YyBib29sIHNob3VsZERlYnVnID0gc2hvdWxkU2hvd1RpbGVEZWJ1Z1Zpc3VhbHMoKTsKICAgICAg ICAgaWYgKCFzaG91bGREZWJ1ZykKICAgICAgICAgICAgIGNvbnRpbnVlOworCisjaWYgUExBVEZP Uk0oUVQpCiAgICAgICAgIHRleHR1cmVNYXBwZXItPmRyYXdCb3JkZXIoUUNvbG9yKFF0OjpyZWQp LCAyLCB0aWxlLT5yZWN0KCksIHRyYW5zZm9ybSk7CisjZWxzZQorICAgICAgICB0ZXh0dXJlTWFw cGVyLT5kcmF3Qm9yZGVyKENvbG9yKENvbG9yOjpsaWdodEdyYXkpLCAyLCB0aWxlLT5yZWN0KCks IHRyYW5zZm9ybSk7CisjZW5kaWYKICAgICAgICAgdGV4dHVyZU1hcHBlci0+ZHJhd1JlcGFpbnRD b3VudGVyKHN0YXRpY19jYXN0PExheWVyQmFja2luZ1N0b3JlVGlsZSo+KHRpbGUpLT5yZXBhaW50 Q291bnQoKSwgOCwgdGlsZXNUb1BhaW50W2ldLT5yZWN0KCkubG9jYXRpb24oKSwgdHJhbnNmb3Jt KTsKICAgICB9CiB9Cg== 152924 2012-07-17 22:28:02 -0700 2012-07-18 01:55:46 -0700 patch drawBorder.diff text/plain 1671 youngtaeck.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkMmE5YzQ0Li5hMDU2YWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMTcgIFlvdW5nVGFlY2sgU29uZyAgPHlvdW5ndGFlY2suc29uZ0BzYW1zdW5n LmNvbT4KKworICAgICAgICBbV0syXVtFRkxdIEFkZCBhIGNvbW1vbiBjb2RlIHVzaW5nIENvbG9y IGluc3RlYWQgb2YgUUNvbG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MTU4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcGF0Y2ggaXMgYSBzdWJzZXQgb2YgRWZsJ3MgVUlfU0lERV9DT01QT1NJ VElORyBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAgZHJhd0JvcmRlcidzIGFyZ3VtZW50IGlzIFFD b2xvci4gU28gYWRkIGEgY29tbW9uIGNvZGUgdXNpbmcgQ29sb3IgdG8gYmUgdXNlZCBieSBFZmwu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvdGV4bWFwL0xheWVyQmFja2luZ1N0b3JlLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6TGF5ZXJCYWNraW5nU3RvcmU6OnBhaW50VG9UZXh0dXJlTWFwcGVyKToK KwogMjAxMi0wNy0xNyAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwu Y29tPgogCiAgICAgICAgIFtFRkxdIFJlcGxhY2UgMCBieSBOVUxMIGluIHB1YmxpYyBoZWFkZXJz IGRvY3VtZW50YXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy90ZXht YXAvTGF5ZXJCYWNraW5nU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3RleG1h cC9MYXllckJhY2tpbmdTdG9yZS5jcHAKaW5kZXggOTY3ZjA3NS4uMzMzMDhjZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3RleG1hcC9MYXllckJhY2tpbmdTdG9yZS5jcHAK KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3RleG1hcC9MYXllckJhY2tpbmdTdG9yZS5j cHAKQEAgLTE0MSw3ICsxNDEsMTIgQEAgdm9pZCBMYXllckJhY2tpbmdTdG9yZTo6cGFpbnRUb1Rl eHR1cmVNYXBwZXIoVGV4dHVyZU1hcHBlciogdGV4dHVyZU1hcHBlciwgY29uc3QKICAgICAgICAg c3RhdGljIGJvb2wgc2hvdWxkRGVidWcgPSBzaG91bGRTaG93VGlsZURlYnVnVmlzdWFscygpOwog ICAgICAgICBpZiAoIXNob3VsZERlYnVnKQogICAgICAgICAgICAgY29udGludWU7CisKKyNpZiBQ TEFURk9STShRVCkKICAgICAgICAgdGV4dHVyZU1hcHBlci0+ZHJhd0JvcmRlcihRQ29sb3IoUXQ6 OnJlZCksIDIsIHRpbGUtPnJlY3QoKSwgdHJhbnNmb3JtKTsKKyNlbHNlCisgICAgICAgIHRleHR1 cmVNYXBwZXItPmRyYXdCb3JkZXIoQ29sb3IoQ29sb3I6OmxpZ2h0R3JheSksIDIsIHRpbGUtPnJl Y3QoKSwgdHJhbnNmb3JtKTsKKyNlbmRpZgogICAgICAgICB0ZXh0dXJlTWFwcGVyLT5kcmF3UmVw YWludENvdW50ZXIoc3RhdGljX2Nhc3Q8TGF5ZXJCYWNraW5nU3RvcmVUaWxlKj4odGlsZSktPnJl cGFpbnRDb3VudCgpLCA4LCB0aWxlc1RvUGFpbnRbaV0tPnJlY3QoKS5sb2NhdGlvbigpLCB0cmFu c2Zvcm0pOwogICAgIH0KIH0K 152962 2012-07-18 01:55:55 -0700 2012-07-18 03:31:24 -0700 Patch bug-91580-20120718175554.patch text/plain 1791 youngtaeck.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDJhOWM0NDYxMzU4Y2M0 MzA2MDhhMzMyNTQ2NDdlOGFjMDUxOTQ2NC4uN2Y2NzgxYjA5YjUyZDdkYTZlYmYzOGU3YWFiMzU2 ZjY1YTIyZTBmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTE4ICBZb3Vu Z1RhZWNrIFNvbmcgIDx5b3VuZ3RhZWNrLnNvbmdAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW1dL Ml1bRUZMXSBBZGQgYSBjb21tb24gY29kZSB1c2luZyBDb2xvciBpbnN0ZWFkIG9mIFFDb2xvcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE1ODAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNo IGlzIGEgc3Vic2V0IG9mIEVmbCdzIFVJX1NJREVfQ09NUE9TSVRJTkcgaW1wbGVtZW50YXRpb24u CisgICAgICAgIGRyYXdCb3JkZXIncyBhcmd1bWVudCBpcyBRQ29sb3IuIFNvIGFkZCBhIGNvbW1v biBjb2RlIHVzaW5nIENvbG9yIHRvIGJlIHVzZWQgYnkgRWZsLgorCisgICAgICAgICogVUlQcm9j ZXNzL3RleG1hcC9MYXllckJhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkxheWVy QmFja2luZ1N0b3JlOjpwYWludFRvVGV4dHVyZU1hcHBlcik6CisKIDIwMTItMDctMTcgIENocmlz dG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZM XSBSZXBsYWNlIDAgYnkgTlVMTCBpbiBwdWJsaWMgaGVhZGVycyBkb2N1bWVudGF0aW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvdGV4bWFwL0xheWVyQmFja2luZ1N0b3Jl LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy90ZXhtYXAvTGF5ZXJCYWNraW5nU3RvcmUu Y3BwCmluZGV4IDk2N2YwNzUxMzg1NGE5NjQ1MTc3Njg0NzhkOWUzMjE3YWI5Y2Y5ZTAuLjQzZGJl MGNiYTUxY2I3NDQyY2RiYzQ3OGFiZWIxZWFmNzRlMDk1Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy90ZXhtYXAvTGF5ZXJCYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy90ZXhtYXAvTGF5ZXJCYWNraW5nU3RvcmUuY3BwCkBAIC0xNDEs NyArMTQxLDggQEAgdm9pZCBMYXllckJhY2tpbmdTdG9yZTo6cGFpbnRUb1RleHR1cmVNYXBwZXIo VGV4dHVyZU1hcHBlciogdGV4dHVyZU1hcHBlciwgY29uc3QKICAgICAgICAgc3RhdGljIGJvb2wg c2hvdWxkRGVidWcgPSBzaG91bGRTaG93VGlsZURlYnVnVmlzdWFscygpOwogICAgICAgICBpZiAo IXNob3VsZERlYnVnKQogICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIHRleHR1cmVNYXBw ZXItPmRyYXdCb3JkZXIoUUNvbG9yKFF0OjpyZWQpLCAyLCB0aWxlLT5yZWN0KCksIHRyYW5zZm9y bSk7CisKKyAgICAgICAgdGV4dHVyZU1hcHBlci0+ZHJhd0JvcmRlcihDb2xvcigweEZGLCAwLCAw KSwgMiwgdGlsZS0+cmVjdCgpLCB0cmFuc2Zvcm0pOwogICAgICAgICB0ZXh0dXJlTWFwcGVyLT5k cmF3UmVwYWludENvdW50ZXIoc3RhdGljX2Nhc3Q8TGF5ZXJCYWNraW5nU3RvcmVUaWxlKj4odGls ZSktPnJlcGFpbnRDb3VudCgpLCA4LCB0aWxlc1RvUGFpbnRbaV0tPnJlY3QoKS5sb2NhdGlvbigp LCB0cmFuc2Zvcm0pOwogICAgIH0KIH0K