91560 2012-07-17 17:15:06 -0700 "webkit-patch rebaseline <test>" fails with exit_code 1 2012-07-27 17:35:04 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eae dpranke abarth dpranke ojan tomhudson tony oldest_to_newest 671773 0 eae 2012-07-17 17:15:06 -0700 $ ./Tools/Scripts/webkit-patch rebaseline css2.1/t100801-c544-valgn-03-d-agi.html Which builder to pull results from: build.webkit.org bots 1. Apple Lion Debug WK1 (Tests) 2. Apple Lion Debug WK2 (Tests) 3. Apple Lion Release WK1 (Tests) 4. Apple Lion Release WK2 (Tests) 5. Apple Win 7 Release (Tests) 6. Apple Win XP Debug (Tests) 7. EFL Linux 64-bit Debug 8. EFL Linux 64-bit Release 9. GTK Linux 32-bit Release 10. GTK Linux 64-bit Debug 11. GTK Linux 64-bit Release 12. GTK Linux 64-bit Release WK2 (Tests) 13. Qt Linux Release build.chromium.org bots 14. Webkit Linux 15. Webkit Linux (dbg) 16. Webkit Linux 32 17. Webkit Mac10.6 18. Webkit Mac10.6 (dbg) 19. Webkit Mac10.7 20. Webkit Win 21. Webkit Win (dbg)(1) 22. Webkit Win (dbg)(2) 23. Webkit Win7 Enter one or more numbers (comma-separated) or ranges (e.g. 3-7), or "all": 18 Traceback (most recent call last): File "./Tools/Scripts/webkit-patch", line 84, in <module> main() File "./Tools/Scripts/webkit-patch", line 79, in main WebKitPatch(os.path.abspath(__file__)).main() File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 311, in main result = command.check_arguments_and_execute(options, args, self) File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 120, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 426, in execute self._rebaseline(options, test_list) File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 305, in _rebaseline self._tool.scm().add_list(list(files_to_add)) File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 180, in add_list return self._run_svn(["add"] + paths, return_exit_code=return_exit_code) File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/common/checkout/scm/svn.py", line 131, in _run_svn return self.run([self.executable_name] + args, **kwargs) File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/common/checkout/scm/scm.py", line 76, in run decode_output=decode_output) File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/common/system/executive.py", line 418, in run_command (error_handler or self.default_error_handler)(script_error) File "/usr/local/google/projects/webkit3/Tools/Scripts/webkitpy/common/system/executive.py", line 335, in default_error_handler raise error webkitpy.common.system.executive.ScriptError: Failed to run "[u'svn', u'add']" exit_code: 1 671845 1 ojan 2012-07-17 18:16:41 -0700 Are you running this on Windows? Wouldn't surprise me if this just didn't work on Windows. 672455 2 eae 2012-07-18 09:54:13 -0700 No, linux. Worked up until a week or two ago. 672494 3 ojan 2012-07-18 10:28:25 -0700 Can you run with -v? That should print out the rebaseline-json command it's using. 672499 4 eae 2012-07-18 10:30:27 -0700 rebaseline-json: {'css2.1/t100801-c544-valgn-03-d-agi.html': {'Webkit Mac10.6 (dbg)': ['wav', 'txt', 'png']}} webkitpy.tool.commands.rebaseline: [DEBUG] "" is not a JSON object, ignoring webkitpy.common.system.executive: [DEBUG] "svn add" took 0.03s Traceback (most recent call last): ... same stack trace as before ... webkitpy.common.system.executive.ScriptError: Failed to run "[u'svn', u'add']" exit_code: 1 672564 5 ojan 2012-07-18 11:25:17 -0700 Works for me on Linux. :( Are you on precise perhaps? 672575 6 eae 2012-07-18 11:34:36 -0700 Nope, ghardy. 672592 7 ojan 2012-07-18 11:50:24 -0700 I'm on Lucid. Maybe it's your python version? I'm on 2.6.5. 672599 8 eae 2012-07-18 11:55:32 -0700 $ more /proc/version Linux version 2.6.38.8-gg868 $ python --version Python 2.6.5 This all worked up until a week or two ago and I haven't upgraded or changed any part of my system config since. 672604 9 eae 2012-07-18 11:59:27 -0700 Is there any way to see what command the script tries to execute when it encounters the error? 672663 10 dpranke 2012-07-18 13:01:42 -0700 (In reply to comment #9) > Is there any way to see what command the script tries to execute when it encounters the error? webkit-patch --verbose should give you a little more info. Also, this is probably a dumb question, but you are in a svn checkout and not a git checkout, right? 672672 11 eae 2012-07-18 13:07:13 -0700 Yeah, webkit svn checkout with the chromium data (update-webkit --chromium). 672678 12 dpranke 2012-07-18 13:10:29 -0700 (In reply to comment #11) > Yeah, webkit svn checkout with the chromium data (update-webkit --chromium). turns out I no longer had an svn checkout on linux, so I'm recreating one now and will attempt to reproduce once I'm there ... 672680 13 dpranke 2012-07-18 13:11:59 -0700 oop, nevermind, I reproduced this on mac. Will investigate ... 672688 14 dpranke 2012-07-18 13:21:07 -0700 yeah, that's what I thought. We're trying to add nothing (an empty list of files), which is why all you're seeing is "svn add" :). It looks like, at least as of now, that test isn't failing anywhere, so we have no work to do, and we don't trap that properly. It's a simple fix to not try to add nothing; however, at a higher level, it would be nice if the tool was reporting that there was nothing to do as the test wasn't failing. Also, it's not clear to me that I'm reproducing what you were seeing either, since maybe the test was failing for you at the time? Lastly, I'm concerned that we're listing the debug bots as well as the release bots; we shouldn't be, since we don't want to add the debug versions if there are release versions. 672701 15 eae 2012-07-18 13:28:27 -0700 Probably a different failure now than before then as the test was failing at the time. Will report back next time I encounter this error with a test that is failing. Thanks! 672706 16 dpranke 2012-07-18 13:34:16 -0700 (In reply to comment #15) > Probably a different failure now than before then as the test was failing at the time. Will report back next time I encounter this error with a test that is failing. > > Thanks! My guess is that it had something to do with you trying to use a debug bot and us ending up throwing away the baseline so you still weren't changing anything. until we figure out how to strip the debug bots out of this, don't try to rebaseline from a debug bot if there is a release equivalent :). 681251 17 155091 dpranke 2012-07-27 17:10:00 -0700 Created attachment 155091 Patch 681253 18 dpranke 2012-07-27 17:11:13 -0700 *** Bug 92559 has been marked as a duplicate of this bug. *** 681278 19 dpranke 2012-07-27 17:35:04 -0700 Committed r123941: <http://trac.webkit.org/changeset/123941> 155091 2012-07-27 17:10:00 -0700 2012-07-27 17:24:02 -0700 Patch bug-91560-20120727170948.patch text/plain 3289 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzODk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDBhMDU1N2U2MzY2YjhmMmMyODhjNjE0ODgxYzlhMDUz Y2U0YmNmMy4uY2QxZTZlYjRlMzc2MmFlYmNhMDZmYmI3ODlkYjYwZmEwOTVkNDVkMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2 IEBACiAyMDEyLTA3LTI3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgICJ3ZWJraXQtcGF0Y2ggcmViYXNlbGluZSA8dGVzdD4iIGZhaWxzIHdpdGggZXhpdF9j b2RlIDEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkx NTYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd2Vi a2l0LXBhdGNoIHJlYmFzZWxpbmUtanNvbiBjcmFzaGVzIGluIGFuIHN2biBjaGVja291dCBpZiBp dAorICAgICAgICB0cmllcyB0byBhZGQgZmlsZXMgYW5kIHRoZXJlIGFyZSBubyBmaWxlcyB0byBh ZGQ7IGFyZ3VhYmx5CisgICAgICAgIHN2bi5hZGQoKSBzaG91bGQgYmUgcm9idXN0IGFnYWluc3Qg dGhpcywgYnV0IHJlYmFzZWxpbmUtanNvbgorICAgICAgICBzaG91bGRuJ3QgYmUgY2FsbGluZyBp dCwgZWl0aGVyLiBUaGlzIHBhdGNoIGZpeGVzIHRoZSBsYXR0ZXIgYW5kCisgICAgICAgIGFkZHMg YmV0dGVyIGRlYnVnZ2luZyBpbmZvIHRvIGdhcmRlbi1vLW1hdGljIHNvIHdlIGNhbiBzZWUgd2hh dAorICAgICAgICBjYXVzZWQgdGhlIGNyYXNoLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL2NvbW1hbmRzL3JlYmFzZWxpbmUucHk6CisgICAgICAgIChBYnN0cmFjdFBhcmFsbGVs UmViYXNlbGluZUNvbW1hbmQuX3JlYmFzZWxpbmUpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvdG9vbC9zZXJ2ZXJzL2dhcmRlbmluZ3NlcnZlci5weToKKyAgICAgICAgKEdhcmRlbmluZ0hU VFBSZXF1ZXN0SGFuZGxlci5yZWJhc2VsaW5lYWxsKToKKyAgICAgICAgKEdhcmRlbmluZ0hUVFBS ZXF1ZXN0SGFuZGxlci5yZWJhc2VsaW5lYWxsLmVycm9yX2hhbmRsZXIpOgorICAgICAgICAoR2Fy ZGVuaW5nSFRUUFJlcXVlc3RIYW5kbGVyKToKKworMjAxMi0wNy0yNyAgRGlyayBQcmFua2UgIDxk cHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBucnd0OiBtb3ZlIGNvbGxlY3RfdGVzdHMo KSwgcGFyc2VfZXhwZWN0YXRpb25zKCkgaW50byBtYW5hZ2VyCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjQyMwogCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZS5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yZWJhc2VsaW5lLnB5CmluZGV4IGMyMTRhMzM5YzJk NjBlYzZlZDk3ZTVmMjJkZGI4OTY5ZjZhYzA4NTkuLmVkMjdhYjU1Mzk3ZDNlMTRiNWVhMGRkZjk3 NWQ1ZTZiOWZhZWFlZDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9yZWJhc2VsaW5lLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9yZWJhc2VsaW5lLnB5CkBAIC0zMDIsNyArMzAyLDggQEAgY2xhc3MgQWJzdHJhY3RQ YXJhbGxlbFJlYmFzZWxpbmVDb21tYW5kKEFic3RyYWN0RGVjbGFyYXRpdmVDb21tYW5kKToKICAg ICAgICAgY29tbWFuZF9yZXN1bHRzID0gc2VsZi5fdG9vbC5leGVjdXRpdmUucnVuX2luX3BhcmFs bGVsKGNvbW1hbmRzKQogCiAgICAgICAgIGZpbGVzX3RvX2FkZCA9IHNlbGYuX2ZpbGVzX3RvX2Fk ZChjb21tYW5kX3Jlc3VsdHMpCi0gICAgICAgIHNlbGYuX3Rvb2wuc2NtKCkuYWRkX2xpc3QobGlz dChmaWxlc190b19hZGQpKQorICAgICAgICBpZiBmaWxlc190b19hZGQ6CisgICAgICAgICAgICBz ZWxmLl90b29sLnNjbSgpLmFkZF9saXN0KGxpc3QoZmlsZXNfdG9fYWRkKSkKIAogICAgICAgICBp ZiBvcHRpb25zLm9wdGltaXplOgogICAgICAgICAgICAgc2VsZi5fb3B0aW1pemVfYmFzZWxpbmVz KHRlc3RfbGlzdCkKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2 ZXJzL2dhcmRlbmluZ3NlcnZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zZXJ2 ZXJzL2dhcmRlbmluZ3NlcnZlci5weQppbmRleCA5NDdiZjFkODg2YmMxOWU4ZTAyNDc4NDdjMzdl NzcyOTJhNjEzOTkzLi40NmQ5NzUxZGIwM2NkZmMxNjc4MzkxNWU5YTExYzg2ZmM5ODM0NWZjIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc2VydmVycy9nYXJkZW5pbmdz ZXJ2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3NlcnZlcnMvZ2FyZGVu aW5nc2VydmVyLnB5CkBAIC0xNDIsNSArMTQyLDExIEBAIGNsYXNzIEdhcmRlbmluZ0hUVFBSZXF1 ZXN0SGFuZGxlcihSZWZsZWN0aW9uSGFuZGxlcik6CiAKICAgICBkZWYgcmViYXNlbGluZWFsbChz ZWxmKToKICAgICAgICAgY29tbWFuZCA9IFsncmViYXNlbGluZS1qc29uJ10KLSAgICAgICAgc2Vs Zi5zZXJ2ZXIudG9vbC5leGVjdXRpdmUucnVuX2NvbW1hbmQoW3NlbGYuc2VydmVyLnRvb2wucGF0 aCgpXSArIGNvbW1hbmQsIGlucHV0PXNlbGYucmVhZF9lbnRpdHlfYm9keSgpLCBjd2Q9c2VsZi5z ZXJ2ZXIudG9vbC5zY20oKS5jaGVja291dF9yb290KQorICAgICAgICBqc29uX2lucHV0ID0gc2Vs Zi5yZWFkX2VudGl0eV9ib2R5KCkKKyAgICAgICAgX2xvZy5kZWJ1ZygicmViYXNlbGluaW5nIHVz aW5nICclcyciICUganNvbl9pbnB1dCkKKworICAgICAgICBkZWYgZXJyb3JfaGFuZGxlcihzY3Jp cHRfZXJyb3IpOgorICAgICAgICAgICAgX2xvZy5lcnJvcigiZXJyb3IgZnJvbSByZWJhc2VsaW5l LWpzb246ICVzLCBpbnB1dD0nJXMnLCBvdXRwdXQ9JyVzJyIgJSAoc3RyKHNjcmlwdF9lcnJvciks IGpzb25faW5wdXQsIHNjcmlwdF9lcnJvci5vdXRwdXQpKQorCisgICAgICAgIHNlbGYuc2VydmVy LnRvb2wuZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFtzZWxmLnNlcnZlci50b29sLnBhdGgoKV0gKyBj b21tYW5kLCBpbnB1dD1qc29uX2lucHV0LCBjd2Q9c2VsZi5zZXJ2ZXIudG9vbC5zY20oKS5jaGVj a291dF9yb290LCByZXR1cm5fc3RkZXJyPVRydWUsIGVycm9yX2hhbmRsZXI9ZXJyb3JfaGFuZGxl cikKICAgICAgICAgc2VsZi5fc2VydmVfdGV4dCgnc3VjY2VzcycpCg==