91550 2012-07-17 15:45:41 -0700 [Chromium] Disable printing on chromium-android 2012-07-18 17:07:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 66687 1 abarth abarth bulach japhet peter tony webkit.review.bot oldest_to_newest 671678 0 abarth 2012-07-17 15:45:41 -0700 Disable printing on chromium-android 671679 1 152855 abarth 2012-07-17 15:46:51 -0700 Created attachment 152855 Patch 672146 2 152855 peter 2012-07-18 02:11:42 -0700 Comment on attachment 152855 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152855&action=review LGTM, thanks! I'll post a patch downstream today to clean this up, as this might cause potential merge confusion. > Source/WebKit/chromium/ChangeLog:3 > + Disable printing on chromium-android nit: Despite mentioning chromium-android in the title, generally [Chromium] as a prefix is clearer. > Source/WebKit/chromium/ChangeLog:8 > + We don't implementing printing on Android. nit: s/implementing/implement/ 672800 3 153096 abarth 2012-07-18 15:01:33 -0700 Created attachment 153096 Patch for landing 672994 4 153096 webkit.review.bot 2012-07-18 17:07:29 -0700 Comment on attachment 153096 Patch for landing Clearing flags on attachment: 153096 Committed r123049: <http://trac.webkit.org/changeset/123049> 672995 5 webkit.review.bot 2012-07-18 17:07:33 -0700 All reviewed patches have been landed. Closing bug. 152855 2012-07-17 15:46:51 -0700 2012-07-18 15:01:28 -0700 Patch bug-91550-20120717154650.patch text/plain 2429 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGYxMTUxOTg5OWIwYzJkNTJkYWE1M2E3MTA4YTc3NDU3ODk3OWJiMTYuLjNhY2NjNjE4N2YzYmZm MmRhZjg5MzEzNDEwYTExYjExYzk1ZDhjZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBEaXNhYmxlIHByaW50aW5nIG9uIGNocm9taXVtLWFuZHJvaWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNTUwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3QgaW1wbGVt ZW50aW5nIHByaW50aW5nIG9uIEFuZHJvaWQuCisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBpOgor ICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFt ZUltcGw6OnByaW50UGFnZSk6CisKIDIwMTItMDctMTcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9t aXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiAgUm9sbGVkIERFUFMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkgYi9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL2ZlYXR1cmVzLmd5cGkKaW5kZXggMzVmODZjZjI0MTFhYzg4ZjUxMGE2OTU5MzkwZTU4 NmUxNTE3YTdkMC4uY2FjMDQyNzcxMTQzYTRmYWEyOTBkNDE3YWM3ZDY3ODdlNGI4MDFjNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCisrKyBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQpAQCAtMTU1LDYgKzE1NSw3IEBACiAgICAg ICAgICAgJ0VOQUJMRV9PUklFTlRBVElPTl9FVkVOVFM9MScsCiAgICAgICAgICAgJ0VOQUJMRV9P VkVSRkxPV19TQ1JPTExJTkc9MScsCiAgICAgICAgICAgJ0VOQUJMRV9QQUdFX1BPUFVQPTAnLAor ICAgICAgICAgICdFTkFCTEVfUFJJTlRJTkc9MCcsCiAgICAgICAgICAgIyBGSVhNRTogRGlzYWJs ZSBvbmNlIHRoZSBsaW5raW5nIGVycm9yIGhhcyBiZWVuIHJlc29sdmVkLgogICAgICAgICAgICMg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg4NjM2CiAgICAgICAgICAg J0VOQUJMRV9TSEFSRURfV09SS0VSUz0xJywKQEAgLTE3NSw2ICsxNzYsNyBAQAogICAgICAgICAg ICdFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTPTAnLAogICAgICAgICAgICdFTkFCTEVfT1ZFUkZM T1dfU0NST0xMSU5HPTAnLAogICAgICAgICAgICdFTkFCTEVfUEFHRV9QT1BVUD0xJywKKyAgICAg ICAgICAnRU5BQkxFX1BSSU5USU5HPTEnLAogICAgICAgICAgICdFTkFCTEVfU0hBUkVEX1dPUktF UlM9MScsCiAgICAgICAgICAgJ0VOQUJMRV9XRUJfQVVESU89MScsCiAgICAgICAgIF0sCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAppbmRleCA4OTE4OWVlYTJk ODEwMzVmZDg4NGU0OWU3ZThjOTI1M2VhNDViMjhiLi4wY2ZiYWMyMDk0MmNmZjEwZDBhMTAwNjFk ZDFhYTljNzZhMTFkMjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJGcmFtZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5jcHAKQEAgLTE1MjksNiArMTUyOSw3IEBAIGZsb2F0IFdlYkZyYW1lSW1wbDo6Z2V0UHJp bnRQYWdlU2hyaW5rKGludCBwYWdlKQogCiBmbG9hdCBXZWJGcmFtZUltcGw6OnByaW50UGFnZShp bnQgcGFnZSwgV2ViQ2FudmFzKiBjYW52YXMpCiB7CisjaWYgRU5BQkxFKFBSSU5USU5HKQogICAg IC8vIEVuc3VyZSBjb3JyZWN0IHN0YXRlLgogICAgIGlmICghbV9wcmludENvbnRleHQgfHwgcGFn ZSA8IDAgfHwgIWZyYW1lKCkgfHwgIWZyYW1lKCktPmRvY3VtZW50KCkpIHsKICAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7CkBAIC0xNTQwLDYgKzE1NDEsOSBAQCBmbG9hdCBXZWJGcmFtZUlt cGw6OnByaW50UGFnZShpbnQgcGFnZSwgV2ViQ2FudmFzKiBjYW52YXMpCiAgICAgZ2MucGxhdGZv cm1Db250ZXh0KCktPnNldFByaW50aW5nKHRydWUpOwogCiAgICAgcmV0dXJuIG1fcHJpbnRDb250 ZXh0LT5zcG9vbFBhZ2UoZ2MsIHBhZ2UpOworI2Vsc2UKKyAgICByZXR1cm4gMDsKKyNlbmRpZgog fQogCiB2b2lkIFdlYkZyYW1lSW1wbDo6cHJpbnRFbmQoKQo= 153096 2012-07-18 15:01:33 -0700 2012-07-18 17:07:29 -0700 Patch for landing bug-91550-20120718150132.patch text/plain 2254 abarth SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjMwMjIpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA3LTE4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgRGlzYWJsZSBwcmludGluZyBvbiBjaHJvbWl1bS1hbmRyb2lkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTU1MAorCisgICAgICAgIFJldmlld2Vk IGJ5IFRvbnkgQ2hhbmcuCisKKyAgICAgICAgV2UgZG9uJ3QgaW1wbGVtZW50IHByaW50aW5nIG9u IEFuZHJvaWQuCisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBpOgorICAgICAgICAqIHNyYy9XZWJG cmFtZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OnByaW50UGFnZSk6 CisKIDIwMTItMDctMTggIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBJbmRleGVkREI6IEZpeCBzb21lIGNvZGluZyBzdHlsZSB2aW9sYXRpb25zCkluZGV4OiBT b3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCShyZXZpc2lvbiAxMjMwMjIpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkJKHdvcmtpbmcgY29weSkKQEAgLTE1NSw2 ICsxNTUsNyBAQAogICAgICAgICAgICdFTkFCTEVfT1JJRU5UQVRJT05fRVZFTlRTPTEnLAogICAg ICAgICAgICdFTkFCTEVfT1ZFUkZMT1dfU0NST0xMSU5HPTEnLAogICAgICAgICAgICdFTkFCTEVf UEFHRV9QT1BVUD0wJywKKyAgICAgICAgICAnRU5BQkxFX1BSSU5USU5HPTAnLAogICAgICAgICAg ICMgRklYTUU6IERpc2FibGUgb25jZSB0aGUgbGlua2luZyBlcnJvciBoYXMgYmVlbiByZXNvbHZl ZC4KICAgICAgICAgICAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 ODYzNgogICAgICAgICAgICdFTkFCTEVfU0hBUkVEX1dPUktFUlM9MScsCkBAIC0xNzUsNiArMTc2 LDcgQEAKICAgICAgICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0wJywKICAgICAgICAg ICAnRU5BQkxFX09WRVJGTE9XX1NDUk9MTElORz0wJywKICAgICAgICAgICAnRU5BQkxFX1BBR0Vf UE9QVVA9MScsCisgICAgICAgICAgJ0VOQUJMRV9QUklOVElORz0xJywKICAgICAgICAgICAnRU5B QkxFX1NIQVJFRF9XT1JLRVJTPTEnLAogICAgICAgICAgICdFTkFCTEVfV0VCX0FVRElPPTEnLAog ICAgICAgICBdLApJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBs LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUlt cGwuY3BwCShyZXZpc2lvbiAxMjMwMjIpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJGcmFtZUltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTI5LDYgKzE1MjksNyBAQCBmbG9h dCBXZWJGcmFtZUltcGw6OmdldFByaW50UGFnZVNocmluayhpCiAKIGZsb2F0IFdlYkZyYW1lSW1w bDo6cHJpbnRQYWdlKGludCBwYWdlLCBXZWJDYW52YXMqIGNhbnZhcykKIHsKKyNpZiBFTkFCTEUo UFJJTlRJTkcpCiAgICAgLy8gRW5zdXJlIGNvcnJlY3Qgc3RhdGUuCiAgICAgaWYgKCFtX3ByaW50 Q29udGV4dCB8fCBwYWdlIDwgMCB8fCAhZnJhbWUoKSB8fCAhZnJhbWUoKS0+ZG9jdW1lbnQoKSkg ewogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKQEAgLTE1NDAsNiArMTU0MSw5IEBAIGZs b2F0IFdlYkZyYW1lSW1wbDo6cHJpbnRQYWdlKGludCBwYWdlLCAKICAgICBnYy5wbGF0Zm9ybUNv bnRleHQoKS0+c2V0UHJpbnRpbmcodHJ1ZSk7CiAKICAgICByZXR1cm4gbV9wcmludENvbnRleHQt PnNwb29sUGFnZShnYywgcGFnZSk7CisjZWxzZQorICAgIHJldHVybiAwOworI2VuZGlmCiB9CiAK IHZvaWQgV2ViRnJhbWVJbXBsOjpwcmludEVuZCgpCg==