91546 2012-07-17 15:12:21 -0700 Implement putIndexKeys in WebIDBObjectStoreImpl 2012-07-18 12:27:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91123 1 alecflett alecflett fishd jsbell webkit.review.bot oldest_to_newest 671636 0 alecflett 2012-07-17 15:12:21 -0700 Implement putIndexKeys in WebIDBObjectStoreImpl 671637 1 152842 alecflett 2012-07-17 15:13:11 -0700 Created attachment 152842 Patch 671640 2 alecflett 2012-07-17 15:14:11 -0700 Ugh, I managed to break up my patches incorrectly. This has to land before the chrome side. 672544 3 152842 fishd 2012-07-18 11:04:56 -0700 Comment on attachment 152842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152842&action=review > Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp:72 > + for (size_t i = 0; i < webIndexNames.size(); ++i) { Perhaps WebVector<T> should have a helper method for converting to a WTF::Vector. 672618 4 152842 webkit.review.bot 2012-07-18 12:27:08 -0700 Comment on attachment 152842 Patch Clearing flags on attachment: 152842 Committed r122999: <http://trac.webkit.org/changeset/122999> 672619 5 webkit.review.bot 2012-07-18 12:27:13 -0700 All reviewed patches have been landed. Closing bug. 152842 2012-07-17 15:13:11 -0700 2012-07-18 12:27:08 -0700 Patch bug-91546-20120717151309.patch text/plain 4006 alecflett U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY5MjAwZjAwMDIwMmFmMzkzNWE3MDA2ODEzZmIxMDJlM2IwZTlkODguLmNkZDQ3YzQ4YmQ4YjU5 MDQ2OTNlMzVkMGZiYTc2MWZmM2Y2ZWM5NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDctMTcgIEFsZWMgRmxldHQgIDxhbGVjZmxldHRAY2hyb21p dW0ub3JnPgorCisgICAgICAgIEltcGxlbWVudCBwdXRJbmRleEtleXMgaW4gV2ViSURCT2JqZWN0 U3RvcmVJbXBsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05MTU0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEltcGxlbWVudCBwdXRJbmRleEtleXMgaW4gdGhlIGNocm9taXVtIEFQSSwgc28gaXQgaXMgY2Fs bGFibGUKKyAgICAgICAgZnJvbSBjaHJvbWl1bS4KKworICAgICAgICAqIHNyYy9XZWJJREJPYmpl Y3RTdG9yZUltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJPYmplY3RTdG9yZUltcGw6 OnB1dFdpdGhJbmRleEtleXMpOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBzcmMvV2Vi SURCT2JqZWN0U3RvcmVJbXBsLmg6CisgICAgICAgIChXZWJJREJPYmplY3RTdG9yZUltcGwpOgor CiAyMDEyLTA3LTE3ICBWaXZlayBHYWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlZmFjdG9yIEluc3BlY3RvckNvbnRyb2xsZXI6OmNv bm5lY3RGcm9udGVuZCgpIHRvIGFjY2VwdCBJbnNwZWN0b3JGcm9udGVuZENoYW5uZWwuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJPYmplY3RTdG9yZUltcGwu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSURCT2JqZWN0U3RvcmVJbXBsLmNw cAppbmRleCA5YmFjNmQzYzM3OTI2MjFlMzlkNmZhNjRlY2RmZjdjZjFjMDhjYzU1Li41M2QxNDBm NDJiZTk4YjNhYmU3M2E3NGJiMzM1ZGYzY2ViNjVkMjljIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJJREJPYmplY3RTdG9yZUltcGwuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQk9iamVjdFN0b3JlSW1wbC5jcHAKQEAgLTYzLDYgKzYz LDIzIEBAIHZvaWQgV2ViSURCT2JqZWN0U3RvcmVJbXBsOjpwdXQoY29uc3QgV2ViU2VyaWFsaXpl ZFNjcmlwdFZhbHVlJiB2YWx1ZSwgY29uc3QgV2ViCiAgICAgbV9vYmplY3RTdG9yZS0+cHV0KHZh bHVlLCBrZXksIHN0YXRpY19jYXN0PElEQk9iamVjdFN0b3JlQmFja2VuZEludGVyZmFjZTo6UHV0 TW9kZT4ocHV0TW9kZSksIElEQkNhbGxiYWNrc1Byb3h5OjpjcmVhdGUoYWRvcHRQdHIoY2FsbGJh Y2tzKSksIHRyYW5zYWN0aW9uLmdldElEQlRyYW5zYWN0aW9uQmFja2VuZEludGVyZmFjZSgpLCBl Yyk7CiB9CiAKK3ZvaWQgV2ViSURCT2JqZWN0U3RvcmVJbXBsOjpwdXRXaXRoSW5kZXhLZXlzKGNv bnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSYgdmFsdWUsIGNvbnN0IFdlYklEQktleSYga2V5 LCBQdXRNb2RlIHB1dE1vZGUsIFdlYklEQkNhbGxiYWNrcyogY2FsbGJhY2tzLCBjb25zdCBXZWJJ REJUcmFuc2FjdGlvbiYgdHJhbnNhY3Rpb24sIGNvbnN0IFdlYlZlY3RvcjxXZWJTdHJpbmc+JiB3 ZWJJbmRleE5hbWVzLCBjb25zdCBXZWJWZWN0b3I8V2ViSW5kZXhLZXlzPiYgd2ViSW5kZXhLZXlz LCBXZWJFeGNlcHRpb25Db2RlJiBlYykKK3sKKyAgICBBU1NFUlQod2ViSW5kZXhOYW1lcy5zaXpl KCkgPT0gd2ViSW5kZXhLZXlzLnNpemUoKSk7CisgICAgVmVjdG9yPFN0cmluZz4gaW5kZXhOYW1l cyh3ZWJJbmRleE5hbWVzLnNpemUoKSk7CisgICAgVmVjdG9yPElEQk9iamVjdFN0b3JlQmFja2Vu ZEludGVyZmFjZTo6SW5kZXhLZXlzPiBpbmRleEtleXMod2ViSW5kZXhLZXlzLnNpemUoKSk7CisK KyAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHdlYkluZGV4TmFtZXMuc2l6ZSgpOyArK2kpIHsK KyAgICAgICAgaW5kZXhOYW1lc1tpXSA9IHdlYkluZGV4TmFtZXNbaV07CisgICAgICAgIFZlY3Rv cjxSZWZQdHI8SURCS2V5PiA+IGluZGV4S2V5TGlzdCh3ZWJJbmRleEtleXNbaV0uc2l6ZSgpKTsK KyAgICAgICAgZm9yIChzaXplX3QgaiA9IDA7IGogPCB3ZWJJbmRleEtleXNbaV0uc2l6ZSgpOyAr K2opCisgICAgICAgICAgICBpbmRleEtleUxpc3Rbal0gPSB3ZWJJbmRleEtleXNbaV1bal07Cisg ICAgICAgIGluZGV4S2V5c1tpXSA9IGluZGV4S2V5TGlzdDsKKyAgICB9CisKKyAgICBtX29iamVj dFN0b3JlLT5wdXRXaXRoSW5kZXhLZXlzKHZhbHVlLCBrZXksIHN0YXRpY19jYXN0PElEQk9iamVj dFN0b3JlQmFja2VuZEludGVyZmFjZTo6UHV0TW9kZT4ocHV0TW9kZSksIElEQkNhbGxiYWNrc1By b3h5OjpjcmVhdGUoYWRvcHRQdHIoY2FsbGJhY2tzKSksIHRyYW5zYWN0aW9uLmdldElEQlRyYW5z YWN0aW9uQmFja2VuZEludGVyZmFjZSgpLCBpbmRleE5hbWVzLCBpbmRleEtleXMsIGVjKTsKK30K Kwogdm9pZCBXZWJJREJPYmplY3RTdG9yZUltcGw6OmRlbGV0ZUZ1bmN0aW9uKGNvbnN0IFdlYklE QktleVJhbmdlJiBrZXlSYW5nZSwgV2ViSURCQ2FsbGJhY2tzKiBjYWxsYmFja3MsIGNvbnN0IFdl YklEQlRyYW5zYWN0aW9uJiB0cmFuc2FjdGlvbiwgV2ViRXhjZXB0aW9uQ29kZSYgZWMpCiB7CiAg ICAgbV9vYmplY3RTdG9yZS0+ZGVsZXRlRnVuY3Rpb24oa2V5UmFuZ2UsIElEQkNhbGxiYWNrc1By b3h5OjpjcmVhdGUoYWRvcHRQdHIoY2FsbGJhY2tzKSksIHRyYW5zYWN0aW9uLmdldElEQlRyYW5z YWN0aW9uQmFja2VuZEludGVyZmFjZSgpLCBlYyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJJREJPYmplY3RTdG9yZUltcGwuaCBiL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYklEQk9iamVjdFN0b3JlSW1wbC5oCmluZGV4IDVhODgxYjU5MmRjMzExZmM5 OTczODA4NjIxNzlmOTE0Y2IzOThmZDUuLmU2ZGM4OGY1NGQzNjQ3YmQ3YWIyZjZmOGE3Y2YyNjc0 ZjY2YzNiZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQk9i amVjdFN0b3JlSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQk9i amVjdFN0b3JlSW1wbC5oCkBAIC00Nyw2ICs0Nyw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgZ2V0 KGNvbnN0IFdlYklEQktleVJhbmdlJiwgV2ViSURCQ2FsbGJhY2tzKiwgY29uc3QgV2ViSURCVHJh bnNhY3Rpb24mLCBXZWJFeGNlcHRpb25Db2RlJik7CiAgICAgdm9pZCBwdXQoY29uc3QgV2ViU2Vy aWFsaXplZFNjcmlwdFZhbHVlJiwgY29uc3QgV2ViSURCS2V5JiwgUHV0TW9kZSwgV2ViSURCQ2Fs bGJhY2tzKiwgY29uc3QgV2ViSURCVHJhbnNhY3Rpb24mLCBXZWJFeGNlcHRpb25Db2RlJik7Cisg ICAgdm9pZCBwdXRXaXRoSW5kZXhLZXlzKGNvbnN0IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSYs IGNvbnN0IFdlYklEQktleSYsIFB1dE1vZGUsIFdlYklEQkNhbGxiYWNrcyosIGNvbnN0IFdlYklE QlRyYW5zYWN0aW9uJiwgY29uc3QgV2ViVmVjdG9yPFdlYlN0cmluZz4mIGluZGV4TmFtZXMsIGNv bnN0IFdlYlZlY3RvcjxXZWJJbmRleEtleXM+JiwgV2ViRXhjZXB0aW9uQ29kZSYpOwogICAgIHZv aWQgZGVsZXRlRnVuY3Rpb24oY29uc3QgV2ViSURCS2V5UmFuZ2UmLCBXZWJJREJDYWxsYmFja3Mq LCBjb25zdCBXZWJJREJUcmFuc2FjdGlvbiYsIFdlYkV4Y2VwdGlvbkNvZGUmKTsKICAgICB2b2lk IGNsZWFyKFdlYklEQkNhbGxiYWNrcyosIGNvbnN0IFdlYklEQlRyYW5zYWN0aW9uJiwgV2ViRXhj ZXB0aW9uQ29kZSYpOwogCg==