91545 2012-07-17 14:46:57 -0700 DragImageChromiumMac.cpp is never compiled and can be removed 2012-07-17 17:16:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 webkit.review.bot abarth abarth tony oldest_to_newest 671617 0 webkit.review.bot 2012-07-17 14:46:57 -0700 Check if we can delete DragImageChromiumMac.cpp Requested by abarth on #webkit. 671625 1 abarth 2012-07-17 14:58:50 -0700 Looks likely. 671657 2 tony 2012-07-17 15:27:16 -0700 Maybe from when we switched from cg to skia? Sure, let's delete it. 671660 3 152849 abarth 2012-07-17 15:31:29 -0700 Created attachment 152849 Patch 671667 4 abarth 2012-07-17 15:35:26 -0700 (In reply to comment #2) > Maybe from when we switched from cg to skia? Sure, let's delete it. Yeah. 671775 5 152849 webkit.review.bot 2012-07-17 17:16:15 -0700 Comment on attachment 152849 Patch Clearing flags on attachment: 152849 Committed r122900: <http://trac.webkit.org/changeset/122900> 671776 6 webkit.review.bot 2012-07-17 17:16:19 -0700 All reviewed patches have been landed. Closing bug. 152849 2012-07-17 15:31:29 -0700 2012-07-17 17:16:14 -0700 Patch bug-91545-20120717153128.patch text/plain 6917 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGYyMGFjNzQ5YzU1ODgz OGNiOWZkYTNjMTE0ZTVkN2ViYTYyYmM0OC4uZmQ5NWMwZDBjMTM5ODIxYmNhMmE0MjgxMTc1MTcz M2QyZjdlZmFlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTE3ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRHJhZ0ltYWdlQ2hyb21pdW1N YWMuY3BwIGlzIG5ldmVyIGNvbXBpbGVkIGFuZCBjYW4gYmUgcmVtb3ZlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE1NDUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGZpbGUgd291bGQgb25seSBi ZSBjb21waWxlZCBvbiBjaHJvbWl1bS1tYWMsIGJ1dCBpdCdzIGV4Y2x1ZGVkCisgICAgICAgIGZy b20gdGhhdCBidWlsZC4gVGhpcyBpcyBsaWtlbHkgbGVmdCBvdmVyIGZyb20gdGhlIENHIGNvbmZp Z3VyYXRpb24uCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cC9XZWJDb3JlLmd5cDoKKyAgICAgICAg KiBXZWJDb3JlLmd5cGk6CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hy b21pdW1NYWMuY3BwOiBSZW1vdmVkLgorCiAyMDEyLTA3LTE3ICBIYW5zIE11bGxlciAgPGhtdWxs ZXJAYWRvYmUuY29tPgogCiAgICAgICAgIFJlbmFtZSBDU1MgRXhjbHVzaW9ucyBDU1NXcmFwU2hh cGUgY2xhc3MgcHJvcGVydGllcyB0byBtYXRjaCBFeGNsdXNpb24gc2hhcGUgZnVuY3Rpb24gcGFy YW1ldGVycwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5n eXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCBjMjc0ZTJm MDNlYmJlMmMzYjgzODg4ZTk5OWRmZjg0MWY5MmE5Y2QwLi41NGNmMTQ0MDc5N2U0NTQ2MTIxM2Ex MjczYTYzZTdhM2U1NGYyYWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5 cC9XZWJDb3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5 cApAQCAtMTcwMyw3ICsxNzAzLDYgQEAKICAgICAgICAgICAgIFsnZXhjbHVkZScsICdwbGF0Zm9y bS9ncmFwaGljcy9za2lhL0ZvbnRDYWNoZVNraWFcXC5jcHAkJ10sCiAgICAgICAgICAgICBbJ2V4 Y2x1ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HbHlwaFBhZ2VUcmVlTm9kZVNraWFcXC5j cHAkJ10sCiAgICAgICAgICAgICBbJ2V4Y2x1ZGUnLCAncGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9T aW1wbGVGb250RGF0YVNraWFcXC5jcHAkJ10sCi0gICAgICAgICAgICBbJ2V4Y2x1ZGUnLCAncGxh dGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1NYWNcXC5jcHAkJ10sCiAKICAgICAgICAg ICAgICMgTWFjIHVzZXMgSGFyZmJ1enotbmcuCiAgICAgICAgICAgICBbJ2luY2x1ZGUnLCAncGxh dGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXJCYXNlXFwuKGNwcHxoKSQnXSwK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaSBiL1NvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZ3lwaQppbmRleCAzNjY3OGFmNGU1YWNlZmNhOGJjYmFlZmYxZjRkYzU0YmViNTBl ZTlkLi5jNDhlNjAyYzRjNmQ5MzQyMmQwOWExNmQzYzNiNmI4Y2ZhZGU3MDNjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29y ZS5neXBpCkBAIC0zMzYwLDcgKzMzNjAsNiBAQAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9t aXVtL0N1cnNvckNocm9taXVtLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vY2hyb21pdW0v RHJhZ0RhdGFDaHJvbWl1bS5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL0Ry YWdEYXRhUmVmLmgnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL0RyYWdJbWFnZUNo cm9taXVtTWFjLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdl Q2hyb21pdW1Ta2lhLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vY2hyb21pdW0vRHJhZ0lt YWdlUmVmLmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL0V2ZW50VHJhY2VyQ2hy b21pdW0uY3BwJywKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L0RyYWdJbWFnZUNocm9taXVtTWFjLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9t aXVtL0RyYWdJbWFnZUNocm9taXVtTWFjLmNwcApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggZTEyNzgwZjdlMWQ0NzliYTM4NWUwNjZkYjA0OTg0YzNmNWM0MmYyZi4uMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9jaHJvbWl1bS9EcmFnSW1hZ2VDaHJvbWl1bU1hYy5jcHAKKysrIC9kZXYvbnVsbApAQCAtMSwx MTQgKzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAoYykgMjAxMCwgR29vZ2xlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KLSAqIAotICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0Ci0gKiBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCi0gKiBt ZXQ6Ci0gKiAKLSAqICAgICAqIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJl dGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0Ci0gKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRp b25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCi0gKiAgICAgKiBSZWRpc3RyaWJ1dGlv bnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlCi0gKiBjb3B5cmlnaHQg bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp bWVyCi0gKiBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3Zp ZGVkIHdpdGggdGhlCi0gKiBkaXN0cmlidXRpb24uCi0gKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1l IG9mIEdvb2dsZSBJbmMuIG5vciB0aGUgbmFtZXMgb2YgaXRzCi0gKiBjb250cmlidXRvcnMgbWF5 IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQotICog dGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4K LSAqIAotICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERF UlMgQU5EIENPTlRSSUJVVE9SUwotICogIkFTIElTIiBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElF RCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKLSAqIExJTUlURUQgVE8sIFRIRSBJTVBM SUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUgotICogQSBQ QVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBD T1BZUklHSFQKLSAqIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJF Q1QsIElORElSRUNULCBJTkNJREVOVEFMLAotICogU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05T RVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAotICogTElNSVRFRCBUTywgUFJP Q1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsCi0g KiBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FV U0VEIEFORCBPTiBBTlkKLSAqIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJB Q1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKLSAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBP UiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQotICogT0YgVEhJ UyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB TUFHRS4KLSAqLwotCi0jaW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVkZSAiRHJhZ0ltYWdlLmgi Ci0KLSNpbmNsdWRlICJJbWFnZS5oIgotI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCi0jaW5j bHVkZSA8d3RmL1JldGFpblB0ci5oPgotCi0jaW5jbHVkZSA8Q29yZUdyYXBoaWNzL0NHQml0bWFw Q29udGV4dC5oPgotI2luY2x1ZGUgPENvcmVHcmFwaGljcy9DR0ltYWdlLmg+Ci0KLW5hbWVzcGFj ZSBXZWJDb3JlIHsKLQotSW50U2l6ZSBkcmFnSW1hZ2VTaXplKERyYWdJbWFnZVJlZiBpbWFnZSkK LXsKLSAgICBpZiAoIWltYWdlKQotICAgICAgICByZXR1cm4gSW50U2l6ZSgpOwotICAgIHJldHVy biBJbnRTaXplKENHSW1hZ2VHZXRXaWR0aChpbWFnZSksIENHSW1hZ2VHZXRIZWlnaHQoaW1hZ2Up KTsKLX0KLQotdm9pZCBkZWxldGVEcmFnSW1hZ2UoRHJhZ0ltYWdlUmVmIGltYWdlKQotewotICAg IENHSW1hZ2VSZWxlYXNlKGltYWdlKTsKLX0KLQotRHJhZ0ltYWdlUmVmIHNjYWxlRHJhZ0ltYWdl KERyYWdJbWFnZVJlZiBpbWFnZSwgRmxvYXRTaXplIHNjYWxlKQotewotICAgIGlmICghaW1hZ2Up Ci0gICAgICAgIHJldHVybiAwOwotICAgIHNpemVfdCB3aWR0aCA9IHJvdW5kZihDR0ltYWdlR2V0 V2lkdGgoaW1hZ2UpICogc2NhbGUud2lkdGgoKSk7Ci0gICAgc2l6ZV90IGhlaWdodCA9IHJvdW5k ZihDR0ltYWdlR2V0SGVpZ2h0KGltYWdlKSAqIHNjYWxlLmhlaWdodCgpKTsKLQotICAgIFJldGFp blB0cjxDR0NvbG9yU3BhY2VSZWY+IGRldmljZVJHQihXVEY6OkFkb3B0Q0YsIENHQ29sb3JTcGFj ZUNyZWF0ZVdpdGhOYW1lKGtDR0NvbG9yU3BhY2VHZW5lcmljUkdCKSk7Ci0gICAgQ0dDb250ZXh0 UmVmIGNvbnRleHQgPSBDR0JpdG1hcENvbnRleHRDcmVhdGUoMCwgd2lkdGgsIGhlaWdodCwgOCwg d2lkdGggKiA0LCBkZXZpY2VSR0IuZ2V0KCksIGtDR0ltYWdlQWxwaGFQcmVtdWx0aXBsaWVkRmly c3QgfCBrQ0dCaXRtYXBCeXRlT3JkZXIzMkhvc3QpOwotCi0gICAgaWYgKCFjb250ZXh0KQotICAg ICAgICByZXR1cm4gMDsKLSAgICBDR0NvbnRleHREcmF3SW1hZ2UoY29udGV4dCwgQ0dSZWN0TWFr ZSgwLCAwLCB3aWR0aCwgaGVpZ2h0KSwgaW1hZ2UpOwotICAgIENHSW1hZ2VSZWxlYXNlKGltYWdl KTsKLQotICAgIENHSW1hZ2VSZWYgc2NhbGVkSW1hZ2UgPSBDR0JpdG1hcENvbnRleHRDcmVhdGVJ bWFnZShjb250ZXh0KTsKLSAgICBDR0NvbnRleHRSZWxlYXNlKGNvbnRleHQpOwotICAgIHJldHVy biBzY2FsZWRJbWFnZTsKLX0KLQotRHJhZ0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFj dGlvbihEcmFnSW1hZ2VSZWYgaW1hZ2UsIGZsb2F0IGRlbHRhKQotewotICAgIGlmICghaW1hZ2Up Ci0gICAgICAgIHJldHVybiAwOwotICAgIHNpemVfdCB3aWR0aCA9IENHSW1hZ2VHZXRXaWR0aChp bWFnZSk7Ci0gICAgc2l6ZV90IGhlaWdodCA9IENHSW1hZ2VHZXRIZWlnaHQoaW1hZ2UpOwotCi0g ICAgUmV0YWluUHRyPENHQ29sb3JTcGFjZVJlZj4gZGV2aWNlUkdCKFdURjo6QWRvcHRDRiwgQ0dD b2xvclNwYWNlQ3JlYXRlV2l0aE5hbWUoa0NHQ29sb3JTcGFjZUdlbmVyaWNSR0IpKTsKLSAgICBD R0NvbnRleHRSZWYgY29udGV4dCA9IENHQml0bWFwQ29udGV4dENyZWF0ZSgwLCB3aWR0aCwgaGVp Z2h0LCA4LCB3aWR0aCAqIDQsIGRldmljZVJHQi5nZXQoKSwga0NHSW1hZ2VBbHBoYVByZW11bHRp cGxpZWRGaXJzdCB8IGtDR0JpdG1hcEJ5dGVPcmRlcjMySG9zdCk7Ci0KLSAgICBpZiAoIWNvbnRl eHQpCi0gICAgICAgIHJldHVybiAwOwotICAgIC8vIEZyb20gQ0dDb250ZXh0Lmg6Ci0gICAgLy8g ICAgIFRoZSBQb3J0ZXItRHVmZiAic291cmNlIG92ZXIiIG1vZGUgaXMgY2FsbGVkIGBrQ0dCbGVu ZE1vZGVOb3JtYWwnOgotICAgIC8vICAgICAgIFIgPSBTICsgRCooMSAtIFNhKQotICAgIC8vICBU aGlzIGlzIHRoZSBzYW1lIGFzIE5TQ29tcG9zaXRlU291cmNlT3Zlciwgd2hpY2ggaXMgd2hhdCAt W05TSW1hZ2UgZGlzc29sdmVUb1BvaW50OmZyYWN0aW9uOl0gdXNlcy4KLSAgICBDR0NvbnRleHRT ZXRBbHBoYShjb250ZXh0LCBkZWx0YSk7Ci0gICAgQ0dDb250ZXh0U2V0QmxlbmRNb2RlKGNvbnRl eHQsIGtDR0JsZW5kTW9kZU5vcm1hbCk7Ci0gICAgQ0dDb250ZXh0RHJhd0ltYWdlKGNvbnRleHQs IENHUmVjdE1ha2UoMCwgMCwgd2lkdGgsIGhlaWdodCksIGltYWdlKTsKLSAgICBDR0ltYWdlUmVs ZWFzZShpbWFnZSk7Ci0KLSAgICBDR0ltYWdlUmVmIGRpc3NvbHZlZEltYWdlID0gQ0dCaXRtYXBD b250ZXh0Q3JlYXRlSW1hZ2UoY29udGV4dCk7Ci0gICAgQ0dDb250ZXh0UmVsZWFzZShjb250ZXh0 KTsKLSAgICByZXR1cm4gZGlzc29sdmVkSW1hZ2U7Ci19Ci0KLURyYWdJbWFnZVJlZiBjcmVhdGVE cmFnSW1hZ2VGcm9tSW1hZ2UoSW1hZ2UqIGltYWdlLCBSZXNwZWN0SW1hZ2VPcmllbnRhdGlvbkVu dW0pCi17Ci0gICAgaWYgKCFpbWFnZSkKLSAgICAgICAgcmV0dXJuIDA7Ci0gICAgcmV0dXJuIENH SW1hZ2VDcmVhdGVDb3B5KGltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpKTsKLX0K LQotRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUljb25Gb3JDYWNoZWRJbWFnZShDYWNoZWRJ bWFnZSopCi17Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gMDsKLX0KLQotfSAv LyBuYW1lc3BhY2UgV2ViQ29yZQo=