91540 2012-07-17 13:52:09 -0700 [BlackBerry] Remove unnecessary clearWindow() calls and the method itself 2012-07-17 14:48:08 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits manyoso mifenton staikos tonikitoo webkit.review.bot oldest_to_newest 671565 0 jpetsovits 2012-07-17 13:52:09 -0700 While starting to fix the underlying issues of internal PR 174365 (assertion through clearWindow() call when we don't have any target buffer), I realized that this function call is actually entirely unnecessary. That doesn't obviate the need for a proper fix, but why not get rid of it when we have the chance. Patch below, more detailed explanation in the commit message. 671569 1 152820 jpetsovits 2012-07-17 13:55:03 -0700 Created attachment 152820 Patch 671618 2 152820 webkit.review.bot 2012-07-17 14:48:04 -0700 Comment on attachment 152820 Patch Clearing flags on attachment: 152820 Committed r122876: <http://trac.webkit.org/changeset/122876> 671619 3 webkit.review.bot 2012-07-17 14:48:08 -0700 All reviewed patches have been landed. Closing bug. 152820 2012-07-17 13:55:03 -0700 2012-07-17 14:48:04 -0700 Patch bug-91540-20120717165415.patch text/plain 4857 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAyYjQ0MDk2OWUxYzY3NDRkODQxMmY1MzI1OGE4ODEwMTRiYTdiNWUwLi4wZTlhNzlmMWM5 NDJhN2EyOTA0MzUwM2IxOWVlZjEzZTgxODMyZWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMi0wNy0xNyAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBSZW1vdmUgdW5uZWNlc3Nh cnkgY2xlYXJXaW5kb3coKSBjYWxscyBhbmQgdGhlIG1ldGhvZCBpdHNlbGYKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNTQwCisgICAgICAgIFJJTSBQ UiAxNzQzNjUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJZiB3ZSByZXN1bWUgdGhlIGJhY2tpbmdzdG9yZSByaWdodCBhZnRlcndhcmRzIHdpdGgKKyAg ICAgICAgUmVuZGVyQW5kQmxpdCB0aGVuIHRoYXQnbGwgZmlsbCB0aGUgd2hvbGUgdmlzaWJsZSBh cmVhCisgICAgICAgIHdpdGggY29udGVudCwgbWFraW5nIGEgY2xlYXJXaW5kb3coKSBjYWxsIHVu bmVjZXNzYXJ5LgorICAgICAgICBUaGlzIGNhbGwgaXMgYSByZW1uYW50IGZyb20gYWdlcyBhZ28s IGFuZCBpcyB3ZWxsIHN1aXRlZAorICAgICAgICB0byBkaXNhcHBlYXIgaW50byBub3RoaW5nbmVz cy4KKworICAgICAgICAoVGhlcmUgaXMgc3RpbGwgYSBjbGVhcldpbmRvdygpIGNhbGwsIHdpdGgg cmVjdCBhcmd1bWVudCwKKyAgICAgICAgd2hpY2ggd2UgY29udGludWUgdXNpbmcuIFRoaXMgY29t bWl0IG9ubHkgcmVtb3ZlcyB0aGUKKyAgICAgICAgcmVjdC1sZXNzIHZlcnNpb24uKQorCisgICAg ICAgICogQXBpL0JhY2tpbmdTdG9yZS5jcHA6CisgICAgICAgICogQXBpL0JhY2tpbmdTdG9yZV9w Lmg6CisgICAgICAgIChCYWNraW5nU3RvcmVQcml2YXRlKToKKyAgICAgICAgKiBBcGkvV2ViUGFn ZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjp6b29t QWJvdXRQb2ludCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRl Ojp6b29tQmxvY2spOgorCiAyMDEyLTA3LTEyICBKb25hdGhhbiBEb25nICA8am9uYXRoYW4uZG9u Z0B0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIENhbm5vdCB1c2Ug ZGlnZXN0IHByb3h5IGF1dGggYW5kIE5UTE0gYXV0aCBhdCB0aGUgc2FtZSB0aW1lCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKaW5kZXggZmYxMGZiNzM0 MTkzYmU1NjY4MjY0NTVmNzhjNzAxNjFjMWY1ZGU0OS4uZjRkZDY2MjQxZGRiZTc2NmI1NGQzMmQx OTRlNzQ4MmMxOWU2MjY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0Fw aS9CYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFj a2luZ1N0b3JlLmNwcApAQCAtMjUyMiwzMCArMjUyMiw2IEBAIHZvaWQgQmFja2luZ1N0b3JlUHJp dmF0ZTo6aW52YWxpZGF0ZVdpbmRvdyhjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCYgZHN0KQogICAg ICAgICB3aW5kb3ctPnBvc3QoZHN0UmVjdCk7CiB9CiAKLXZvaWQgQmFja2luZ1N0b3JlUHJpdmF0 ZTo6Y2xlYXJXaW5kb3coKQotewotICAgIGlmICghQmxhY2tCZXJyeTo6UGxhdGZvcm06OnVzZXJJ bnRlcmZhY2VUaHJlYWRNZXNzYWdlQ2xpZW50KCktPmlzQ3VycmVudFRocmVhZCgpICYmICFzaG91 bGREaXJlY3RSZW5kZXJpbmdUb1dpbmRvdygpKSB7Ci0gICAgICAgIHR5cGVkZWYgdm9pZCAoQmxh Y2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjoqRnVuY3Rpb25UeXBlKSgpOwot ICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6dXNlckludGVyZmFjZVRocmVhZE1lc3NhZ2VD bGllbnQoKS0+ZGlzcGF0Y2hNZXNzYWdlKAotICAgICAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZv cm06OmNyZWF0ZU1ldGhvZENhbGxNZXNzYWdlPEZ1bmN0aW9uVHlwZSwgQmFja2luZ1N0b3JlUHJp dmF0ZT4oCi0gICAgICAgICAgICAgICAgJkJhY2tpbmdTdG9yZVByaXZhdGU6OmNsZWFyV2luZG93 LCB0aGlzKSk7Ci0gICAgICAgIHJldHVybjsKLSAgICB9Ci0KLSAgICBCbGFja0JlcnJ5OjpQbGF0 Zm9ybTo6R3JhcGhpY3M6OkJ1ZmZlciogZHN0QnVmZmVyID0gYnVmZmVyKCk7Ci0gICAgQVNTRVJU KGRzdEJ1ZmZlcik7Ci0gICAgaWYgKCFkc3RCdWZmZXIpCi0gICAgICAgIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpsb2coQmxhY2tCZXJyeTo6UGxhdGZvcm06OkxvZ0xldmVsV2FybiwgIkVtcHR5IHdp bmRvdyBidWZmZXIsIGNvdWxkbid0IGNsZWFyV2luZG93Iik7Ci0KLSAgICB3aW5kb3dGcm9udEJ1 ZmZlclN0YXRlKCktPmNsZWFyQmxpdHRlZFJlZ2lvbigpOwotICAgIHdpbmRvd0JhY2tCdWZmZXJT dGF0ZSgpLT5hZGRCbGl0dGVkUmVnaW9uKFBsYXRmb3JtOjpJbnRSZWN0KAotICAgICAgICBQbGF0 Zm9ybTo6SW50UG9pbnQoMCwgMCksIHN1cmZhY2VTaXplKCkpKTsKLQotICAgIENvbG9yIGNvbG9y KG1fd2ViUGFnZS0+c2V0dGluZ3MoKS0+YmFja2dyb3VuZENvbG9yKCkpOwotICAgIEJsYWNrQmVy cnk6OlBsYXRmb3JtOjpHcmFwaGljczo6Y2xlYXJCdWZmZXIoZHN0QnVmZmVyLAotICAgICAgICBj b2xvci5yZWQoKSwgY29sb3IuZ3JlZW4oKSwgY29sb3IuYmx1ZSgpLCBjb2xvci5hbHBoYSgpKTsK LX0KLQogdm9pZCBCYWNraW5nU3RvcmVQcml2YXRlOjpjbGVhcldpbmRvdyhjb25zdCBQbGF0Zm9y bTo6SW50UmVjdCYgcmVjdCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dW5zaWduZWQgY2hhciByZWQsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHVuc2lnbmVkIGNoYXIgZ3JlZW4sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQXBpL0JhY2tpbmdTdG9yZV9wLmggYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0Jh Y2tpbmdTdG9yZV9wLmgKaW5kZXggM2NhYTJkZGFhODFmMGY0OGFjMjRhNzJmMmE3MjM4ZmY2ODI4 YTU1My4uMzI2NTE1NjU5NmMzYjUxM2JmMjdmMzQ2ZGU0NGQ1YzcxOWZjYTNjNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmVfcC5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlX3AuaApAQCAtMzEwLDcgKzMx MCw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgaW52YWxpZGF0ZVdpbmRvdygpOwogICAgIHZvaWQg aW52YWxpZGF0ZVdpbmRvdyhjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCYgZHN0KTsKLSAgICB2b2lk IGNsZWFyV2luZG93KCk7CiAgICAgdm9pZCBjbGVhcldpbmRvdyhjb25zdCBQbGF0Zm9ybTo6SW50 UmVjdCYsIHVuc2lnbmVkIGNoYXIgcmVkLCB1bnNpZ25lZCBjaGFyIGdyZWVuLCB1bnNpZ25lZCBj aGFyIGJsdWUsIHVuc2lnbmVkIGNoYXIgYWxwaGEgPSAyNTUpOwogCiAgICAgYm9vbCBpc1Njcm9s bGluZ09yWm9vbWluZygpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFn ZS5jcHAKaW5kZXggNGJkODAyYWYyZmRlOGJkZDA0MTAzMjgxYWRhN2U5YWU3ZmM4Mjc1Mi4uOGYz MTY5NTBlZTNkOWQ1ZjZlM2RhMmMyMTNkYzFlYjJkMjJjYWE1OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0xMjg0LDcgKzEyODQsNiBAQCBib29sIFdlYlBh Z2VQcml2YXRlOjp6b29tQWJvdXRQb2ludChkb3VibGUgdW5jbGFtcGVkU2NhbGUsIGNvbnN0IEZs b2F0UG9pbnQmIGFuYwogCiAgICAgLy8gQ2xlYXIgd2luZG93IHRvIG1ha2Ugc3VyZSB0aGVyZSBh cmUgbm8gYXJ0aWZhY3RzLgogICAgIGlmIChzaG91bGRSZW5kZXIpIHsKLSAgICAgICAgbV9iYWNr aW5nU3RvcmUtPmQtPmNsZWFyV2luZG93KCk7CiAgICAgICAgIC8vIFJlc3VtZSBhbGwgc2NyZWVu IHVwZGF0ZXMgdG8gdGhlIGJhY2tpbmdzdG9yZSBhbmQgcmVuZGVyK2JsaXQgdmlzaWJsZSBjb250 ZW50cyB0byBzY3JlZW4uCiAgICAgICAgIG1fYmFja2luZ1N0b3JlLT5kLT5yZXN1bWVTY3JlZW5B bmRCYWNraW5nU3RvcmVVcGRhdGVzKEJhY2tpbmdTdG9yZTo6UmVuZGVyQW5kQmxpdCk7CiAgICAg fSBlbHNlIHsKQEAgLTMxODcsNyArMzE4Niw2IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6Onpvb21C bG9jaygpCiAgICAgfQogCiAgICAgbm90aWZ5VHJhbnNmb3JtQ2hhbmdlZCgpOwotICAgIG1fYmFj a2luZ1N0b3JlLT5kLT5jbGVhcldpbmRvdygpOwogICAgIG1fYmFja2luZ1N0b3JlLT5kLT5yZXN1 bWVTY3JlZW5BbmRCYWNraW5nU3RvcmVVcGRhdGVzKEJhY2tpbmdTdG9yZTo6UmVuZGVyQW5kQmxp dCk7CiAgICAgbV9jbGllbnQtPnpvb21DaGFuZ2VkKG1fd2ViUGFnZS0+aXNNaW5ab29tZWQoKSwg bV93ZWJQYWdlLT5pc01heFpvb21lZCgpLCAhc2hvdWxkWm9vbU9uRXNjYXBlKCksIGN1cnJlbnRT Y2FsZSgpKTsKIH0K