91522 2012-07-17 10:44:21 -0700 Add MIPS add32 function 2012-07-31 11:44:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 fu webkit-unassigned webkit.review.bot oldest_to_newest 671377 0 fu 2012-07-17 10:44:21 -0700 Hi, I will post a patch to add "add32" function. Thanks! 671385 1 152785 fu 2012-07-17 10:48:56 -0700 Created attachment 152785 MIPS add32 function Here is the patch. The jsc testing is ok. Thanks! 672607 2 152785 ap 2012-07-18 12:08:14 -0700 Comment on attachment 152785 MIPS add32 function View in context: https://bugs.webkit.org/attachment.cgi?id=152785&action=review > Source/JavaScriptCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). Please write a brief description, as requested here. 672708 3 153078 fu 2012-07-18 13:36:12 -0700 Created attachment 153078 Update ChangeLog to include descriptions Hi, I updated ChangeLog to include descriptions. Thanks! 678569 4 154470 fu 2012-07-25 16:04:14 -0700 Created attachment 154470 Add MIPS isCompactPtrAlignedAddressOffset and add32 I added the "isCompactPtrAlignedAddressOffset" function to fix the MIPS build. The JSC testing is OK. Thanks a lot! 683318 5 154470 webkit.review.bot 2012-07-31 11:44:21 -0700 Comment on attachment 154470 Add MIPS isCompactPtrAlignedAddressOffset and add32 Clearing flags on attachment: 154470 Committed r124228: <http://trac.webkit.org/changeset/124228> 683319 6 webkit.review.bot 2012-07-31 11:44:24 -0700 All reviewed patches have been landed. Closing bug. 152785 2012-07-17 10:48:56 -0700 2012-07-18 13:36:12 -0700 MIPS add32 function mips-20120717.diff text/plain 1405 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIyODU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA3LTE3ICBDaGFvLXlpbmcgRnUgIDxmdUBtaXBzLmNvbT4KKworICAgICAgICBBZGQg TUlQUyBhZGQzMiBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTE1MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFuZ2Ugc3VjaCBhcyBh cHByb2FjaCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1mdW5jdGlvbiBkZXNjcmlwdGlvbnMg YmVsb3cgKE9PUFMhKS4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMu aDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjphZGQzMik6CisgICAgICAgIChN YWNyb0Fzc2VtYmxlck1JUFMpOgorCiAyMDEyLTA3LTE3ICBHYWJvciBSYXBjc2FueWkgIDxyZ2Fi b3JAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkZml4IGZyb20gWm9sdGFu IEhlcmN6ZWcgYWZ0ZXIgMTIyNzY4LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2Vt Ymxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCShyZXZpc2lvbiAxMjI4MzcpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xODksNiArMTg5LDEyIEBAIHB1YmxpYzoKICAgICAgICAgYWRkMzIo ZGF0YVRlbXBSZWdpc3RlciwgZGVzdCk7CiAgICAgfQogCisgICAgdm9pZCBhZGQzMihBYnNvbHV0 ZUFkZHJlc3Mgc3JjLCBSZWdpc3RlcklEIGRlc3QpCisgICAgeworICAgICAgICBsb2FkMzIoc3Jj Lm1fcHRyLCBkYXRhVGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgYWRkMzIoZGF0YVRlbXBSZWdpc3Rl ciwgZGVzdCk7CisgICAgfQorCiAgICAgdm9pZCBhZGQzMihSZWdpc3RlcklEIHNyYywgQWRkcmVz cyBkZXN0KQogICAgIHsKICAgICAgICAgaWYgKGRlc3Qub2Zmc2V0ID49IC0zMjc2OCAmJiBkZXN0 Lm9mZnNldCA8PSAzMjc2NyAmJiAhbV9maXhlZFdpZHRoKSB7Cg== 153078 2012-07-18 13:36:12 -0700 2012-07-25 16:04:14 -0700 Update ChangeLog to include descriptions mips-20120718.diff text/plain 1389 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIyODU1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA3LTE3ICBDaGFvLXlpbmcgRnUgIDxmdUBtaXBzLmNvbT4KKworICAgICAgICBBZGQg TUlQUyBhZGQzMiBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTE1MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgYSBuZXcgdmVyc2lvbiBvZiBhZGQzMiB0aGF0IGFjY2VwdHMgQWJzb2x1 dGVBZGRyZXNzIGFzIGlucHV0cy4KKworICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ck1JUFMuaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjphZGQzMik6IFN1cHBv cnQgQWJzb2x1dGVBZGRyZXNzIGFzIGlucHV0cy4KKyAgICAgICAgKE1hY3JvQXNzZW1ibGVyTUlQ Uyk6CisKIDIwMTItMDctMTcgIEdhYm9yIFJhcGNzYW55aSAgPHJnYWJvckB3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGRmaXggZnJvbSBab2x0YW4gSGVyY3plZyBhZnRlciAx MjI3NjguCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1i bGVyTUlQUy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHJldmlzaW9uIDEyMjgzNykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgJKHdvcmtpbmcgY29weSkKQEAg LTE4OSw2ICsxODksMTIgQEAgcHVibGljOgogICAgICAgICBhZGQzMihkYXRhVGVtcFJlZ2lzdGVy LCBkZXN0KTsKICAgICB9CiAKKyAgICB2b2lkIGFkZDMyKEFic29sdXRlQWRkcmVzcyBzcmMsIFJl Z2lzdGVySUQgZGVzdCkKKyAgICB7CisgICAgICAgIGxvYWQzMihzcmMubV9wdHIsIGRhdGFUZW1w UmVnaXN0ZXIpOworICAgICAgICBhZGQzMihkYXRhVGVtcFJlZ2lzdGVyLCBkZXN0KTsKKyAgICB9 CisKICAgICB2b2lkIGFkZDMyKFJlZ2lzdGVySUQgc3JjLCBBZGRyZXNzIGRlc3QpCiAgICAgewog ICAgICAgICBpZiAoZGVzdC5vZmZzZXQgPj0gLTMyNzY4ICYmIGRlc3Qub2Zmc2V0IDw9IDMyNzY3 ICYmICFtX2ZpeGVkV2lkdGgpIHsK 154470 2012-07-25 16:04:14 -0700 2012-07-31 11:44:21 -0700 Add MIPS isCompactPtrAlignedAddressOffset and add32 mips-20120725.diff text/plain 1813 fu SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIzNjcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDEyLTA3LTI1ICBDaGFvLXlpbmcgRnUgIDxmdUBtaXBzLmNvbT4KKworICAgICAgICBBZGQg TUlQUyBhZGQzMiBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTE1MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBZGQgaXNDb21wYWN0UHRyQWxpZ25lZEFkZHJlc3NPZmZzZXQuCisgICAgICAg IEFkZCBhIG5ldyB2ZXJzaW9uIG9mIGFkZDMyIHRoYXQgYWNjZXB0cyBBYnNvbHV0ZUFkZHJlc3Mg YXMgaW5wdXRzLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oOgor ICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxlck1JUFM6OmlzQ29tcGFjdFB0ckFsaWduZWRBZGRy ZXNzT2Zmc2V0KTogTmV3LgorICAgICAgICAoTWFjcm9Bc3NlbWJsZXJNSVBTKToKKyAgICAgICAg KEpTQzo6TWFjcm9Bc3NlbWJsZXJNSVBTOjphZGQzMik6IFN1cHBvcnQgQWJzb2x1dGVBZGRyZXNz IGFzIGlucHV0cy4KKwogMjAxMi0wNy0yNSAgQ2FpbyBNYXJjZWxvIGRlIE9saXZlaXJhIEZpbGhv ICA8Y2Fpby5vbGl2ZWlyYUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIENyZWF0ZSBhIHNwZWNp YWxpemVkIHBhaXIgZm9yIHVzZSBpbiBIYXNoTWFwIGl0ZXJhdG9ycwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCShy ZXZpc2lvbiAxMjM2MDQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyTUlQUy5oCSh3b3JraW5nIGNvcHkpCkBAIC00Myw2ICs0MywxMSBAQCBwdWJsaWM6 CiAgICAgewogICAgIH0KIAorICAgIHN0YXRpYyBib29sIGlzQ29tcGFjdFB0ckFsaWduZWRBZGRy ZXNzT2Zmc2V0KHB0cmRpZmZfdCB2YWx1ZSkKKyAgICB7CisgICAgICAgIHJldHVybiB2YWx1ZSA+ PSAtMjE0NzQ4MzY0NyAtIDEgJiYgdmFsdWUgPD0gMjE0NzQ4MzY0NzsKKyAgICB9CisKICAgICBz dGF0aWMgY29uc3QgU2NhbGUgU2NhbGVQdHIgPSBUaW1lc0ZvdXI7CiAKICAgICAvLyBGb3Igc3Rv cmluZyBpbW1lZGlhdGUgbnVtYmVyCkBAIC0xODksNiArMTk0LDEyIEBAIHB1YmxpYzoKICAgICAg ICAgYWRkMzIoZGF0YVRlbXBSZWdpc3RlciwgZGVzdCk7CiAgICAgfQogCisgICAgdm9pZCBhZGQz MihBYnNvbHV0ZUFkZHJlc3Mgc3JjLCBSZWdpc3RlcklEIGRlc3QpCisgICAgeworICAgICAgICBs b2FkMzIoc3JjLm1fcHRyLCBkYXRhVGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgYWRkMzIoZGF0YVRl bXBSZWdpc3RlciwgZGVzdCk7CisgICAgfQorCiAgICAgdm9pZCBhZGQzMihSZWdpc3RlcklEIHNy YywgQWRkcmVzcyBkZXN0KQogICAgIHsKICAgICAgICAgaWYgKGRlc3Qub2Zmc2V0ID49IC0zMjc2 OCAmJiBkZXN0Lm9mZnNldCA8PSAzMjc2NyAmJiAhbV9maXhlZFdpZHRoKSB7Cg==