91513 2012-07-17 10:06:51 -0700 Web Inspector: create timeline detail records lazily 2012-07-18 05:39:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 671345 0 caseq 2012-07-17 10:06:51 -0700 Timeline record details include linkified locations, which are rather large. I'm getting a reduction from 132M to 117M in heap sizes by not creating record details until these are used. 671347 1 152775 caseq 2012-07-17 10:07:59 -0700 Created attachment 152775 Patch 671520 2 152775 pfeldman 2012-07-17 13:11:00 -0700 Comment on attachment 152775 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152775&action=review > Source/WebCore/inspector/front-end/TimelinePresentationModel.js:633 > + get details() Please annotate. Also, please use functions where possible since they are more compiler-friendly. 672282 3 caseq 2012-07-18 05:39:08 -0700 Committed r122950: <http://trac.webkit.org/changeset/122950> 152775 2012-07-17 10:07:59 -0700 2012-07-17 13:11:00 -0700 Patch bug-91513-20120717210757.patch text/plain 1655 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI5MzhlODAxM2U3NjM2 YzMyOGYzN2E3Mjk3MDdiZWE2NTk1ZGE4NS4uZDM2MThmZDI4OTkyOTNlOTM3ZmFjMjkzNWI2M2U4 Yjc0ZGY0ZTI4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTE3ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogY3JlYXRlIHRpbWVsaW5lIGRldGFpbCByZWNvcmRzIGxhemlseQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE1MTMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIG9ubHkgY3JlYXRlIHRpbWVsaW5lIHJl Y29yZCBkZXRhaWxzIHdoZW4gdGhlc2UgYXJlIHVzZWQ7CisKKyAgICAgICAgKiBpbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbC5SZWNvcmQucHJvdG90eXBlLl9yZWZyZXNo RGV0YWlscyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQcmVzZW50YXRpb25Nb2Rl bC5SZWNvcmQucHJvdG90eXBlLmdldCBkZXRhaWxzKToKKwogMjAxMi0wNy0xNyAgU2hlcmlmZiBC b3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg cm9sbGluZyBvdXQgcjEyMjgzNC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvVGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbC5qcyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQcmVzZW50YXRpb25Nb2RlbC5qcwppbmRleCAw MmFkOTkwNTEyNDU0MGNhZjg5MTMzMDQ0MGUwNTdjZjEyNWNhNzIzLi40YmI0MjVmNDZjMWYyZjkw MWI2Yzk5MTMzYzhmZGZmMGIyMTAyYjBlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUHJlc2VudGF0aW9uTW9kZWwuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVByZXNlbnRhdGlvbk1vZGVsLmpz CkBAIC02MjcsNyArNjI3LDE0IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVByZXNlbnRhdGlvbk1v ZGVsLlJlY29yZC5wcm90b3R5cGUgPSB7CiAKICAgICBfcmVmcmVzaERldGFpbHM6IGZ1bmN0aW9u KCkKICAgICB7Ci0gICAgICAgIHRoaXMuZGV0YWlscyA9IHRoaXMuX2dldFJlY29yZERldGFpbHMo KTsKKyAgICAgICAgZGVsZXRlIHRoaXMuX2RldGFpbHM7CisgICAgfSwKKworICAgIGdldCBkZXRh aWxzKCkKKyAgICB7CisgICAgICAgIGlmICghdGhpcy5fZGV0YWlscykKKyAgICAgICAgICAgIHRo aXMuX2RldGFpbHMgPSB0aGlzLl9nZXRSZWNvcmREZXRhaWxzKCk7CisgICAgICAgIHJldHVybiB0 aGlzLl9kZXRhaWxzOwogICAgIH0sCiAKICAgICBfZ2V0UmVjb3JkRGV0YWlsczogZnVuY3Rpb24o KQo=