91496 2012-07-17 05:26:40 -0700 [GTK] Don't use deprecated soup API in WebKit2APITests/TestResources 2012-07-17 07:45:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 671198 0 cgarcia 2012-07-17 05:26:40 -0700 soup_message_headers_get() is deprecated, we should use soup_message_headers_get_one() instead 671199 1 152743 cgarcia 2012-07-17 05:28:04 -0700 Created attachment 152743 Patch 671202 2 webkit.review.bot 2012-07-17 05:30:58 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 671270 3 cgarcia 2012-07-17 07:45:50 -0700 Committed r122844: <http://trac.webkit.org/changeset/122844> 152743 2012-07-17 05:28:04 -0700 2012-07-17 06:14:27 -0700 Patch wk2-soup-deprecated.diff text/plain 1550 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZTc4OGU0OS4uZDYyMzFjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEyLTA3LTE3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAorICAgICAgICBbR1RLXSBEb24ndCB1c2UgZGVwcmVjYXRlZCBzb3VwIEFQSSBpbiBXZWJL aXQyQVBJVGVzdHMvVGVzdFJlc291cmNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTE0OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19nZXQoKSBpcyBkZXByZWNhdGVk LCB1c2UKKyAgICAgICAgc291cF9tZXNzYWdlX2hlYWRlcnNfZ2V0X29uZSgpIGluc3RlYWQuCisK KyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0UmVzb3VyY2VzLmNwcDoKKyAg ICAgICAgKHNlcnZlckNhbGxiYWNrKToKKworMjAxMi0wNy0xNyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gUGFzdGUgcHJpbWFyeSBz ZWxlY3Rpb24gd2hlbiBtaWRkbGUgY2xpY2tpbmcgaW4gWDExIFdlYktpdDIKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNDExCiAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RSZXNvdXJjZXMuY3Bw IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFJlc291cmNlcy5j cHAKaW5kZXggODQyMGE5OS4uZGM3YTUxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFJlc291cmNlcy5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFJlc291cmNlcy5jcHAKQEAgLTU2Miw3ICs1 NjIsNyBAQCBzdGF0aWMgdm9pZCBzZXJ2ZXJDYWxsYmFjayhTb3VwU2VydmVyKiBzZXJ2ZXIsIFNv dXBNZXNzYWdlKiBtZXNzYWdlLCBjb25zdCBjaGFyKgogCiAgICAgc291cF9tZXNzYWdlX3NldF9z dGF0dXMobWVzc2FnZSwgU09VUF9TVEFUVVNfT0spOwogCi0gICAgaWYgKHNvdXBfbWVzc2FnZV9o ZWFkZXJzX2dldChtZXNzYWdlLT5yZXF1ZXN0X2hlYWRlcnMsICJJZi1Nb2RpZmllZC1TaW5jZSIp KSB7CisgICAgaWYgKHNvdXBfbWVzc2FnZV9oZWFkZXJzX2dldF9vbmUobWVzc2FnZS0+cmVxdWVz dF9oZWFkZXJzLCAiSWYtTW9kaWZpZWQtU2luY2UiKSkgewogICAgICAgICBzb3VwX21lc3NhZ2Vf c2V0X3N0YXR1cyhtZXNzYWdlLCBTT1VQX1NUQVRVU19OT1RfTU9ESUZJRUQpOwogICAgICAgICBz b3VwX21lc3NhZ2VfYm9keV9jb21wbGV0ZShtZXNzYWdlLT5yZXNwb25zZV9ib2R5KTsKICAgICAg ICAgcmV0dXJuOwo=