91495 2012-07-17 05:13:50 -0700 [GTK] Fix a typo in WebKit2APITests/TestResources 2012-07-17 05:30:23 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 91478 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 671187 0 cgarcia 2012-07-17 05:13:50 -0700 s/waitUntilResourceLoadFinsihed/waitUntilResourceLoadFinished/g 671189 1 152738 cgarcia 2012-07-17 05:15:33 -0700 Created attachment 152738 Patch 671192 2 webkit.review.bot 2012-07-17 05:18:41 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 671194 3 152738 xan.lopez 2012-07-17 05:21:09 -0700 Comment on attachment 152738 Patch r=me 671201 4 cgarcia 2012-07-17 05:30:23 -0700 Committed r122840: <http://trac.webkit.org/changeset/122840> 152738 2012-07-17 05:15:33 -0700 2012-07-17 05:21:09 -0700 Patch wk2-typo.diff text/plain 6593 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlZTc4OGU0OS4uMjdkNjIyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4 IEBACiAyMDEyLTA3LTE3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KIAorICAgICAgICBbR1RLXSBGaXggYSB0eXBvIGluIFdlYktpdDJBUElUZXN0cy9UZXN0UmVz b3VyY2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MTQ5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9ndGsvdGVzdHMvVGVzdFJlc291cmNlcy5jcHA6CisgICAgICAgICh0ZXN0 V2ViUmVzb3VyY2VMb2FkaW5nKToKKyAgICAgICAgKHRlc3RXZWJSZXNvdXJjZVJlc3BvbnNlKToK KyAgICAgICAgKHRlc3RXZWJSZXNvdXJjZU1pbWVUeXBlKToKKyAgICAgICAgKHRlc3RXZWJSZXNv dXJjZUFjdGl2ZVVSSSk6CisKKzIwMTItMDctMTcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFBhc3RlIHByaW1hcnkgc2VsZWN0aW9u IHdoZW4gbWlkZGxlIGNsaWNraW5nIGluIFgxMSBXZWJLaXQyCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTQxMQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay90ZXN0cy9UZXN0UmVzb3VyY2VzLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RSZXNvdXJjZXMuY3BwCmluZGV4 IDdkZTk1ZTAuLjE0MjNjOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL3Rlc3RzL1Rlc3RSZXNvdXJjZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9BUEkvZ3RrL3Rlc3RzL1Rlc3RSZXNvdXJjZXMuY3BwCkBAIC0yOTMsMTYgKzI5MywxNiBA QCBwdWJsaWM6CiAgICAgICAgICAgICBtX2xvYWRFdmVudHMuYXBwZW5kKEZhaWxlZCk7CiAgICAg fQogCi0gICAgdm9pZCB3YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5zaWhlZCgpCisgICAgdm9pZCB3 YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5pc2hlZCgpCiAgICAgewogICAgICAgICBtX3Jlc291cmNl ID0gMDsKICAgICAgICAgbV9yZXNvdXJjZXNMb2FkZWQgPSAwOwogICAgICAgICBnX21haW5fbG9v cF9ydW4obV9tYWluTG9vcCk7CiAgICAgfQogCi0gICAgV2ViS2l0VVJJUmVzcG9uc2UqIHdhaXRV bnRpbFJlc291cmNlTG9hZEZpbnNpaGVkQW5kUmV0dXJuVVJJUmVzcG9uc2UoKQorICAgIFdlYktp dFVSSVJlc3BvbnNlKiB3YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5pc2hlZEFuZFJldHVyblVSSVJl c3BvbnNlKCkKICAgICB7Ci0gICAgICAgIHdhaXRVbnRpbFJlc291cmNlTG9hZEZpbnNpaGVkKCk7 CisgICAgICAgIHdhaXRVbnRpbFJlc291cmNlTG9hZEZpbmlzaGVkKCk7CiAgICAgICAgIGdfYXNz ZXJ0KG1fcmVzb3VyY2UpOwogICAgICAgICByZXR1cm4gd2Via2l0X3dlYl9yZXNvdXJjZV9nZXRf cmVzcG9uc2UobV9yZXNvdXJjZS5nZXQoKSk7CiAgICAgfQpAQCAtMzE1LDcgKzMxNSw3IEBAIHB1 YmxpYzoKIHN0YXRpYyB2b2lkIHRlc3RXZWJSZXNvdXJjZUxvYWRpbmcoU2luZ2xlUmVzb3VyY2VM b2FkVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKIHsKICAgICB0ZXN0LT5sb2FkVVJJKGtTZXJ2 ZXItPmdldFVSSUZvclBhdGgoIi9qYXZhc2NyaXB0Lmh0bWwiKS5kYXRhKCkpOwotICAgIHRlc3Qt PndhaXRVbnRpbFJlc291cmNlTG9hZEZpbnNpaGVkKCk7CisgICAgdGVzdC0+d2FpdFVudGlsUmVz b3VyY2VMb2FkRmluaXNoZWQoKTsKICAgICBnX2Fzc2VydCh0ZXN0LT5tX3Jlc291cmNlKTsKICAg ICBWZWN0b3I8U2luZ2xlUmVzb3VyY2VMb2FkVGVzdDo6TG9hZEV2ZW50cz4mIGV2ZW50cyA9IHRl c3QtPm1fbG9hZEV2ZW50czsKICAgICBnX2Fzc2VydF9jbXBpbnQoZXZlbnRzLnNpemUoKSwgPT0s IDUpOwpAQCAtMzI3LDcgKzMyNyw3IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJSZXNvdXJjZUxvYWRp bmcoU2luZ2xlUmVzb3VyY2VMb2FkVGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICBldmVu dHMuY2xlYXIoKTsKIAogICAgIHRlc3QtPmxvYWRVUkkoa1NlcnZlci0+Z2V0VVJJRm9yUGF0aCgi L3JlZGlyZWN0ZWQtY3NzLmh0bWwiKS5kYXRhKCkpOwotICAgIHRlc3QtPndhaXRVbnRpbFJlc291 cmNlTG9hZEZpbnNpaGVkKCk7CisgICAgdGVzdC0+d2FpdFVudGlsUmVzb3VyY2VMb2FkRmluaXNo ZWQoKTsKICAgICBnX2Fzc2VydCh0ZXN0LT5tX3Jlc291cmNlKTsKICAgICBnX2Fzc2VydF9jbXBp bnQoZXZlbnRzLnNpemUoKSwgPT0sIDYpOwogICAgIGdfYXNzZXJ0X2NtcGludChldmVudHNbMF0s ID09LCBTaW5nbGVSZXNvdXJjZUxvYWRUZXN0OjpTdGFydGVkKTsKQEAgLTMzOSw3ICszMzksNyBA QCBzdGF0aWMgdm9pZCB0ZXN0V2ViUmVzb3VyY2VMb2FkaW5nKFNpbmdsZVJlc291cmNlTG9hZFRl c3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCiAgICAgZXZlbnRzLmNsZWFyKCk7CiAKICAgICB0ZXN0 LT5sb2FkVVJJKGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi9pbnZhbGlkLWNzcy5odG1sIikuZGF0 YSgpKTsKLSAgICB0ZXN0LT53YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5zaWhlZCgpOworICAgIHRl c3QtPndhaXRVbnRpbFJlc291cmNlTG9hZEZpbmlzaGVkKCk7CiAgICAgZ19hc3NlcnQodGVzdC0+ bV9yZXNvdXJjZSk7CiAgICAgZ19hc3NlcnRfY21waW50KGV2ZW50cy5zaXplKCksID09LCA0KTsK ICAgICBnX2Fzc2VydF9jbXBpbnQoZXZlbnRzWzBdLCA9PSwgU2luZ2xlUmVzb3VyY2VMb2FkVGVz dDo6U3RhcnRlZCk7CkBAIC0zNTMsNDcgKzM1Myw0NyBAQCBzdGF0aWMgdm9pZCB0ZXN0V2ViUmVz b3VyY2VSZXNwb25zZShTaW5nbGVSZXNvdXJjZUxvYWRUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVy KQogewogICAgIC8vIE5vIGNhY2hlZCByZXNvdXJjZTogRmlyc3QgbG9hZC4KICAgICB0ZXN0LT5s b2FkVVJJKGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi9qYXZhc2NyaXB0Lmh0bWwiKS5kYXRhKCkp OwotICAgIFdlYktpdFVSSVJlc3BvbnNlKiByZXNwb25zZSA9IHRlc3QtPndhaXRVbnRpbFJlc291 cmNlTG9hZEZpbnNpaGVkQW5kUmV0dXJuVVJJUmVzcG9uc2UoKTsKKyAgICBXZWJLaXRVUklSZXNw b25zZSogcmVzcG9uc2UgPSB0ZXN0LT53YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5pc2hlZEFuZFJl dHVyblVSSVJlc3BvbnNlKCk7CiAgICAgZ19hc3NlcnRfY21waW50KHdlYmtpdF91cmlfcmVzcG9u c2VfZ2V0X3N0YXR1c19jb2RlKHJlc3BvbnNlKSwgPT0sIFNPVVBfU1RBVFVTX09LKTsKIAogICAg IC8vIE5vIGNhY2hlZCByZXNvdXJjZTogU2Vjb25kIGxvYWQuCiAgICAgdGVzdC0+bG9hZFVSSShr U2VydmVyLT5nZXRVUklGb3JQYXRoKCIvamF2YXNjcmlwdC5odG1sIikuZGF0YSgpKTsKLSAgICBy ZXNwb25zZSA9IHRlc3QtPndhaXRVbnRpbFJlc291cmNlTG9hZEZpbnNpaGVkQW5kUmV0dXJuVVJJ UmVzcG9uc2UoKTsKKyAgICByZXNwb25zZSA9IHRlc3QtPndhaXRVbnRpbFJlc291cmNlTG9hZEZp bmlzaGVkQW5kUmV0dXJuVVJJUmVzcG9uc2UoKTsKICAgICBnX2Fzc2VydF9jbXBpbnQod2Via2l0 X3VyaV9yZXNwb25zZV9nZXRfc3RhdHVzX2NvZGUocmVzcG9uc2UpLCA9PSwgU09VUF9TVEFUVVNf T0spOwogCiAgICAgLy8gTm8gY2FjaGVkIHJlc291cmNlOiBSZWxvYWQuCiAgICAgd2Via2l0X3dl Yl92aWV3X3JlbG9hZCh0ZXN0LT5tX3dlYlZpZXcpOwotICAgIHJlc3BvbnNlID0gdGVzdC0+d2Fp dFVudGlsUmVzb3VyY2VMb2FkRmluc2loZWRBbmRSZXR1cm5VUklSZXNwb25zZSgpOworICAgIHJl c3BvbnNlID0gdGVzdC0+d2FpdFVudGlsUmVzb3VyY2VMb2FkRmluaXNoZWRBbmRSZXR1cm5VUklS ZXNwb25zZSgpOwogICAgIGdfYXNzZXJ0X2NtcGludCh3ZWJraXRfdXJpX3Jlc3BvbnNlX2dldF9z dGF0dXNfY29kZShyZXNwb25zZSksID09LCBTT1VQX1NUQVRVU19PSyk7CiAKICAgICAvLyBDYWNo ZWQgcmVzb3VyY2U6IEZpcnN0IGxvYWQuCiAgICAgdGVzdC0+bG9hZFVSSShrU2VydmVyLT5nZXRV UklGb3JQYXRoKCIvaW1hZ2UuaHRtbCIpLmRhdGEoKSk7Ci0gICAgcmVzcG9uc2UgPSB0ZXN0LT53 YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5zaWhlZEFuZFJldHVyblVSSVJlc3BvbnNlKCk7CisgICAg cmVzcG9uc2UgPSB0ZXN0LT53YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5pc2hlZEFuZFJldHVyblVS SVJlc3BvbnNlKCk7CiAgICAgZ19hc3NlcnRfY21waW50KHdlYmtpdF91cmlfcmVzcG9uc2VfZ2V0 X3N0YXR1c19jb2RlKHJlc3BvbnNlKSwgPT0sIFNPVVBfU1RBVFVTX09LKTsKIAogICAgIC8vIENh Y2hlZCByZXNvdXJjZTogU2Vjb25kIGxvYWQuCiAgICAgdGVzdC0+bG9hZFVSSShrU2VydmVyLT5n ZXRVUklGb3JQYXRoKCIvaW1hZ2UuaHRtbCIpLmRhdGEoKSk7Ci0gICAgcmVzcG9uc2UgPSB0ZXN0 LT53YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5zaWhlZEFuZFJldHVyblVSSVJlc3BvbnNlKCk7Cisg ICAgcmVzcG9uc2UgPSB0ZXN0LT53YWl0VW50aWxSZXNvdXJjZUxvYWRGaW5pc2hlZEFuZFJldHVy blVSSVJlc3BvbnNlKCk7CiAgICAgZ19hc3NlcnRfY21waW50KHdlYmtpdF91cmlfcmVzcG9uc2Vf Z2V0X3N0YXR1c19jb2RlKHJlc3BvbnNlKSwgPT0sIFNPVVBfU1RBVFVTX09LKTsKIAogICAgIC8v IENhY2hlZCByZXNvdXJjZTogUmVsb2FkLgogICAgIHdlYmtpdF93ZWJfdmlld19yZWxvYWQodGVz dC0+bV93ZWJWaWV3KTsKLSAgICByZXNwb25zZSA9IHRlc3QtPndhaXRVbnRpbFJlc291cmNlTG9h ZEZpbnNpaGVkQW5kUmV0dXJuVVJJUmVzcG9uc2UoKTsKKyAgICByZXNwb25zZSA9IHRlc3QtPndh aXRVbnRpbFJlc291cmNlTG9hZEZpbmlzaGVkQW5kUmV0dXJuVVJJUmVzcG9uc2UoKTsKICAgICBn X2Fzc2VydF9jbXBpbnQod2Via2l0X3VyaV9yZXNwb25zZV9nZXRfc3RhdHVzX2NvZGUocmVzcG9u c2UpLCA9PSwgU09VUF9TVEFUVVNfTk9UX01PRElGSUVEKTsKIH0KIAogc3RhdGljIHZvaWQgdGVz dFdlYlJlc291cmNlTWltZVR5cGUoU2luZ2xlUmVzb3VyY2VMb2FkVGVzdCogdGVzdCwgZ2NvbnN0 cG9pbnRlcikKIHsKICAgICB0ZXN0LT5sb2FkVVJJKGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi9q YXZhc2NyaXB0Lmh0bWwiKS5kYXRhKCkpOwotICAgIFdlYktpdFVSSVJlc3BvbnNlKiByZXNwb25z ZSA9IHRlc3QtPndhaXRVbnRpbFJlc291cmNlTG9hZEZpbnNpaGVkQW5kUmV0dXJuVVJJUmVzcG9u c2UoKTsKKyAgICBXZWJLaXRVUklSZXNwb25zZSogcmVzcG9uc2UgPSB0ZXN0LT53YWl0VW50aWxS ZXNvdXJjZUxvYWRGaW5pc2hlZEFuZFJldHVyblVSSVJlc3BvbnNlKCk7CiAgICAgZ19hc3NlcnRf Y21wc3RyKHdlYmtpdF91cmlfcmVzcG9uc2VfZ2V0X21pbWVfdHlwZShyZXNwb25zZSksID09LCAi dGV4dC9qYXZhc2NyaXB0Iik7CiAKICAgICB0ZXN0LT5sb2FkVVJJKGtTZXJ2ZXItPmdldFVSSUZv clBhdGgoIi9pbWFnZS5odG1sIikuZGF0YSgpKTsKLSAgICByZXNwb25zZSA9IHRlc3QtPndhaXRV bnRpbFJlc291cmNlTG9hZEZpbnNpaGVkQW5kUmV0dXJuVVJJUmVzcG9uc2UoKTsKKyAgICByZXNw b25zZSA9IHRlc3QtPndhaXRVbnRpbFJlc291cmNlTG9hZEZpbmlzaGVkQW5kUmV0dXJuVVJJUmVz cG9uc2UoKTsKICAgICBnX2Fzc2VydF9jbXBzdHIod2Via2l0X3VyaV9yZXNwb25zZV9nZXRfbWlt ZV90eXBlKHJlc3BvbnNlKSwgPT0sICJpbWFnZS92bmQubWljcm9zb2Z0Lmljb24iKTsKIAogICAg IHRlc3QtPmxvYWRVUkkoa1NlcnZlci0+Z2V0VVJJRm9yUGF0aCgiL3JlZGlyZWN0ZWQtY3NzLmh0 bWwiKS5kYXRhKCkpOwotICAgIHJlc3BvbnNlID0gdGVzdC0+d2FpdFVudGlsUmVzb3VyY2VMb2Fk Rmluc2loZWRBbmRSZXR1cm5VUklSZXNwb25zZSgpOworICAgIHJlc3BvbnNlID0gdGVzdC0+d2Fp dFVudGlsUmVzb3VyY2VMb2FkRmluaXNoZWRBbmRSZXR1cm5VUklSZXNwb25zZSgpOwogICAgIGdf YXNzZXJ0X2NtcHN0cih3ZWJraXRfdXJpX3Jlc3BvbnNlX2dldF9taW1lX3R5cGUocmVzcG9uc2Up LCA9PSwgInRleHQvY3NzIik7CiB9CiAKQEAgLTQ3NSw3ICs0NzUsNyBAQCBwcml2YXRlOgogc3Rh dGljIHZvaWQgdGVzdFdlYlJlc291cmNlQWN0aXZlVVJJKFJlc291cmNlVVJJVHJhY2tpbmdUZXN0 KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogewogICAgIHRlc3QtPmxvYWRVUkkoa1NlcnZlci0+Z2V0 VVJJRm9yUGF0aCgiL3JlZGlyZWN0ZWQtY3NzLmh0bWwiKS5kYXRhKCkpOwotICAgIHRlc3QtPndh aXRVbnRpbFJlc291cmNlTG9hZEZpbnNpaGVkKCk7CisgICAgdGVzdC0+d2FpdFVudGlsUmVzb3Vy Y2VMb2FkRmluaXNoZWQoKTsKIH0KIAogc3RhdGljIHZvaWQgdGVzdFdlYlJlc291cmNlR2V0RGF0 YShSZXNvdXJjZXNUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQo=