91481 2012-07-17 03:00:32 -0700 Decimal::toString should not round integer value. 2012-07-18 01:09:59 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91572 91579 1 yosin yosin tkent oldest_to_newest 671113 0 yosin 2012-07-17 03:00:32 -0700 Following test case in LayoutTests/fast/forms/datetime/input-valueasnumber-datetime.html is failed: shouldBe('setValueAsNumberAndGetValue(275760, 8, 12, 0, 0, 0, 1)', '"275760-09-12T00:00:00.001Z"'); The root cause is Decimal::toString. It converts an integer 8639999913600001 (= Date.UTC(275760, 8, 12, 0, 0, 0 1)) to a string "8639999913600000", the last digit "1" is converted to digit "0". 671117 1 152724 yosin 2012-07-17 03:09:12 -0700 Created attachment 152724 Patch 1 671119 2 152724 yosin 2012-07-17 03:11:40 -0700 Comment on attachment 152724 Patch 1 Could you review this patch? Thanks in advance. P.S. Changes for Decimal.cpp is only adding "if (originalExponent < 0)" and indentation. git diff -w Decimal.cpp shows two line changes. 671134 3 152724 tkent 2012-07-17 03:40:00 -0700 Comment on attachment 152724 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=152724&action=review > Source/WebCore/ChangeLog:14 > + (WebCore::Decimal::toString): When the value is an integer, we don't > + round coefficient to DBL_DIG(15) digits. Why do we need the rounding for non-integer cases? > Source/WebKit/chromium/tests/DecimalTest.cpp:1045 > + // 8639999913600001=Date.UTC(275760, 8, 12, 0, 0, 0 1) Understing it helps nothing. Please remove the comment. > Source/WebKit/chromium/tests/DecimalTest.cpp:1046 > + EXPECT_STREQ(("8639999913600001"), encode(8639999913600001, 0, Positive).toString().ascii().data()); We need more test cases. For example, MaxCoefficient with various exponents. 671886 4 152904 yosin 2012-07-17 19:22:20 -0700 Created attachment 152904 Patch 2 672070 5 152949 yosin 2012-07-18 00:23:12 -0700 Created attachment 152949 Patch 3 672075 6 yosin 2012-07-18 00:29:52 -0700 (In reply to comment #3) > (From update of attachment 152724 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152724&action=review > > > Source/WebCore/ChangeLog:14 > > + (WebCore::Decimal::toString): When the value is an integer, we don't > > + round coefficient to DBL_DIG(15) digits. > > Why do we need the rounding for non-integer cases? The reason is we would like to get "1" for 1/3 * 3 or 1/256 * 256. Using DBL_DIG is chosen by converting Decimal to double, e.g. HTMLInputElement.valueAsNumber method. 672078 7 152949 yosin 2012-07-18 00:31:11 -0700 Comment on attachment 152949 Patch 3 Could you review this patch? Thanks in advance. = Changes since the last review = * Added more tests as suggested. * Use newly introduced macro EXPECT_DECIMAL_STREQ. 672090 8 152949 tkent 2012-07-18 00:45:25 -0700 Comment on attachment 152949 Patch 3 ok 672104 9 152949 yosin 2012-07-18 01:09:53 -0700 Comment on attachment 152949 Patch 3 Clearing flags on attachment: 152949 Committed r122928: <http://trac.webkit.org/changeset/122928> 672105 10 yosin 2012-07-18 01:09:59 -0700 All reviewed patches have been landed. Closing bug. 152724 2012-07-17 03:09:12 -0700 2012-07-17 19:22:15 -0700 Patch 1 bug-91481-20120717190911.patch text/plain 3760 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU0ZGRhMDQ1ODZkMTk5 NDRmMTdmY2MzYzEyYjllYjNlYTU2ZWM1Zi4uNmY3YjU2YjA3Y2FjZTkyNmZhMDdkMTQxMjdhYzkx ODk2OWUzOWRjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTE3ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVjaW1hbDo6dG9T dHJpbmcgc2hvdWxkIG5vdCByb3VuZCBpbnRlZ2VyIHZhbHVlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0ODEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoLi4uCisKKyAgICAgICAgTm8g bmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9EZWNpbWFsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRlY2ltYWw6OnRvU3RyaW5nKTogV2hlbiB0aGUgdmFsdWUgaXMgYW4g aW50ZWdlciwgd2UgZG9uJ3QKKyAgICAgICAgcm91bmQgY29lZmZpY2llbnQgdG8gREJMX0RJRygx NSkgZGlnaXRzLgorCiAyMDEyLTA3LTE3ICBTaGlueWEgS2F3YW5ha2EgIDxzaGlueWFrQGNocm9t aXVtLm9yZz4gCiAKICAgICAgICAgW1JlZ3Jlc3Npb25dIEluZmluaXRlIGxvb3AgaW4gZG9jdW1l bnQuZWxlbWVudEZyb21Qb2ludApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCA4MjI3MmIx ZWQxNzM0YTQ4NzA3NzU1OGFmNThjNTc1NzJkZDdjNmY3Li5iNmY3NmU0OGIxNDkxZTU1Y2I4NGI2 NTM0NjNkMDMyOTMzMWE4ZGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEyLTA3LTE3ICBZb3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgRGVjaW1hbDo6dG9TdHJpbmcgc2hvdWxkIG5vdCByb3VuZCBpbnRlZ2VyIHZh bHVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0 ODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIGFkZHMgYSBuZXcgdGVzdCBjYXNlIGZvciBEZWNpbWFsOjp0b1N0cmluZygpIGZvciBm YWlsZWQKKyAgICAgICAgdmFsdWUuCisKKyAgICAgICAgKiB0ZXN0cy9EZWNpbWFsVGVzdC5jcHA6 CisgICAgICAgIChURVNUX0YpOgorCiAyMDEyLTA3LTE2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUmVtb3ZlIHR3byBlbXB0eSBkaXJlY3Rv cmllcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RlY2ltYWwuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGVjaW1hbC5jcHAKaW5kZXggM2JiNjU3MGI1MTRkODJh NmYxMjkwN2FlMzc1MzMwZWJkMjY3OGQ4MS4uZjhiOTYzMzcyZjRmNjFkYWEwZDNlYTUwZTM2M2Y2 ZTQ1ODNhOWVhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGVjaW1hbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGVjaW1hbC5jcHAKQEAgLTk2NywyMiAr OTY3LDI0IEBAIFN0cmluZyBEZWNpbWFsOjp0b1N0cmluZygpIGNvbnN0CiAgICAgICAgIGJ1aWxk ZXIuYXBwZW5kKCctJyk7CiAKICAgICBpbnQgb3JpZ2luYWxFeHBvbmVudCA9IGV4cG9uZW50KCk7 Ci0KLSAgICBjb25zdCBpbnQgbWF4RGlnaXRzID0gREJMX0RJRzsKICAgICB1aW50NjRfdCBjb2Vm ZmljaWVudCA9IG1fZGF0YS5jb2VmZmljaWVudCgpOwotICAgIHVpbnQ2NF90IGxhc3REaWdpdCA9 IDA7Ci0gICAgd2hpbGUgKGNvdW50RGlnaXRzKGNvZWZmaWNpZW50KSA+IG1heERpZ2l0cykgewot ICAgICAgICBsYXN0RGlnaXQgPSBjb2VmZmljaWVudCAlIDEwOwotICAgICAgICBjb2VmZmljaWVu dCAvPSAxMDsKLSAgICAgICAgKytvcmlnaW5hbEV4cG9uZW50OwotICAgIH0KIAotICAgIGlmIChs YXN0RGlnaXQgPj0gNSkKLSAgICAgICAgKytjb2VmZmljaWVudDsKKyAgICBpZiAob3JpZ2luYWxF eHBvbmVudCA8IDApIHsKKyAgICAgICAgY29uc3QgaW50IG1heERpZ2l0cyA9IERCTF9ESUc7Cisg ICAgICAgIHVpbnQ2NF90IGxhc3REaWdpdCA9IDA7CisgICAgICAgIHdoaWxlIChjb3VudERpZ2l0 cyhjb2VmZmljaWVudCkgPiBtYXhEaWdpdHMpIHsKKyAgICAgICAgICAgIGxhc3REaWdpdCA9IGNv ZWZmaWNpZW50ICUgMTA7CisgICAgICAgICAgICBjb2VmZmljaWVudCAvPSAxMDsKKyAgICAgICAg ICAgICsrb3JpZ2luYWxFeHBvbmVudDsKKyAgICAgICAgfQogCi0gICAgd2hpbGUgKG9yaWdpbmFs RXhwb25lbnQgPCAwICYmIGNvZWZmaWNpZW50ICYmICEoY29lZmZpY2llbnQgJSAxMCkpIHsKLSAg ICAgICAgY29lZmZpY2llbnQgLz0gMTA7Ci0gICAgICAgICsrb3JpZ2luYWxFeHBvbmVudDsKKyAg ICAgICAgaWYgKGxhc3REaWdpdCA+PSA1KQorICAgICAgICAgICAgKytjb2VmZmljaWVudDsKKwor ICAgICAgICB3aGlsZSAob3JpZ2luYWxFeHBvbmVudCA8IDAgJiYgY29lZmZpY2llbnQgJiYgIShj b2VmZmljaWVudCAlIDEwKSkgeworICAgICAgICAgICAgY29lZmZpY2llbnQgLz0gMTA7CisgICAg ICAgICAgICArK29yaWdpbmFsRXhwb25lbnQ7CisgICAgICAgIH0KICAgICB9CiAKICAgICBjb25z dCBTdHJpbmcgZGlnaXRzID0gU3RyaW5nOjpudW1iZXIoY29lZmZpY2llbnQpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EZWNpbWFsVGVzdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL0RlY2ltYWxUZXN0LmNwcAppbmRleCBmZmI3ODdiZmUyMzNk MTcxYTY5NDM3ODk2MmY5NDFiMjdjM2Q1OTI0Li4wY2VjZWIzNDRmNDc3NmY5OWQyM2IzYzhlZWQ2 MTQxYzZhMjQ5YWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0Rl Y2ltYWxUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0RlY2ltYWxU ZXN0LmNwcApAQCAtMTA0Miw2ICsxMDQyLDggQEAgVEVTVF9GKERlY2ltYWxUZXN0LCBUb1N0cmlu ZykKICAgICBFWFBFQ1RfRVEoU3RyaW5nKCItNS42NzhlKzEwMyIpLCBlbmNvZGUoNTY3OCwgMTAw LCBOZWdhdGl2ZSkudG9TdHJpbmcoKSk7CiAgICAgRVhQRUNUX0VRKFN0cmluZygiNS42NzhlLTk3 IiksIGVuY29kZSg1Njc4LCAtMTAwLCBQb3NpdGl2ZSkudG9TdHJpbmcoKSk7CiAgICAgRVhQRUNU X0VRKFN0cmluZygiLTUuNjc4ZS05NyIpLCBlbmNvZGUoNTY3OCwgLTEwMCwgTmVnYXRpdmUpLnRv U3RyaW5nKCkpOworICAgIC8vIDg2Mzk5OTk5MTM2MDAwMDE9RGF0ZS5VVEMoMjc1NzYwLCA4LCAx MiwgMCwgMCwgMCAxKQorICAgIEVYUEVDVF9TVFJFUSgoIjg2Mzk5OTk5MTM2MDAwMDEiKSwgZW5j b2RlKDg2Mzk5OTk5MTM2MDAwMDEsIDAsIFBvc2l0aXZlKS50b1N0cmluZygpLmFzY2lpKCkuZGF0 YSgpKTsKIH0KIAogVEVTVF9GKERlY2ltYWxUZXN0LCBUb1N0cmluZ1NwZWNpYWxWYWx1ZXMpCg== 152904 2012-07-17 19:22:20 -0700 2012-07-18 00:23:08 -0700 Patch 2 bug-91481-20120718112219.patch text/plain 4571 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTE2ZTRmZTliMWFkMjNl YWU3YjU4NWYyYTBlOTYxMjFjOTA0ZDBkOS4uN2EyMTU4MWE5ZjBkOGY0MjNmYTRkMTk1ZGVlMzRh M2NlZDc4NzUyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTE3ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVjaW1hbDo6dG9T dHJpbmcgc2hvdWxkIG5vdCByb3VuZCBpbnRlZ2VyIHZhbHVlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0ODEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIERlY2ltYWw6OnRv U3RyaW5nIG5vdCB0byByb3VuZCBhbiBpbnRlZ2VyIHZhbHVlCisgICAgICAgIGJlZm9yZSBjb252 ZXJ0aW5nIHN0cmluZy4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL0RlY2ltYWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVjaW1hbDo6dG9T dHJpbmcpOiBXaGVuIHRoZSB2YWx1ZSBpcyBhbiBpbnRlZ2VyLCB3ZSBkb24ndAorICAgICAgICBy b3VuZCBjb2VmZmljaWVudCB0byBiZSBEQkxfRElHKDE1KSBkaWdpdHMgYmVjYXVzZSBkb3VibGUg Y2FuCisgICAgICAgIHJlcHJlc2VudCBhbiBpbnRlZ2VyIHdpdGhvdXQgcm91bmRpbmcgZXJyb3Iu CisKIDIwMTItMDctMTcgIEFsZWMgRmxldHQgIDxhbGVjZmxldHRAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIEluZGV4ZWREQjogY3JlYXRlSW5kZXggc2hvdWxkIHRocm93IElOVkFMSURfQUNDRVNT X0VSUiBpbnN0ZWFkIG9mIE5PVF9TVVBQT1JURURfRVJSCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9n CmluZGV4IGM5MThkM2VmMWI5MTg1MDM4ZjU3M2ZkZGM3MWM2Y2I4OTRkMDdiZTEuLjNlYTNlMzBj OGYwZmRlZTg1YmRkNWZiODczM2RiOTAxOGQ2YjdmNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTcgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2lu QGNocm9taXVtLm9yZz4KKworICAgICAgICBEZWNpbWFsOjp0b1N0cmluZyBzaG91bGQgbm90IHJv dW5kIGludGVnZXIgdmFsdWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MTQ4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyBhIG5ldyB0ZXN0IGNhc2VzIGZvciBEZWNpbWFsOjp0 b1N0cmluZygpIGZvciBmYWlsZWQKKyAgICAgICAgdmFsdWUgYW5kIGJpZyBjb2VmZmljaWVudCBu dW1iZXJzIHdpdGggdmFyaW91cyBleHBvbmVudC4KKworICAgICAgICAqIHRlc3RzL0RlY2ltYWxU ZXN0LmNwcDoKKyAgICAgICAgKFRFU1RfRik6CisKIDIwMTItMDctMTcgIFRvbnkgQ2hhbmcgIDx0 b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTIy ODg0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vRGVjaW1hbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EZWNpbWFsLmNwcAppbmRleCAzYmI2NTcwYjUxNGQ4MmE2 ZjEyOTA3YWUzNzUzMzBlYmQyNjc4ZDgxLi5mOGI5NjMzNzJmNGY2MWRhYTBkM2VhNTBlMzYzZjZl NDU4M2E5ZWE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EZWNpbWFsLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EZWNpbWFsLmNwcApAQCAtOTY3LDIyICs5 NjcsMjQgQEAgU3RyaW5nIERlY2ltYWw6OnRvU3RyaW5nKCkgY29uc3QKICAgICAgICAgYnVpbGRl ci5hcHBlbmQoJy0nKTsKIAogICAgIGludCBvcmlnaW5hbEV4cG9uZW50ID0gZXhwb25lbnQoKTsK LQotICAgIGNvbnN0IGludCBtYXhEaWdpdHMgPSBEQkxfRElHOwogICAgIHVpbnQ2NF90IGNvZWZm aWNpZW50ID0gbV9kYXRhLmNvZWZmaWNpZW50KCk7Ci0gICAgdWludDY0X3QgbGFzdERpZ2l0ID0g MDsKLSAgICB3aGlsZSAoY291bnREaWdpdHMoY29lZmZpY2llbnQpID4gbWF4RGlnaXRzKSB7Ci0g ICAgICAgIGxhc3REaWdpdCA9IGNvZWZmaWNpZW50ICUgMTA7Ci0gICAgICAgIGNvZWZmaWNpZW50 IC89IDEwOwotICAgICAgICArK29yaWdpbmFsRXhwb25lbnQ7Ci0gICAgfQogCi0gICAgaWYgKGxh c3REaWdpdCA+PSA1KQotICAgICAgICArK2NvZWZmaWNpZW50OworICAgIGlmIChvcmlnaW5hbEV4 cG9uZW50IDwgMCkgeworICAgICAgICBjb25zdCBpbnQgbWF4RGlnaXRzID0gREJMX0RJRzsKKyAg ICAgICAgdWludDY0X3QgbGFzdERpZ2l0ID0gMDsKKyAgICAgICAgd2hpbGUgKGNvdW50RGlnaXRz KGNvZWZmaWNpZW50KSA+IG1heERpZ2l0cykgeworICAgICAgICAgICAgbGFzdERpZ2l0ID0gY29l ZmZpY2llbnQgJSAxMDsKKyAgICAgICAgICAgIGNvZWZmaWNpZW50IC89IDEwOworICAgICAgICAg ICAgKytvcmlnaW5hbEV4cG9uZW50OworICAgICAgICB9CiAKLSAgICB3aGlsZSAob3JpZ2luYWxF eHBvbmVudCA8IDAgJiYgY29lZmZpY2llbnQgJiYgIShjb2VmZmljaWVudCAlIDEwKSkgewotICAg ICAgICBjb2VmZmljaWVudCAvPSAxMDsKLSAgICAgICAgKytvcmlnaW5hbEV4cG9uZW50OworICAg ICAgICBpZiAobGFzdERpZ2l0ID49IDUpCisgICAgICAgICAgICArK2NvZWZmaWNpZW50OworCisg ICAgICAgIHdoaWxlIChvcmlnaW5hbEV4cG9uZW50IDwgMCAmJiBjb2VmZmljaWVudCAmJiAhKGNv ZWZmaWNpZW50ICUgMTApKSB7CisgICAgICAgICAgICBjb2VmZmljaWVudCAvPSAxMDsKKyAgICAg ICAgICAgICsrb3JpZ2luYWxFeHBvbmVudDsKKyAgICAgICAgfQogICAgIH0KIAogICAgIGNvbnN0 IFN0cmluZyBkaWdpdHMgPSBTdHJpbmc6Om51bWJlcihjb2VmZmljaWVudCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0RlY2ltYWxUZXN0LmNwcCBiL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vdGVzdHMvRGVjaW1hbFRlc3QuY3BwCmluZGV4IGZmYjc4N2JmZTIzM2Qx NzFhNjk0Mzc4OTYyZjk0MWIyN2MzZDU5MjQuLmU0ODdkMDMzYWZjZjRhNjlmNmYxZTFlNjM4MDM5 YmY0OWUzMjA1NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRGVj aW1hbFRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRGVjaW1hbFRl c3QuY3BwCkBAIC0xMDQyLDYgKzEwNDIsMTMgQEAgVEVTVF9GKERlY2ltYWxUZXN0LCBUb1N0cmlu ZykKICAgICBFWFBFQ1RfRVEoU3RyaW5nKCItNS42NzhlKzEwMyIpLCBlbmNvZGUoNTY3OCwgMTAw LCBOZWdhdGl2ZSkudG9TdHJpbmcoKSk7CiAgICAgRVhQRUNUX0VRKFN0cmluZygiNS42NzhlLTk3 IiksIGVuY29kZSg1Njc4LCAtMTAwLCBQb3NpdGl2ZSkudG9TdHJpbmcoKSk7CiAgICAgRVhQRUNU X0VRKFN0cmluZygiLTUuNjc4ZS05NyIpLCBlbmNvZGUoNTY3OCwgLTEwMCwgTmVnYXRpdmUpLnRv U3RyaW5nKCkpOworICAgIEVYUEVDVF9FUShTdHJpbmcoIjg2Mzk5OTk5MTM2MDAwMDEiKSwgZW5j b2RlKFVJTlQ2NF9DKDg2Mzk5OTk5MTM2MDAwMDEpLCAwLCBQb3NpdGl2ZSkudG9TdHJpbmcoKSk7 CisgICAgRVhQRUNUX0VRKFN0cmluZygiOTAwNzE5OTI1NDc0MDk5MSIpLCBlbmNvZGUoKHN0YXRp Y19jYXN0PHVpbnQ2NF90PigxKSA8PCBEQkxfTUFOVF9ESUcpIC0gMSwgMCwgUG9zaXRpdmUpLnRv U3RyaW5nKCkpOworICAgIEVYUEVDVF9FUShTdHJpbmcoIjk5OTk5OTk5OTk5OTk5OTgiKSwgZW5j b2RlKFVJTlQ2NF9DKDk5OTk5OTk5OTk5OTk5OTgpLCAwLCBQb3NpdGl2ZSkudG9TdHJpbmcoKSk7 CisgICAgRVhQRUNUX0VRKFN0cmluZygiOS45OTk5OTk5OTk5OTk5OThlKzE2IiksIGVuY29kZShV SU5UNjRfQyg5OTk5OTk5OTk5OTk5OTk4KSwgMSwgUG9zaXRpdmUpLnRvU3RyaW5nKCkpOworICAg IEVYUEVDVF9FUShTdHJpbmcoIjEwMDAwMDAwMDAwMDAwMDAiKSwgZW5jb2RlKFVJTlQ2NF9DKDk5 OTk5OTk5OTk5OTk5OTgpLCAtMSwgUG9zaXRpdmUpLnRvU3RyaW5nKCkpOworICAgIEVYUEVDVF9F UShTdHJpbmcoIjkuOTk5OTk5OTk5OTk5OTk4ZSszMiIpLCBlbmNvZGUoVUlOVDY0X0MoOTk5OTk5 OTk5OTk5OTk5OCksIDE3LCBQb3NpdGl2ZSkudG9TdHJpbmcoKSk7CisgICAgRVhQRUNUX0VRKFN0 cmluZygiMC4xIiksIGVuY29kZShVSU5UNjRfQyg5OTk5OTk5OTk5OTk5OTk4KSwgLTE3LCBQb3Np dGl2ZSkudG9TdHJpbmcoKSk7CiB9CiAKIFRFU1RfRihEZWNpbWFsVGVzdCwgVG9TdHJpbmdTcGVj aWFsVmFsdWVzKQo= 152949 2012-07-18 00:23:12 -0700 2012-07-18 01:09:53 -0700 Patch 3 bug-91481-20120718162311.patch text/plain 4882 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzMyZDI4ZDY0MDU5YTY3 MjlmNzRkZTVlOTUwZTAwNzhhMTRjMzQ4My4uNTIxZTk3NjFiZDI3YTZhYTliMzJlYjJkZjc1ZjU3 ODYxZDI2OTExZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTE4ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVjaW1hbDo6dG9T dHJpbmcgc2hvdWxkIG5vdCByb3VuZCBpbnRlZ2VyIHZhbHVlLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0ODEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIERlY2ltYWw6OnRv U3RyaW5nIG5vdCB0byByb3VuZCBhbiBpbnRlZ2VyIHZhbHVlCisgICAgICAgIGJlZm9yZSBjb252 ZXJ0aW5nIHN0cmluZy4KKworICAgICAgICBUZXN0czogV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0Rl Y2ltYWxUZXN0LmNwcDogRGVjaW1hbFRlc3QudG9TdHJpbmcKKworICAgICAgICAqIHBsYXRmb3Jt L0RlY2ltYWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RGVjaW1hbDo6dG9TdHJpbmcpOiBXaGVu IHRoZSB2YWx1ZSBpcyBhbiBpbnRlZ2VyLCB3ZSBkb24ndAorICAgICAgICByb3VuZCBjb2VmZmlj aWVudCB0byBiZSBEQkxfRElHKDE1KSBkaWdpdHMgYmVjYXVzZSBkb3VibGUgY2FuCisgICAgICAg IHJlcHJlc2VudCBhbiBpbnRlZ2VyIHdpdGhvdXQgcm91bmRpbmcgZXJyb3IuCisKIDIwMTItMDct MTcgIFlvc2hpZnVtaSBJbm91ZSAgPHlvc2luQGNocm9taXVtLm9yZz4KIAogICAgICAgICBEZWNp bWFsIGNvbnN0cnVjdG9yIHdpdGggOTk5OTk5OTk5OTk5OTk5OTkgbG9zZXMgbGFzdCBkaWdpdApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCAyZjc3MTJmZGQ3NTkxNDgwYTI5ODU5M2ZhNGE3 YWRlYjhhNjZiNjBiLi4yMzlkZmFiODZhZThkODU4NTJkY2E5OGM5NGY2YTVmNzcwMjhlZDBhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTE4ICBZ b3NoaWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgRGVjaW1hbDo6 dG9TdHJpbmcgc2hvdWxkIG5vdCByb3VuZCBpbnRlZ2VyIHZhbHVlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0ODEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgYSBuZXcgdGVz dCBjYXNlcyBmb3IgRGVjaW1hbDo6dG9TdHJpbmcoKSBmb3IgZmFpbGVkCisgICAgICAgIHZhbHVl IGFuZCBtYXhpbXVtIGNvZWZmaWNpZW50IHZhbHVlIHdpdGggdmFyaW91cyBleHBvbmVudC4KKwor ICAgICAgICAqIHRlc3RzL0RlY2ltYWxUZXN0LmNwcDoKKyAgICAgICAgKFRFU1RfRik6IERlY2lt YWxUZXN0LnRvU3RyaW5nOiBBZGQgdGVzdCBjYXNlcyBmb3IgYmlnIGNvZWZmaWNpZW50IHZhbHVl cy4KKwogMjAxMi0wNy0xNyAgWW9zaGlmdW1pIElub3VlICA8eW9zaW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIERlY2ltYWwgY29uc3RydWN0b3Igd2l0aCA5OTk5OTk5OTk5OTk5OTk5OSBsb3Nl cyBsYXN0IGRpZ2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9EZWNpbWFs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RlY2ltYWwuY3BwCmluZGV4IDE0NzJkYzEy YTkyNjViZjI4ZjM5NmI4Y2UzMjM3Yzg1OWNiZmUwODYuLjhhNWUyNzViZTk3NGMzYTk0Yzc0ZTJh OTBkNGNkODhhYTFjNzNlZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0Rl Y2ltYWwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0RlY2ltYWwuY3BwCkBAIC05 NjcsMjIgKzk2NywyNCBAQCBTdHJpbmcgRGVjaW1hbDo6dG9TdHJpbmcoKSBjb25zdAogICAgICAg ICBidWlsZGVyLmFwcGVuZCgnLScpOwogCiAgICAgaW50IG9yaWdpbmFsRXhwb25lbnQgPSBleHBv bmVudCgpOwotCi0gICAgY29uc3QgaW50IG1heERpZ2l0cyA9IERCTF9ESUc7CiAgICAgdWludDY0 X3QgY29lZmZpY2llbnQgPSBtX2RhdGEuY29lZmZpY2llbnQoKTsKLSAgICB1aW50NjRfdCBsYXN0 RGlnaXQgPSAwOwotICAgIHdoaWxlIChjb3VudERpZ2l0cyhjb2VmZmljaWVudCkgPiBtYXhEaWdp dHMpIHsKLSAgICAgICAgbGFzdERpZ2l0ID0gY29lZmZpY2llbnQgJSAxMDsKLSAgICAgICAgY29l ZmZpY2llbnQgLz0gMTA7Ci0gICAgICAgICsrb3JpZ2luYWxFeHBvbmVudDsKLSAgICB9CiAKLSAg ICBpZiAobGFzdERpZ2l0ID49IDUpCi0gICAgICAgICsrY29lZmZpY2llbnQ7CisgICAgaWYgKG9y aWdpbmFsRXhwb25lbnQgPCAwKSB7CisgICAgICAgIGNvbnN0IGludCBtYXhEaWdpdHMgPSBEQkxf RElHOworICAgICAgICB1aW50NjRfdCBsYXN0RGlnaXQgPSAwOworICAgICAgICB3aGlsZSAoY291 bnREaWdpdHMoY29lZmZpY2llbnQpID4gbWF4RGlnaXRzKSB7CisgICAgICAgICAgICBsYXN0RGln aXQgPSBjb2VmZmljaWVudCAlIDEwOworICAgICAgICAgICAgY29lZmZpY2llbnQgLz0gMTA7Cisg ICAgICAgICAgICArK29yaWdpbmFsRXhwb25lbnQ7CisgICAgICAgIH0KIAotICAgIHdoaWxlIChv cmlnaW5hbEV4cG9uZW50IDwgMCAmJiBjb2VmZmljaWVudCAmJiAhKGNvZWZmaWNpZW50ICUgMTAp KSB7Ci0gICAgICAgIGNvZWZmaWNpZW50IC89IDEwOwotICAgICAgICArK29yaWdpbmFsRXhwb25l bnQ7CisgICAgICAgIGlmIChsYXN0RGlnaXQgPj0gNSkKKyAgICAgICAgICAgICsrY29lZmZpY2ll bnQ7CisKKyAgICAgICAgd2hpbGUgKG9yaWdpbmFsRXhwb25lbnQgPCAwICYmIGNvZWZmaWNpZW50 ICYmICEoY29lZmZpY2llbnQgJSAxMCkpIHsKKyAgICAgICAgICAgIGNvZWZmaWNpZW50IC89IDEw OworICAgICAgICAgICAgKytvcmlnaW5hbEV4cG9uZW50OworICAgICAgICB9CiAgICAgfQogCiAg ICAgY29uc3QgU3RyaW5nIGRpZ2l0cyA9IFN0cmluZzo6bnVtYmVyKGNvZWZmaWNpZW50KTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRGVjaW1hbFRlc3QuY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EZWNpbWFsVGVzdC5jcHAKaW5kZXggYmY3NGVh NzhlNDMwYjMyNzVjMTZiYjU2ZjUyNDRlZGNhYTBmNGIwNC4uOGQ0MTA2MjYwMzhlYTg3Yjk3YmI1 YzAwZWNlYmU4MmJmZDA3OTU0NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90 ZXN0cy9EZWNpbWFsVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9E ZWNpbWFsVGVzdC5jcHAKQEAgLTEwNzIsNiArMTA3MiwxNiBAQCBURVNUX0YoRGVjaW1hbFRlc3Qs IFRvU3RyaW5nKQogICAgIEVYUEVDVF9ERUNJTUFMX1NUUkVRKCItNS42NzhlKzEwMyIsIGVuY29k ZSg1Njc4LCAxMDAsIE5lZ2F0aXZlKSk7CiAgICAgRVhQRUNUX0RFQ0lNQUxfU1RSRVEoIjUuNjc4 ZS05NyIsIGVuY29kZSg1Njc4LCAtMTAwLCBQb3NpdGl2ZSkpOwogICAgIEVYUEVDVF9ERUNJTUFM X1NUUkVRKCItNS42NzhlLTk3IiwgZW5jb2RlKDU2NzgsIC0xMDAsIE5lZ2F0aXZlKSk7CisgICAg RVhQRUNUX0RFQ0lNQUxfU1RSRVEoIjg2Mzk5OTk5MTM2MDAwMDEiLCBlbmNvZGUoVUlOVDY0X0Mo ODYzOTk5OTkxMzYwMDAwMSksIDAsIFBvc2l0aXZlKSk7CisgICAgRVhQRUNUX0RFQ0lNQUxfU1RS RVEoIjkwMDcxOTkyNTQ3NDA5OTEiLCBlbmNvZGUoKHN0YXRpY19jYXN0PHVpbnQ2NF90PigxKSA8 PCBEQkxfTUFOVF9ESUcpIC0gMSwgMCwgUG9zaXRpdmUpKTsKKyAgICBFWFBFQ1RfREVDSU1BTF9T VFJFUSgiOTk5OTk5OTk5OTk5OTk5OTkiLCBlbmNvZGUoVUlOVDY0X0MoOTk5OTk5OTk5OTk5OTk5 OTkpLCAwLCBQb3NpdGl2ZSkpOworICAgIEVYUEVDVF9ERUNJTUFMX1NUUkVRKCI5Ljk5OTk5OTk5 OTk5OTk5OTllKzE3IiwgZW5jb2RlKFVJTlQ2NF9DKDk5OTk5OTk5OTk5OTk5OTk5KSwgMSwgUG9z aXRpdmUpKTsKKyAgICBFWFBFQ1RfREVDSU1BTF9TVFJFUSgiOS45OTk5OTk5OTk5OTk5OTk5ZSsx OCIsIGVuY29kZShVSU5UNjRfQyg5OTk5OTk5OTk5OTk5OTk5OSksIDIsIFBvc2l0aXZlKSk7Cisg ICAgRVhQRUNUX0RFQ0lNQUxfU1RSRVEoIjFlKzE2IiwgZW5jb2RlKFVJTlQ2NF9DKDk5OTk5OTk5 OTk5OTk5OTk5KSwgLTEsIFBvc2l0aXZlKSk7CisgICAgRVhQRUNUX0RFQ0lNQUxfU1RSRVEoIjEw MDAwMDAwMDAwMDAwMDAiLCBlbmNvZGUoVUlOVDY0X0MoOTk5OTk5OTk5OTk5OTk5OTkpLCAtMiwg UG9zaXRpdmUpKTsKKyAgICBFWFBFQ1RfREVDSU1BTF9TVFJFUSgiMSIsIGVuY29kZShVSU5UNjRf Qyg5OTk5OTk5OTk5OTk5OTk5OSksIC0xNywgUG9zaXRpdmUpKTsKKyAgICBFWFBFQ1RfREVDSU1B TF9TVFJFUSgiMC4wMDEiLCBlbmNvZGUoVUlOVDY0X0MoOTk5OTk5OTk5OTk5OTk5OTkpLCAtMjAs IFBvc2l0aXZlKSk7CisgICAgRVhQRUNUX0RFQ0lNQUxfU1RSRVEoIjFlLTgzIiwgZW5jb2RlKFVJ TlQ2NF9DKDk5OTk5OTk5OTk5OTk5OTk5KSwgLTEwMCwgUG9zaXRpdmUpKTsKIH0KIAogVEVTVF9G KERlY2ltYWxUZXN0LCBUb1N0cmluZ1NwZWNpYWxWYWx1ZXMpCg==