91473 2012-07-17 00:12:34 -0700 "in body" insertion mode, "any other end tag" step 2.1 is updated 2012-07-17 15:24:24 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 skyul skyul abarth eric webkit.review.bot oldest_to_newest 671039 0 skyul 2012-07-17 00:12:34 -0700 Eric filed a bug with HTML5: "in body" insertion mode, "any other end tag", step 2.2 seems wrong. https://www.w3.org/Bugs/Public/show_bug.cgi?id=10080 Since then the HTML5 spec is updated to change the 'end tag' processing to not imply its own end tag, since that makes no sense. http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#parsing-main-inbody 2.1 Generate implied end tags. -> 2.1 Generate implied end tags, except for elements with the same tag name as the token. 671064 1 152710 skyul 2012-07-17 01:02:45 -0700 Created attachment 152710 Patch 671099 2 152710 eric 2012-07-17 02:12:33 -0700 Comment on attachment 152710 Patch OK. 671111 3 152710 webkit.review.bot 2012-07-17 02:59:49 -0700 Comment on attachment 152710 Patch Clearing flags on attachment: 152710 Committed r122831: <http://trac.webkit.org/changeset/122831> 671112 4 webkit.review.bot 2012-07-17 02:59:53 -0700 All reviewed patches have been landed. Closing bug. 671381 5 abarth 2012-07-17 10:47:23 -0700 Is there any observable change in behavior with this change? If so, we should have added a test. 671630 6 skyul 2012-07-17 15:07:04 -0700 (In reply to comment #5) > Is there any observable change in behavior with this change? If so, we should have added a test. As I mentioned briefly in the change log, there is no observable change in behavior. This patch reduces parse errors, but that's not observable because HTMLTreeBuilder::parseError(AtomicToken&) is just an empty marker. 671655 7 abarth 2012-07-17 15:24:24 -0700 Thanks! 152710 2012-07-17 01:02:45 -0700 2012-07-17 02:59:49 -0700 Patch bug-91473-20120717170238.patch text/plain 2981 skyul U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQ0Y2FkMjM1MzU4ZTJk N2E3MmY2NzA2MWYwZDhiNjIwYWMwMmQxMi4uNmIzNTFkMGM0MGE2YmQ5Yzg3M2Y3OTI0NGQ0MjMx NjQzMzZkYjQ3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA3LTE3ICBLd2Fu ZyBZdWwgU2VvICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CisKKyAgICAgICAgImluIGJvZHkiIGlu c2VydGlvbiBtb2RlLCAiYW55IG90aGVyIGVuZCB0YWciIHN0ZXAgMi4xIGlzIHVwZGF0ZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNDczCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEhUTUw1IHNw ZWMgaXMgdXBkYXRlZCB0byBjaGFuZ2UgdGhlICdlbmQgdGFnJyBwcm9jZXNzaW5nIHRvIG5vdCBp bXBseQorICAgICAgICBpdHMgb3duIGVuZCB0YWcsIHNpbmNlIHRoYXQgbWFrZXMgbm8gc2Vuc2Uu IFN0ZXAgMi4xIG5vdyBzYXlzCisgICAgICAgICJHZW5lcmF0ZSBpbXBsaWVkIGVuZCB0YWdzLCBl eGNlcHQgZm9yIGVsZW1lbnRzIHdpdGggdGhlIHNhbWUgdGFnIG5hbWUgYXMgdGhlIHRva2VuLiIK KyAgICAgICAgTW9kaWZpZWQgdG8gZm9sbG93IHRoZSB1cGRhdGVkIHNwZWMuIEFsc28gcmVtb3Zl ZCB0aGUgZmlyc3QgRklYTUUgYmVjYXVzZSBub3cKKyAgICAgICAgRWxlbWVudFJlY29yZCBjYW4n dCBiZSBkZWxldGVkIGJ5IHRoZSBwcmVjZWVkaW5nIGNhbGwuCisKKyAgICAgICAgVGhpcyBwYXRj aCBkb2VzIG5vdCBhY3R1YWxseSBjaGFuZ2UgdGhlIGJlaGF2aW9yIGJlY2F1c2Ugb2YgdGhlIHBy ZXZpb3VzCisgICAgICAgIGNoZWNrIChhYm9ydHMgaWYgZ2VuZXJhdGVJbXBsaWVkRW5kVGFncyBo YXMgYWxyZWFkeSBwb3BwZWQgdGhlIG5vZGUgZm9yIHRoZSB0b2tlbiksCisgICAgICAgIHNvIG5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NBbnlPdGhlckVuZFRh Z0ZvckluQm9keSk6CisKIDIwMTItMDctMTYgIFBldGUgV2lsbGlhbXNvbiAgPHBldGV3aWxAZ29v Z2xlLmNvbT4KIAogICAgICAgICBDaGFuZ2VkIHRoZSBiZWhhdmlvciBvZiBpY29uVVJMcyB0byBh bHdheXMgcmVjYWxjdWxhdGUgdGhlIGxpc3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9o dG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9wYXJz ZXIvSFRNTFRyZWVCdWlsZGVyLmNwcAppbmRleCBjYmRjNDM1MmZmMWM3YjFlMDUyOGVlNjRiNjFj ZGJjMGVhNzczMzFjLi44MDNiMGU3ZDMyZjI1NjViZGM4ZDk5ZDA2YzU0N2NlYWExYTNhNTIwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJlZUJ1aWxkZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKQEAg LTE0NjgsMjEgKzE0NjgsOSBAQCB2b2lkIEhUTUxUcmVlQnVpbGRlcjo6cHJvY2Vzc0FueU90aGVy RW5kVGFnRm9ySW5Cb2R5KEF0b21pY0hUTUxUb2tlbiYgdG9rZW4pCiAgICAgd2hpbGUgKDEpIHsK ICAgICAgICAgUmVmUHRyPENvbnRhaW5lck5vZGU+IG5vZGUgPSByZWNvcmQtPm5vZGUoKTsKICAg ICAgICAgaWYgKG5vZGUtPmhhc0xvY2FsTmFtZSh0b2tlbi5uYW1lKCkpKSB7Ci0gICAgICAgICAg ICBtX3RyZWUuZ2VuZXJhdGVJbXBsaWVkRW5kVGFncygpOwotICAgICAgICAgICAgLy8gRklYTUU6 IFRoZSBFbGVtZW50UmVjb3JkIHBvaW50ZWQgdG8gYnkgcmVjb3JkIG1pZ2h0IGJlIGRlbGV0ZWQg YnkKLSAgICAgICAgICAgIC8vIHRoZSBwcmVjZWRpbmcgY2FsbC4gUGVyaGFwcyB3ZSBzaG91bGQg aG9sZCBhIFJlZlB0ciBzbyB0aGF0IGl0Ci0gICAgICAgICAgICAvLyBzdGF5cyBhbGl2ZSBmb3Ig dGhlIGR1cmF0aW9uIG9mIHJlY29yZCdzIHNjb3BlLgotICAgICAgICAgICAgcmVjb3JkID0gMDsK LSAgICAgICAgICAgIGlmICghbV90cmVlLmN1cnJlbnROb2RlKCktPmhhc0xvY2FsTmFtZSh0b2tl bi5uYW1lKCkpKSB7CisgICAgICAgICAgICBtX3RyZWUuZ2VuZXJhdGVJbXBsaWVkRW5kVGFnc1dp dGhFeGNsdXNpb24odG9rZW4ubmFtZSgpKTsKKyAgICAgICAgICAgIGlmICghbV90cmVlLmN1cnJl bnROb2RlKCktPmhhc0xvY2FsTmFtZSh0b2tlbi5uYW1lKCkpKQogICAgICAgICAgICAgICAgIHBh cnNlRXJyb3IodG9rZW4pOwotICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIGlzIGVpdGhl ciBhIGJ1ZyBpbiB0aGUgc3BlYywgb3IgYSBidWcgaW4gb3VyCi0gICAgICAgICAgICAgICAgLy8g aW1wbGVtZW50YXRpb24uICBGaWxlZCBhIGJ1ZyB3aXRoIEhUTUw1OgotICAgICAgICAgICAgICAg IC8vIGh0dHA6Ly93d3cudzMub3JnL0J1Z3MvUHVibGljL3Nob3dfYnVnLmNnaT9pZD0xMDA4MAot ICAgICAgICAgICAgICAgIC8vIFdlIG1pZ2h0IGhhdmUgYWxyZWFkeSBwb3BwZWQgdGhlIG5vZGUg Zm9yIHRoZSB0b2tlbiBpbgotICAgICAgICAgICAgICAgIC8vIGdlbmVyYXRlSW1wbGllZEVuZFRh Z3MsIGp1c3QgYWJvcnQuCi0gICAgICAgICAgICAgICAgaWYgKCFtX3RyZWUub3BlbkVsZW1lbnRz KCktPmNvbnRhaW5zKHRvRWxlbWVudChub2RlLmdldCgpKSkpCi0gICAgICAgICAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgICAgIH0KICAgICAgICAgICAgIG1fdHJlZS5vcGVuRWxlbWVudHMo KS0+cG9wVW50aWxQb3BwZWQodG9FbGVtZW50KG5vZGUuZ2V0KCkpKTsKICAgICAgICAgICAgIHJl dHVybjsKICAgICAgICAgfQo=