91451 2012-07-16 17:26:54 -0700 REGRESSION: RenderInline::absoluteQuads produces incorrect results for fixed position. 2012-07-17 13:06:23 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cmuppala cmuppala cmuppala dbates eric simon.fraser webkit-bug-importer webkit.review.bot oldest_to_newest 670807 0 cmuppala 2012-07-16 17:26:54 -0700 RenderInline::absoluteQuads is producing incorrect results if having a fixed position. This leads to assertion failures in RenderGeometryMap::absoluteRect when opening webpages with such content. On investigation, found that the RenderGeometryStep copy constructor was not coping the offset and hence the result was incorrect. However, while looking at RenderGeometryStep's copy constructor I also observed that in general it is not safe to copy a RenderGeometryMap, since it's individual step's have a owned pointer to their respective transforms. So, the broader issue here is that RenderInline::absoluteQuads creates copies of RenderGeometryMap indirectly by passing copies of AbsoluteQuadsGeneratorContext. To avoid issues with copying a GeometryMap it is better to modify RenderInline::absoluteQuads to pass AbsoluteQuadsGeneratorContext by reference instead. 670808 1 cmuppala 2012-07-16 17:27:26 -0700 <rdar://problem/11839315> 670874 2 152672 cmuppala 2012-07-16 18:19:46 -0700 Created attachment 152672 Patch 670938 3 152672 webkit.review.bot 2012-07-16 20:26:13 -0700 Comment on attachment 152672 Patch Clearing flags on attachment: 152672 Committed r122802: <http://trac.webkit.org/changeset/122802> 670939 4 webkit.review.bot 2012-07-16 20:26:19 -0700 All reviewed patches have been landed. Closing bug. 671049 5 dbates 2012-07-17 00:23:57 -0700 (In reply to comment #3) > (From update of attachment 152672 [details]) > Clearing flags on attachment: 152672 > > Committed r122802: <http://trac.webkit.org/changeset/122802> For some reason this commit caused the Chromium Mac build to fail because the compiler detected that the private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed was unused (see remark (*)): /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../rendering/RenderInline.cpp:665:11: error: private field 'm_wasFixed' is not used [-Werror,-Wunused-private-field] bool* m_wasFixed; <http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/40008/steps/compile-webkit/logs/stdio> Removed unused private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed and committed this in <http://trac.webkit.org/changeset/122812>. (*) AbsoluteQuadsGeneratorContext::m_wasFixed has remained unused since it was added in <http://trac.webkit.org/changeset/116718> (bug #85725). 671517 6 cmuppala 2012-07-17 13:06:23 -0700 (In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 152672 [details] [details]) > > Clearing flags on attachment: 152672 > > > > Committed r122802: <http://trac.webkit.org/changeset/122802> > > For some reason this commit caused the Chromium Mac build to fail because the compiler detected that the private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed was unused (see remark (*)): > > /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebCore/WebCore.gyp/../rendering/RenderInline.cpp:665:11: error: private field 'm_wasFixed' is not used [-Werror,-Wunused-private-field] > bool* m_wasFixed; > > <http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/40008/steps/compile-webkit/logs/stdio> > > Removed unused private instance variable AbsoluteQuadsGeneratorContext::m_wasFixed and committed this in <http://trac.webkit.org/changeset/122812>. > > (*) AbsoluteQuadsGeneratorContext::m_wasFixed has remained unused since it was added in <http://trac.webkit.org/changeset/116718> (bug #85725). I am not sure why commit r122802, started to trigger the failure, may be because prior to it the sole instantiation of AbsoluteQuadsGeneratorContext was a temporary and that possibly allowed the compiler to be lax with the checks. Thanks for the fix. The code is cleaner without the unused variable for sure. 152672 2012-07-16 18:19:46 -0700 2012-07-16 20:26:13 -0700 Patch bug-91451-20120716181944.patch text/plain 10074 cmuppala U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjM1MmRhOWJmYThlYTZk ZmQzZjcxNTZiNzA0OTdkNzgyYTg5NThiNS4uN2IyNmQwODQ5OGNhYThjOTM0MjEzZjZiMDQwMGRh MDNmM2YzZWUyZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4IEBACisyMDEyLTA3LTE2ICBLaXJh biBNdXBwYWxhICA8Y211cHBhbGFAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFJl bmRlcklubGluZTo6YWJzb2x1dGVRdWFkcyBwcm9kdWNlcyBpbmNvcnJlY3QgcmVzdWx0cyBmb3Ig Zml4ZWQgcG9zaXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MTQ1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbmRlcklubGluZTo6YWJzb2x1dGVRdWFkcyByZWxpZXMgb24gY29waWVzIG9mIFJl bmRlckdlb21ldHJ5TWFwLAorICAgICAgICBjcmVhdGVkIGluZGlyZWN0bHkgYnkgcGFzc2luZyBB YnNvbHV0ZVF1YWRzR2VuZXJhdG9yQ29udGV4dCBvYmplY3QgYnkKKyAgICAgICAgdmFsdWUuICBU aGVzZSBjb3BpZXMgYXJlIHVuc2FmZSBiZWNhdXNlIHRoZSBpbmRpdmlkdWFsIHRyYW5zZm9ybSBz dGVwcworICAgICAgICB3aXRoaW4gdGhlIGdlb21ldHJ5IG1hcCBpbmNsdWRlIGEgb3duZWQgcG9p dG5lciB0byB0aGVpciByZXNwZWN0aXZlCisgICAgICAgIHRyYW5zZm9ybS4KKworICAgICAgICBN b2RpZnkgdGhlIGNhbGxlZSBtZXRob2RzIHRvIHRha2UgY29udGV4dCBieSByZWZlcmVuY2UgYW5k IGRpc2FibGUKKyAgICAgICAgY29weSBjb25zdHJ1Y3RvciBmb3IgUmVuZGVyR2VvbWV0cnlNYXAu CisKKyAgICAgICAgVGVzdDogZmFzdC9pbmxpbmUvaW5saW5lLWZpeGVkLXBvc2l0aW9uLWJvdW5k aW5nYm94Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJHZW9tZXRyeU1hcC5oOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyR2VvbWV0cnlNYXBTdGVwOjpSZW5kZXJHZW9tZXRyeU1h cFN0ZXApOiBBZGQgbWlzc2luZworICAgICAgICBtX29mZnNldCB0byBjb3B5IGNvbnN0cnVjdG9y IGluaXRpYWxpemF0aW9uIGxpc3QuCisgICAgICAgIChSZW5kZXJHZW9tZXRyeU1hcCk6IERpc2Fi bGUgY29weSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmNw cDogUGFzcyBjb250ZXh0IG9iamVjdCBieSByZWZlcmVuY2UuCisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJJbmxpbmU6OmdlbmVyYXRlTGluZUJveFJlY3RzKTogCisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJJbmxpbmU6OmdlbmVyYXRlQ3VsbGVkTGluZUJveFJlY3RzKToKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlcklubGluZTo6YWJzb2x1dGVSZWN0cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5k ZXJJbmxpbmU6OmFic29sdXRlUXVhZHMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW5saW5l OjpsaW5lc0JvdW5kaW5nQm94KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlcklubGluZTo6Y3Vs bGVkSW5saW5lVmlzdWFsT3ZlcmZsb3dCb3VuZGluZ0JveCk6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJJbmxpbmU6OmFkZEZvY3VzUmluZ1JlY3RzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVySW5saW5lLmg6CisgICAgICAgIChSZW5kZXJJbmxpbmU6OmdlbmVyYXRlTGluZUJveFJlY3Rz KTogVXBkYXRlIG1ldGhvZCBkZWNsYXJhdGlvbnMgdG8KKyAgICAgICAgc2hvdyBwYXNzIGJ5IHJl ZmVyZW5jZSBjb250ZXh0IHBhcmFtZXRlci4KKyAgICAgICAgKFJlbmRlcklubGluZTo6Z2VuZXJh dGVDdWxsZWRMaW5lQm94UmVjdHMpOiBEaXR0by4KKwogMjAxMi0wNy0xNiAgTU9SSVRBIEhhamlt ZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBDb21tZW50IG9uIFdlYkNvcmU6OkhU TUxNZWRpYUVsZW1lbnQ6OmNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVyZXIoKSBzaG91bGQgZXhwbGFp biB3aHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHZW9tZXRy eU1hcC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdlb21ldHJ5TWFwLmgKaW5k ZXggOGU2M2M1MDg0ODE2ZDM0ODI4YmVmZjgwYWE3OTQyZmYwY2UwMDEzYS4uOThmNDRjNjMzZGIz ZTc5ZGZhN2VjNzJiODU4ODgyMTYwMGM4YmJjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckdlb21ldHJ5TWFwLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckdlb21ldHJ5TWFwLmgKQEAgLTQxLDYgKzQxLDcgQEAgY2xhc3MgUmVuZGVyTGF5 ZXI7CiBzdHJ1Y3QgUmVuZGVyR2VvbWV0cnlNYXBTdGVwIHsKICAgICBSZW5kZXJHZW9tZXRyeU1h cFN0ZXAoY29uc3QgUmVuZGVyR2VvbWV0cnlNYXBTdGVwJiBvKQogICAgICAgICA6IG1fcmVuZGVy ZXIoby5tX3JlbmRlcmVyKQorICAgICAgICAsIG1fb2Zmc2V0KG8ubV9vZmZzZXQpCiAgICAgICAg ICwgbV9hY2N1bXVsYXRpbmdUcmFuc2Zvcm0oby5tX2FjY3VtdWxhdGluZ1RyYW5zZm9ybSkKICAg ICAgICAgLCBtX2lzTm9uVW5pZm9ybShvLm1faXNOb25Vbmlmb3JtKQogICAgICAgICAsIG1faXNG aXhlZFBvc2l0aW9uKG8ubV9pc0ZpeGVkUG9zaXRpb24pCkBAIC02Nyw2ICs2OCw3IEBAIHN0cnVj dCBSZW5kZXJHZW9tZXRyeU1hcFN0ZXAgewogCiAvLyBDYW4gYmUgdXNlZCB3aGlsZSB3YWxraW5n IHRoZSBSZW5kZXJlciB0cmVlIHRvIGNhY2hlIGRhdGEgYWJvdXQgb2Zmc2V0cyBhbmQgdHJhbnNm b3Jtcy4KIGNsYXNzIFJlbmRlckdlb21ldHJ5TWFwIHsKKyAgICBXVEZfTUFLRV9OT05DT1BZQUJM RShSZW5kZXJHZW9tZXRyeU1hcCk7CiBwdWJsaWM6CiAgICAgUmVuZGVyR2VvbWV0cnlNYXAoKTsK ICAgICB+UmVuZGVyR2VvbWV0cnlNYXAoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJJbmxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl cklubGluZS5jcHAKaW5kZXggYzRlMTQyMzkyZTI1ZWY1MGM2YTkyODZlNDQ4NTliNDlhYTdlZjQz OC4uODVhNzIxN2UzOTlhNGZiODQ0OWZkZTFiYTk5NjJjNDlhNWNhY2FmMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAKQEAgLTUzMyw3ICs1MzMsNyBAQCB2b2lk IFJlbmRlcklubGluZTo6cGFpbnQoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBv aW50JiBwYWludE9mZnNldCkKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgR2VuZXJhdG9yQ29udGV4 dD4KLXZvaWQgUmVuZGVySW5saW5lOjpnZW5lcmF0ZUxpbmVCb3hSZWN0cyhHZW5lcmF0b3JDb250 ZXh0IHlpZWxkKSBjb25zdAordm9pZCBSZW5kZXJJbmxpbmU6OmdlbmVyYXRlTGluZUJveFJlY3Rz KEdlbmVyYXRvckNvbnRleHQmIHlpZWxkKSBjb25zdAogewogICAgIGlmICghYWx3YXlzQ3JlYXRl TGluZUJveGVzKCkpCiAgICAgICAgIGdlbmVyYXRlQ3VsbGVkTGluZUJveFJlY3RzKHlpZWxkLCB0 aGlzKTsKQEAgLTU0NSw3ICs1NDUsNyBAQCB2b2lkIFJlbmRlcklubGluZTo6Z2VuZXJhdGVMaW5l Qm94UmVjdHMoR2VuZXJhdG9yQ29udGV4dCB5aWVsZCkgY29uc3QKIH0KIAogdGVtcGxhdGU8dHlw ZW5hbWUgR2VuZXJhdG9yQ29udGV4dD4KLXZvaWQgUmVuZGVySW5saW5lOjpnZW5lcmF0ZUN1bGxl ZExpbmVCb3hSZWN0cyhHZW5lcmF0b3JDb250ZXh0IHlpZWxkLCBjb25zdCBSZW5kZXJJbmxpbmUq IGNvbnRhaW5lcikgY29uc3QKK3ZvaWQgUmVuZGVySW5saW5lOjpnZW5lcmF0ZUN1bGxlZExpbmVC b3hSZWN0cyhHZW5lcmF0b3JDb250ZXh0JiB5aWVsZCwgY29uc3QgUmVuZGVySW5saW5lKiBjb250 YWluZXIpIGNvbnN0CiB7CiAgICAgaWYgKCFjdWxsZWRJbmxpbmVGaXJzdExpbmVCb3goKSkgewog ICAgICAgICB5aWVsZChGbG9hdFJlY3QoKSk7CkBAIC02MzEsNyArNjMxLDggQEAgcHJpdmF0ZToK IAogdm9pZCBSZW5kZXJJbmxpbmU6OmFic29sdXRlUmVjdHMoVmVjdG9yPEludFJlY3Q+JiByZWN0 cywgY29uc3QgTGF5b3V0UG9pbnQmIGFjY3VtdWxhdGVkT2Zmc2V0KSBjb25zdAogewotICAgIGdl bmVyYXRlTGluZUJveFJlY3RzKEFic29sdXRlUmVjdHNHZW5lcmF0b3JDb250ZXh0KHJlY3RzLCBh Y2N1bXVsYXRlZE9mZnNldCkpOworICAgIEFic29sdXRlUmVjdHNHZW5lcmF0b3JDb250ZXh0IGNv bnRleHQocmVjdHMsIGFjY3VtdWxhdGVkT2Zmc2V0KTsKKyAgICBnZW5lcmF0ZUxpbmVCb3hSZWN0 cyhjb250ZXh0KTsKIAogICAgIGlmIChjb250aW51YXRpb24oKSkgewogICAgICAgICBpZiAoY29u dGludWF0aW9uKCktPmlzQm94KCkpIHsKQEAgLTY2OSw3ICs2NzAsOCBAQCBwcml2YXRlOgogCiB2 b2lkIFJlbmRlcklubGluZTo6YWJzb2x1dGVRdWFkcyhWZWN0b3I8RmxvYXRRdWFkPiYgcXVhZHMs IGJvb2wqIHdhc0ZpeGVkKSBjb25zdAogewotICAgIGdlbmVyYXRlTGluZUJveFJlY3RzKEFic29s dXRlUXVhZHNHZW5lcmF0b3JDb250ZXh0KHRoaXMsIHF1YWRzLCB3YXNGaXhlZCkpOworICAgIEFi c29sdXRlUXVhZHNHZW5lcmF0b3JDb250ZXh0IGNvbnRleHQodGhpcywgcXVhZHMsIHdhc0ZpeGVk KTsKKyAgICBnZW5lcmF0ZUxpbmVCb3hSZWN0cyhjb250ZXh0KTsKIAogICAgIGlmIChjb250aW51 YXRpb24oKSkKICAgICAgICAgY29udGludWF0aW9uKCktPmFic29sdXRlUXVhZHMocXVhZHMsIHdh c0ZpeGVkKTsKQEAgLTgwNCw3ICs4MDYsOCBAQCBJbnRSZWN0IFJlbmRlcklubGluZTo6bGluZXNC b3VuZGluZ0JveCgpIGNvbnN0CiAgICAgaWYgKCFhbHdheXNDcmVhdGVMaW5lQm94ZXMoKSkgewog ICAgICAgICBBU1NFUlQoIWZpcnN0TGluZUJveCgpKTsKICAgICAgICAgRmxvYXRSZWN0IGZsb2F0 UmVzdWx0OwotICAgICAgICBnZW5lcmF0ZUN1bGxlZExpbmVCb3hSZWN0cyhMaW5lc0JvdW5kaW5n Qm94R2VuZXJhdG9yQ29udGV4dChmbG9hdFJlc3VsdCksIHRoaXMpOworICAgICAgICBMaW5lc0Jv dW5kaW5nQm94R2VuZXJhdG9yQ29udGV4dCBjb250ZXh0KGZsb2F0UmVzdWx0KTsKKyAgICAgICAg Z2VuZXJhdGVDdWxsZWRMaW5lQm94UmVjdHMoY29udGV4dCwgdGhpcyk7CiAgICAgICAgIHJldHVy biBlbmNsb3NpbmdJbnRSZWN0KGZsb2F0UmVzdWx0KTsKICAgICB9CiAKQEAgLTg4OCw3ICs4OTEs OCBAQCBJbmxpbmVCb3gqIFJlbmRlcklubGluZTo6Y3VsbGVkSW5saW5lTGFzdExpbmVCb3goKSBj b25zdAogTGF5b3V0UmVjdCBSZW5kZXJJbmxpbmU6OmN1bGxlZElubGluZVZpc3VhbE92ZXJmbG93 Qm91bmRpbmdCb3goKSBjb25zdAogewogICAgIEZsb2F0UmVjdCBmbG9hdFJlc3VsdDsKLSAgICBn ZW5lcmF0ZUN1bGxlZExpbmVCb3hSZWN0cyhMaW5lc0JvdW5kaW5nQm94R2VuZXJhdG9yQ29udGV4 dChmbG9hdFJlc3VsdCksIHRoaXMpOworICAgIExpbmVzQm91bmRpbmdCb3hHZW5lcmF0b3JDb250 ZXh0IGNvbnRleHQoZmxvYXRSZXN1bHQpOworICAgIGdlbmVyYXRlQ3VsbGVkTGluZUJveFJlY3Rz KGNvbnRleHQsIHRoaXMpOwogICAgIExheW91dFJlY3QgcmVzdWx0KGVuY2xvc2luZ0xheW91dFJl Y3QoZmxvYXRSZXN1bHQpKTsKICAgICBib29sIGlzSG9yaXpvbnRhbCA9IHN0eWxlKCktPmlzSG9y aXpvbnRhbFdyaXRpbmdNb2RlKCk7CiAgICAgZm9yIChSZW5kZXJPYmplY3QqIGN1cnIgPSBmaXJz dENoaWxkKCk7IGN1cnI7IGN1cnIgPSBjdXJyLT5uZXh0U2libGluZygpKSB7CkBAIC0xMzU0LDcg KzEzNTgsOCBAQCB2b2lkIFJlbmRlcklubGluZTo6aW1hZ2VDaGFuZ2VkKFdyYXBwZWRJbWFnZVB0 ciwgY29uc3QgSW50UmVjdCopCiAKIHZvaWQgUmVuZGVySW5saW5lOjphZGRGb2N1c1JpbmdSZWN0 cyhWZWN0b3I8SW50UmVjdD4mIHJlY3RzLCBjb25zdCBMYXlvdXRQb2ludCYgYWRkaXRpb25hbE9m ZnNldCkKIHsKLSAgICBnZW5lcmF0ZUxpbmVCb3hSZWN0cyhBYnNvbHV0ZVJlY3RzR2VuZXJhdG9y Q29udGV4dChyZWN0cywgYWRkaXRpb25hbE9mZnNldCkpOworICAgIEFic29sdXRlUmVjdHNHZW5l cmF0b3JDb250ZXh0IGNvbnRleHQocmVjdHMsIGFkZGl0aW9uYWxPZmZzZXQpOworICAgIGdlbmVy YXRlTGluZUJveFJlY3RzKGNvbnRleHQpOwogCiAgICAgZm9yIChSZW5kZXJPYmplY3QqIGN1cnIg PSBmaXJzdENoaWxkKCk7IGN1cnI7IGN1cnIgPSBjdXJyLT5uZXh0U2libGluZygpKSB7CiAgICAg ICAgIGlmICghY3Vyci0+aXNUZXh0KCkgJiYgIWN1cnItPmlzTGlzdE1hcmtlcigpKSB7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmggYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmgKaW5kZXggNzIyMzAwYWI4Mjk4NGRhYTlk ZmEyN2NmMjc4OGU4Mjc0N2I2ZjQzOS4uYThjYzJmMWJlNTA1NzM4MDJlYzY5N2VlMzEzNDQyM2E2 ZGMwZGQ3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGlu ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmxpbmUuaApAQCAtMTA2 LDkgKzEwNiw5IEBAIHByaXZhdGU6CiAgICAgSW5saW5lQm94KiBjdWxsZWRJbmxpbmVMYXN0TGlu ZUJveCgpIGNvbnN0OwogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgR2VuZXJhdG9yQ29udGV4dD4K LSAgICB2b2lkIGdlbmVyYXRlTGluZUJveFJlY3RzKEdlbmVyYXRvckNvbnRleHQgeWllbGQpIGNv bnN0OworICAgIHZvaWQgZ2VuZXJhdGVMaW5lQm94UmVjdHMoR2VuZXJhdG9yQ29udGV4dCYgeWll bGQpIGNvbnN0OwogICAgIHRlbXBsYXRlPHR5cGVuYW1lIEdlbmVyYXRvckNvbnRleHQ+Ci0gICAg dm9pZCBnZW5lcmF0ZUN1bGxlZExpbmVCb3hSZWN0cyhHZW5lcmF0b3JDb250ZXh0IHlpZWxkLCBj b25zdCBSZW5kZXJJbmxpbmUqIGNvbnRhaW5lcikgY29uc3Q7CisgICAgdm9pZCBnZW5lcmF0ZUN1 bGxlZExpbmVCb3hSZWN0cyhHZW5lcmF0b3JDb250ZXh0JiB5aWVsZCwgY29uc3QgUmVuZGVySW5s aW5lKiBjb250YWluZXIpIGNvbnN0OwogCiAgICAgdm9pZCBhZGRDaGlsZFRvQ29udGludWF0aW9u KFJlbmRlck9iamVjdCogbmV3Q2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQpOwogICAg IHZpcnR1YWwgdm9pZCBhZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKFJlbmRlck9iamVjdCog bmV3Q2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQgPSAwKTsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYTYyNjAx MTM5MDViMmI1ZDhjYzk1Yzc2YTlmNjJlMTMwMzg4NDVhLi4xNjcyZjNlYjI5YmE2NGE3MGM4MTU3 ZDQzMWE0MzIzZDdmMzQwZDhjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysr IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTYgIEtp cmFuIE11cHBhbGEgIDxjbXVwcGFsYUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjog UmVuZGVySW5saW5lOjphYnNvbHV0ZVF1YWRzIHByb2R1Y2VzIGluY29ycmVjdCByZXN1bHRzIGZv ciBmaXhlZCBwb3NpdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkxNDUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIGEgcmVncmVzc2lvbiB0ZXN0IGZvciBib3VuZGluZ0JveCBvZiBhbiBpbmxp bmUgZWxlbWVudCB3aXRoIGZpeGVkIHBvc2l0aW9uLgorCisgICAgICAgICogZmFzdC9pbmxpbmUv aW5saW5lLWZpeGVkLXBvc2l0aW9uLWJvdW5kaW5nYm94LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogZmFzdC9pbmxpbmUvaW5saW5lLWZpeGVkLXBvc2l0aW9uLWJvdW5kaW5nYm94Lmh0 bWw6IEFkZGVkLgorCiAyMDEyLTA3LTE2ICBKb3NodWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBJbXBsZW1lbnQgc3BlYyB1cGRhdGVzIHRvIElEQlRy YW5zYWN0aW9uLmVycm9yCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxp bmUtZml4ZWQtcG9zaXRpb24tYm91bmRpbmdib3gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv ZmFzdC9pbmxpbmUvaW5saW5lLWZpeGVkLXBvc2l0aW9uLWJvdW5kaW5nYm94LWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi42ODY3MmQ3MzYxNDVhMjdhYTNmNWEzZjRlOTE1ZWJkMTUwMjVjMmM3Ci0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5lLWZpeGVkLXBv c2l0aW9uLWJvdW5kaW5nYm94LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBACitCdWcgOTE0 NTE6IFJFR1JFU1NJT046IFJlbmRlcklubGluZTo6YWJzb2x1dGVRdWFkcyBwcm9kdWNlcyBpbmNv cnJlY3QgcmVzdWx0cyBmb3IgZml4ZWQgcG9zaXRpb24uCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KKworCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExF VEUKK1BBU1MgaW5saW5lUmVjdC5sZWZ0IGlzIHBhcmVudFJlY3QubGVmdAorCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtZml4ZWQtcG9zaXRpb24tYm91bmRpbmdi b3guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lubGluZS1maXhlZC1wb3NpdGlvbi1i b3VuZGluZ2JveC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZjMTM4OTViZTI1YmI3ODExZTIyNTJhNGRhODcy MzVmNWU5MzY4NWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9p bmxpbmUtZml4ZWQtcG9zaXRpb24tYm91bmRpbmdib3guaHRtbApAQCAtMCwwICsxLDI1IEBACis8 aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1w cmUuanMiPjwvc2NyaXB0PgorICAgIDxzY3JpcHQ+CisgICAgICAgIGRlc2NyaXB0aW9uKCc8YSBo cmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0NTEiPkJ1ZyA5 MTQ1MTwvYT46IFJFR1JFU1NJT046IFJlbmRlcklubGluZTo6YWJzb2x1dGVRdWFkcyBwcm9kdWNl cyBpbmNvcnJlY3QgcmVzdWx0cyBmb3IgZml4ZWQgcG9zaXRpb24uJyk7CisKKyAgICAgICAgZnVu Y3Rpb24gcnVuVGVzdCgpCisgICAgICAgIHsKKyAgICAgICAgICAgIGlubGluZSA9IGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCJpbmxpbmVFbGVtZW50Iik7CisgICAgICAgICAgICBpbmxpbmVSZWN0 ID0gaW5saW5lLmdldEJvdW5kaW5nQ2xpZW50UmVjdCgpOworICAgICAgICAgICAgcGFyZW50ID0g aW5saW5lLnBhcmVudE5vZGU7CisgICAgICAgICAgICBwYXJlbnRSZWN0ID0gcGFyZW50LmdldEJv dW5kaW5nQ2xpZW50UmVjdCgpOworICAgICAgICAgICAgc2hvdWxkQmUoImlubGluZVJlY3QubGVm dCIsICJwYXJlbnRSZWN0LmxlZnQiKTsKKyAgICAgICAgfQorCisgICAgICAgIHdpbmRvdy5vbmxv YWQgPSBydW5UZXN0OworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAgPGRpdiBz dHlsZT0icG9zaXRpb246Zml4ZWQiPgorICAgICAgICA8c3BhbiBpZD0iaW5saW5lRWxlbWVudCI+ PC9zcGFuPgorICAgIDwvZGl2PgorICAgIDxzY3JpcHQgc3JjPSIuLi9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K