91447 2012-07-16 17:05:23 -0700 nrwt: clean up logging when we're only running one chunk of the tests 2012-07-17 16:18:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth eric ojan tony oldest_to_newest 670791 0 dpranke 2012-07-16 17:05:23 -0700 nrwt: clean up logging when we're only running one chunk of the tests 670792 1 152647 dpranke 2012-07-16 17:06:41 -0700 Created attachment 152647 Patch 671535 2 152647 ojan 2012-07-17 13:34:17 -0700 Comment on attachment 152647 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152647&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-431 > - tests_run_filename = self._filesystem.join(self._results_directory, "tests_run.txt") The valgrind layout tests bots used to use this IIRC in order to know which chunk to run next. I suppose we can get rid of it for now since noone seems to be using it. I suppose it's silly for this to be in RWT. The bot itself should just read the stdio log and maintain this information itself if it needs it. 671713 3 dpranke 2012-07-17 16:18:58 -0700 Committed r122892: <http://trac.webkit.org/changeset/122892> 152647 2012-07-16 17:06:41 -0700 2012-07-17 13:34:17 -0700 Patch bug-91447-20120716170640.patch text/plain 2747 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmE4MDMwOGYzZWUxNjYyNDIzNDk1NTg0OWIxMTM5MDE5 MTVlMzdlYS4uMTIwNWZmNzgyYmU1ODYzN2I0YTdmNDAyOTFhMzY3MjM4ZjY0NTBiNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIy IEBACiAyMDEyLTA3LTE2ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IGNsZWFuIHVwIGxvZ2dpbmcgd2hlbiB3ZSdyZSBvbmx5IHJ1bm5pbmcgb25l IGNodW5rIG9mIHRoZSB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTE0NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBBcHBhcmVudGx5IHdlIHdlcmUgY3JlYXRpbmcgYSAndGVzdHNfcnVuLnR4dCcg aW4gdGhlIHJlc3VsdHMKKyAgICAgICAgZGlyZWN0b3J5IGlmIHdlIHdlcmUgb25seSBydW5uaW5n IG9uZSBjaHVuayBvZiB0aGUgdGVzdHM7IGFmdGVyCisgICAgICAgIDMrIHllYXJzIG9mIGhhY2tp bmcgb24gdGhpcyBjb2RlLCB0aGF0IHdhcyBuZXdzIHRvIG1lLCBzbyBJJ20KKyAgICAgICAgZ3Vl c3Npbmcgbm8gb25lIHVzZXMgdGhpcy4gSSdtIHJlbW92aW5nIHRoaXMsIGFuZCBjaGFuZ2luZyB0 aGUKKyAgICAgICAgX3ByaW50X2V4cGVjdGVkIGNhbGxzIHRvIGRlYnVnIG1lc3NhZ2VzIHRvIHNp bXBsaWZ5IHRoZQorICAgICAgICBsYXllcmluZy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHk6CisgICAgICAgIChNYW5hZ2Vy Ll9zcGxpdF9pbnRvX2NodW5rc19pZl9uZWNlc3NhcnkpOgorCisyMDEyLTA3LTE2ICBEaXJrIFBy YW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIG5yd3Q6IG1vdmUgdGhlIGJ1 bGsgb2YgdGhlICJleHBlY3RlZCIgb3V0cHV0IHRvIHByaW50aW5nLnB5CiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTQ0MgogCmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdl ci5weQppbmRleCA5OWE4NjFlNzlkNWQ3NDYxNDI1YzY0NWRlYmE5NjU5Yzk5NGQ4ZDBhLi4zMDMx YWNkYjE3YzgwNWZlMWVjMjAwMmI3NmMwNjA5OTg4YzRkODljIDEwMDY0NAotLS0gYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIu cHkKQEAgLTQxNywxOSArNDE3LDE0IEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKIAogICAgICAg ICBmaWxlcyA9IHRlc3RfZmlsZXNbc2xpY2Vfc3RhcnQ6c2xpY2VfZW5kXQogCi0gICAgICAgIHRl c3RzX3J1bl9tc2cgPSAnUnVubmluZzogJWQgdGVzdHMgKGNodW5rIHNsaWNlIFslZDolZF0gb2Yg JWQpJyAlICgoc2xpY2VfZW5kIC0gc2xpY2Vfc3RhcnQpLCBzbGljZV9zdGFydCwgc2xpY2VfZW5k LCBudW1fdGVzdHMpCi0gICAgICAgIHNlbGYuX3ByaW50ZXIuX3ByaW50X2V4cGVjdGVkKHRlc3Rz X3J1bl9tc2cpCisgICAgICAgIF9sb2cuZGVidWcoJ2NodW5rIHNsaWNlIFslZDolZF0gb2YgJWQg aXMgJWQgdGVzdHMnICUgKHNsaWNlX3N0YXJ0LCBzbGljZV9lbmQsIG51bV90ZXN0cywgKHNsaWNl X2VuZCAtIHNsaWNlX3N0YXJ0KSkpCiAKICAgICAgICAgIyBJZiB3ZSByZWFjaGVkIHRoZSBlbmQg YW5kIHdlIGRvbid0IGhhdmUgZW5vdWdoIHRlc3RzLCB3ZSBydW4gc29tZQogICAgICAgICAjIGZy b20gdGhlIGJlZ2lubmluZy4KICAgICAgICAgaWYgc2xpY2VfZW5kIC0gc2xpY2Vfc3RhcnQgPCBj aHVua19sZW46CiAgICAgICAgICAgICBleHRyYSA9IGNodW5rX2xlbiAtIChzbGljZV9lbmQgLSBz bGljZV9zdGFydCkKLSAgICAgICAgICAgIGV4dHJhX21zZyA9ICgnICAgbGFzdCBjaHVuayBpcyBw YXJ0aWFsLCBhcHBlbmRpbmcgWzA6JWRdJyAlIGV4dHJhKQotICAgICAgICAgICAgc2VsZi5fcHJp bnRlci5fcHJpbnRfZXhwZWN0ZWQoZXh0cmFfbXNnKQotICAgICAgICAgICAgdGVzdHNfcnVuX21z ZyArPSAiXG4iICsgZXh0cmFfbXNnCisgICAgICAgICAgICBfbG9nLmRlYnVnKCcgICBsYXN0IGNo dW5rIGlzIHBhcnRpYWwsIGFwcGVuZGluZyBbMDolZF0nICUgZXh0cmEpCiAgICAgICAgICAgICBm aWxlcy5leHRlbmQodGVzdF9maWxlc1swOmV4dHJhXSkKLSAgICAgICAgdGVzdHNfcnVuX2ZpbGVu YW1lID0gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYuX3Jlc3VsdHNfZGlyZWN0b3J5LCAidGVz dHNfcnVuLnR4dCIpCi0gICAgICAgIHNlbGYuX2ZpbGVzeXN0ZW0ud3JpdGVfdGV4dF9maWxlKHRl c3RzX3J1bl9maWxlbmFtZSwgdGVzdHNfcnVuX21zZykKIAogICAgICAgICBsZW5fc2tpcF9jaHVu ayA9IGludChsZW4oZmlsZXMpICogbGVuKHNraXBwZWQpIC8gZmxvYXQobGVuKHNlbGYuX3Rlc3Rf ZmlsZXMpKSkKICAgICAgICAgc2tpcF9jaHVua19saXN0ID0gbGlzdChza2lwcGVkKVswOmxlbl9z a2lwX2NodW5rXQo=