91411 2012-07-16 11:54:49 -0700 [GTK] Paste primary selection when middle clicking in X11 WebKit2 2012-07-17 04:12:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo xan.lopez oldest_to_newest 670530 0 cgarcia 2012-07-16 11:54:49 -0700 We should handle middle click events to paste primary selection like we do in WebKit1. This is expected in any X11 application. 670533 1 152578 cgarcia 2012-07-16 11:59:15 -0700 Created attachment 152578 Patch 671108 2 152578 xan.lopez 2012-07-17 02:41:26 -0700 Comment on attachment 152578 Patch Looks good to me! 671159 3 cgarcia 2012-07-17 04:12:13 -0700 Committed r122835: <http://trac.webkit.org/changeset/122835> 152578 2012-07-16 11:59:15 -0700 2012-07-17 02:41:26 -0700 Patch wk2-middle-click-paste.diff text/plain 3828 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NDFmN2U4Li42ZjUzNWQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTItMDctMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIFBhc3RlIHByaW1hcnkgc2VsZWN0aW9uIHdoZW4gbWlkZGxlIGNs aWNraW5nIGluIFgxMSBXZWJLaXQyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MTQxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEhhbmRsZSBtaWRkbGUgY2xpY2sgZXZlbnRzIHRvIHBhc3RlIHByaW1hcnkg c2VsZWN0aW9uIGFzIGV4cGVjdGVkCisgICAgICAgIGluIGFueSBYMTEgYXBwbGljYXRpb24uCisK KyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJL aXQ6OmhhbmRsZU1vdXNlRXZlbnQpOiBDYWxsIGhhbmRsZU1vdXNlUHJlc3NlZEV2ZW50KCkgZm9y IEdUSysKKyAgICAgICAgcGxhdGZvcm0uCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dl YlBhZ2UuaDoKKyAgICAgICAgKFdlYlBhZ2UpOiBBZGQgaGFuZGxlTW91c2VQcmVzc2VkRXZlbnQo KSBmb3IgR1RLKyBwbGF0Zm9ybS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dl YlBhZ2VHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpoYW5kbGVNb3VzZVByZXNz ZWRFdmVudCk6IEhhbmRsZSBtaWRkbGUgY2xpY2sKKyAgICAgICAgZXZlbnRzIHRvIHBhc3RlIHBy aW1hcnkgc2VsZWN0aW9uIGxpa2Ugd2UgZG8gaW4gV2ViS2l0MS4KKworMjAxMi0wNy0xNiAgQ2Fy bG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5yZXZp ZXdlZC4gRml4IG1ha2UgZGlzdGNoZWNrLgogCiAgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsv dGVzdHMvR05VbWFrZWZpbGUuYW06IEFkZCB0ZXN0IHJlc291cmNlcyB0bwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDJjYjI5MGUuLjUxODFk YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAK QEAgLTEzMzksNiArMTMzOSwxMCBAQCBzdGF0aWMgYm9vbCBoYW5kbGVNb3VzZUV2ZW50KGNvbnN0 IFdlYk1vdXNlRXZlbnQmIG1vdXNlRXZlbnQsIFdlYlBhZ2UqIHBhZ2UsIGJvbwogICAgICAgICAg ICAgaWYgKGlzQ29udGV4dENsaWNrKHBsYXRmb3JtTW91c2VFdmVudCkpCiAgICAgICAgICAgICAg ICAgaGFuZGxlZCA9IGhhbmRsZUNvbnRleHRNZW51RXZlbnQocGxhdGZvcm1Nb3VzZUV2ZW50LCBw YWdlKTsKICNlbmRpZgorI2lmIFBMQVRGT1JNKEdUSykKKyAgICAgICAgICAgIGJvb2wgZ3RrTW91 c2VCdXR0b25QcmVzc0hhbmRsZWQgPSBwYWdlLT5oYW5kbGVNb3VzZVByZXNzZWRFdmVudChwbGF0 Zm9ybU1vdXNlRXZlbnQpOworICAgICAgICAgICAgaGFuZGxlZCA9IGhhbmRsZWQgfHwgZ3RrTW91 c2VCdXR0b25QcmVzc0hhbmRsZWQ7CisjZW5kaWYKIAogICAgICAgICAgICAgcmV0dXJuIGhhbmRs ZWQ7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5oCmluZGV4IGQyMzRhMWQuLmU0YzE1ZTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAtNDQ1LDYgKzQ0NSw3IEBAIHB1YmxpYzoKIAogI2VsaWYg UExBVEZPUk0oR1RLKQogICAgIHZvaWQgdXBkYXRlQWNjZXNzaWJpbGl0eVRyZWUoKTsKKyAgICBi b29sIGhhbmRsZU1vdXNlUHJlc3NlZEV2ZW50KGNvbnN0IFdlYkNvcmU6OlBsYXRmb3JtTW91c2VF dmVudCYpOwogI2lmIFVTRShURVhUVVJFX01BUFBFUl9HTCkKICAgICB2b2lkIHdpZGdldE1hcHBl ZChpbnQ2NF90IG5hdGl2ZVdpbmRvd0hhbmRsZSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlBhZ2VHdGsuY3BwCmluZGV4IGEwMjg5 MWMuLjMwYWFhNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFn ZS9ndGsvV2ViUGFnZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQ YWdlL2d0ay9XZWJQYWdlR3RrLmNwcApAQCAtMzcsNiArMzcsNyBAQAogI2luY2x1ZGUgPFdlYkNv cmUvRnJhbWUuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0tleWJvYXJkRXZlbnQuaD4KICNpbmNsdWRl IDxXZWJDb3JlL1BhZ2UuaD4KKyNpbmNsdWRlIDxXZWJDb3JlL1Bhc3RlYm9hcmRIZWxwZXIuaD4K ICNpbmNsdWRlIDxXZWJDb3JlL1BsYXRmb3JtS2V5Ym9hcmRFdmVudC5oPgogI2luY2x1ZGUgPFdl YkNvcmUvU2V0dGluZ3MuaD4KICNpbmNsdWRlIDx3dGYvZ29iamVjdC9HT3duUHRyLmg+CkBAIC0x NTksNyArMTYwLDMxIEBAIHZvaWQgV2ViUGFnZTo6d2lkZ2V0TWFwcGVkKGludDY0X3QgbmF0aXZl V2luZG93SGFuZGxlKQogewogICAgIG1fbmF0aXZlV2luZG93SGFuZGxlID0gbmF0aXZlV2luZG93 SGFuZGxlOwogfQorI2VuZGlmCisKK2Jvb2wgV2ViUGFnZTo6aGFuZGxlTW91c2VQcmVzc2VkRXZl bnQoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiBwbGF0Zm9ybU1vdXNlRXZlbnQpCit7CisgICAg Ym9vbCByZXR1cm5WYWx1ZSA9IGZhbHNlOworICAgIGlmIChwbGF0Zm9ybU1vdXNlRXZlbnQuYnV0 dG9uKCkgIT0gV2ViQ29yZTo6TWlkZGxlQnV0dG9uKQorICAgICAgICByZXR1cm4gcmV0dXJuVmFs dWU7CisKKyNpZiBQTEFURk9STShYMTEpCisgICAgRnJhbWUqIGZyYW1lID0gbV9wYWdlLT5mb2N1 c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFpbkZyYW1lKCk7CisgICAgaWYgKCFmcmFtZSkKKyAg ICAgICAgcmV0dXJuIHJldHVyblZhbHVlOwogCisgICAgUGFzdGVib2FyZEhlbHBlciogcGFzdGVi b2FyZEhlbHBlciA9IFBhc3RlYm9hcmRIZWxwZXI6OmRlZmF1bHRQYXN0ZWJvYXJkSGVscGVyKCk7 CisgICAgYm9vbCB3YXNVc2luZ1ByaW1hcnkgPSBwYXN0ZWJvYXJkSGVscGVyLT51c2VQcmltYXJ5 U2VsZWN0aW9uQ2xpcGJvYXJkKCk7CisgICAgcGFzdGVib2FyZEhlbHBlci0+c2V0VXNlUHJpbWFy eVNlbGVjdGlvbkNsaXBib2FyZCh0cnVlKTsKKworICAgIEVkaXRvciogZWRpdG9yID0gZnJhbWUt PmVkaXRvcigpOworICAgIHJldHVyblZhbHVlID0gZWRpdG9yLT5jYW5QYXN0ZSgpIHx8IGVkaXRv ci0+Y2FuREhUTUxQYXN0ZSgpOworICAgIGVkaXRvci0+cGFzdGUoKTsKKworICAgIHBhc3RlYm9h cmRIZWxwZXItPnNldFVzZVByaW1hcnlTZWxlY3Rpb25DbGlwYm9hcmQod2FzVXNpbmdQcmltYXJ5 KTsKICNlbmRpZgogCisgICAgcmV0dXJuIHJldHVyblZhbHVlOworfQorCiB9IC8vIG5hbWVzcGFj ZSBXZWJLaXQK