91408 2012-07-16 11:15:51 -0700 IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h 2012-07-18 18:31:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91414 1 dgrogan dgrogan abarth alecflett dglazkov fishd jamesr jsbell tkent+wkapi tony webkit.review.bot oldest_to_newest 670488 0 dgrogan 2012-07-16 11:15:51 -0700 IndexedDB: Add intVersion to chromium/public/WebIDBMetadata.h 670495 1 152570 dgrogan 2012-07-16 11:19:36 -0700 Created attachment 152570 Patch 670496 2 dgrogan 2012-07-16 11:20:28 -0700 Josh or Alec, could you look at this? 670500 3 webkit.review.bot 2012-07-16 11:24:05 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 670501 4 152570 jsbell 2012-07-16 11:25:57 -0700 Comment on attachment 152570 Patch LGTM 670514 5 152573 dgrogan 2012-07-16 11:36:52 -0700 Created attachment 152573 Patch 670621 6 152573 fishd 2012-07-16 13:36:54 -0700 Comment on attachment 152573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152573&action=review > Source/WebKit/chromium/public/WebIDBMetadata.h:48 > WebIDBMetadata() { } perhaps you should initialize intVersion? it is good practice for default constructors to initialize integer fields, etc. 670651 7 152609 dgrogan 2012-07-16 14:17:40 -0700 Created attachment 152609 Patch 670652 8 152573 dgrogan 2012-07-16 14:19:25 -0700 Comment on attachment 152573 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152573&action=review >> Source/WebKit/chromium/public/WebIDBMetadata.h:48 >> WebIDBMetadata() { } > > perhaps you should initialize intVersion? it is good practice for > default constructors to initialize integer fields, etc. Sounds good. Done. 671605 9 152609 dgrogan 2012-07-17 14:32:43 -0700 Comment on attachment 152609 Patch ping fishd / other WebKit API reviewers 671629 10 152609 abarth 2012-07-17 15:06:18 -0700 Comment on attachment 152609 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152609&action=review > Source/WebKit/chromium/public/WebIDBMetadata.h:49 > WebString version; > + int64_t intVersion; Is the plan to delete version and rename intVersion to version at some point? I wonder if it make sense to add a macro for selecting between the two? Maybe add a FIXME explaining your future plans? 671641 11 152609 dgrogan 2012-07-17 15:15:47 -0700 Comment on attachment 152609 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152609&action=review >> Source/WebKit/chromium/public/WebIDBMetadata.h:49 >> + int64_t intVersion; > > Is the plan to delete version and rename intVersion to version at some point? I wonder if it make sense to add a macro for selecting between the two? Maybe add a FIXME explaining your future plans? The plan is to delete version, but not necessarily to rename intVersion. A macro seems like overkill, but a FIXME would be prudent. Coming up. 671646 12 152844 dgrogan 2012-07-17 15:18:22 -0700 Created attachment 152844 Patch for landing 671695 13 152844 webkit.review.bot 2012-07-17 16:04:58 -0700 Comment on attachment 152844 Patch for landing Clearing flags on attachment: 152844 Committed r122884: <http://trac.webkit.org/changeset/122884> 671696 14 webkit.review.bot 2012-07-17 16:05:04 -0700 All reviewed patches have been landed. Closing bug. 671748 15 tony 2012-07-17 16:45:11 -0700 This appears to be causing compile failures on Windows: 7> WebIDBMetadata.cpp 7>C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WebKit\chromium\public\WebIDBMetadata.h(52): error C2146: syntax error : missing ';' before identifier 'intVersion' 7>C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WebKit\chromium\public\WebIDBMetadata.h(52): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 7>C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WebKit\chromium\public\WebIDBMetadata.h(52): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 7>C:\b\build\slave\webkit-win-latest-rel\build\src\third_party\WebKit\Source\WebKit\chromium\public\WebIDBMetadata.h(54): error C2614: 'WebKit::WebIDBMetadata' : illegal member initialization: 'intVersion' is not a base or member 7>c:\b\build\slave\webkit-win-latest-rel\build\src\third_party\webkit\source\webkit\chromium\public\WebIDBMetadata.h(52): error C2146: syntax error : missing ';' before identifier 'intVersion' 7>c:\b\build\slave\webkit-win-latest-rel\build\src\third_party\webkit\source\webkit\chromium\public\WebIDBMetadata.h(52): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 7>c:\b\build\slave\webkit-win-latest-rel\build\src\third_party\webkit\source\webkit\chromium\public\WebIDBMetadata.h(52): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 7>c:\b\build\slave\webkit-win-latest-rel\build\src\third_party\webkit\source\webkit\chromium\public\WebIDBMetadata.h(54): error C2614: 'WebKit::WebIDBMetadata' : illegal member initialization: 'intVersion' is not a base or member 7 671764 16 tony 2012-07-17 17:03:41 -0700 Reverted r122884 for reason: Broke the chromium-win build. Committed r122898: <http://trac.webkit.org/changeset/122898> 672881 17 153115 dgrogan 2012-07-18 15:48:43 -0700 Created attachment 153115 Patch 672891 18 153115 dgrogan 2012-07-18 15:52:04 -0700 Comment on attachment 153115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153115&action=review > Source/Platform/chromium/public/WebCommon.h:77 > +typedef __int64 int64_t; The windows try server suggests this will fix the problem: original patch fails compile: http://build.chromium.org/p/tryserver.chromium/builders/win_layout_rel/builds/519 patch with typedef compiles fine: http://build.chromium.org/p/tryserver.chromium/builders/win_layout_rel/builds/520 672892 19 webkit.review.bot 2012-07-18 15:52:18 -0700 Attachment 153115 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 Source/Platform/chromium/public/WebCommon.h:77: int64_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 672933 20 dgrogan 2012-07-18 16:22:14 -0700 (In reply to comment #19) > Attachment 153115 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1 > Source/Platform/chromium/public/WebCommon.h:77: int64_t is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. Done: https://bugs.webkit.org/show_bug.cgi?id=91691 672938 21 153115 dgrogan 2012-07-18 16:24:19 -0700 Comment on attachment 153115 Patch Adam, could you review this patch (again)? Thanks. 672944 22 153115 abarth 2012-07-18 16:29:07 -0700 Comment on attachment 153115 Patch We must use 64-bit numbers in the WebKit API. I'm surprised that we'd need this typedef. 672949 23 abarth 2012-07-18 16:29:54 -0700 Looks like we use "long long" for 64 bit ints. 672952 24 abarth 2012-07-18 16:30:19 -0700 e.g., WebFrame::identifier() 673026 25 153147 dgrogan 2012-07-18 17:41:49 -0700 Created attachment 153147 Patch 673029 26 dgrogan 2012-07-18 17:44:51 -0700 (In reply to comment #23) > Looks like we use "long long" for 64 bit ints. Switched to long long. Another look? 673055 27 153147 webkit.review.bot 2012-07-18 18:31:53 -0700 Comment on attachment 153147 Patch Clearing flags on attachment: 153147 Committed r123059: <http://trac.webkit.org/changeset/123059> 673056 28 webkit.review.bot 2012-07-18 18:31:59 -0700 All reviewed patches have been landed. Closing bug. 152570 2012-07-16 11:19:36 -0700 2012-07-16 11:36:49 -0700 Patch bug-91408-20120716111936.patch text/plain 1390 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMDA0OTE2OGRkZTY1NWRmOGRkOTA3MmZkMGZkZjExNWVhYmEwZTguLjMyNzViOTVmNTZlYWNi MDE3ZTc1ZDNiM2I2MWJkMzkzYmI3NzA2NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTYgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogQWRkIGludFZlcnNpb24gdG8gY2hyb21pdW0v cHVibGljL1dlYklEQk1ldGFkYXRhLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkxNDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBpcyBpbiBzdXBwb3J0IG9mIHRoZSBuZXcgdXBncmFkZW5lZWRl ZCB2ZXJzaW9uaW5nIGFwaS4KKyAgICAgICAgaW50VmVyc2lvbiB3aWxsIGV2ZW50dWFsbHkgcmVw bGFjZSB0aGUgV2ViU3RyaW5nIHZlcnNpb24gbWVtYmVyLgorCisgICAgICAgICogcHVibGljL1dl YklEQk1ldGFkYXRhLmg6CisgICAgICAgIChXZWJJREJNZXRhZGF0YSk6CisKIDIwMTItMDctMTMg IEVyaWMgUGVubmVyICA8ZXBlbm5lckBnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0g QWRkICdzZWxmLW1hbmFnZWQnIG9wdGlvbiB0byBDQ1ByaW9yaXRpemVkVGV4dHVyZSB0byBlbmFi bGUgcmVuZGVyLXN1cmZhY2UgYW5kIGNhbnZhcyB1c2UgY2FzZXMuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJNZXRhZGF0YS5oIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCTWV0YWRhdGEuaAppbmRleCAxYzMzZDFiMDgwZDc1Njgy ZWRjZWQyZmRmYWJlYTRiMWVlNGQ4NjVmLi45ZmIyMTRiOGQ2ZmNhOThhY2EyZGYwNGFmMzc1ZDIy ODRhNGY0NTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJ REJNZXRhZGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQk1l dGFkYXRhLmgKQEAgLTQzLDYgKzQzLDcgQEAgc3RydWN0IFdlYklEQk1ldGFkYXRhIHsKIAogICAg IFdlYlN0cmluZyBuYW1lOwogICAgIFdlYlN0cmluZyB2ZXJzaW9uOworICAgIGludDY0X3QgaW50 VmVyc2lvbjsKICAgICBXZWJWZWN0b3I8T2JqZWN0U3RvcmU+IG9iamVjdFN0b3JlczsKICAgICBX ZWJJREJNZXRhZGF0YSgpIHsgfQogCg== 152573 2012-07-16 11:36:52 -0700 2012-07-16 14:19:25 -0700 Patch bug-91408-20120716113652.patch text/plain 1572 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMDA0OTE2OGRkZTY1NWRmOGRkOTA3MmZkMGZkZjExNWVhYmEwZTguLjI1OTZlOTY3OGJjODJi Y2ZmMzQzYjQ5ODdjNjRlMzk0NTEzOTgxNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDctMTYgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogQWRkIGludFZlcnNpb24gdG8gY2hyb21pdW0v cHVibGljL1dlYklEQk1ldGFkYXRhLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkxNDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBpcyBpbiBzdXBwb3J0IG9mIHRoZSBuZXcgdXBncmFkZW5lZWRl ZCB2ZXJzaW9uaW5nIGFwaS4KKyAgICAgICAgaW50VmVyc2lvbiB3aWxsIGV2ZW50dWFsbHkgcmVw bGFjZSB0aGUgV2ViU3RyaW5nIHZlcnNpb24gbWVtYmVyLgorCisgICAgICAgICogcHVibGljL1dl YklEQk1ldGFkYXRhLmg6CisgICAgICAgIChXZWJJREJNZXRhZGF0YSk6IFRoZSBzcGVjIHVzZXMg dW5zaWduZWQgbG9uZyBsb25nIGZvciB2ZXJzaW9uCisgICAgICAgIG51bWJlcnMgYnV0IHdlIHVz ZSBpbnQ2NF90IGhlcmUgYmVjYXVzZSB3ZSdyZSBnb2luZyB0byB1c2UgLTEgdG8KKyAgICAgICAg aW5kaWNhdGUgdGhhdCBhIGRhdGFiYXNlIHN0aWxsIHVzZXMgYSBzdHJpbmcgdmVyc2lvbi4KKwog MjAxMi0wNy0xMyAgRXJpYyBQZW5uZXIgIDxlcGVubmVyQGdvb2dsZS5jb20+CiAKICAgICAgICAg W2Nocm9taXVtXSBBZGQgJ3NlbGYtbWFuYWdlZCcgb3B0aW9uIHRvIENDUHJpb3JpdGl6ZWRUZXh0 dXJlIHRvIGVuYWJsZSByZW5kZXItc3VyZmFjZSBhbmQgY2FudmFzIHVzZSBjYXNlcy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQk1ldGFkYXRhLmggYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJNZXRhZGF0YS5oCmluZGV4IDFjMzNk MWIwODBkNzU2ODJlZGNlZDJmZGZhYmVhNGIxZWU0ZDg2NWYuLjlmYjIxNGI4ZDZmY2E5OGFjYTJk ZjA0YWYzNzVkMjI4NGE0ZjQ1OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYklEQk1ldGFkYXRhLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViSURCTWV0YWRhdGEuaApAQCAtNDMsNiArNDMsNyBAQCBzdHJ1Y3QgV2ViSURCTWV0YWRh dGEgewogCiAgICAgV2ViU3RyaW5nIG5hbWU7CiAgICAgV2ViU3RyaW5nIHZlcnNpb247CisgICAg aW50NjRfdCBpbnRWZXJzaW9uOwogICAgIFdlYlZlY3RvcjxPYmplY3RTdG9yZT4gb2JqZWN0U3Rv cmVzOwogICAgIFdlYklEQk1ldGFkYXRhKCkgeyB9CiAK 152609 2012-07-16 14:17:40 -0700 2012-07-17 15:18:18 -0700 Patch bug-91408-20120716141739.patch text/plain 1837 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMDA0OTE2OGRkZTY1NWRmOGRkOTA3MmZkMGZkZjExNWVhYmEwZTguLmQ2ZTAwMWIzYjU4N2Uw OWVhZjA3ZmFlYTAzZWNhOTRmZWE2ZDIwYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDctMTYgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogQWRkIGludFZlcnNpb24gdG8gY2hyb21pdW0v cHVibGljL1dlYklEQk1ldGFkYXRhLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkxNDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBpcyBpbiBzdXBwb3J0IG9mIHRoZSBuZXcgdXBncmFkZW5lZWRl ZCB2ZXJzaW9uaW5nIGFwaS4KKyAgICAgICAgaW50VmVyc2lvbiB3aWxsIGV2ZW50dWFsbHkgcmVw bGFjZSB0aGUgV2ViU3RyaW5nIHZlcnNpb24gbWVtYmVyLgorCisgICAgICAgICogcHVibGljL1dl YklEQk1ldGFkYXRhLmg6CisgICAgICAgIChXZWJJREJNZXRhZGF0YSk6IFRoZSBzcGVjIHVzZXMg dW5zaWduZWQgbG9uZyBsb25nIGZvciB2ZXJzaW9uCisgICAgICAgIG51bWJlcnMgYnV0IHdlIHVz ZSBpbnQ2NF90IGhlcmUgc28gdGhhdCB3ZSBjYW4gdXNlIC0xIGFzIGEgc2VudGluZWwuCisgICAg ICAgIEl0IGluZGljYXRlcyB0aGF0IGEgZGF0YWJhc2Ugc3RpbGwgdXNlcyBhIHN0cmluZyB2ZXJz aW9uLgorCiAyMDEyLTA3LTEzICBFcmljIFBlbm5lciAgPGVwZW5uZXJAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBbY2hyb21pdW1dIEFkZCAnc2VsZi1tYW5hZ2VkJyBvcHRpb24gdG8gQ0NQcmlvcml0 aXplZFRleHR1cmUgdG8gZW5hYmxlIHJlbmRlci1zdXJmYWNlIGFuZCBjYW52YXMgdXNlIGNhc2Vz LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCTWV0YWRh dGEuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQk1ldGFkYXRhLmgKaW5k ZXggMWMzM2QxYjA4MGQ3NTY4MmVkY2VkMmZkZmFiZWE0YjFlZTRkODY1Zi4uNzlhMTdhZWM3Yzc4 MjU1ZDg4YzM4Y2I2MmJiM2M1NTkzYzQ3ZDY5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViSURCTWV0YWRhdGEuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJREJNZXRhZGF0YS5oCkBAIC0zOCwxMyArMzgsMTggQEAgc3RydWN0IElE QkRhdGFiYXNlTWV0YWRhdGE7CiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogc3RydWN0IFdlYklEQk1l dGFkYXRhIHsKKyAgICBlbnVtIHsKKyAgICAgICAgTm9JbnRWZXJzaW9uID0gLTEKKyAgICB9Owog ICAgIHN0cnVjdCBJbmRleDsKICAgICBzdHJ1Y3QgT2JqZWN0U3RvcmU7CiAKICAgICBXZWJTdHJp bmcgbmFtZTsKICAgICBXZWJTdHJpbmcgdmVyc2lvbjsKKyAgICBpbnQ2NF90IGludFZlcnNpb247 CiAgICAgV2ViVmVjdG9yPE9iamVjdFN0b3JlPiBvYmplY3RTdG9yZXM7Ci0gICAgV2ViSURCTWV0 YWRhdGEoKSB7IH0KKyAgICBXZWJJREJNZXRhZGF0YSgpCisgICAgICAgIDogaW50VmVyc2lvbihO b0ludFZlcnNpb24pIHsgfQogCiAgICAgc3RydWN0IE9iamVjdFN0b3JlIHsKICAgICAgICAgV2Vi U3RyaW5nIG5hbWU7Cg== 152844 2012-07-17 15:18:22 -0700 2012-07-18 15:48:34 -0700 Patch for landing bug-91408-20120717151822.patch text/plain 2044 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMDA0OTE2OGRkZTY1NWRmOGRkOTA3MmZkMGZkZjExNWVhYmEwZTguLmQ4ZGVmNzI2MDRiZjBj ZDM1NjkyZDc2NTVhY2ZmNGE4Y2Y5M2ZmNzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDctMTYgIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogQWRkIGludFZlcnNpb24gdG8gY2hyb21pdW0v cHVibGljL1dlYklEQk1ldGFkYXRhLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkxNDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K KworICAgICAgICBUaGlzIGlzIGluIHN1cHBvcnQgb2YgdGhlIG5ldyB1cGdyYWRlbmVlZGVkIHZl cnNpb25pbmcgYXBpLgorICAgICAgICBpbnRWZXJzaW9uIHdpbGwgZXZlbnR1YWxseSByZXBsYWNl IHRoZSBXZWJTdHJpbmcgdmVyc2lvbiBtZW1iZXIuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSURC TWV0YWRhdGEuaDoKKyAgICAgICAgKFdlYklEQk1ldGFkYXRhKTogVGhlIHNwZWMgdXNlcyB1bnNp Z25lZCBsb25nIGxvbmcgZm9yIHZlcnNpb24KKyAgICAgICAgbnVtYmVycyBidXQgd2UgdXNlIGlu dDY0X3QgaGVyZSBzbyB0aGF0IHdlIGNhbiB1c2UgLTEgYXMgYSBzZW50aW5lbC4KKyAgICAgICAg SXQgaW5kaWNhdGVzIHRoYXQgYSBkYXRhYmFzZSBzdGlsbCB1c2VzIGEgc3RyaW5nIHZlcnNpb24u CisKIDIwMTItMDctMTMgIEVyaWMgUGVubmVyICA8ZXBlbm5lckBnb29nbGUuY29tPgogCiAgICAg ICAgIFtjaHJvbWl1bV0gQWRkICdzZWxmLW1hbmFnZWQnIG9wdGlvbiB0byBDQ1ByaW9yaXRpemVk VGV4dHVyZSB0byBlbmFibGUgcmVuZGVyLXN1cmZhY2UgYW5kIGNhbnZhcyB1c2UgY2FzZXMuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJNZXRhZGF0YS5o IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSURCTWV0YWRhdGEuaAppbmRleCAx YzMzZDFiMDgwZDc1NjgyZWRjZWQyZmRmYWJlYTRiMWVlNGQ4NjVmLi44MDYwZTUyZmFkYzFjMTBk Y2QyMzMxYTAwZWI3N2I4NzVhODhlZjdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJJREJNZXRhZGF0YS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYklEQk1ldGFkYXRhLmgKQEAgLTM4LDEzICszOCwyMSBAQCBzdHJ1Y3QgSURCRGF0 YWJhc2VNZXRhZGF0YTsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBzdHJ1Y3QgV2ViSURCTWV0YWRh dGEgeworICAgIGVudW0geworICAgICAgICBOb0ludFZlcnNpb24gPSAtMQorICAgIH07CiAgICAg c3RydWN0IEluZGV4OwogICAgIHN0cnVjdCBPYmplY3RTdG9yZTsKIAogICAgIFdlYlN0cmluZyBu YW1lOworICAgIC8vIEZJWE1FOiBCb3RoIHZlcnNpb24gbWVtYmVycyBuZWVkIHRvIGJlIHByZXNl bnQgd2hpbGUgd2Ugc3VwcG9ydCBib3RoIHRoZQorICAgIC8vIG9sZCBzZXRWZXJzaW9uIGFuZCBu ZXcgdXBncmFkZW5lZWRlZCBBUEkuIE9uY2Ugd2Ugbm8gbG9uZ2VyIHN1cHBvcnQKKyAgICAvLyBz ZXRWZXJzaW9uLCBXZWJTdHJpbmcgdmVyc2lvbiBjYW4gYmUgcmVtb3ZlZC4KICAgICBXZWJTdHJp bmcgdmVyc2lvbjsKKyAgICBpbnQ2NF90IGludFZlcnNpb247CiAgICAgV2ViVmVjdG9yPE9iamVj dFN0b3JlPiBvYmplY3RTdG9yZXM7Ci0gICAgV2ViSURCTWV0YWRhdGEoKSB7IH0KKyAgICBXZWJJ REJNZXRhZGF0YSgpCisgICAgICAgIDogaW50VmVyc2lvbihOb0ludFZlcnNpb24pIHsgfQogCiAg ICAgc3RydWN0IE9iamVjdFN0b3JlIHsKICAgICAgICAgV2ViU3RyaW5nIG5hbWU7Cg== 153115 2012-07-18 15:48:43 -0700 2012-07-18 17:41:37 -0700 Patch bug-91408-20120718154842.patch text/plain 3468 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCAxZmU5OWIxM2Q2ODkx ZTg2MzBkOTU2MWI0YTQ0NThmMzUzMzI0NzYxLi5jNDU0ZWM0MmJjNDlhMmNiNWFjZjZjYmQwNTNl MjZhMTE4NzRlZDliIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0wNy0xOCAg RGF2aWQgR3JvZ2FuICA8ZGdyb2dhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERC OiBBZGQgaW50VmVyc2lvbiB0byBjaHJvbWl1bS9wdWJsaWMvV2ViSURCTWV0YWRhdGEuaAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0MDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaW5kb3dzIGRvZXMg bm90IHByb3ZpZGUgaW50NjRfdC4gSXQgaXMgdHlwZWRlZidkIGludG8gZXhpc3RlbmNlCisgICAg ICAgIDUgb3RoZXIgcGxhY2VzIHRocm91Z2hvdXQgV2ViS2l0L1NvdXJjZSwgYnV0IGFwcGFyZW50 bHkgbm90IGFueXdoZXJlCisgICAgICAgIGF2YWlsYWJsZSB0byB0aGUgcHVibGljIFdlYktpdCBB UEkuCisKKyAgICAgICAgVGhlIHR5cGVkZWZzIGluIFdlYkNvbW1vbi5oIG1hdGNoIHRob3NlIGlu CisgICAgICAgIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vcy13aW4zMi9zdGRpbnQuaCBhbmQKKyAg ICAgICAgU291cmNlL1dURi93dGYvZHRvYS91dGlscy5oCisKKyAgICAgICAgKiBjaHJvbWl1bS9w dWJsaWMvV2ViQ29tbW9uLmg6CisKIDIwMTItMDctMTMgIFRvbnkgUGF5bmUgIDx0cGF5bmVAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBXaWRnZXQgZnJvbSBzY3JlZW5Db2xvclByb2Zp bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggYzkxOGQzZWYxYjkxODUwMzhmNTczZmRk YzcxYzZjYjg5NGQwN2JlMS4uNDc2NmFlMDcyMjNhY2U4NjhkOGU4NTk0M2Q2OWE2NTVjZTc5N2Yw NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wNy0x OCAgRGF2aWQgR3JvZ2FuICA8ZGdyb2dhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhl ZERCOiBBZGQgaW50VmVyc2lvbiB0byBjaHJvbWl1bS9wdWJsaWMvV2ViSURCTWV0YWRhdGEuaAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE0MDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGlu IHN1cHBvcnQgb2YgdGhlIG5ldyB1cGdyYWRlbmVlZGVkIHZlcnNpb25pbmcgYXBpLgorICAgICAg ICBpbnRWZXJzaW9uIHdpbGwgZXZlbnR1YWxseSByZXBsYWNlIHRoZSBXZWJTdHJpbmcgdmVyc2lv biBtZW1iZXIuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSURCTWV0YWRhdGEuaDoKKyAgICAgICAg KFdlYktpdDo6V2ViSURCTWV0YWRhdGE6OldlYklEQk1ldGFkYXRhKToKKyAgICAgICAgVGhlIHNw ZWMgdXNlcyB1bnNpZ25lZCBsb25nIGxvbmcgZm9yIHZlcnNpb24gbnVtYmVycyBidXQgd2UgdXNl CisgICAgICAgIGludDY0X3QgaGVyZSBzbyB0aGF0IHdlIGNhbiB1c2UgLTEgYXMgYSBzZW50aW5l bC4gSXQgaW5kaWNhdGVzIHRoYXQgYQorICAgICAgICBkYXRhYmFzZSBzdGlsbCB1c2VzIGEgc3Ry aW5nIHZlcnNpb24uCisKIDIwMTItMDctMTcgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTIyODg0LgpkaWZmIC0tZ2l0 IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9XZWJDb21tb24uaCBiL1NvdXJjZS9Q bGF0Zm9ybS9jaHJvbWl1bS9wdWJsaWMvV2ViQ29tbW9uLmgKaW5kZXggYjcwYTU4ZDllODcxMmY1 ZGFjYWM5YWE3YmIzM2QwY2MxOTA5NjQ2ZC4uNTI4MWU5MDgxNDI1Yzg1YjQ4Yjk5NTkyODcxZTc3 YzI5NjNkZTQ1YSAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9X ZWJDb21tb24uaAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1dlYkNvbW1v bi5oCkBAIC03NCw2ICs3NCw4IEBAIHR5cGVkZWYgc2hvcnQgaW50MTZfdDsKIHR5cGVkZWYgdW5z aWduZWQgc2hvcnQgdWludDE2X3Q7CiB0eXBlZGVmIGludCBpbnQzMl90OwogdHlwZWRlZiB1bnNp Z25lZCBpbnQgdWludDMyX3Q7Cit0eXBlZGVmIF9faW50NjQgaW50NjRfdDsKK3R5cGVkZWYgdW5z aWduZWQgX19pbnQ2NCB1aW50NjRfdDsKICNlbmRpZgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQk1ldGFkYXRhLmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJNZXRhZGF0YS5oCmluZGV4IDFj MzNkMWIwODBkNzU2ODJlZGNlZDJmZGZhYmVhNGIxZWU0ZDg2NWYuLjgwNjBlNTJmYWRjMWMxMGRj ZDIzMzFhMDBlYjc3Yjg3NWE4OGVmN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYklEQk1ldGFkYXRhLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViSURCTWV0YWRhdGEuaApAQCAtMzgsMTMgKzM4LDIxIEBAIHN0cnVjdCBJREJEYXRh YmFzZU1ldGFkYXRhOwogbmFtZXNwYWNlIFdlYktpdCB7CiAKIHN0cnVjdCBXZWJJREJNZXRhZGF0 YSB7CisgICAgZW51bSB7CisgICAgICAgIE5vSW50VmVyc2lvbiA9IC0xCisgICAgfTsKICAgICBz dHJ1Y3QgSW5kZXg7CiAgICAgc3RydWN0IE9iamVjdFN0b3JlOwogCiAgICAgV2ViU3RyaW5nIG5h bWU7CisgICAgLy8gRklYTUU6IEJvdGggdmVyc2lvbiBtZW1iZXJzIG5lZWQgdG8gYmUgcHJlc2Vu dCB3aGlsZSB3ZSBzdXBwb3J0IGJvdGggdGhlCisgICAgLy8gb2xkIHNldFZlcnNpb24gYW5kIG5l dyB1cGdyYWRlbmVlZGVkIEFQSS4gT25jZSB3ZSBubyBsb25nZXIgc3VwcG9ydAorICAgIC8vIHNl dFZlcnNpb24sIFdlYlN0cmluZyB2ZXJzaW9uIGNhbiBiZSByZW1vdmVkLgogICAgIFdlYlN0cmlu ZyB2ZXJzaW9uOworICAgIGludDY0X3QgaW50VmVyc2lvbjsKICAgICBXZWJWZWN0b3I8T2JqZWN0 U3RvcmU+IG9iamVjdFN0b3JlczsKLSAgICBXZWJJREJNZXRhZGF0YSgpIHsgfQorICAgIFdlYklE Qk1ldGFkYXRhKCkKKyAgICAgICAgOiBpbnRWZXJzaW9uKE5vSW50VmVyc2lvbikgeyB9CiAKICAg ICBzdHJ1Y3QgT2JqZWN0U3RvcmUgewogICAgICAgICBXZWJTdHJpbmcgbmFtZTsK 153147 2012-07-18 17:41:49 -0700 2012-07-18 18:31:53 -0700 Patch bug-91408-20120718174148.patch text/plain 2010 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGM5MThkM2VmMWI5MTg1MDM4ZjU3M2ZkZGM3MWM2Y2I4OTRkMDdiZTEuLjE0ZjUxNjZjOGJlM2Zk OWEwNzNiZmJhYTU2ZWYxYjU0YWNiM2YzZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMDctMTggIERhdmlkIEdyb2dhbiAgPGRncm9nYW5AY2hyb21p dW0ub3JnPgorCisgICAgICAgIEluZGV4ZWREQjogQWRkIGludFZlcnNpb24gdG8gY2hyb21pdW0v cHVibGljL1dlYklEQk1ldGFkYXRhLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTkxNDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBpcyBpbiBzdXBwb3J0IG9mIHRoZSBuZXcgdXBncmFkZW5lZWRl ZCB2ZXJzaW9uaW5nIGFwaS4KKyAgICAgICAgaW50VmVyc2lvbiB3aWxsIGV2ZW50dWFsbHkgcmVw bGFjZSB0aGUgV2ViU3RyaW5nIHZlcnNpb24gbWVtYmVyLgorCisgICAgICAgICogcHVibGljL1dl YklEQk1ldGFkYXRhLmg6CisgICAgICAgIChXZWJLaXQ6OldlYklEQk1ldGFkYXRhOjpXZWJJREJN ZXRhZGF0YSk6CisgICAgICAgIFRoZSBzcGVjIHVzZXMgdW5zaWduZWQgbG9uZyBsb25nIGZvciB2 ZXJzaW9uIG51bWJlcnMgYnV0IHdlIHVzZSBzaWduZWQKKyAgICAgICAgbG9uZyBsb25nIHNvIHRo YXQgd2UgY2FuIHVzZSAtMSBhcyBhIHNlbnRpbmVsLiBJdCBpbmRpY2F0ZXMgdGhhdCBhCisgICAg ICAgIGRhdGFiYXNlIHN0aWxsIHVzZXMgYSBzdHJpbmcgdmVyc2lvbi4KKwogMjAxMi0wNy0xNyAg VG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxMjI4ODQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJJREJNZXRhZGF0YS5oIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi SURCTWV0YWRhdGEuaAppbmRleCAxYzMzZDFiMDgwZDc1NjgyZWRjZWQyZmRmYWJlYTRiMWVlNGQ4 NjVmLi4xZjJlOWVhZDQ1ZjIyM2E2OWE2NjBjYzdjYzY3ODQxMDAyZjFmZjZlIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJNZXRhZGF0YS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQk1ldGFkYXRhLmgKQEAgLTM4LDEzICsz OCwyMSBAQCBzdHJ1Y3QgSURCRGF0YWJhc2VNZXRhZGF0YTsKIG5hbWVzcGFjZSBXZWJLaXQgewog CiBzdHJ1Y3QgV2ViSURCTWV0YWRhdGEgeworICAgIGVudW0geworICAgICAgICBOb0ludFZlcnNp b24gPSAtMQorICAgIH07CiAgICAgc3RydWN0IEluZGV4OwogICAgIHN0cnVjdCBPYmplY3RTdG9y ZTsKIAogICAgIFdlYlN0cmluZyBuYW1lOworICAgIC8vIEZJWE1FOiBCb3RoIHZlcnNpb24gbWVt YmVycyBuZWVkIHRvIGJlIHByZXNlbnQgd2hpbGUgd2Ugc3VwcG9ydCBib3RoIHRoZQorICAgIC8v IG9sZCBzZXRWZXJzaW9uIGFuZCBuZXcgdXBncmFkZW5lZWRlZCBBUEkuIE9uY2Ugd2Ugbm8gbG9u Z2VyIHN1cHBvcnQKKyAgICAvLyBzZXRWZXJzaW9uLCBXZWJTdHJpbmcgdmVyc2lvbiBjYW4gYmUg cmVtb3ZlZC4KICAgICBXZWJTdHJpbmcgdmVyc2lvbjsKKyAgICBsb25nIGxvbmcgaW50VmVyc2lv bjsKICAgICBXZWJWZWN0b3I8T2JqZWN0U3RvcmU+IG9iamVjdFN0b3JlczsKLSAgICBXZWJJREJN ZXRhZGF0YSgpIHsgfQorICAgIFdlYklEQk1ldGFkYXRhKCkKKyAgICAgICAgOiBpbnRWZXJzaW9u KE5vSW50VmVyc2lvbikgeyB9CiAKICAgICBzdHJ1Y3QgT2JqZWN0U3RvcmUgewogICAgICAgICBX ZWJTdHJpbmcgbmFtZTsK