91401 2012-07-16 09:51:50 -0700 [EFL][WK2] Implement decidePolicyForResponse in policy client 2012-07-16 20:51:43 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61838 91345 1 cdumez cdumez gustavo gyuyoung.kim kenneth rakuco ryuan.choi tonikitoo webkit.review.bot oldest_to_newest 670414 0 cdumez 2012-07-16 09:51:50 -0700 We need to implement the decidePolicyForResponse callback in our policy client. The basic rule should be that if the view can show the MIME type, then we should accept the request, otherwise we should download it. 670449 1 152559 cdumez 2012-07-16 10:32:27 -0700 Created attachment 152559 Patch The patch is based on Qt's implementation, except for the resourceResponse.isAttachment() check which is inspired from GTK port. 670950 2 152559 webkit.review.bot 2012-07-16 20:51:34 -0700 Comment on attachment 152559 Patch Clearing flags on attachment: 152559 Committed r122803: <http://trac.webkit.org/changeset/122803> 670951 3 webkit.review.bot 2012-07-16 20:51:43 -0700 All reviewed patches have been landed. Closing bug. 152559 2012-07-16 10:32:27 -0700 2012-07-16 20:51:34 -0700 Patch 91401_decidePolicyForResponse.patch text/plain 3679 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMWJkOWZlLi5kOWUyNzc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMTYgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEltcGxlbWVudCBkZWNpZGVQb2xpY3lGb3JSZXNw b25zZSBpbiBwb2xpY3kgY2xpZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MTQwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFByb3ZpZGUgaW1wbGVtZW50YXRpb24gZm9yIGRlY2lkZVBvbGljeUZvclJl c3BvbnNlIGNhbGxiYWNrCisgICAgICAgIGluIFdlYktpdDIgRUZMJ3MgcG9saWN5IGNsaWVudC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3BvbGljeV9jbGllbnQuY3Bw OgorICAgICAgICAoZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2VDYWxsYmFjayk6CisgICAgICAgIChl d2tfdmlld19wb2xpY3lfY2xpZW50X2F0dGFjaCk6CisKIDIwMTItMDctMTYgIFpvbHRhbiBIb3J2 YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBDaGFuZ2UgTmF0aXZlSW1h Z2VQdHIgZnJvbSBRUGl4bWFwKiB0byBRSW1hZ2UqCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlld19wb2xpY3lfY2xpZW50LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3BvbGljeV9jbGllbnQuY3BwCmluZGV4 IDVmNjg5ZTUuLmM4NWZkODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3X3BvbGljeV9jbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3X3BvbGljeV9jbGllbnQuY3BwCkBAIC0yNiwxMiArMjYs MTQgQEAKICNpbmNsdWRlICJjb25maWcuaCIKIAogI2luY2x1ZGUgIldLRnJhbWUuaCIKKyNpbmNs dWRlICJXS0ZyYW1lUG9saWN5TGlzdGVuZXIuaCIKICNpbmNsdWRlICJld2tfbmF2aWdhdGlvbl9w b2xpY3lfZGVjaXNpb24uaCIKICNpbmNsdWRlICJld2tfbmF2aWdhdGlvbl9wb2xpY3lfZGVjaXNp b25fcHJpdmF0ZS5oIgogI2luY2x1ZGUgImV3a192aWV3X3BvbGljeV9jbGllbnRfcHJpdmF0ZS5o IgogI2luY2x1ZGUgImV3a192aWV3X3ByaXZhdGUuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3Ry aW5nLmg+CiAKK3VzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogdXNpbmcgbmFtZXNwYWNlIFdlYktp dDsKIAogc3RhdGljIGlubGluZSBFdmFzX09iamVjdCogdG9Fd2tWaWV3KGNvbnN0IHZvaWQqIGNs aWVudEluZm8pCkBAIC01Myw2ICs1NSwzOSBAQCBzdGF0aWMgdm9pZCBkZWNpZGVQb2xpY3lGb3JO ZXdXaW5kb3dBY3Rpb24oV0tQYWdlUmVmIHBhZ2UsIFdLRnJhbWVSZWYgZnJhbWUsIFdLRgogICAg IGV3a19uYXZpZ2F0aW9uX3BvbGljeV9kZWNpc2lvbl9mcmVlKGRlY2lzaW9uKTsKIH0KIAorc3Rh dGljIHZvaWQgZGVjaWRlUG9saWN5Rm9yUmVzcG9uc2VDYWxsYmFjayhXS1BhZ2VSZWYgcGFnZSwg V0tGcmFtZVJlZiBmcmFtZSwgV0tVUkxSZXNwb25zZVJlZiByZXNwb25zZSwgV0tVUkxSZXF1ZXN0 UmVmLCBXS0ZyYW1lUG9saWN5TGlzdGVuZXJSZWYgbGlzdGVuZXIsIFdLVHlwZVJlZiB1c2VyRGF0 YSwgY29uc3Qgdm9pZCogY2xpZW50SW5mbykKK3sKKyAgICBjb25zdCBSZXNvdXJjZVJlc3BvbnNl IHJlc291cmNlUmVzcG9uc2UgPSB0b0ltcGwocmVzcG9uc2UpLT5yZXNvdXJjZVJlc3BvbnNlKCk7 CisgICAgLy8gSWYgdGhlIFVSTCBSZXNwb25zZSBoYXMgIkNvbnRlbnQtRGlzcG9zaXRpb246IGF0 dGFjaG1lbnQ7IiBoZWFkZXIsIHRoZW4KKyAgICAvLyB3ZSBzaG91bGQgZG93bmxvYWQgaXQuCisg ICAgaWYgKHJlc291cmNlUmVzcG9uc2UuaXNBdHRhY2htZW50KCkpIHsKKyAgICAgICAgV0tGcmFt ZVBvbGljeUxpc3RlbmVyRG93bmxvYWQobGlzdGVuZXIpOworICAgICAgICByZXR1cm47CisgICAg fQorCisgICAgU3RyaW5nIG1pbWVUeXBlID0gdG9JbXBsKHJlc3BvbnNlKS0+cmVzb3VyY2VSZXNw b25zZSgpLm1pbWVUeXBlKCkubG93ZXIoKTsKKyAgICBib29sIGNhblNob3dNSU1FVHlwZSA9IHRv SW1wbChmcmFtZSktPmNhblNob3dNSU1FVHlwZShtaW1lVHlwZSk7CisgICAgaWYgKFdLRnJhbWVJ c01haW5GcmFtZShmcmFtZSkpIHsKKyAgICAgICAgaWYgKGNhblNob3dNSU1FVHlwZSkgeworICAg ICAgICAgICAgV0tGcmFtZVBvbGljeUxpc3RlbmVyVXNlKGxpc3RlbmVyKTsKKyAgICAgICAgICAg IHJldHVybjsKKyAgICAgICAgfQorCisgICAgICAgIC8vIElmIHdlIGNhbid0IHVzZSAoc2hvdykg aXQgdGhlbiB3ZSBzaG91bGQgZG93bmxvYWQgaXQuCisgICAgICAgIFdLRnJhbWVQb2xpY3lMaXN0 ZW5lckRvd25sb2FkKGxpc3RlbmVyKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIC8v IFdlIHNob3VsZCBpZ25vcmUgZG93bmxvYWRhYmxlIHRvcC1sZXZlbCBjb250ZW50IGZvciBzdWJm cmFtZXMsIHdpdGggYW4gZXhjZXB0aW9uIGZvciB0ZXh0L3htbCBhbmQgYXBwbGljYXRpb24veG1s IHNvIHdlIGNhbiBzdGlsbCBzdXBwb3J0IEFjaWQzIHRlc3QuCisgICAgLy8gSXQgbWFrZXMgdGhl IGJyb3dzZXIgaW50ZW50aW9uYWxseSBiZWhhdmUgZGlmZmVyZW50bHkgd2hlbiBpdCBjb21lcyB0 byB0ZXh0KGFwcGxpY2F0aW9uKS94bWwgY29udGVudCBpbiBzdWJmcmFtZXMgdnMuIG1haW5mcmFt ZS4KKyAgICBpZiAoIWNhblNob3dNSU1FVHlwZSAmJiAhKG1pbWVUeXBlID09ICJ0ZXh0L3htbCIg fHwgbWltZVR5cGUgPT0gImFwcGxpY2F0aW9uL3htbCIpKSB7CisgICAgICAgIFdLRnJhbWVQb2xp Y3lMaXN0ZW5lcklnbm9yZShsaXN0ZW5lcik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAg ICBXS0ZyYW1lUG9saWN5TGlzdGVuZXJVc2UobGlzdGVuZXIpOworfQorCiB2b2lkIGV3a192aWV3 X3BvbGljeV9jbGllbnRfYXR0YWNoKFdLUGFnZVJlZiBwYWdlUmVmLCBFdmFzX09iamVjdCogZXdr VmlldykKIHsKICAgICBXS1BhZ2VQb2xpY3lDbGllbnQgcG9saWN5Q2xpZW50OwpAQCAtNjEsNiAr OTYsNyBAQCB2b2lkIGV3a192aWV3X3BvbGljeV9jbGllbnRfYXR0YWNoKFdLUGFnZVJlZiBwYWdl UmVmLCBFdmFzX09iamVjdCogZXdrVmlldykKICAgICBwb2xpY3lDbGllbnQuY2xpZW50SW5mbyA9 IGV3a1ZpZXc7CiAgICAgcG9saWN5Q2xpZW50LmRlY2lkZVBvbGljeUZvck5hdmlnYXRpb25BY3Rp b24gPSBkZWNpZGVQb2xpY3lGb3JOYXZpZ2F0aW9uQWN0aW9uOwogICAgIHBvbGljeUNsaWVudC5k ZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dBY3Rpb24gPSBkZWNpZGVQb2xpY3lGb3JOZXdXaW5kb3dB Y3Rpb247CisgICAgcG9saWN5Q2xpZW50LmRlY2lkZVBvbGljeUZvclJlc3BvbnNlID0gZGVjaWRl UG9saWN5Rm9yUmVzcG9uc2VDYWxsYmFjazsKIAogICAgIFdLUGFnZVNldFBhZ2VQb2xpY3lDbGll bnQocGFnZVJlZiwgJnBvbGljeUNsaWVudCk7CiB9Cg==