91399 2012-07-16 09:06:35 -0700 [Qt] platform/qt/editing/pasteboard tests needs update after rebaseline and new testfonts (75) 2012-07-27 04:12:05 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85203 0 kadam webkit-unassigned cmarcelo hausmann kkristof ossy szledan webkit.review.bot oldest_to_newest 670382 0 kadam 2012-07-16 09:06:35 -0700 I'm updating test expectations after font change. 670392 1 152549 kadam 2012-07-16 09:17:21 -0700 Created attachment 152549 proposed patch I updated test expectations and png. I skipped a failing test. 673479 2 hausmann 2012-07-19 07:21:55 -0700 Did you forget to set r? 673580 3 cmarcelo 2012-07-19 09:27:22 -0700 Fixing typo in the bug title. 675546 4 kadam 2012-07-23 01:56:02 -0700 Sorry, I forgot to set r?. I'll fix it. 675635 5 153778 kadam 2012-07-23 05:17:24 -0700 Created attachment 153778 proposed patch Update last patch. 675832 6 153778 cmarcelo 2012-07-23 11:13:07 -0700 Comment on attachment 153778 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=153778&action=review > LayoutTests/platform/qt-5.0/Skipped:1552 > +editing/pasteboard/4944770-1.html > +editing/pasteboard/4944770-2.html Are these two still failing? They seem to work here. 676513 7 kadam 2012-07-24 01:31:27 -0700 It's very interesting. These tests wasn't working, when I tested them therefore I left them on skippedlist. I'm going to testing again. Maybe I was inattentive. 676622 8 kadam 2012-07-24 03:58:47 -0700 You were right. :) Thanks for the review. I was inattentive. :( I added new expectations to platform/qt but these tests had some older expectations in qt-5.0-wk2 and qt-5.0 too. When I was testing it the script didn't consider platform/qt baseline directory. Those expectations will be deleted and it will work fine. 676675 9 154023 kadam 2012-07-24 05:01:11 -0700 Created attachment 154023 proposed patch I updated my patch. Now these tests are working well. 678005 10 154343 kadam 2012-07-25 07:05:48 -0700 Created attachment 154343 proposed patch I think patch is ready. I hope it's working now. Could you have look at it please? 678016 11 154343 ossy 2012-07-25 07:15:47 -0700 Comment on attachment 154343 proposed patch rs=me 678023 12 154343 webkit.review.bot 2012-07-25 07:21:41 -0700 Comment on attachment 154343 proposed patch Rejecting attachment 154343 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: s/platform/qt/editing/pasteboard/smart-paste-007-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Csaba Oszt..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13341254 678293 13 cmarcelo 2012-07-25 11:37:10 -0700 Maybe the patch needs to be rebased? 679389 14 154663 kadam 2012-07-26 09:05:44 -0700 Created attachment 154663 proposed patch I'm ready to update. 679554 15 154663 webkit.review.bot 2012-07-26 11:22:34 -0700 Comment on attachment 154663 proposed patch Rejecting attachment 154663 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ed.txt patching file LayoutTests/platform/qt/editing/pasteboard/smart-paste-007-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/styled-element-markup-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/undoable-fragment-removes-expected.txt patching file LayoutTests/platform/qt/editing/pasteboard/unrendered-br-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13349870 680173 16 154856 kadam 2012-07-26 23:50:11 -0700 Created attachment 154856 proposed patch Update. 680236 17 154856 webkit.review.bot 2012-07-27 01:04:27 -0700 Comment on attachment 154856 proposed patch Rejecting attachment 154856 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13361989 680420 18 154856 webkit.review.bot 2012-07-27 04:12:01 -0700 Comment on attachment 154856 proposed patch Clearing flags on attachment: 154856 Committed r123862: <http://trac.webkit.org/changeset/123862> 680421 19 webkit.review.bot 2012-07-27 04:12:05 -0700 All reviewed patches have been landed. Closing bug. 152549 2012-07-16 09:17:21 -0700 2012-07-23 05:17:24 -0700 proposed patch testfont_editing_pasteboard.patch text/plain 0 kadam 153778 2012-07-23 05:17:24 -0700 2012-07-24 05:01:11 -0700 proposed patch testfont_editing_pasteboard.patch text/plain 0 kadam 154023 2012-07-24 05:01:11 -0700 2012-07-25 07:05:48 -0700 proposed patch testfont_editing_pasteboardnew.patch text/plain 0 kadam 154343 2012-07-25 07:05:48 -0700 2012-07-26 09:05:44 -0700 proposed patch testfont_editing_pasteboard0725_2.patch text/plain 0 kadam 154663 2012-07-26 09:05:44 -0700 2012-07-26 23:50:11 -0700 proposed patch testfont_editing_pasteboard0725.patch text/plain 0 kadam 154856 2012-07-26 23:50:11 -0700 2012-07-27 04:12:00 -0700 proposed patch testfont_editing_pasteboard0725_2.patch text/plain 0 kadam