91387 2012-07-16 07:05:32 -0700 [CMake][EFL] Building jsc causes reconfiguration 2012-07-18 05:59:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 88717 1 tmpsantos tmpsantos cdumez dbates gyuyoung.kim rakuco rwlbuis sw0524.lee webkit.review.bot oldest_to_newest 670306 0 tmpsantos 2012-07-16 07:05:32 -0700 One of the steps of our build bot calls ./Tools/Scripts/run-javascriptcore-tests which calls ./Tools/Scripts/build-jsc internally. This script builds the "jsc" target, which is fine. The problem is: we are removing the CMakeCache.txt every time we build a target using the convenience perl script "buildCMakeProjectOrExit". In this case, the whole project is reconfigured using the default build options. This leads to 2 side effects: - jsc is rebuilt on the bots every time (since it takes different configuration). - We are not building and running the WebKit2 unit tests on the bots. We should remove the cache only when running ./Tools/Scripts/build-webkit. 671162 1 152731 tmpsantos 2012-07-17 04:19:20 -0700 Created attachment 152731 Patch 671404 2 152731 dbates 2012-07-17 11:04:16 -0700 Comment on attachment 152731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152731&action=review OK > Tools/ChangeLog:9 > + other it will cause a reconfiguration every time someone calls Nit: other => otherwise > Tools/ChangeLog:11 > + not running WebKit 2 unit tests on the bots because the project was Nit: WebKit 2 => WebKit2 > Tools/Scripts/webkitdirs.pm:2129 > + my $config = configuration(); > + my $buildPath = File::Spec->catdir(baseProductDir(), $config); > + my $cacheFilePath = File::Spec->catdir($buildPath, "CMakeCache.txt"); I don't see much value in defining the variables $config and $buildPath that are only used towards building the filesystem path to the appropriate file CMakeCache.txt. I would write this as: my $cacheFilePath = File::Spec->catdir(baseProductDir(), configuration(), "CMakeCache.txt"); > Tools/Scripts/webkitdirs.pm:2130 > + Nit: I don't feel that this empty line improves the readability of this function and I suggest that we remove it. The body of this function is concise and straightforward to follow without this empty line. 672224 3 152983 tmpsantos 2012-07-18 04:06:11 -0700 Created attachment 152983 Patch Thanks a lot for reviewing. 672299 4 152983 webkit.review.bot 2012-07-18 05:59:36 -0700 Comment on attachment 152983 Patch Clearing flags on attachment: 152983 Committed r122956: <http://trac.webkit.org/changeset/122956> 672301 5 webkit.review.bot 2012-07-18 05:59:42 -0700 All reviewed patches have been landed. Closing bug. 152731 2012-07-17 04:19:20 -0700 2012-07-18 04:06:04 -0700 Patch bug-91387-20120717142132.patch text/plain 3098 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2Y2MzlmOGVlNGQzMmZhOTFjODRjY2FjNGUzMjc0M2Yz NmNiYWY2Ni4uNTcxMzliNWZmY2Q5N2ZkYzQ3ZDBiNTg2MTAwMWQ2ZTY2OWRkYWFmMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTA3LTE3ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFtDTWFrZV1bRUZMXSBCdWlsZGluZyBqc2MgY2F1c2VzIHJl Y29uZmlndXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTEzODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBXZSBzaG91bGQgcmVtb3ZlIENNYWtlQ2FjaGUgb25seSB3aGVuIHJ1bm5pbmcgYnVpbGQt d2Via2l0IHNjcmlwdCwKKyAgICAgICAgb3RoZXIgaXQgd2lsbCBjYXVzZSBhIHJlY29uZmlndXJh dGlvbiBldmVyeSB0aW1lIHNvbWVvbmUgY2FsbHMKKyAgICAgICAgZ2VuZXJhdGVCdWlsZFN5c3Rl bUZyb21DTWFrZVByb2plY3QoKS4gV2Ugd2VyZSByZS1idWlsZGluZyAianNjIiBhbmQKKyAgICAg ICAgbm90IHJ1bm5pbmcgV2ViS2l0IDIgdW5pdCB0ZXN0cyBvbiB0aGUgYm90cyBiZWNhdXNlIHRo ZSBwcm9qZWN0IHdhcworICAgICAgICByZWNvbmZpZ3VyZWQgd2l0aCBkZWZhdWx0IHZhbHVlcyBi eSB0aGUgc2NyaXB0cyB0aGF0IHJ1biB0aGVzZSB0ZXN0cy4KKworICAgICAgICAqIFNjcmlwdHMv YnVpbGQtd2Via2l0OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAg KHJlbW92ZUNNYWtlQ2FjaGUpOgorICAgICAgICAoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFr ZVByb2plY3QpOgorCiAyMDEyLTA3LTEyICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFn by5zYW50b3NAaW50ZWwuY29tPgogCiAgICAgICAgIFtDTWFrZV1bRUZMXSBCdWlsZCBhbmQgcnVu IFRlc3RXZWJLaXRBUEkgdW5pdCB0ZXN0cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9idWls ZC13ZWJraXQgYi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAppbmRleCA0NGExYmJmMGY4YjBl YzgzODRiNGQ1MjVmMmQ3MmZiNTMzNDdjN2ZkLi5hZTJhYjgyODZjZmM1MWE0OTJlNmVjMmI2Mjk5 ZDYwYTk3YjYyY2I4IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAorKysg Yi9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdApAQCAtMzMxLDYgKzMzMSwxMSBAQCBpZiAoaXNF ZmwoKSkgewogICAgICRtYWtlQXJncyAuPSAoJG1ha2VBcmdzID8gIiAiIDogIiIpIC4gIi1qIiAu IG51bWJlck9mQ1BVcygpIGlmICRtYWtlQXJncyAhfiAvLWpccypcZCsvOwogICAgICRjbWFrZUFy Z3MgLj0gKCRjbWFrZUFyZ3MgPyAiICIgOiAiIikgLiAiLURFTkFCTEVfV0VCS0lUPU9OIjsKICAg ICAkY21ha2VBcmdzIC49ICIgLURFTkFCTEVfV0VCS0lUMj1PTiIgaWYgISRub1dlYktpdDI7CisK KyAgICAjIFdlIHJlbW92ZSBDTWFrZUNhY2hlIHRvIGF2b2lkIHRoZSBib3RzIHRvIHJldXNlIGNh Y2hlZCBmbGFncyB3aGVuCisgICAgIyB3ZSBlbmFibGUgbmV3IGZlYXR1cmVzLiBUaGlzIGZvcmNl cyBhIHJlY29uZmlndXJhdGlvbi4KKyAgICByZW1vdmVDTWFrZUNhY2hlKCk7CisKICAgICBidWls ZENNYWtlUHJvamVjdE9yRXhpdCgkY2xlYW4sICJFZmwiLCAkcHJlZml4UGF0aCwgJG1ha2VBcmdz LCAoY21ha2VCYXNlZFBvcnRBcmd1bWVudHMoKSwgY01ha2VBcmdzRnJvbUZlYXR1cmVzKCkpLCAk Y21ha2VBcmdzKTsKIH0KIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDFkYTA5NDcxYmE3OGQ4MzFhMWIz ODE5ZTc4YjQxMTQ4Y2Q0ZTFhZjguLjQ5OGM5MzE1NWMzYWRhZjBkYjVkZWQ3YWRhYjA3ZTkzMTBm OGFiNjQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIxMjIsNiArMjEyMiwxNSBAQCBzdWIgamhidWls ZFdyYXBwZXJQcmVmaXhJZk5lZWRlZCgpCiAgICAgcmV0dXJuICIiOwogfQogCitzdWIgcmVtb3Zl Q01ha2VDYWNoZSgpCit7CisgICAgbXkgJGNvbmZpZyA9IGNvbmZpZ3VyYXRpb24oKTsKKyAgICBt eSAkYnVpbGRQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0RGlyKCksICRjb25m aWcpOworICAgIG15ICRjYWNoZUZpbGVQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKCRidWlsZFBh dGgsICJDTWFrZUNhY2hlLnR4dCIpOworCisgICAgdW5saW5rKCRjYWNoZUZpbGVQYXRoKSBpZiAt ZSAkY2FjaGVGaWxlUGF0aDsKK30KKwogc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQ cm9qZWN0CiB7CiAgICAgbXkgKCRwb3J0LCAkcHJlZml4UGF0aCwgQGNtYWtlQXJncywgJGFkZGl0 aW9uYWxDTWFrZUFyZ3MpID0gQF87CkBAIC0yMTYxLDEyICsyMTcwLDYgQEAgc3ViIGdlbmVyYXRl QnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgICAgIHNhdmVKaGJ1aWxkTWQ1KCk7CiAg ICAgfQogCi0gICAgIyBSZW1vdmUgQ01ha2VDYWNoZS50eHQgdG8gYXZvaWQgdXNpbmcgb3V0ZGF0 ZWQgYnVpbGQgZmxhZ3MKLSAgICBpZiAoaXNFZmwoKSkgewotICAgICAgICBteSAkY2FjaGVGaWxl UGF0aCA9IEZpbGU6OlNwZWMtPmNhdGRpcigkYnVpbGRQYXRoLCAiQ01ha2VDYWNoZS50eHQiKTsK LSAgICAgICAgdW5saW5rKCRjYWNoZUZpbGVQYXRoKSBpZiAtZSAkY2FjaGVGaWxlUGF0aDsKLSAg ICB9Ci0KICAgICAjIFdlIGNhbGwgc3lzdGVtKCJjbWFrZSBAYXJncyIpIGluc3RlYWQgb2Ygc3lz dGVtKCJjbWFrZSIsIEBhcmdzKSBzbyB0aGF0IEBhcmdzIGlzCiAgICAgIyBwYXJzZWQgZm9yIHNo ZWxsIG1ldGFjaGFyYWN0ZXJzLgogICAgIG15ICR3cmFwcGVyID0gamhidWlsZFdyYXBwZXJQcmVm aXhJZk5lZWRlZCgpIC4gIiAiOwo= 152983 2012-07-18 04:06:11 -0700 2012-07-18 05:59:36 -0700 Patch bug-91387-20120718140610.patch text/plain 3002 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTMyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGRjNjJiZjM4Zjc1MTQ3NWUzMzhlNzZmMmU5MTNhZTA2 N2MwOWE1MC4uYTI4NzRmOWE2ZjZiOWNhYTE4OTUzMjlhNGY1OWRmYzU1ZTFlNjk0MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTA3LTE4ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFtDTWFrZV1bRUZMXSBCdWlsZGluZyBqc2MgY2F1c2VzIHJl Y29uZmlndXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTEzODcKKworICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAgICAg ICAgV2Ugc2hvdWxkIHJlbW92ZSBDTWFrZUNhY2hlIG9ubHkgd2hlbiBydW5uaW5nIGJ1aWxkLXdl YmtpdCBzY3JpcHQsCisgICAgICAgIG90aGVyd2lzZSBpdCB3aWxsIGNhdXNlIGEgcmVjb25maWd1 cmF0aW9uIGV2ZXJ5IHRpbWUgc29tZW9uZSBjYWxscworICAgICAgICBnZW5lcmF0ZUJ1aWxkU3lz dGVtRnJvbUNNYWtlUHJvamVjdCgpLiBXZSB3ZXJlIHJlLWJ1aWxkaW5nICJqc2MiIGFuZAorICAg ICAgICBub3QgcnVubmluZyBXZWJLaXQyIHVuaXQgdGVzdHMgb24gdGhlIGJvdHMgYmVjYXVzZSB0 aGUgcHJvamVjdCB3YXMKKyAgICAgICAgcmVjb25maWd1cmVkIHdpdGggZGVmYXVsdCB2YWx1ZXMg YnkgdGhlIHNjcmlwdHMgdGhhdCBydW4gdGhlc2UgdGVzdHMuCisKKyAgICAgICAgKiBTY3JpcHRz L2J1aWxkLXdlYmtpdDoKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAg IChyZW1vdmVDTWFrZUNhY2hlKToKKyAgICAgICAgKGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01h a2VQcm9qZWN0KToKKwogMjAxMi0wNy0xOCAgS3Jpc3TDs2YgS29zenR5w7MgIDxra3Jpc3RvZkBp bmYudS1zemVnZWQuaHU+CiAKICAgICAgICAgW05SV1RdIFVucmV2aWV3ZWQgZ2FyZGVuaW5nIGFm dGVyIHIxMjI5MTMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvVG9v bHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggYzM3YmNlN2Q0YWM0MjRkNjRjYTZiODFmMzM1 OGI3ZTExMzVjMmI2Ni4uYTgxOTIyYTExNzcyNWMxZTBmMDczYTU0ZDQzZWEwYTZiZGM5Nzk4YiAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0 cy9idWlsZC13ZWJraXQKQEAgLTMxOSw2ICszMTksMTEgQEAgaWYgKGlzRWZsKCkpIHsKICAgICAk bWFrZUFyZ3MgLj0gKCRtYWtlQXJncyA/ICIgIiA6ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMo KSBpZiAkbWFrZUFyZ3MgIX4gLy1qXHMqXGQrLzsKICAgICAkY21ha2VBcmdzIC49ICgkY21ha2VB cmdzID8gIiAiIDogIiIpIC4gIi1ERU5BQkxFX1dFQktJVD1PTiI7CiAgICAgJGNtYWtlQXJncyAu PSAiIC1ERU5BQkxFX1dFQktJVDI9T04iIGlmICEkbm9XZWJLaXQyOworCisgICAgIyBXZSByZW1v dmUgQ01ha2VDYWNoZSB0byBhdm9pZCB0aGUgYm90cyB0byByZXVzZSBjYWNoZWQgZmxhZ3Mgd2hl bgorICAgICMgd2UgZW5hYmxlIG5ldyBmZWF0dXJlcy4gVGhpcyBmb3JjZXMgYSByZWNvbmZpZ3Vy YXRpb24uCisgICAgcmVtb3ZlQ01ha2VDYWNoZSgpOworCiAgICAgYnVpbGRDTWFrZVByb2plY3RP ckV4aXQoJGNsZWFuLCAiRWZsIiwgJHByZWZpeFBhdGgsICRtYWtlQXJncywgKGNtYWtlQmFzZWRQ b3J0QXJndW1lbnRzKCksIGNNYWtlQXJnc0Zyb21GZWF0dXJlcygpKSwgJGNtYWtlQXJncyk7CiB9 CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbQppbmRleCA1OGM1NWE0OWNhOTFmZGJlNjMzZGI2ZDg4MzNkYTBhZjYx OTVkZjJlLi5mODdhYjA0ZGJlNWU1MDU5NTI3MTc0OTNhYTE5NWZlMzYyMTdkMTE4IDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCkBAIC0yMTI4LDYgKzIxMjgsMTIgQEAgc3ViIGpoYnVpbGRXcmFwcGVyUHJlZml4 SWZOZWVkZWQoKQogICAgIHJldHVybiAiIjsKIH0KIAorc3ViIHJlbW92ZUNNYWtlQ2FjaGUoKQor eworICAgIG15ICRjYWNoZUZpbGVQYXRoID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKGJhc2VQcm9kdWN0 RGlyKCksIGNvbmZpZ3VyYXRpb24oKSwgIkNNYWtlQ2FjaGUudHh0Iik7CisgICAgdW5saW5rKCRj YWNoZUZpbGVQYXRoKSBpZiAtZSAkY2FjaGVGaWxlUGF0aDsKK30KKwogc3ViIGdlbmVyYXRlQnVp bGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiB7CiAgICAgbXkgKCRwb3J0LCAkcHJlZml4UGF0aCwg QGNtYWtlQXJncywgJGFkZGl0aW9uYWxDTWFrZUFyZ3MpID0gQF87CkBAIC0yMTY3LDEyICsyMTcz LDYgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgICAgIHNh dmVKaGJ1aWxkTWQ1KCk7CiAgICAgfQogCi0gICAgIyBSZW1vdmUgQ01ha2VDYWNoZS50eHQgdG8g YXZvaWQgdXNpbmcgb3V0ZGF0ZWQgYnVpbGQgZmxhZ3MKLSAgICBpZiAoaXNFZmwoKSkgewotICAg ICAgICBteSAkY2FjaGVGaWxlUGF0aCA9IEZpbGU6OlNwZWMtPmNhdGRpcigkYnVpbGRQYXRoLCAi Q01ha2VDYWNoZS50eHQiKTsKLSAgICAgICAgdW5saW5rKCRjYWNoZUZpbGVQYXRoKSBpZiAtZSAk Y2FjaGVGaWxlUGF0aDsKLSAgICB9Ci0KICAgICAjIFdlIGNhbGwgc3lzdGVtKCJjbWFrZSBAYXJn cyIpIGluc3RlYWQgb2Ygc3lzdGVtKCJjbWFrZSIsIEBhcmdzKSBzbyB0aGF0IEBhcmdzIGlzCiAg ICAgIyBwYXJzZWQgZm9yIHNoZWxsIG1ldGFjaGFyYWN0ZXJzLgogICAgIG15ICR3cmFwcGVyID0g amhidWlsZFdyYXBwZXJQcmVmaXhJZk5lZWRlZCgpIC4gIiAiOwo=