91370 2012-07-16 03:16:00 -0700 run-webkit-test returns 254 at exit even when it succeeds 2012-07-17 08:49:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91129 1 tmpsantos tmpsantos abarth cdumez dpranke hausmann ojan vsevik webkit.review.bot oldest_to_newest 670211 0 tmpsantos 2012-07-16 03:16:00 -0700 Which makes impossible to make our bots green. 670221 1 152505 tmpsantos 2012-07-16 03:40:20 -0700 Created attachment 152505 Patch 670224 2 152505 cdumez 2012-07-16 03:44:13 -0700 Comment on attachment 152505 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152505&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:486 > except BaseException, e: Shouldn't we catch Exception instead of BaseException ? 670226 3 tmpsantos 2012-07-16 03:46:28 -0700 (In reply to comment #2) > (From update of attachment 152505 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152505&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:486 > > except BaseException, e: > > Shouldn't we catch Exception instead of BaseException ? Check bug 91129. 670293 4 152522 tmpsantos 2012-07-16 06:45:31 -0700 Created attachment 152522 Patch Better name to return code variable. 670309 5 152522 buildbot 2012-07-16 07:07:33 -0700 Comment on attachment 152522 Patch Attachment 152522 did not pass win-ews (win): Output: http://queues.webkit.org/results/13238934 670338 6 152522 webkit.review.bot 2012-07-16 07:56:35 -0700 Comment on attachment 152522 Patch Clearing flags on attachment: 152522 Committed r122728: <http://trac.webkit.org/changeset/122728> 670340 7 webkit.review.bot 2012-07-16 07:56:41 -0700 All reviewed patches have been landed. Closing bug. 670475 8 152522 dpranke 2012-07-16 11:09:56 -0700 Comment on attachment 152522 Patch interesting, I didn't realize that (obviously). Thanks for the fix! 670480 9 dpranke 2012-07-16 11:11:34 -0700 *** Bug 91389 has been marked as a duplicate of this bug. *** 671261 10 vsevik 2012-07-17 07:19:04 -0700 webkit_lint is still red on chromium bots. http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none 671268 11 tmpsantos 2012-07-17 07:40:27 -0700 (In reply to comment #10) > webkit_lint is still red on chromium bots. > > http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none IMO the actual failure is unrelated to this bug. Looks to me it is failing because of this: LayoutTests/platform/chromium/TestExpectations:2885 More specific entry for fast/frames/calculate-fixed.html on line LayoutTests/platform/chromium/TestExpectations:2885 overrides line LayoutTests/platform/chromium/TestExpectations:2883. fast/frames/calculate-fixed.html http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/19523/steps/webkit_lint/logs/stdio 671295 12 vsevik 2012-07-17 08:49:57 -0700 (In reply to comment #11) > (In reply to comment #10) > > webkit_lint is still red on chromium bots. > > > > http://build.chromium.org/p/chromium.webkit/waterfall?branch=&builder=Webkit+Win+Builder&builder=Webkit+Win&builder=Webkit+Vista&builder=Webkit+Win7&builder=Webkit+Mac+Builder&builder=Webkit+Mac10.5&builder=Webkit+Mac10.6&builder=Webkit+Mac+Builder+%28CG%29&builder=Webkit+Mac10.5+%28CG%29&builder=Webkit+Mac10.6+%28CG%29&builder=Webkit+Mac10.7&builder=Webkit+Linux&builder=Webkit+Linux+32&reload=none > > IMO the actual failure is unrelated to this bug. Looks to me it is failing because of this: > > LayoutTests/platform/chromium/TestExpectations:2885 More specific entry for fast/frames/calculate-fixed.html on line LayoutTests/platform/chromium/TestExpectations:2885 overrides line LayoutTests/platform/chromium/TestExpectations:2883. fast/frames/calculate-fixed.html > > http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6/builds/19523/steps/webkit_lint/logs/stdio That's correct. Sorry for the noise. 152505 2012-07-16 03:40:20 -0700 2012-07-16 06:45:22 -0700 Patch bug-91370-20120716134230.patch text/plain 1552 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJkNGU0NzYyM2U2ZjFlMGU3NmJkZjJmMDVmYjFhYmVh N2E0YTExOC4uMjRmNTZlM2EzMzRhN2ZmNjQyMDM4OTRkYmU4Zjc5ZDA0NWNkM2JlMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA3LTE2ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIHJ1bi13ZWJraXQtdGVzdCByZXR1cm5zIDI1NCBhdCBleGl0 IGV2ZW4gd2hlbiBpdCBzdWNjZWVkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTEzNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBzeXMuZXhpdCgpIGlzIGltcGxlbWVudGVkIGJ5IHJhaXNpbmcgU3lzdGVt RXhpdCB3aGljaCBpbmhlcml0cyBmcm9tCisgICAgICAgIEJhc2VFeGNlcHRpb24uIFNpbmNlIHdl IGFyZSBjYXRjaGluZyBCYXNlRXhjZXB0aW9uLCBydW5fd2Via2l0X3Rlc3RzLnB5CisgICAgICAg IHdhcyBhbHdheXMgcmV0dXJuaW5nIGFuIGVycm9yIGNvZGUuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorCiAyMDEyLTA3LTEy ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgogCiAg ICAgICAgIFtDTWFrZV1bRUZMXSBCdWlsZCBhbmQgcnVuIFRlc3RXZWJLaXRBUEkgdW5pdCB0ZXN0 cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl YmtpdF90ZXN0cy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93 ZWJraXRfdGVzdHMucHkKaW5kZXggNjkxYzg0NTZiMWMzYmVlMWNlN2QyN2U3NjJkMzBkM2Q3YzUz MjlmZi4uNzEwMmE5ZjdhMzFiOTZiNjFmYzBmOTdjYTJiMTM0ZGNjYTM5ZDYyOSAxMDA3NTUKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzLnB5CkBAIC00ODIsOCArNDgyLDEwIEBAIGRlZiBtYWluKGFyZ3Y9Tm9uZSk6CiAKIGlmICdf X21haW5fXycgPT0gX19uYW1lX186CiAgICAgdHJ5OgotICAgICAgICBzeXMuZXhpdChtYWluKCkp CisgICAgICAgIHJldCA9IG1haW4oKQogICAgIGV4Y2VwdCBCYXNlRXhjZXB0aW9uLCBlOgogICAg ICAgICBpZiBlLl9fY2xhc3NfXyBpbiAoS2V5Ym9hcmRJbnRlcnJ1cHQsIFRlc3RSdW5JbnRlcnJ1 cHRlZEV4Y2VwdGlvbik6CiAgICAgICAgICAgICBzeXMuZXhpdChJTlRFUlJVUFRFRF9FWElUX1NU QVRVUykKICAgICAgICAgc3lzLmV4aXQoRVhDRVBUSU9OQUxfRVhJVF9TVEFUVVMpCisKKyAgICBz eXMuZXhpdChyZXQpCg== 152522 2012-07-16 06:45:31 -0700 2012-07-16 11:09:56 -0700 Patch bug-91370-20120716164742.patch text/plain 1568 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJkNGU0NzYyM2U2ZjFlMGU3NmJkZjJmMDVmYjFhYmVh N2E0YTExOC4uMjRmNTZlM2EzMzRhN2ZmNjQyMDM4OTRkYmU4Zjc5ZDA0NWNkM2JlMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA3LTE2ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIHJ1bi13ZWJraXQtdGVzdCByZXR1cm5zIDI1NCBhdCBleGl0 IGV2ZW4gd2hlbiBpdCBzdWNjZWVkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTEzNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBzeXMuZXhpdCgpIGlzIGltcGxlbWVudGVkIGJ5IHJhaXNpbmcgU3lzdGVt RXhpdCB3aGljaCBpbmhlcml0cyBmcm9tCisgICAgICAgIEJhc2VFeGNlcHRpb24uIFNpbmNlIHdl IGFyZSBjYXRjaGluZyBCYXNlRXhjZXB0aW9uLCBydW5fd2Via2l0X3Rlc3RzLnB5CisgICAgICAg IHdhcyBhbHdheXMgcmV0dXJuaW5nIGFuIGVycm9yIGNvZGUuCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorCiAyMDEyLTA3LTEy ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NAaW50ZWwuY29tPgogCiAg ICAgICAgIFtDTWFrZV1bRUZMXSBCdWlsZCBhbmQgcnVuIFRlc3RXZWJLaXRBUEkgdW5pdCB0ZXN0 cwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dl YmtpdF90ZXN0cy5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93 ZWJraXRfdGVzdHMucHkKaW5kZXggNjkxYzg0NTZiMWMzYmVlMWNlN2QyN2U3NjJkMzBkM2Q3YzUz MjlmZi4uOTYxY2JhODQ4MmI1NzFkZjZhYmFlNGE1MzVkOGJjNGU3YWYyMTI5ZSAxMDA3NTUKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzLnB5CkBAIC00ODIsOCArNDgyLDEwIEBAIGRlZiBtYWluKGFyZ3Y9Tm9uZSk6CiAKIGlmICdf X21haW5fXycgPT0gX19uYW1lX186CiAgICAgdHJ5OgotICAgICAgICBzeXMuZXhpdChtYWluKCkp CisgICAgICAgIHJldHVybl9jb2RlID0gbWFpbigpCiAgICAgZXhjZXB0IEJhc2VFeGNlcHRpb24s IGU6CiAgICAgICAgIGlmIGUuX19jbGFzc19fIGluIChLZXlib2FyZEludGVycnVwdCwgVGVzdFJ1 bkludGVycnVwdGVkRXhjZXB0aW9uKToKICAgICAgICAgICAgIHN5cy5leGl0KElOVEVSUlVQVEVE X0VYSVRfU1RBVFVTKQogICAgICAgICBzeXMuZXhpdChFWENFUFRJT05BTF9FWElUX1NUQVRVUykK KworICAgIHN5cy5leGl0KHJldHVybl9jb2RlKQo=