91364 2012-07-16 00:26:09 -0700 It is invalid when both numberOfInputChannels and numberOfOutputChannels to be zero in JavaScriptAudioNode. 2012-07-25 14:34:20 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 li.yin li.yin crogers eric.carlson feature-media-reviews haraken kbr rtoy webkit.review.bot oldest_to_newest 670155 0 li.yin 2012-07-16 00:26:09 -0700 From Spec: http://www.w3.org/TR/webaudio/#JavaScriptAudioNode-section numberOfInputChannels and numberOfOutputChannels determine the number of input and output channels. It is invalid for both numberOfInputChannels and numberOfOutputChannels to be zero. 670182 1 152496 li.yin 2012-07-16 01:12:10 -0700 Created attachment 152496 Patch 672101 2 haraken 2012-07-18 01:08:14 -0700 Looks reasonable. (I am not an AudioContext guy though.) 672118 3 li.yin 2012-07-18 01:23:37 -0700 (In reply to comment #2) > Looks reasonable. (I am not an AudioContext guy though.) Thanks for your review. 673690 4 152496 rtoy 2012-07-19 11:04:51 -0700 Comment on attachment 152496 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152496&action=review Just a few minor comments on the pass/fail messages. Otherwise it looks good. Should we test the case where inputs = 0 and outputs = 2 and inputs = 2 and outputs = 0? > LayoutTests/webaudio/javascriptaudionode.html:92 > + testFailed("Exception should be thrown for both of numberOfInputChannels and numberOfOutputChannels to be zero."); Slight grammatical fix: "Exception should be thrown when both numberOfInputChannels and numberOfOutputChannels are zero." > LayoutTests/webaudio/javascriptaudionode.html:94 > + testPassed("Exception was thrown for both of numberOfInputChannels and numberOfOutputChannels to be zero."); "Exception was thrown when both numberOfInputChannels and numberOfOutputChannels are zero." > LayoutTests/webaudio/javascriptaudionode.html:101 > + testFailed("Exception should not be thrown."); Be more explicit on failure to match the pass case? Something like "Exception should not be thrown when numberOfInputChannels = 1 and numberOfOutputChannels = 0." > LayoutTests/webaudio/javascriptaudionode.html:108 > + testFailed("Exception should not be thrown."); Be more explicit on failure to match the pass case? Something like "Exception should not be thrown when numberOfInputChannels = 0 and numberOfOutputChannels = 1." 675126 5 153633 li.yin 2012-07-20 18:09:58 -0700 Created attachment 153633 Patch 675127 6 li.yin 2012-07-20 18:12:23 -0700 (In reply to comment #4) > (From update of attachment 152496 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152496&action=review > > Just a few minor comments on the pass/fail messages. Otherwise it looks good. Should we test the case where inputs = 0 and outputs = 2 and inputs = 2 and outputs = 0? > > > LayoutTests/webaudio/javascriptaudionode.html:92 > > + testFailed("Exception should be thrown for both of numberOfInputChannels and numberOfOutputChannels to be zero."); > > Slight grammatical fix: > > "Exception should be thrown when both numberOfInputChannels and numberOfOutputChannels are zero." > > > LayoutTests/webaudio/javascriptaudionode.html:94 > > + testPassed("Exception was thrown for both of numberOfInputChannels and numberOfOutputChannels to be zero."); > > "Exception was thrown when both numberOfInputChannels and numberOfOutputChannels are zero." > > > LayoutTests/webaudio/javascriptaudionode.html:101 > > + testFailed("Exception should not be thrown."); > > Be more explicit on failure to match the pass case? Something like > > "Exception should not be thrown when numberOfInputChannels = 1 and numberOfOutputChannels = 0." > > > LayoutTests/webaudio/javascriptaudionode.html:108 > > + testFailed("Exception should not be thrown."); > > Be more explicit on failure to match the pass case? Something like > > "Exception should not be thrown when numberOfInputChannels = 0 and numberOfOutputChannels = 1." Done. Thanks for your comments. 677320 7 kbr 2012-07-24 16:25:23 -0700 Raymond, is this patch ready to go in your opinion? 677345 8 rtoy 2012-07-24 16:41:04 -0700 (In reply to comment #7) > Raymond, is this patch ready to go in your opinion? Yes, pretty much. BUT, there has been some recent (side) discussion on the W3C audio list about whether JavaScriptNode's should allow 0 inputs. I can't seem to find the relevant messages right now, so perhaps we should hold off on this. 677353 9 153633 kbr 2012-07-24 16:50:45 -0700 Comment on attachment 153633 Patch OK. I'm clearing the review bit in this case. Please request review again once this is determined. 677479 10 li.yin 2012-07-24 18:29:30 -0700 (In reply to comment #8) > (In reply to comment #7) > > Raymond, is this patch ready to go in your opinion? > > Yes, pretty much. > > BUT, there has been some recent (side) discussion on the W3C audio list about whether JavaScriptNode's should allow 0 inputs. I can't seem to find the relevant messages right now, so perhaps we should hold off on this. Hi Raymond, could you please add some detailed information about this discussion? I can't find it in recent mail list. Thanks. 678118 11 rtoy 2012-07-25 08:54:39 -0700 (In reply to comment #10) > (In reply to comment #8) > > (In reply to comment #7) > > > Raymond, is this patch ready to go in your opinion? > > > > Yes, pretty much. > > > > BUT, there has been some recent (side) discussion on the W3C audio list about whether JavaScriptNode's should allow 0 inputs. I can't seem to find the relevant messages right now, so perhaps we should hold off on this. > > Hi Raymond, could you please add some detailed information about this discussion? I can't find it in recent mail list. > Thanks. I can't find the discussion either. But the spec clearly allows 0 inputs, and your patch allows that and clearly disallows the case when the number of inputs and outputs are both 0. This looks fine to me. Sorry for the trouble. 678450 12 153633 kbr 2012-07-25 14:10:39 -0700 Comment on attachment 153633 Patch Thanks Raymond. r=me 678481 13 153633 webkit.review.bot 2012-07-25 14:34:15 -0700 Comment on attachment 153633 Patch Clearing flags on attachment: 153633 Committed r123662: <http://trac.webkit.org/changeset/123662> 678482 14 webkit.review.bot 2012-07-25 14:34:20 -0700 All reviewed patches have been landed. Closing bug. 152496 2012-07-16 01:12:10 -0700 2012-07-20 18:09:52 -0700 Patch bug-91364-20120717161634.patch text/plain 5474 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVmMjk2ZDA0MWI1MGU2 OTRjN2Q4ZjU4YTdkMDE5ZWMzM2NlZTc4Yy4uNDc5Njk2OTdhY2YxNTkzMjMxMDkxZjM4ZWI5YWEy MDA1YzBkNWUyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTE3ICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIEl0IGlzIGludmFsaWQgd2hlbiBib3Ro IG51bWJlck9mSW5wdXRDaGFubmVscyBhbmQgbnVtYmVyT2ZPdXRwdXRDaGFubmVscyB0byBiZSB6 ZXJvIGluIEphdmFTY3JpcHRBdWRpb05vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MTM2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNwZWM6IGh0dHA6Ly93d3cudzMub3JnL1RSL3dlYmF1ZGlvLyNK YXZhU2NyaXB0QXVkaW9Ob2RlLXNlY3Rpb24KKyAgICAgICAgSXQgaXMgaW52YWxpZCBmb3IgYm90 aCBudW1iZXJPZklucHV0Q2hhbm5lbHMgYW5kIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgdG8gYmUg emVyby4KKworICAgICAgICBUZXN0OiB3ZWJhdWRpby9qYXZhc2NyaXB0YXVkaW9ub2RlLmh0bWwK KworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpKYXZhU2NyaXB0QXVkaW9Ob2RlOjpjcmVhdGUpOgorCiAyMDEyLTA3 LTEwICBQcmF2aW4gRCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KIAogICAgICAgICBSZS1mYWN0 b3JpbmcgcmVjYWxjQ29sdW1uIGluIEF1dG9UYWJsZUxheW91dC5jcHAgZm9yIHJlYWRhYmlsaXR5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0phdmFTY3JpcHRB dWRpb05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9KYXZhU2NyaXB0 QXVkaW9Ob2RlLmNwcAppbmRleCBhNmViNjAxNDY5MmU3ZmQ4YzRkZGE2NDdhMjhkNDNmYzM1NmU2 YTllLi5iZTYwYWY4ODdkNjFjMzJlODFmNTJiZTFjOGYyN2Y3NTQ3ZGY5YTE5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9k ZS5jcHAKQEAgLTU4LDEwICs1OCwxMyBAQCBQYXNzUmVmUHRyPEphdmFTY3JpcHRBdWRpb05vZGU+ IEphdmFTY3JpcHRBdWRpb05vZGU6OmNyZWF0ZShBdWRpb0NvbnRleHQqIGNvbnRleAogICAgICAg ICByZXR1cm4gMDsKICAgICB9CiAKKyAgICBpZiAoIW51bWJlck9mSW5wdXRDaGFubmVscyAmJiAh bnVtYmVyT2ZPdXRwdXRDaGFubmVscykKKyAgICAgICAgcmV0dXJuIDA7CisKICAgICBpZiAobnVt YmVyT2ZJbnB1dENoYW5uZWxzID4gQXVkaW9Db250ZXh0OjptYXhOdW1iZXJPZkNoYW5uZWxzKCkp CiAgICAgICAgIHJldHVybiAwOwogCi0gICAgaWYgKCFudW1iZXJPZk91dHB1dENoYW5uZWxzIHx8 IG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgPiBBdWRpb0NvbnRleHQ6Om1heE51bWJlck9mQ2hhbm5l bHMoKSkKKyAgICBpZiAobnVtYmVyT2ZPdXRwdXRDaGFubmVscyA+IEF1ZGlvQ29udGV4dDo6bWF4 TnVtYmVyT2ZDaGFubmVscygpKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIHJldHVybiBhZG9w dFJlZihuZXcgSmF2YVNjcmlwdEF1ZGlvTm9kZShjb250ZXh0LCBzYW1wbGVSYXRlLCBidWZmZXJT aXplLCBudW1iZXJPZklucHV0Q2hhbm5lbHMsIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMpKTsKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCBiMjNjY2Q5MGE1MDNiZmI2NjI3MDdjNzFkODkxYjViNzAxYzk1NzlmLi44YzBhOWZlNmNk MzZkM2U4N2VjMWJhMzg4YjgxNDI1YjE5OGI0MmM3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTItMDctMTcgIExpIFlpbiAgPGxpLnlpbkBpbnRlbC5jb20+CisKKyAgICAgICAgSXQgaXMgaW52 YWxpZCB3aGVuIGJvdGggbnVtYmVyT2ZJbnB1dENoYW5uZWxzIGFuZCBudW1iZXJPZk91dHB1dENo YW5uZWxzIHRvIGJlIHplcm8gaW4gSmF2YVNjcmlwdEF1ZGlvTm9kZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMzY0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3RzIGZvciAobnVtYmVyT2ZJ bnB1dENoYW5uZWxzLCBudW1iZXJPZk91dHB1dENoYW5uZWxzKSB0byBiZSAoMCwgMCksICgwLCAx KSBhbmQgKDEsIDApLgorCisgICAgICAgICogd2ViYXVkaW8vamF2YXNjcmlwdGF1ZGlvbm9kZS1l eHBlY3RlZC50eHQ6CisgICAgICAgICogd2ViYXVkaW8vamF2YXNjcmlwdGF1ZGlvbm9kZS5odG1s OgorCiAyMDEyLTA3LTEwICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBMaW5lIGRpcmVjdGl2ZSB0ZXN0IGluIGZhc3QvY2FudmFzL3dlYmdsL2dsc2wtY29uZm9y bWFuY2UuaHRtbCBpcyBpbmNvcnJlY3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3dlYmF1ZGlv L2phdmFzY3JpcHRhdWRpb25vZGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8v amF2YXNjcmlwdGF1ZGlvbm9kZS1leHBlY3RlZC50eHQKaW5kZXggODFlMWEwNTFiOGI2NmQ4Y2Zh Y2M2MTg3MWQ0YzAxMTJiZmI3NDE4Ni4uMTYwYTA1MTQwMmMwNGM1YWUyOTFlOWMwYWIzYWNkMDU0 NDBhMDNjMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvd2ViYXVkaW8vamF2YXNjcmlwdGF1ZGlv bm9kZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vamF2YXNjcmlwdGF1 ZGlvbm9kZS1leHBlY3RlZC50eHQKQEAgLTIsNyArMiw5IEBAIFRlc3RzIEphdmFTY3JpcHRBdWRp b05vZGUuCiAKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAotUEFTUyBFeGNlcHRpb24gd2Fz IHRocm93biBmb3IgaWxsZWdhbCBudW1iZXJPZk91dHB1dENoYW5uZWxzLgorUEFTUyBFeGNlcHRp b24gd2FzIHRocm93biBmb3IgYm90aCBvZiBudW1iZXJPZklucHV0Q2hhbm5lbHMgYW5kIG51bWJl ck9mT3V0cHV0Q2hhbm5lbHMgdG8gYmUgemVyby4KK1BBU1MgU3VjY2Vzc2Z1bGx5IGNyZWF0ZWQg SmF2YVNjcmlwdEF1ZGlvTm9kZSB3aXRoIG51bWJlck9mSW5wdXRDaGFubmVscyA9IDEgYW5kIG51 bWJlck9mT3V0cHV0Q2hhbm5lbHMgPSAwLgorUEFTUyBTdWNjZXNzZnVsbHkgY3JlYXRlZCBKYXZh U2NyaXB0QXVkaW9Ob2RlIHdpdGggbnVtYmVyT2ZJbnB1dENoYW5uZWxzID0gMCBhbmQgbnVtYmVy T2ZPdXRwdXRDaGFubmVscyA9IDEuCiBQQVNTIEV4Y2VwdGlvbiB3YXMgdGhyb3duIGZvciBpbGxl Z2FsIGJ1ZmZlclNpemUuCiBQQVNTIFN1Y2Nlc3NmdWxseSBjcmVhdGVkIEphdmFTY3JpcHRBdWRp b05vZGUgd2l0aCBidWZmZXJTaXplID0gMjU2LgogUEFTUyBTdWNjZXNzZnVsbHkgY3JlYXRlZCBK YXZhU2NyaXB0QXVkaW9Ob2RlIHdpdGggYnVmZmVyU2l6ZSA9IDUxMi4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3dlYmF1ZGlvL2phdmFzY3JpcHRhdWRpb25vZGUuaHRtbCBiL0xheW91dFRlc3Rz L3dlYmF1ZGlvL2phdmFzY3JpcHRhdWRpb25vZGUuaHRtbAppbmRleCA0NWU2MWFhZGVlYTE4ZTk2 NjBjZWFiNTU0OWQ5OGI1ZjZiMmRiYTI0Li42MDY5NWY0MDQ5Y2YwMmNiNjU2ZTkxMmJiMzdlODY0 ODc2MGEzYmQ3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9qYXZhc2NyaXB0YXVk aW9ub2RlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vamF2YXNjcmlwdGF1ZGlvbm9k ZS5odG1sCkBAIC04OCwxMiArODgsMjYgQEAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICBjb250 ZXh0ID0gbmV3IHdlYmtpdEF1ZGlvQ29udGV4dCgyLCByZW5kZXJMZW5ndGhJbkZyYW1lcywgc2Ft cGxlUmF0ZSk7CiAKICAgICB0cnkgeworICAgICAgICB2YXIganNub2RlID0gY29udGV4dC5jcmVh dGVKYXZhU2NyaXB0Tm9kZSg1MTIsIDAsIDApOworICAgICAgICB0ZXN0RmFpbGVkKCJFeGNlcHRp b24gc2hvdWxkIGJlIHRocm93biBmb3IgYm90aCBvZiBudW1iZXJPZklucHV0Q2hhbm5lbHMgYW5k IG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgdG8gYmUgemVyby4iKTsKKyAgICB9IGNhdGNoKGUpIHsK KyAgICAgICAgdGVzdFBhc3NlZCgiRXhjZXB0aW9uIHdhcyB0aHJvd24gZm9yIGJvdGggb2YgbnVt YmVyT2ZJbnB1dENoYW5uZWxzIGFuZCBudW1iZXJPZk91dHB1dENoYW5uZWxzIHRvIGJlIHplcm8u Iik7CisgICAgfQorICAgIAorICAgIHRyeSB7CiAgICAgICAgIHZhciBqc25vZGUgPSBjb250ZXh0 LmNyZWF0ZUphdmFTY3JpcHROb2RlKDUxMiwgMSwgMCk7Ci0gICAgICAgIHRlc3RGYWlsZWQoIkV4 Y2VwdGlvbiBzaG91bGQgYmUgdGhyb3duIGZvciBpbGxlZ2FsIG51bWJlck9mT3V0cHV0Q2hhbm5l bHMuIik7CisgICAgICAgIHRlc3RQYXNzZWQoIlN1Y2Nlc3NmdWxseSBjcmVhdGVkIEphdmFTY3Jp cHRBdWRpb05vZGUgd2l0aCBudW1iZXJPZklucHV0Q2hhbm5lbHMgPSAxIGFuZCBudW1iZXJPZk91 dHB1dENoYW5uZWxzID0gMC4iKTsKICAgICB9IGNhdGNoKGUpIHsKLSAgICAgICAgdGVzdFBhc3Nl ZCgiRXhjZXB0aW9uIHdhcyB0aHJvd24gZm9yIGlsbGVnYWwgbnVtYmVyT2ZPdXRwdXRDaGFubmVs cy4iKTsKKyAgICAgICAgdGVzdEZhaWxlZCgiRXhjZXB0aW9uIHNob3VsZCBub3QgYmUgdGhyb3du LiIpOwogICAgIH0KLQorICAgIAorICAgIHRyeSB7CisgICAgICAgIHZhciBqc25vZGUgPSBjb250 ZXh0LmNyZWF0ZUphdmFTY3JpcHROb2RlKDUxMiwgMCwgMSk7CisgICAgICAgIHRlc3RQYXNzZWQo IlN1Y2Nlc3NmdWxseSBjcmVhdGVkIEphdmFTY3JpcHRBdWRpb05vZGUgd2l0aCBudW1iZXJPZklu cHV0Q2hhbm5lbHMgPSAwIGFuZCBudW1iZXJPZk91dHB1dENoYW5uZWxzID0gMS4iKTsKKyAgICB9 IGNhdGNoKGUpIHsKKyAgICAgICAgdGVzdEZhaWxlZCgiRXhjZXB0aW9uIHNob3VsZCBub3QgYmUg dGhyb3duLiIpOworICAgIH0KKyAgICAKICAgICB0cnkgewogICAgICAgICB2YXIganNub2RlID0g Y29udGV4dC5jcmVhdGVKYXZhU2NyaXB0Tm9kZSg1MTEsIDEsIDEpOwogICAgICAgICB0ZXN0RmFp bGVkKCJFeGNlcHRpb24gc2hvdWxkIGJlIHRocm93biBmb3IgaWxsZWdhbCBidWZmZXJTaXplLiIp Owo= 153633 2012-07-20 18:09:58 -0700 2012-07-25 14:34:14 -0700 Patch bug-91364-20120722091426.patch text/plain 6634 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjVmMjk2ZDA0MWI1MGU2 OTRjN2Q4ZjU4YTdkMDE5ZWMzM2NlZTc4Yy4uNDc5Njk2OTdhY2YxNTkzMjMxMDkxZjM4ZWI5YWEy MDA1YzBkNWUyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA3LTE3ICBMaSBZ aW4gIDxsaS55aW5AaW50ZWwuY29tPgorCisgICAgICAgIEl0IGlzIGludmFsaWQgd2hlbiBib3Ro IG51bWJlck9mSW5wdXRDaGFubmVscyBhbmQgbnVtYmVyT2ZPdXRwdXRDaGFubmVscyB0byBiZSB6 ZXJvIGluIEphdmFTY3JpcHRBdWRpb05vZGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05MTM2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNwZWM6IGh0dHA6Ly93d3cudzMub3JnL1RSL3dlYmF1ZGlvLyNK YXZhU2NyaXB0QXVkaW9Ob2RlLXNlY3Rpb24KKyAgICAgICAgSXQgaXMgaW52YWxpZCBmb3IgYm90 aCBudW1iZXJPZklucHV0Q2hhbm5lbHMgYW5kIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgdG8gYmUg emVyby4KKworICAgICAgICBUZXN0OiB3ZWJhdWRpby9qYXZhc2NyaXB0YXVkaW9ub2RlLmh0bWwK KworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9kZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpKYXZhU2NyaXB0QXVkaW9Ob2RlOjpjcmVhdGUpOgorCiAyMDEyLTA3 LTEwICBQcmF2aW4gRCAgPHByYXZpbmQuMms0QGdtYWlsLmNvbT4KIAogICAgICAgICBSZS1mYWN0 b3JpbmcgcmVjYWxjQ29sdW1uIGluIEF1dG9UYWJsZUxheW91dC5jcHAgZm9yIHJlYWRhYmlsaXR5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0phdmFTY3JpcHRB dWRpb05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9KYXZhU2NyaXB0 QXVkaW9Ob2RlLmNwcAppbmRleCBhNmViNjAxNDY5MmU3ZmQ4YzRkZGE2NDdhMjhkNDNmYzM1NmU2 YTllLi5iZTYwYWY4ODdkNjFjMzJlODFmNTJiZTFjOGYyN2Y3NTQ3ZGY5YTE5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0phdmFTY3JpcHRBdWRpb05vZGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vSmF2YVNjcmlwdEF1ZGlvTm9k ZS5jcHAKQEAgLTU4LDEwICs1OCwxMyBAQCBQYXNzUmVmUHRyPEphdmFTY3JpcHRBdWRpb05vZGU+ IEphdmFTY3JpcHRBdWRpb05vZGU6OmNyZWF0ZShBdWRpb0NvbnRleHQqIGNvbnRleAogICAgICAg ICByZXR1cm4gMDsKICAgICB9CiAKKyAgICBpZiAoIW51bWJlck9mSW5wdXRDaGFubmVscyAmJiAh bnVtYmVyT2ZPdXRwdXRDaGFubmVscykKKyAgICAgICAgcmV0dXJuIDA7CisKICAgICBpZiAobnVt YmVyT2ZJbnB1dENoYW5uZWxzID4gQXVkaW9Db250ZXh0OjptYXhOdW1iZXJPZkNoYW5uZWxzKCkp CiAgICAgICAgIHJldHVybiAwOwogCi0gICAgaWYgKCFudW1iZXJPZk91dHB1dENoYW5uZWxzIHx8 IG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgPiBBdWRpb0NvbnRleHQ6Om1heE51bWJlck9mQ2hhbm5l bHMoKSkKKyAgICBpZiAobnVtYmVyT2ZPdXRwdXRDaGFubmVscyA+IEF1ZGlvQ29udGV4dDo6bWF4 TnVtYmVyT2ZDaGFubmVscygpKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIHJldHVybiBhZG9w dFJlZihuZXcgSmF2YVNjcmlwdEF1ZGlvTm9kZShjb250ZXh0LCBzYW1wbGVSYXRlLCBidWZmZXJT aXplLCBudW1iZXJPZklucHV0Q2hhbm5lbHMsIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMpKTsKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCBiMjNjY2Q5MGE1MDNiZmI2NjI3MDdjNzFkODkxYjViNzAxYzk1NzlmLi4xNzUxNGEyM2Q5 NzM0MjVhNzA3ODQwMGMzMTkxOWY5MDk3MzNlZGY2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MTItMDctMTcgIExpIFlpbiAgPGxpLnlpbkBpbnRlbC5jb20+CisKKyAgICAgICAgSXQgaXMgaW52 YWxpZCB3aGVuIGJvdGggbnVtYmVyT2ZJbnB1dENoYW5uZWxzIGFuZCBudW1iZXJPZk91dHB1dENo YW5uZWxzIHRvIGJlIHplcm8gaW4gSmF2YVNjcmlwdEF1ZGlvTm9kZS4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMzY0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRlc3RzIGZvciAobnVtYmVyT2ZJ bnB1dENoYW5uZWxzLCBudW1iZXJPZk91dHB1dENoYW5uZWxzKSB0byBiZSAoMCwgMCksKDAsIDEp LCgwLCAyKSwoMSwgMCkgYW5kICgyLCAwKS4KKworICAgICAgICAqIHdlYmF1ZGlvL2phdmFzY3Jp cHRhdWRpb25vZGUtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdlYmF1ZGlvL2phdmFzY3JpcHRh dWRpb25vZGUuaHRtbDoKKwogMjAxMi0wNy0xMCAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2ds ZS5jb20+CiAKICAgICAgICAgTGluZSBkaXJlY3RpdmUgdGVzdCBpbiBmYXN0L2NhbnZhcy93ZWJn bC9nbHNsLWNvbmZvcm1hbmNlLmh0bWwgaXMgaW5jb3JyZWN0CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy93ZWJhdWRpby9qYXZhc2NyaXB0YXVkaW9ub2RlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRl c3RzL3dlYmF1ZGlvL2phdmFzY3JpcHRhdWRpb25vZGUtZXhwZWN0ZWQudHh0CmluZGV4IDgxZTFh MDUxYjhiNjZkOGNmYWNjNjE4NzFkNGMwMTEyYmZiNzQxODYuLmQzMGE0ZDZiZWU5MzFjYjhiZTUx MzEzYjE5YjNlNDBlZWY2MmIyZmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2ph dmFzY3JpcHRhdWRpb25vZGUtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3dlYmF1ZGlv L2phdmFzY3JpcHRhdWRpb25vZGUtZXhwZWN0ZWQudHh0CkBAIC0yLDcgKzIsMTEgQEAgVGVzdHMg SmF2YVNjcmlwdEF1ZGlvTm9kZS4KIAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgogCi1QQVNT IEV4Y2VwdGlvbiB3YXMgdGhyb3duIGZvciBpbGxlZ2FsIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMu CitQQVNTIEV4Y2VwdGlvbiB3YXMgdGhyb3duIHdoZW4gYm90aCBudW1iZXJPZklucHV0Q2hhbm5l bHMgYW5kIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgYXJlIHplcm8uCitQQVNTIFN1Y2Nlc3NmdWxs eSBjcmVhdGVkIEphdmFTY3JpcHRBdWRpb05vZGUgd2l0aCBudW1iZXJPZklucHV0Q2hhbm5lbHMg PSAxIGFuZCBudW1iZXJPZk91dHB1dENoYW5uZWxzID0gMC4KK1BBU1MgU3VjY2Vzc2Z1bGx5IGNy ZWF0ZWQgSmF2YVNjcmlwdEF1ZGlvTm9kZSB3aXRoIG51bWJlck9mSW5wdXRDaGFubmVscyA9IDIg YW5kIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgPSAwLgorUEFTUyBTdWNjZXNzZnVsbHkgY3JlYXRl ZCBKYXZhU2NyaXB0QXVkaW9Ob2RlIHdpdGggbnVtYmVyT2ZJbnB1dENoYW5uZWxzID0gMCBhbmQg bnVtYmVyT2ZPdXRwdXRDaGFubmVscyA9IDEuCitQQVNTIFN1Y2Nlc3NmdWxseSBjcmVhdGVkIEph dmFTY3JpcHRBdWRpb05vZGUgd2l0aCBudW1iZXJPZklucHV0Q2hhbm5lbHMgPSAwIGFuZCBudW1i ZXJPZk91dHB1dENoYW5uZWxzID0gMi4KIFBBU1MgRXhjZXB0aW9uIHdhcyB0aHJvd24gZm9yIGls bGVnYWwgYnVmZmVyU2l6ZS4KIFBBU1MgU3VjY2Vzc2Z1bGx5IGNyZWF0ZWQgSmF2YVNjcmlwdEF1 ZGlvTm9kZSB3aXRoIGJ1ZmZlclNpemUgPSAyNTYuCiBQQVNTIFN1Y2Nlc3NmdWxseSBjcmVhdGVk IEphdmFTY3JpcHRBdWRpb05vZGUgd2l0aCBidWZmZXJTaXplID0gNTEyLgpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvd2ViYXVkaW8vamF2YXNjcmlwdGF1ZGlvbm9kZS5odG1sIGIvTGF5b3V0VGVz dHMvd2ViYXVkaW8vamF2YXNjcmlwdGF1ZGlvbm9kZS5odG1sCmluZGV4IDQ1ZTYxYWFkZWVhMThl OTY2MGNlYWI1NTQ5ZDk4YjVmNmIyZGJhMjQuLjhlMjczNTBiYTA2NjYyZGM1YzMyYTZkMjZmYzAy MzAyZTFhMGVhYjEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlvL2phdmFzY3JpcHRh dWRpb25vZGUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy93ZWJhdWRpby9qYXZhc2NyaXB0YXVkaW9u b2RlLmh0bWwKQEAgLTEsNSArMSw0IEBACiA8IURPQ1RZUEUgaHRtbD4KLQogPGh0bWw+CiA8aGVh ZD4KIDxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9z Y3JpcHQ+CkBAIC04OCwxMiArODcsNDAgQEAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKICAgICBjb250 ZXh0ID0gbmV3IHdlYmtpdEF1ZGlvQ29udGV4dCgyLCByZW5kZXJMZW5ndGhJbkZyYW1lcywgc2Ft cGxlUmF0ZSk7CiAKICAgICB0cnkgeworICAgICAgICB2YXIganNub2RlID0gY29udGV4dC5jcmVh dGVKYXZhU2NyaXB0Tm9kZSg1MTIsIDAsIDApOworICAgICAgICB0ZXN0RmFpbGVkKCJFeGNlcHRp b24gc2hvdWxkIGJlIHRocm93biB3aGVuIGJvdGggbnVtYmVyT2ZJbnB1dENoYW5uZWxzIGFuZCBu dW1iZXJPZk91dHB1dENoYW5uZWxzIGFyZSB6ZXJvLiIpOworICAgIH0gY2F0Y2goZSkgeworICAg ICAgICB0ZXN0UGFzc2VkKCJFeGNlcHRpb24gd2FzIHRocm93biB3aGVuIGJvdGggbnVtYmVyT2ZJ bnB1dENoYW5uZWxzIGFuZCBudW1iZXJPZk91dHB1dENoYW5uZWxzIGFyZSB6ZXJvLiIpOworICAg IH0KKyAgICAKKyAgICB0cnkgewogICAgICAgICB2YXIganNub2RlID0gY29udGV4dC5jcmVhdGVK YXZhU2NyaXB0Tm9kZSg1MTIsIDEsIDApOwotICAgICAgICB0ZXN0RmFpbGVkKCJFeGNlcHRpb24g c2hvdWxkIGJlIHRocm93biBmb3IgaWxsZWdhbCBudW1iZXJPZk91dHB1dENoYW5uZWxzLiIpOwor ICAgICAgICB0ZXN0UGFzc2VkKCJTdWNjZXNzZnVsbHkgY3JlYXRlZCBKYXZhU2NyaXB0QXVkaW9O b2RlIHdpdGggbnVtYmVyT2ZJbnB1dENoYW5uZWxzID0gMSBhbmQgbnVtYmVyT2ZPdXRwdXRDaGFu bmVscyA9IDAuIik7CiAgICAgfSBjYXRjaChlKSB7Ci0gICAgICAgIHRlc3RQYXNzZWQoIkV4Y2Vw dGlvbiB3YXMgdGhyb3duIGZvciBpbGxlZ2FsIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMuIik7Cisg ICAgICAgIHRlc3RGYWlsZWQoIkV4Y2VwdGlvbiBzaG91bGQgbm90IGJlIHRocm93biB3aGVuIG51 bWJlck9mSW5wdXRDaGFubmVscyA9IDEgYW5kIG51bWJlck9mT3V0cHV0Q2hhbm5lbHMgPSAwLiIp OwogICAgIH0KLQorICAgIAorICAgIHRyeSB7CisgICAgICAgIHZhciBqc25vZGUgPSBjb250ZXh0 LmNyZWF0ZUphdmFTY3JpcHROb2RlKDUxMiwgMiwgMCk7CisgICAgICAgIHRlc3RQYXNzZWQoIlN1 Y2Nlc3NmdWxseSBjcmVhdGVkIEphdmFTY3JpcHRBdWRpb05vZGUgd2l0aCBudW1iZXJPZklucHV0 Q2hhbm5lbHMgPSAyIGFuZCBudW1iZXJPZk91dHB1dENoYW5uZWxzID0gMC4iKTsKKyAgICB9IGNh dGNoKGUpIHsKKyAgICAgICAgdGVzdEZhaWxlZCgiRXhjZXB0aW9uIHNob3VsZCBub3QgYmUgdGhy b3duIHdoZW4gbnVtYmVyT2ZJbnB1dENoYW5uZWxzID0gMiBhbmQgbnVtYmVyT2ZPdXRwdXRDaGFu bmVscyA9IDAuIik7CisgICAgfQorICAgIAorICAgIHRyeSB7CisgICAgICAgIHZhciBqc25vZGUg PSBjb250ZXh0LmNyZWF0ZUphdmFTY3JpcHROb2RlKDUxMiwgMCwgMSk7CisgICAgICAgIHRlc3RQ YXNzZWQoIlN1Y2Nlc3NmdWxseSBjcmVhdGVkIEphdmFTY3JpcHRBdWRpb05vZGUgd2l0aCBudW1i ZXJPZklucHV0Q2hhbm5lbHMgPSAwIGFuZCBudW1iZXJPZk91dHB1dENoYW5uZWxzID0gMS4iKTsK KyAgICB9IGNhdGNoKGUpIHsKKyAgICAgICAgdGVzdEZhaWxlZCgiRXhjZXB0aW9uIHNob3VsZCBu b3QgYmUgdGhyb3duIHdoZW4gbnVtYmVyT2ZJbnB1dENoYW5uZWxzID0gMCBhbmQgbnVtYmVyT2ZP dXRwdXRDaGFubmVscyA9IDEuIik7CisgICAgfQorICAgIAorICAgIHRyeSB7CisgICAgICAgIHZh ciBqc25vZGUgPSBjb250ZXh0LmNyZWF0ZUphdmFTY3JpcHROb2RlKDUxMiwgMCwgMik7CisgICAg ICAgIHRlc3RQYXNzZWQoIlN1Y2Nlc3NmdWxseSBjcmVhdGVkIEphdmFTY3JpcHRBdWRpb05vZGUg d2l0aCBudW1iZXJPZklucHV0Q2hhbm5lbHMgPSAwIGFuZCBudW1iZXJPZk91dHB1dENoYW5uZWxz ID0gMi4iKTsKKyAgICB9IGNhdGNoKGUpIHsKKyAgICAgICAgdGVzdEZhaWxlZCgiRXhjZXB0aW9u IHNob3VsZCBub3QgYmUgdGhyb3duIHdoZW4gbnVtYmVyT2ZJbnB1dENoYW5uZWxzID0gMCBhbmQg bnVtYmVyT2ZPdXRwdXRDaGFubmVscyA9IDIuIik7CisgICAgfQorICAgIAogICAgIHRyeSB7CiAg ICAgICAgIHZhciBqc25vZGUgPSBjb250ZXh0LmNyZWF0ZUphdmFTY3JpcHROb2RlKDUxMSwgMSwg MSk7CiAgICAgICAgIHRlc3RGYWlsZWQoIkV4Y2VwdGlvbiBzaG91bGQgYmUgdGhyb3duIGZvciBp bGxlZ2FsIGJ1ZmZlclNpemUuIik7Cg==