91363 2012-07-16 00:14:25 -0700 REGRESSION(r122681): Patch introduces crashes in debug builds for GTK and EFL ports (Requested by zdobersek on #webkit). 2012-07-16 08:11:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91348 1 webkit.review.bot webkit.review.bot andersca d-r mitz zan oldest_to_newest 670143 0 webkit.review.bot 2012-07-16 00:14:25 -0700 http://trac.webkit.org/changeset/122681 broke the build: Patch introduces crashes in debug builds for GTK and EFL ports (Requested by zdobersek on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 670145 1 152490 webkit.review.bot 2012-07-16 00:15:01 -0700 Created attachment 152490 ROLLOUT of r122681 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 670147 2 zan 2012-07-16 00:20:32 -0700 Here's the crash log from the EFL builder, GTK crashes in the same way. I'm happy to help out by testing any potential fixes. crash log for DumpRenderTree (pid 26046): STDOUT: <empty> STDERR: SHOULD NEVER BE REACHED STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/ScrollableArea.h(136) : virtual WebCore::IntPoint WebCore::ScrollableArea::scrollPosition() const STDERR: 1 0x7fa34467cd72 WebCore::ScrollableArea::scrollPosition() const STDERR: 2 0x7fa34467c272 WebCore::ScrollableArea::scrollPositionChanged(WebCore::IntPoint const&) STDERR: 3 0x7fa34467c533 WebCore::ScrollableArea::setScrollOffsetFromAnimation(WebCore::IntPoint const&) STDERR: 4 0x7fa34467bc4b WebCore::ScrollAnimator::notifyPositionChanged() STDERR: 5 0x7fa34467b5e3 WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&) STDERR: 6 0x7fa34467c12c WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&) STDERR: 7 0x7fa34467c1f2 WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::ScrollbarOrientation, float) STDERR: 8 0x7fa34487a2fa WebCore::RenderListBox::computeLogicalHeight() STDERR: 9 0x7fa34477d7ee WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 10 0x7fa34477cabe WebCore::RenderBlock::layout() STDERR: 11 0x7fa344879736 WebCore::RenderListBox::layout() STDERR: 12 0x7fa344751519 WebCore::RenderObject::layoutIfNeeded() STDERR: 13 0x7fa3447cff79 WebCore::RenderBlock::LineBreaker::nextLineBreak(WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::LineInfo&, std::pair<WebCore::RenderText*, WebCore::LazyLineBreakIterator>&, WebCore::RenderBlock::FloatingObject*, unsigned int) STDERR: 14 0x7fa3447ca421 WebCore::RenderBlock::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int) STDERR: 15 0x7fa3447ca09b WebCore::RenderBlock::layoutRunsAndFloats(WebCore::LineLayoutState&, bool) STDERR: 16 0x7fa3447cc234 WebCore::RenderBlock::layoutInlineChildren(bool, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 17 0x7fa34477d5ab WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 18 0x7fa34477cabe WebCore::RenderBlock::layout() STDERR: 19 0x7fa3447828ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 20 0x7fa3447823b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&) STDERR: 21 0x7fa34477d5cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 22 0x7fa34477cabe WebCore::RenderBlock::layout() STDERR: 23 0x7fa3447828ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 24 0x7fa3447823b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&) STDERR: 25 0x7fa34477d5cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 26 0x7fa34477cabe WebCore::RenderBlock::layout() STDERR: 27 0x7fa3447828ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 28 0x7fa3447823b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&) STDERR: 29 0x7fa34477d5cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 30 0x7fa34477cabe WebCore::RenderBlock::layout() STDERR: 31 0x7fa3448f6cc4 WebCore::RenderView::layout() 670152 3 152490 webkit.review.bot 2012-07-16 00:24:29 -0700 Comment on attachment 152490 ROLLOUT of r122681 Clearing flags on attachment: 152490 Committed r122701: <http://trac.webkit.org/changeset/122701> 670153 4 webkit.review.bot 2012-07-16 00:24:33 -0700 All reviewed patches have been landed. Closing bug. 670344 5 mitz 2012-07-16 08:01:28 -0700 (In reply to comment #2) > Here's the crash log from the EFL builder, GTK crashes in the same way. I'm happy to help out by testing any potential fixes. Did you try the one attached to bug 91359? 670347 6 mitz 2012-07-16 08:11:06 -0700 (In reply to comment #5) > (In reply to comment #2) > > Here's the crash log from the EFL builder, GTK crashes in the same way. I'm happy to help out by testing any potential fixes. > > Did you try the one attached to bug 91359? Never mind. Looking at the backtrace, it's obvious that that won't help. 152490 2012-07-16 00:15:01 -0700 2012-07-16 00:24:29 -0700 ROLLOUT of r122681 bug-91363-20120716072029.patch text/plain 1598 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzdkNTU0MzhhZWFiNmJl ODA5NzRmYWQ5YWFiZTg3NGEwYWEyNWQ2MS4uYmVjNDliY2YxZDUxNmE1OTI2YzJlOTcwNzkxMDUy NzU1ZmNiZTUwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTE2ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTIyNjgxLgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMjI2ODEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTkxMzYzCisKKyAgICAgICAgUGF0Y2ggaW50cm9kdWNlcyBjcmFzaGVzIGluIGRl YnVnIGJ1aWxkcyBmb3IgR1RLIGFuZCBFRkwgcG9ydHMKKyAgICAgICAgKFJlcXVlc3RlZCBieSB6 ZG9iZXJzZWsgb24gI3dlYmtpdCkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9TY3JvbGxhYmxlQXJl YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxhYmxlQXJlYTo6c2Nyb2xsUG9zaXRpb25D aGFuZ2VkKToKKwogMjAxMi0wNy0xNiAgTHVrZSBNYWNwaGVyc29uICA8bWFjcGhlcnNvbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgQ29tcGlsYXRpb24gZmFpbHVyZSBpbiBTdHlsZVJlc29sdmVy LmNwcCAoY2xhbmcpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxh YmxlQXJlYS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAK aW5kZXggY2QwZTBjNjE4NjI3YzRkYzhjZDM0MjI0Yzg4ZDUxMzI3ZjA2N2Y0Yy4uMzUwNmU1NTky N2E5ZDgwYjhkNDAwNGU4YmI4MjQyYWRmZDc0ZTU2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL1Njcm9sbGFibGVBcmVhLmNwcApAQCAtMTQyLDEzICsxNDIsOSBAQCB2b2lkIFNjcm9sbGFi bGVBcmVhOjpub3RpZnlTY3JvbGxQb3NpdGlvbkNoYW5nZWQoY29uc3QgSW50UG9pbnQmIHBvc2l0 aW9uKQogCiB2b2lkIFNjcm9sbGFibGVBcmVhOjpzY3JvbGxQb3NpdGlvbkNoYW5nZWQoY29uc3Qg SW50UG9pbnQmIHBvc2l0aW9uKQogewotICAgIEludFBvaW50IG9sZFBvc2l0aW9uID0gc2Nyb2xs UG9zaXRpb24oKTsKICAgICAvLyBUZWxsIHRoZSBkZXJpdmVkIGNsYXNzIHRvIHNjcm9sbCBpdHMg Y29udGVudHMuCiAgICAgc2V0U2Nyb2xsT2Zmc2V0KHBvc2l0aW9uKTsKIAotICAgIGlmIChzY3Jv bGxQb3NpdGlvbigpID09IG9sZFBvc2l0aW9uKQotICAgICAgICByZXR1cm47Ci0KICAgICBTY3Jv bGxiYXIqIHZlcnRpY2FsU2Nyb2xsYmFyID0gdGhpcy0+dmVydGljYWxTY3JvbGxiYXIoKTsKIAog ICAgIC8vIFRlbGwgdGhlIHNjcm9sbGJhcnMgdG8gdXBkYXRlIHRoZWlyIHRodW1iIHBvc3Rpb25z Lgo=