91359 2012-07-15 22:33:30 -0700 REGRESSION (r122681): css3/flexbox/flexbox-overflow-auto.html is failing 2012-07-16 09:32:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P1 Normal --- 1 cdumez webkit-unassigned andersca gyuyoung.kim lucas.de.marchi mitz oldest_to_newest 670084 0 cdumez 2012-07-15 22:33:30 -0700 After http://trac.webkit.org/r122681 the following ref test is failing: css3/flexbox/flexbox-overflow-auto.html The reason for the failure is that a few scrollbars are no longer in their expected position: http://build.webkit.org/results/EFL%20Linux%2064-bit%20Release/r122681%20(2660)/css3/flexbox/flexbox-overflow-auto-diffs.html 670088 1 mitz 2012-07-15 22:36:24 -0700 The issue reproduces on OS X as well when overlay scroll bars are disabled. 670092 2 cdumez 2012-07-15 22:41:09 -0700 Skipping the test for EFL port in Bug 91360. Please unskip with proper fix, thanks. 670093 3 152479 mitz 2012-07-15 22:46:43 -0700 Created attachment 152479 Only skip notifyContentAreaScrolled() if the scroll position doesn’t change 670131 4 cdumez 2012-07-16 00:00:28 -0700 On the EFL debug bot, a lot of tests started crashing after r122681: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2819 I haven't tested if the proposed patch fixes the crash in debug mode as well. backtrace: crash log for DumpRenderTree (pid 25888): STDOUT: <empty> STDERR: SHOULD NEVER BE REACHED STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/ScrollableArea.h(136) : virtual WebCore::IntPoint WebCore::ScrollableArea::scrollPosition() const STDERR: 1 0x7fa26f7e8d72 WebCore::ScrollableArea::scrollPosition() const STDERR: 2 0x7fa26f7e8272 WebCore::ScrollableArea::scrollPositionChanged(WebCore::IntPoint const&) STDERR: 3 0x7fa26f7e8533 WebCore::ScrollableArea::setScrollOffsetFromAnimation(WebCore::IntPoint const&) STDERR: 4 0x7fa26f7e7c4b WebCore::ScrollAnimator::notifyPositionChanged() STDERR: 5 0x7fa26f7e75e3 WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&) STDERR: 6 0x7fa26f7e812c WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::FloatPoint const&) STDERR: 7 0x7fa26f7e81f2 WebCore::ScrollableArea::scrollToOffsetWithoutAnimation(WebCore::ScrollbarOrientation, float) STDERR: 8 0x7fa26f9e62fa WebCore::RenderListBox::computeLogicalHeight() STDERR: 9 0x7fa26f8e97ee WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 10 0x7fa26f8e8abe WebCore::RenderBlock::layout() STDERR: 11 0x7fa26f9e5736 WebCore::RenderListBox::layout() STDERR: 12 0x7fa26f8bd519 WebCore::RenderObject::layoutIfNeeded() STDERR: 13 0x7fa26f93bf79 WebCore::RenderBlock::LineBreaker::nextLineBreak(WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::LineInfo&, std::pair<WebCore::RenderText*, WebCore::LazyLineBreakIterator>&, WebCore::RenderBlock::FloatingObject*, unsigned int) STDERR: 14 0x7fa26f936421 WebCore::RenderBlock::layoutRunsAndFloatsInRange(WebCore::LineLayoutState&, WebCore::BidiResolver<WebCore::InlineIterator, WebCore::BidiRun>&, WebCore::InlineIterator const&, WebCore::BidiStatus const&, unsigned int) STDERR: 15 0x7fa26f93609b WebCore::RenderBlock::layoutRunsAndFloats(WebCore::LineLayoutState&, bool) STDERR: 16 0x7fa26f938234 WebCore::RenderBlock::layoutInlineChildren(bool, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 17 0x7fa26f8e95ab WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 18 0x7fa26f8e8abe WebCore::RenderBlock::layout() STDERR: 19 0x7fa26f8ee8ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 20 0x7fa26f8ee3b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&) STDERR: 21 0x7fa26f8e95cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 22 0x7fa26f8e8abe WebCore::RenderBlock::layout() STDERR: 23 0x7fa26f8ee8ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 24 0x7fa26f8ee3b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&) STDERR: 25 0x7fa26f8e95cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 26 0x7fa26f8e8abe WebCore::RenderBlock::layout() STDERR: 27 0x7fa26f8ee8ce WebCore::RenderBlock::layoutBlockChild(WebCore::RenderBox*, WebCore::RenderBlock::MarginInfo&, WebCore::FractionalLayoutUnit&, WebCore::FractionalLayoutUnit&) STDERR: 28 0x7fa26f8ee3b0 WebCore::RenderBlock::layoutBlockChildren(bool, WebCore::FractionalLayoutUnit&) STDERR: 29 0x7fa26f8e95cc WebCore::RenderBlock::layoutBlock(bool, WebCore::FractionalLayoutUnit) STDERR: 30 0x7fa26f8e8abe WebCore::RenderBlock::layout() STDERR: 31 0x7fa26fa62cc4 WebCore::RenderView::layout() 670401 5 mitz 2012-07-16 09:32:53 -0700 This has been fixed in <http://trac.webkit.org/r122701> by reverting r122681. 152479 2012-07-15 22:46:43 -0700 2012-07-16 09:22:53 -0700 Only skip notifyContentAreaScrolled() if the scroll position doesn’t change 91359_r1.diff text/plain 1758 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMjY5NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTE1ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEyMjY4MSk6 IGNzczMvZmxleGJveC9mbGV4Ym94LW92ZXJmbG93LWF1dG8uaHRtbCBpcyBmYWlsaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTM1OQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vU2Ny b2xsYWJsZUFyZWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYWJsZUFyZWE6OnNjcm9s bFBvc2l0aW9uQ2hhbmdlZCk6IE1vdmVkIHRoZSBjaGVja2luZyBmb3IgYSBzY3JvbGwgcG9zaXRp b24KKyAgICAgICAgY2hhbmdlIHRvIHRoZSBlbmQgb2YgdGhpcyBmdW5jdGlvbiwgc28gdGhhdCB0 aGUgc2Nyb2xsIGJhcnMgYXJlIHN0aWxsIGludmFsaWRhdGVkIGV2ZW4gaWYKKyAgICAgICAgdGhl IHBvc2l0aW9uIGRvZXMgbm90IGNoYW5nZS4KKwogMjAxMi0wNy0xNSAgTWlrZSBMYXd0aGVyICA8 bWlrZWxhd3RoZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEZpeCBjYWxjdWxhdGlvbiBvZiBy Z2JhJ3MgYWxwaGEgaW4gQ1NTIGN1c3RvbSB0ZXh0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vU2Nyb2xsYWJsZUFyZWEuY3BwCShyZXZpc2lvbiAxMjI2ODEpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9TY3JvbGxhYmxlQXJlYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE0Niw5 ICsxNDYsNiBAQCB2b2lkIFNjcm9sbGFibGVBcmVhOjpzY3JvbGxQb3NpdGlvbkNoYW5nCiAgICAg Ly8gVGVsbCB0aGUgZGVyaXZlZCBjbGFzcyB0byBzY3JvbGwgaXRzIGNvbnRlbnRzLgogICAgIHNl dFNjcm9sbE9mZnNldChwb3NpdGlvbik7CiAKLSAgICBpZiAoc2Nyb2xsUG9zaXRpb24oKSA9PSBv bGRQb3NpdGlvbikKLSAgICAgICAgcmV0dXJuOwotCiAgICAgU2Nyb2xsYmFyKiB2ZXJ0aWNhbFNj cm9sbGJhciA9IHRoaXMtPnZlcnRpY2FsU2Nyb2xsYmFyKCk7CiAKICAgICAvLyBUZWxsIHRoZSBz Y3JvbGxiYXJzIHRvIHVwZGF0ZSB0aGVpciB0aHVtYiBwb3N0aW9ucy4KQEAgLTE3Miw3ICsxNjks OCBAQCB2b2lkIFNjcm9sbGFibGVBcmVhOjpzY3JvbGxQb3NpdGlvbkNoYW5nCiAgICAgICAgICAg ICB2ZXJ0aWNhbFNjcm9sbGJhci0+aW52YWxpZGF0ZSgpOwogICAgIH0KIAotICAgIHNjcm9sbEFu aW1hdG9yKCktPm5vdGlmeUNvbnRlbnRBcmVhU2Nyb2xsZWQoKTsKKyAgICBpZiAoc2Nyb2xsUG9z aXRpb24oKSAhPSBvbGRQb3NpdGlvbikKKyAgICAgICAgc2Nyb2xsQW5pbWF0b3IoKS0+bm90aWZ5 Q29udGVudEFyZWFTY3JvbGxlZCgpOwogfQogCiBib29sIFNjcm9sbGFibGVBcmVhOjpoYW5kbGVX aGVlbEV2ZW50KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgd2hlZWxFdmVudCkK