91296 2012-07-13 15:59:26 -0700 LLInt fails to mark structures stored in the bytecode 2012-07-13 16:33:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 91298 1 oliver oliver webkit.review.bot oldest_to_newest 669529 0 oliver 2012-07-13 15:59:26 -0700 LLInt fails to mark structures stored in the bytecode 669535 1 152362 oliver 2012-07-13 16:03:23 -0700 Created attachment 152362 Patch 669540 2 152362 ggaren 2012-07-13 16:07:25 -0700 Comment on attachment 152362 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152362&action=review r=me > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2252 > + if (!m_globalData->interpreter->classicEnabled() && !!numberOfInstructions() && getJITType() < JITCode::bottomTierJIT()) { Can we merge this with the CLASSIC_INTERPRETER case? 669546 3 oliver 2012-07-13 16:12:22 -0700 Committed r122640: <http://trac.webkit.org/changeset/122640> 669560 4 webkit.review.bot 2012-07-13 16:25:28 -0700 Re-opened since this is blocked by 91298 669572 5 oliver 2012-07-13 16:33:20 -0700 Okay, my understanding of what the LLInt expects to do is clearly flawed. Back to trying to work out how it's failing to unlink the resolves correctly. 152362 2012-07-13 16:03:23 -0700 2012-07-13 16:07:25 -0700 Patch bug-91296-20120713160322.patch text/plain 4312 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 NDY1MDk5M2ZkZmMzYTlmYWNiN2ZiMGE1ODkyNDJkZjg2MjcyNTdjLi41ZWVjNWEzMTZkY2RkNGI3 ZGY2NjA4YjI2MWZmNmFkMzUzMGNlYzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxMi0wNy0xMyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIExMSW50IGZhaWxzIHRvIG1hcmsgc3RydWN0dXJlcyBzdG9yZWQgaW4gdGhlIGJ5 dGVjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MTI5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExM SW50IHN0b3JlcyBzdHJ1Y3R1cmVzIGluIHRoZSBieXRlY29kZSwgc28gd2UgbmVlZCB0byB2aXNp dCB0aGUgYXBwcm9wcmlhdGUKKyAgICAgICAgaW5zdHJ1Y3Rpb25zIGFzIHdlIHdvdWxkIGlmIHdl IHdlcmUgcnVubmluZyBpbiB0aGUgY2xhc3NpYyBpbnRlcnByZXRlci4KKyAgICAgICAgVGhpcyBy ZXF1aXJlcyBhZGRpbmcgYWRkaXRpb25hbCBjaGVja3MgZm9yIHRoZSBMTEludCBzcGVjaWZpYyBv cGNvZGVzLCBhbmQKKyAgICAgICAgdGhlIGxpbnQgc3BlY2lmaWMgdmFyaWFudHMgb2Ygb3BlcmFu ZCBvcmRlcmluZy4gCisKKyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAg ICAoSlNDOjpDb2RlQmxvY2s6OnZpc2l0U3RydWN0dXJlcyk6CisgICAgICAgIChKU0M6OkNvZGVC bG9jazo6c3Ryb25nbHlWaXNpdFN0cm9uZ1JlZmVyZW5jZXMpOgorCiAyMDEyLTA3LTEzICBZb25n IExpICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBJbXBsZW1lbnQgR0NB Y3Rpdml0eUNhbGxiYWNrIHdpdGggcGxhdGZvcm0gdGltZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2RlQmxvY2suY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKaW5kZXggZDQxN2E1ZmJkMzA2MmRjMzg4NTY5MDdm NjVhZGEwYzFhMjM4Y2Q5NC4uNGNhOGYzZTI5ZmY3ZTQ3NGFiZGQ5ZDkwNzk5N2NlODIyNzRjZTkz YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKQEAg LTE4NDAsMTEgKzE4NDAsMTEgQEAgdm9pZCBDb2RlQmxvY2s6OnZpc2l0U3RydWN0dXJlcyhTbG90 VmlzaXRvciYgdmlzaXRvciwgSW5zdHJ1Y3Rpb24qIHZQQykKIHsKICAgICBJbnRlcnByZXRlciog aW50ZXJwcmV0ZXIgPSBtX2dsb2JhbERhdGEtPmludGVycHJldGVyOwogCi0gICAgaWYgKHZQQ1sw XS51Lm9wY29kZSA9PSBpbnRlcnByZXRlci0+Z2V0T3Bjb2RlKG9wX2dldF9ieV9pZCkgJiYgdlBD WzRdLnUuc3RydWN0dXJlKSB7CisgICAgaWYgKCh2UENbMF0udS5vcGNvZGUgPT0gaW50ZXJwcmV0 ZXItPmdldE9wY29kZShvcF9nZXRfYnlfaWQpIHx8IHZQQ1swXS51Lm9wY29kZSA9PSBpbnRlcnBy ZXRlci0+Z2V0T3Bjb2RlKG9wX2dldF9ieV9pZF9vdXRfb2ZfbGluZSkpICYmIHZQQ1s0XS51LnN0 cnVjdHVyZSkgewogICAgICAgICB2aXNpdG9yLmFwcGVuZCgmdlBDWzRdLnUuc3RydWN0dXJlKTsK ICAgICAgICAgcmV0dXJuOwogICAgIH0KLQorICAgIAogICAgIGlmICh2UENbMF0udS5vcGNvZGUg PT0gaW50ZXJwcmV0ZXItPmdldE9wY29kZShvcF9nZXRfYnlfaWRfc2VsZikgfHwgdlBDWzBdLnUu b3Bjb2RlID09IGludGVycHJldGVyLT5nZXRPcGNvZGUob3BfZ2V0X2J5X2lkX2dldHRlcl9zZWxm KSB8fCB2UENbMF0udS5vcGNvZGUgPT0gaW50ZXJwcmV0ZXItPmdldE9wY29kZShvcF9nZXRfYnlf aWRfY3VzdG9tX3NlbGYpKSB7CiAgICAgICAgIHZpc2l0b3IuYXBwZW5kKCZ2UENbNF0udS5zdHJ1 Y3R1cmUpOwogICAgICAgICByZXR1cm47CkBAIC0xODYwLDYgKzE4NjAsMTYgQEAgdm9pZCBDb2Rl QmxvY2s6OnZpc2l0U3RydWN0dXJlcyhTbG90VmlzaXRvciYgdmlzaXRvciwgSW5zdHJ1Y3Rpb24q IHZQQykKICAgICAgICAgICAgIHZpc2l0b3IuYXBwZW5kKCZ2UENbNV0udS5zdHJ1Y3R1cmVDaGFp bik7CiAgICAgICAgIHJldHVybjsKICAgICB9CisjaWYgRU5BQkxFKExMSU5UKQorICAgIGlmICh2 UENbMF0udS5vcGNvZGUgPT0gaW50ZXJwcmV0ZXItPmdldE9wY29kZShvcF9wdXRfYnlfaWRfdHJh bnNpdGlvbl9kaXJlY3QpIHx8IHZQQ1swXS51Lm9wY29kZSA9PSBpbnRlcnByZXRlci0+Z2V0T3Bj b2RlKG9wX3B1dF9ieV9pZF90cmFuc2l0aW9uX2RpcmVjdF9vdXRfb2ZfbGluZSkgfHwgdlBDWzBd LnUub3Bjb2RlID09IGludGVycHJldGVyLT5nZXRPcGNvZGUob3BfcHV0X2J5X2lkX3RyYW5zaXRp b25fbm9ybWFsKSB8fCB2UENbMF0udS5vcGNvZGUgPT0gaW50ZXJwcmV0ZXItPmdldE9wY29kZShv cF9wdXRfYnlfaWRfdHJhbnNpdGlvbl9ub3JtYWxfb3V0X29mX2xpbmUpKSB7CisgICAgICAgIHZp c2l0b3IuYXBwZW5kKCZ2UENbNF0udS5zdHJ1Y3R1cmUpOworICAgICAgICB2aXNpdG9yLmFwcGVu ZCgmdlBDWzZdLnUuc3RydWN0dXJlKTsKKyAgICAgICAgaWYgKHZQQ1s3XS51LnN0cnVjdHVyZUNo YWluKQorICAgICAgICAgICAgdmlzaXRvci5hcHBlbmQoJnZQQ1s3XS51LnN0cnVjdHVyZUNoYWlu KTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyNlbmRpZgorICAgICAgICAKICAgICBpZiAodlBD WzBdLnUub3Bjb2RlID09IGludGVycHJldGVyLT5nZXRPcGNvZGUob3BfcHV0X2J5X2lkX3RyYW5z aXRpb24pKSB7CiAgICAgICAgIHZpc2l0b3IuYXBwZW5kKCZ2UENbNF0udS5zdHJ1Y3R1cmUpOwog ICAgICAgICB2aXNpdG9yLmFwcGVuZCgmdlBDWzVdLnUuc3RydWN0dXJlKTsKQEAgLTE4NjcsNyAr MTg3Nyw3IEBAIHZvaWQgQ29kZUJsb2NrOjp2aXNpdFN0cnVjdHVyZXMoU2xvdFZpc2l0b3ImIHZp c2l0b3IsIEluc3RydWN0aW9uKiB2UEMpCiAgICAgICAgICAgICB2aXNpdG9yLmFwcGVuZCgmdlBD WzZdLnUuc3RydWN0dXJlQ2hhaW4pOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIGlmICh2 UENbMF0udS5vcGNvZGUgPT0gaW50ZXJwcmV0ZXItPmdldE9wY29kZShvcF9wdXRfYnlfaWQpICYm IHZQQ1s0XS51LnN0cnVjdHVyZSkgeworICAgIGlmICgodlBDWzBdLnUub3Bjb2RlID09IGludGVy cHJldGVyLT5nZXRPcGNvZGUob3BfcHV0X2J5X2lkKSB8fCB2UENbMF0udS5vcGNvZGUgPT0gaW50 ZXJwcmV0ZXItPmdldE9wY29kZShvcF9wdXRfYnlfaWRfb3V0X29mX2xpbmUpKSAmJiB2UENbNF0u dS5zdHJ1Y3R1cmUpIHsKICAgICAgICAgdmlzaXRvci5hcHBlbmQoJnZQQ1s0XS51LnN0cnVjdHVy ZSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CkBAIC0yMjM4LDYgKzIyNDgsMTQgQEAgdm9pZCBD b2RlQmxvY2s6OnN0cm9uZ2x5VmlzaXRTdHJvbmdSZWZlcmVuY2VzKFNsb3RWaXNpdG9yJiB2aXNp dG9yKQogICAgICAgICAgICAgdmlzaXRTdHJ1Y3R1cmVzKHZpc2l0b3IsICZpbnN0cnVjdGlvbnMo KVttX2dsb2JhbFJlc29sdmVJbnN0cnVjdGlvbnNbaV1dKTsKICAgICB9CiAjZW5kaWYKKyNpZiBF TkFCTEUoTExJTlQpCisgICAgaWYgKCFtX2dsb2JhbERhdGEtPmludGVycHJldGVyLT5jbGFzc2lj RW5hYmxlZCgpICYmICEhbnVtYmVyT2ZJbnN0cnVjdGlvbnMoKSAmJiBnZXRKSVRUeXBlKCkgPCBK SVRDb2RlOjpib3R0b21UaWVySklUKCkpIHsKKyAgICAgICAgZm9yIChzaXplX3Qgc2l6ZSA9IG1f cHJvcGVydHlBY2Nlc3NJbnN0cnVjdGlvbnMuc2l6ZSgpLCBpID0gMDsgaSA8IHNpemU7ICsraSkK KyAgICAgICAgICAgIHZpc2l0U3RydWN0dXJlcyh2aXNpdG9yLCAmaW5zdHJ1Y3Rpb25zKClbbV9w cm9wZXJ0eUFjY2Vzc0luc3RydWN0aW9uc1tpXV0pOworICAgICAgICBmb3IgKHNpemVfdCBzaXpl ID0gbV9nbG9iYWxSZXNvbHZlSW5zdHJ1Y3Rpb25zLnNpemUoKSwgaSA9IDA7IGkgPCBzaXplOyAr K2kpCisgICAgICAgICAgICB2aXNpdFN0cnVjdHVyZXModmlzaXRvciwgJmluc3RydWN0aW9ucygp W21fZ2xvYmFsUmVzb2x2ZUluc3RydWN0aW9uc1tpXV0pOworICAgIH0KKyNlbmRpZgogCiAgICAg dXBkYXRlQWxsUHJlZGljdGlvbnMoQ29sbGVjdGlvbik7CiB9Cg==