91265 2012-07-13 11:04:10 -0700 cr-ews bot doesn't set CWD correctly when zipping layout test results 2012-08-28 20:11:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbr eric abarth dbates dpranke eric ojan webkit.review.bot oldest_to_newest 669250 0 kbr 2012-07-13 11:04:10 -0700 The newly migrated cr-ews bot is setting the CWD incorrectly (one directory too high) when zipping up failed layout test results. Example bug showing this issue: https://bugs.webkit.org/show_bug.cgi?id=76225 . The extracted zip archive creates 'tmp/layout_test_results' rather than just layout_test_results. 669264 1 eric 2012-07-13 11:11:49 -0700 Oh, we've had this forever. I've just never known how to fix it. context: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L331 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L238 The code which likely needs to change: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/queues.py#L275 or probably: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py#L87 http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/workspace.py#L58 669266 2 eric 2012-07-13 11:12:33 -0700 I suspect that Workspace.create_zip just needs to be passed some sort of -D argument or something to have it cd into the directory before its starts zipping. 669270 3 eric 2012-07-13 11:15:10 -0700 (In reply to comment #2) > I suspect that Workspace.create_zip just needs to be passed some sort of -D argument or something to have it cd into the directory before its starts zipping. Hmm... Or maybe I'm thinking of tar. We can probably just pass the zip directory as the cwd= in run_command: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/system/executive.py#L372 and then tell it to zip "." 669275 4 kbr 2012-07-13 11:18:33 -0700 (In reply to comment #1) > Oh, we've had this forever. I've just never known how to fix it. Oops. I thought this was new behavior. Maybe I was confusing this with layout test results coming from Chromium's flakiness dashboard. 701292 5 159801 eric 2012-08-21 16:41:54 -0700 Created attachment 159801 Patch 701295 6 159801 kbr 2012-08-21 16:45:18 -0700 Comment on attachment 159801 Patch LGTM! Thanks for the fix. 701463 7 159801 webkit.review.bot 2012-08-21 18:41:36 -0700 Comment on attachment 159801 Patch Rejecting attachment 159801 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13560090 706741 8 161062 eric 2012-08-28 14:36:08 -0700 Created attachment 161062 Patch for landing 706746 9 161062 webkit.review.bot 2012-08-28 14:41:45 -0700 Comment on attachment 161062 Patch for landing Rejecting attachment 161062 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Kenneth Russel found in /mnt/git/webkit-commit-queue/Tools/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/13654509 706750 10 eric 2012-08-28 14:45:38 -0700 I'll upload a new one with proper spelling shortly. 706899 11 161095 eric 2012-08-28 17:04:58 -0700 Created attachment 161095 Patch for landing 707004 12 161095 webkit.review.bot 2012-08-28 19:24:18 -0700 Comment on attachment 161095 Patch for landing Rejecting attachment 161095 from commit-queue. eric@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 707035 13 161095 webkit.review.bot 2012-08-28 20:11:48 -0700 Comment on attachment 161095 Patch for landing Clearing flags on attachment: 161095 Committed r126952: <http://trac.webkit.org/changeset/126952> 707036 14 webkit.review.bot 2012-08-28 20:11:52 -0700 All reviewed patches have been landed. Closing bug. 159801 2012-08-21 16:41:54 -0700 2012-08-28 14:36:04 -0700 Patch bug-91265-20120821164152.patch text/plain 3129 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzMwZDYxNzJiMmU4NzRkYzg3ODU3OWMxN2Q2YWE1YmFi ZGFlZWY5Mi4uYWM5M2E5YjU4ZmQyZWY4NTMzMGM2ZDQ2YjE2NjQ2YTI0NzE2ZTZmMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA4LTIxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBjci1ld3MgYm90IGRvZXNuJ3Qgc2V0IENXRCBjb3JyZWN0bHkgd2hlbiB6aXBwaW5nIGxheW91 dCB0ZXN0IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkxMjY1CisKKyAgICAgICAgVGhpcyBzaG91bGQgbWFrZSB0aGUgemlwcyBzbGlnaHRs eSBsZXNzIGN1bWJlcnNvbWUgdG8gZGVhbCB3aXRoLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tb24vc3lzdGVtL3dvcmtzcGFjZS5weToKKyAgICAgICAgKFdvcmtzcGFjZS5jcmVh dGVfemlwKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29ya3Nw YWNlX3VuaXR0ZXN0LnB5OgorICAgICAgICAoV29ya3NwYWNlVGVzdC50ZXN0X2NyZWF0ZV96aXAp OgorICAgICAgICAoV29ya3NwYWNlVGVzdC50ZXN0X2NyZWF0ZV96aXBfZXhjZXB0aW9uKToKKwog MjAxMi0wOC0yMCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVs LmNvbT4KIAogICAgICAgICBbRUZMXSBNb3ZlIGpoYnVpbGQgZGVwZW5kZW5jaWVzIGJhc2VkIG9u IFNWTiB0byB0YXJiYWxscwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21t b24vc3lzdGVtL3dvcmtzcGFjZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS93b3Jrc3BhY2UucHkKaW5kZXggNWM3M2RmNzdlODJkNTlkMGJmY2M0NTVlOTlkZGQ4NmQ2 YWM5ZjMyNy4uNjg2ODM3NjE5YmFhNjMzZjQ3MmFmYTU3YTk2YTEwMWU0NDVhMDYyYSAxMDA2NDQK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtzcGFjZS5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29ya3NwYWNlLnB5CkBA IC02NSw3ICs2NSw3IEBAIGNsYXNzIFdvcmtzcGFjZShvYmplY3QpOgogICAgICAgICAjIEhvd2V2 ZXIsIGdldHRpbmcgdGhlIHBhdGhzLCBlbmNvZGluZyBhbmQgY29tcHJlc3Npb24gY29ycmVjdCBj b3VsZCBiZSBub24tdHJpdmlhbC4KICAgICAgICAgIyBTbywgZm9yIG5vdyB3ZSBkZXBlbmQgb24g dGhlIGVudmlyb25tZW50IGhhdmluZyAiemlwIiBpbnN0YWxsZWQgKGxpa2VseSBmYWlscyBvbiBX aW4zMikKICAgICAgICAgdHJ5OgotICAgICAgICAgICAgc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21t YW5kKFsnemlwJywgJy05JywgJy1yJywgemlwX3BhdGgsIHNvdXJjZV9wYXRoXSkKKyAgICAgICAg ICAgIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbJ3ppcCcsICctOScsICctcicsIHppcF9w YXRoLCAnLiddLCBjd2Q9c291cmNlX3BhdGgpCiAgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwg ZToKICAgICAgICAgICAgIF9sb2cuZXJyb3IoIldvcmtzcGFjZS5jcmVhdGVfemlwIGZhaWxlZDpc biVzIiAlIGUubWVzc2FnZV93aXRoX291dHB1dCgpKQogICAgICAgICAgICAgcmV0dXJuIE5vbmUK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS93b3Jrc3Bh Y2VfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29y a3NwYWNlX3VuaXR0ZXN0LnB5CmluZGV4IDY0MmFmYjljNjNhNjUxNzhmOWMyZDEwZTdhOGQzNDY4 MzVhYWJhMjMuLjQ5MDk0YWM2MzZmZmNmNjBhMWQ1MzM0ZWM1M2Q4NjBmOTU0NDMwYTggMTAwNjQ0 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS93b3Jrc3BhY2VfdW5p dHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtz cGFjZV91bml0dGVzdC5weQpAQCAtNTAsNyArNTAsNyBAQCBjbGFzcyBXb3Jrc3BhY2VUZXN0KHVu aXR0ZXN0LlRlc3RDYXNlKToKIAogICAgIGRlZiB0ZXN0X2NyZWF0ZV96aXAoc2VsZik6CiAgICAg ICAgIHdvcmtzcGFjZSA9IFdvcmtzcGFjZShOb25lLCBNb2NrRXhlY3V0aXZlKHNob3VsZF9sb2c9 VHJ1ZSkpCi0gICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBbJ3pp cCcsICctOScsICctcicsICcvemlwL3BhdGgnLCAnL3NvdXJjZS9wYXRoJ10sIGN3ZD1Ob25lXG4i CisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBbJ3ppcCcsICct OScsICctcicsICcvemlwL3BhdGgnLCAnLiddLCBjd2Q9L3NvdXJjZS9wYXRoXG4iCiAgICAgICAg IGNsYXNzIE1vY2taaXBGaWxlKG9iamVjdCk6CiAgICAgICAgICAgICBkZWYgX19pbml0X18oc2Vs ZiwgcGF0aCk6CiAgICAgICAgICAgICAgICAgc2VsZi5maWxlbmFtZSA9IHBhdGgKQEAgLTU5LDcg KzU5LDcgQEAgY2xhc3MgV29ya3NwYWNlVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICBk ZWYgdGVzdF9jcmVhdGVfemlwX2V4Y2VwdGlvbihzZWxmKToKICAgICAgICAgd29ya3NwYWNlID0g V29ya3NwYWNlKE5vbmUsIE1vY2tFeGVjdXRpdmUoc2hvdWxkX2xvZz1UcnVlLCBzaG91bGRfdGhy b3c9VHJ1ZSkpCi0gICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBb J3ppcCcsICctOScsICctcicsICcvemlwL3BhdGgnLCAnL3NvdXJjZS9wYXRoJ10sIGN3ZD1Ob25l XG4iCisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBbJ3ppcCcs ICctOScsICctcicsICcvemlwL3BhdGgnLCAnLiddLCBjd2Q9L3NvdXJjZS9wYXRoXG4iCiAgICAg ICAgIGNsYXNzIE1vY2taaXBGaWxlKG9iamVjdCk6CiAgICAgICAgICAgICBkZWYgX19pbml0X18o c2VsZiwgcGF0aCk6CiAgICAgICAgICAgICAgICAgc2VsZi5maWxlbmFtZSA9IHBhdGgK 161062 2012-08-28 14:36:08 -0700 2012-08-28 17:04:53 -0700 Patch for landing bug-91265-20120828143559.patch text/plain 3168 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTE0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzMwZDYxNzJiMmU4NzRkYzg3ODU3OWMxN2Q2YWE1YmFi ZGFlZWY5Mi4uMTU4NWNmNmI5NzU3NzM0OTBhNmJkOTMzNDRmZjFmMTc5MzA0YTI5NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA4LTIxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBjci1ld3MgYm90IGRvZXNuJ3Qgc2V0IENXRCBjb3JyZWN0bHkgd2hlbiB6aXBwaW5nIGxheW91 dCB0ZXN0IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkxMjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWwuCisKKyAg ICAgICAgVGhpcyBzaG91bGQgbWFrZSB0aGUgemlwcyBzbGlnaHRseSBsZXNzIGN1bWJlcnNvbWUg dG8gZGVhbCB3aXRoLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L3dvcmtzcGFjZS5weToKKyAgICAgICAgKFdvcmtzcGFjZS5jcmVhdGVfemlwKToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29ya3NwYWNlX3VuaXR0ZXN0LnB5Ogor ICAgICAgICAoV29ya3NwYWNlVGVzdC50ZXN0X2NyZWF0ZV96aXApOgorICAgICAgICAoV29ya3Nw YWNlVGVzdC50ZXN0X2NyZWF0ZV96aXBfZXhjZXB0aW9uKToKKwogMjAxMi0wOC0yMCAgVGhpYWdv IE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KIAogICAgICAgICBb RUZMXSBNb3ZlIGpoYnVpbGQgZGVwZW5kZW5jaWVzIGJhc2VkIG9uIFNWTiB0byB0YXJiYWxscwpk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtzcGFj ZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS93b3Jrc3BhY2UucHkK aW5kZXggNWM3M2RmNzdlODJkNTlkMGJmY2M0NTVlOTlkZGQ4NmQ2YWM5ZjMyNy4uNjg2ODM3NjE5 YmFhNjMzZjQ3MmFmYTU3YTk2YTEwMWU0NDVhMDYyYSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtzcGFjZS5weQorKysgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29ya3NwYWNlLnB5CkBAIC02NSw3ICs2NSw3IEBAIGNs YXNzIFdvcmtzcGFjZShvYmplY3QpOgogICAgICAgICAjIEhvd2V2ZXIsIGdldHRpbmcgdGhlIHBh dGhzLCBlbmNvZGluZyBhbmQgY29tcHJlc3Npb24gY29ycmVjdCBjb3VsZCBiZSBub24tdHJpdmlh bC4KICAgICAgICAgIyBTbywgZm9yIG5vdyB3ZSBkZXBlbmQgb24gdGhlIGVudmlyb25tZW50IGhh dmluZyAiemlwIiBpbnN0YWxsZWQgKGxpa2VseSBmYWlscyBvbiBXaW4zMikKICAgICAgICAgdHJ5 OgotICAgICAgICAgICAgc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsnemlwJywgJy05Jywg Jy1yJywgemlwX3BhdGgsIHNvdXJjZV9wYXRoXSkKKyAgICAgICAgICAgIHNlbGYuX2V4ZWN1dGl2 ZS5ydW5fY29tbWFuZChbJ3ppcCcsICctOScsICctcicsIHppcF9wYXRoLCAnLiddLCBjd2Q9c291 cmNlX3BhdGgpCiAgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKICAgICAgICAgICAgIF9s b2cuZXJyb3IoIldvcmtzcGFjZS5jcmVhdGVfemlwIGZhaWxlZDpcbiVzIiAlIGUubWVzc2FnZV93 aXRoX291dHB1dCgpKQogICAgICAgICAgICAgcmV0dXJuIE5vbmUKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS93b3Jrc3BhY2VfdW5pdHRlc3QucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29ya3NwYWNlX3VuaXR0ZXN0LnB5 CmluZGV4IDY0MmFmYjljNjNhNjUxNzhmOWMyZDEwZTdhOGQzNDY4MzVhYWJhMjMuLjQ5MDk0YWM2 MzZmZmNmNjBhMWQ1MzM0ZWM1M2Q4NjBmOTU0NDMwYTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS93b3Jrc3BhY2VfdW5pdHRlc3QucHkKKysrIGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtzcGFjZV91bml0dGVzdC5weQpA QCAtNTAsNyArNTAsNyBAQCBjbGFzcyBXb3Jrc3BhY2VUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK IAogICAgIGRlZiB0ZXN0X2NyZWF0ZV96aXAoc2VsZik6CiAgICAgICAgIHdvcmtzcGFjZSA9IFdv cmtzcGFjZShOb25lLCBNb2NrRXhlY3V0aXZlKHNob3VsZF9sb2c9VHJ1ZSkpCi0gICAgICAgIGV4 cGVjdGVkX3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBbJ3ppcCcsICctOScsICctcicsICcv emlwL3BhdGgnLCAnL3NvdXJjZS9wYXRoJ10sIGN3ZD1Ob25lXG4iCisgICAgICAgIGV4cGVjdGVk X3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBbJ3ppcCcsICctOScsICctcicsICcvemlwL3Bh dGgnLCAnLiddLCBjd2Q9L3NvdXJjZS9wYXRoXG4iCiAgICAgICAgIGNsYXNzIE1vY2taaXBGaWxl KG9iamVjdCk6CiAgICAgICAgICAgICBkZWYgX19pbml0X18oc2VsZiwgcGF0aCk6CiAgICAgICAg ICAgICAgICAgc2VsZi5maWxlbmFtZSA9IHBhdGgKQEAgLTU5LDcgKzU5LDcgQEAgY2xhc3MgV29y a3NwYWNlVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAKICAgICBkZWYgdGVzdF9jcmVhdGVfemlw X2V4Y2VwdGlvbihzZWxmKToKICAgICAgICAgd29ya3NwYWNlID0gV29ya3NwYWNlKE5vbmUsIE1v Y2tFeGVjdXRpdmUoc2hvdWxkX2xvZz1UcnVlLCBzaG91bGRfdGhyb3c9VHJ1ZSkpCi0gICAgICAg IGV4cGVjdGVkX3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBbJ3ppcCcsICctOScsICctcics ICcvemlwL3BhdGgnLCAnL3NvdXJjZS9wYXRoJ10sIGN3ZD1Ob25lXG4iCisgICAgICAgIGV4cGVj dGVkX3N0ZGVyciA9ICJNT0NLIHJ1bl9jb21tYW5kOiBbJ3ppcCcsICctOScsICctcicsICcvemlw L3BhdGgnLCAnLiddLCBjd2Q9L3NvdXJjZS9wYXRoXG4iCiAgICAgICAgIGNsYXNzIE1vY2taaXBG aWxlKG9iamVjdCk6CiAgICAgICAgICAgICBkZWYgX19pbml0X18oc2VsZiwgcGF0aCk6CiAgICAg ICAgICAgICAgICAgc2VsZi5maWxlbmFtZSA9IHBhdGgK 161095 2012-08-28 17:04:58 -0700 2012-08-28 20:11:48 -0700 Patch for landing bug-91265-20120828170448.patch text/plain 3137 eric U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWE0M2E3OGYyZmNhYWIyNTZmYTM3M2UwNzA0NGE5ZGE4 MjQ0ZWU1Ni4uMTU0NWI0ZDZmYzk3ZjMyMjczOTM2OWQ5ZGJjMjIyMzZjYmFmY2QzZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA4LTI4ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KKworICAgICAg ICBjci1ld3MgYm90IGRvZXNuJ3Qgc2V0IENXRCBjb3JyZWN0bHkgd2hlbiB6aXBwaW5nIGxheW91 dCB0ZXN0IHJlc3VsdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkxMjY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNzZWxsLgorCisg ICAgICAgIFRoaXMgc2hvdWxkIG1ha2UgdGhlIHppcHMgc2xpZ2h0bHkgbGVzcyBjdW1iZXJzb21l IHRvIGRlYWwgd2l0aC4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3Rl bS93b3Jrc3BhY2UucHk6CisgICAgICAgIChXb3Jrc3BhY2UuY3JlYXRlX3ppcCk6CisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtzcGFjZV91bml0dGVzdC5weToK KyAgICAgICAgKFdvcmtzcGFjZVRlc3QudGVzdF9jcmVhdGVfemlwKToKKyAgICAgICAgKFdvcmtz cGFjZVRlc3QudGVzdF9jcmVhdGVfemlwX2V4Y2VwdGlvbik6CisKIDIwMTItMDgtMjggIFNoZXJp ZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIxMjY5MTQuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9zeXN0ZW0vd29ya3NwYWNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vc3lzdGVtL3dvcmtzcGFjZS5weQppbmRleCA1YzczZGY3N2U4MmQ1OWQwYmZjYzQ1NWU5 OWRkZDg2ZDZhYzlmMzI3Li42ODY4Mzc2MTliYWE2MzNmNDcyYWZhNTdhOTZhMTAxZTQ0NWEwNjJh IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0ZW0vd29ya3Nw YWNlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS93b3Jrc3Bh Y2UucHkKQEAgLTY1LDcgKzY1LDcgQEAgY2xhc3MgV29ya3NwYWNlKG9iamVjdCk6CiAgICAgICAg ICMgSG93ZXZlciwgZ2V0dGluZyB0aGUgcGF0aHMsIGVuY29kaW5nIGFuZCBjb21wcmVzc2lvbiBj b3JyZWN0IGNvdWxkIGJlIG5vbi10cml2aWFsLgogICAgICAgICAjIFNvLCBmb3Igbm93IHdlIGRl cGVuZCBvbiB0aGUgZW52aXJvbm1lbnQgaGF2aW5nICJ6aXAiIGluc3RhbGxlZCAobGlrZWx5IGZh aWxzIG9uIFdpbjMyKQogICAgICAgICB0cnk6Ci0gICAgICAgICAgICBzZWxmLl9leGVjdXRpdmUu cnVuX2NvbW1hbmQoWyd6aXAnLCAnLTknLCAnLXInLCB6aXBfcGF0aCwgc291cmNlX3BhdGhdKQor ICAgICAgICAgICAgc2VsZi5fZXhlY3V0aXZlLnJ1bl9jb21tYW5kKFsnemlwJywgJy05JywgJy1y JywgemlwX3BhdGgsICcuJ10sIGN3ZD1zb3VyY2VfcGF0aCkKICAgICAgICAgZXhjZXB0IFNjcmlw dEVycm9yLCBlOgogICAgICAgICAgICAgX2xvZy5lcnJvcigiV29ya3NwYWNlLmNyZWF0ZV96aXAg ZmFpbGVkOlxuJXMiICUgZS5tZXNzYWdlX3dpdGhfb3V0cHV0KCkpCiAgICAgICAgICAgICByZXR1 cm4gTm9uZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVt L3dvcmtzcGFjZV91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5 c3RlbS93b3Jrc3BhY2VfdW5pdHRlc3QucHkKaW5kZXggNjQyYWZiOWM2M2E2NTE3OGY5YzJkMTBl N2E4ZDM0NjgzNWFhYmEyMy4uNDkwOTRhYzYzNmZmY2Y2MGExZDUzMzRlYzUzZDg2MGY5NTQ0MzBh OCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL3dvcmtz cGFjZV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0 ZW0vd29ya3NwYWNlX3VuaXR0ZXN0LnB5CkBAIC01MCw3ICs1MCw3IEBAIGNsYXNzIFdvcmtzcGFj ZVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogCiAgICAgZGVmIHRlc3RfY3JlYXRlX3ppcChzZWxm KToKICAgICAgICAgd29ya3NwYWNlID0gV29ya3NwYWNlKE5vbmUsIE1vY2tFeGVjdXRpdmUoc2hv dWxkX2xvZz1UcnVlKSkKLSAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0sgcnVuX2NvbW1h bmQ6IFsnemlwJywgJy05JywgJy1yJywgJy96aXAvcGF0aCcsICcvc291cmNlL3BhdGgnXSwgY3dk PU5vbmVcbiIKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0sgcnVuX2NvbW1hbmQ6IFsn emlwJywgJy05JywgJy1yJywgJy96aXAvcGF0aCcsICcuJ10sIGN3ZD0vc291cmNlL3BhdGhcbiIK ICAgICAgICAgY2xhc3MgTW9ja1ppcEZpbGUob2JqZWN0KToKICAgICAgICAgICAgIGRlZiBfX2lu aXRfXyhzZWxmLCBwYXRoKToKICAgICAgICAgICAgICAgICBzZWxmLmZpbGVuYW1lID0gcGF0aApA QCAtNTksNyArNTksNyBAQCBjbGFzcyBXb3Jrc3BhY2VUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToK IAogICAgIGRlZiB0ZXN0X2NyZWF0ZV96aXBfZXhjZXB0aW9uKHNlbGYpOgogICAgICAgICB3b3Jr c3BhY2UgPSBXb3Jrc3BhY2UoTm9uZSwgTW9ja0V4ZWN1dGl2ZShzaG91bGRfbG9nPVRydWUsIHNo b3VsZF90aHJvdz1UcnVlKSkKLSAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0sgcnVuX2Nv bW1hbmQ6IFsnemlwJywgJy05JywgJy1yJywgJy96aXAvcGF0aCcsICcvc291cmNlL3BhdGgnXSwg Y3dkPU5vbmVcbiIKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIk1PQ0sgcnVuX2NvbW1hbmQ6 IFsnemlwJywgJy05JywgJy1yJywgJy96aXAvcGF0aCcsICcuJ10sIGN3ZD0vc291cmNlL3BhdGhc biIKICAgICAgICAgY2xhc3MgTW9ja1ppcEZpbGUob2JqZWN0KToKICAgICAgICAgICAgIGRlZiBf X2luaXRfXyhzZWxmLCBwYXRoKToKICAgICAgICAgICAgICAgICBzZWxmLmZpbGVuYW1lID0gcGF0 aAo=