91264 2012-07-13 10:48:35 -0700 EWSTools should be able to build a commit-queue instance from scratch 2012-07-13 13:41:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric webkit.review.bot oldest_to_newest 669226 0 abarth 2012-07-13 10:48:35 -0700 EWSTools should be able to build a commit-queue instance from scratch 669228 1 152300 abarth 2012-07-13 10:52:31 -0700 Created attachment 152300 Patch 669245 2 152300 eric 2012-07-13 11:01:16 -0700 Comment on attachment 152300 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152300&action=review LGTM. > Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh:52 > +gcutil ssh $BOT_ID "sudo apt-get install subversion -y && svn checkout http://svn.webkit.org/repository/webkit/trunk/Tools/EWSTools tools && cd tools && bash configure-svn-auth.sh $SVN_USERNAME $SVN_PASSWORD && bash cold-boot.sh $QUEUE_TYPE $BOT_ID $BUGZILLA_USERNAME $BUGZILLA_PASSWORD" I'm sure there is a nicer way to do this. Even just using \ at the end of the line to continue to the next, might make sense... 669262 3 152300 abarth 2012-07-13 11:09:42 -0700 Comment on attachment 152300 Patch Bash line continuations are way to awesome for me. I can't handle it. 669318 4 152300 webkit.review.bot 2012-07-13 12:05:01 -0700 Comment on attachment 152300 Patch Rejecting attachment 152300 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: return self.open(self.click(*args, **kwds)) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open return self._mech_open(url, data, timeout=timeout) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open raise response webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error Full output: http://queues.webkit.org/results/13242186 669348 5 152300 eric 2012-07-13 12:41:29 -0700 Comment on attachment 152300 Patch Seems like we should be able to recover from 500s. 669384 6 152300 webkit.review.bot 2012-07-13 13:41:09 -0700 Comment on attachment 152300 Patch Clearing flags on attachment: 152300 Committed r122627: <http://trac.webkit.org/changeset/122627> 669385 7 webkit.review.bot 2012-07-13 13:41:13 -0700 All reviewed patches have been landed. Closing bug. 152300 2012-07-13 10:52:31 -0700 2012-07-13 13:41:09 -0700 Patch bug-91264-20120713105229.patch text/plain 3649 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTEyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGM1ODZjOTNmNzc5MGZmN2IwODgwYzVjZTk4ZDlhNjg3 Yjk2YTUzZi4uMDU5M2FhNTVmZDM1Zjg4MWUyYzZiNzhkMDc3YzM1ZWFlOTY5NGUzOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA3LTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgRVdTVG9vbHMgc2hvdWxkIGJlIGFibGUgdG8gYnVpbGQgYSBjb21taXQtcXVldWUgaW5zdGFu Y2UgZnJvbSBzY3JhdGNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05MTI2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEkndmUgYmVlbiB1c2luZyB0aGlzIHNjcmlwdCB0byBidWlsZCBjb21taXQtcXVldWUg aW5zdGFuY2VzIG9uIEdvb2dsZQorICAgICAgICBDb21wdXRlIEVuZ2luZSBhbmQgaXQgc2VlbXMg dG8gd29yay4KKworICAgICAgICAqIEVXU1Rvb2xzL0dvb2dsZUNvbXB1dGVFbmdpbmUvYnVpbGQt Y29tbWl0LXF1ZXVlLnNoOiBBZGRlZC4KKwogMjAxMi0wNy0xMiAgRGlyayBQcmFua2UgIDxkcHJh bmtlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBucnd0IGNyYXNoZXMgc2F2aW5nIHRoZSBvdXRw dXQgZm9yIGEgcGxhdGZvcm0tc3BlY2lmaWMgZXhwZWN0ZWQgdGVzdCByZWZlcmVuY2UKZGlmZiAt LWdpdCBhL1Rvb2xzL0VXU1Rvb2xzL0dvb2dsZUNvbXB1dGVFbmdpbmUvYnVpbGQtY29tbWl0LXF1 ZXVlLnNoIGIvVG9vbHMvRVdTVG9vbHMvR29vZ2xlQ29tcHV0ZUVuZ2luZS9idWlsZC1jb21taXQt cXVldWUuc2gKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uYTk0YjAyMDgzYTAwYWRkMWM1YTc0MzYxMWQ2YTgxZjU5ZTA3 ZmIyMwotLS0gL2Rldi9udWxsCisrKyBiL1Rvb2xzL0VXU1Rvb2xzL0dvb2dsZUNvbXB1dGVFbmdp bmUvYnVpbGQtY29tbWl0LXF1ZXVlLnNoCkBAIC0wLDAgKzEsNTIgQEAKKyMhL2Jpbi9zaAorIyBD b3B5cmlnaHQgKGMpIDIwMTIgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMg UmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBv ciB3aXRob3V0CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRo ZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKKyMgbWV0OgorIworIyAgICAgKiBSZWRpc3RyaWJ1 dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorIyBu b3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWlt ZXIuCisjICAgICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVj ZSB0aGUgYWJvdmUKKyMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMg YW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgorIyBpbiB0aGUgZG9jdW1lbnRhdGlvbiBhbmQv b3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisjIGRpc3RyaWJ1dGlvbi4KKyMg ICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0 cworIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1 Y3RzIGRlcml2ZWQgZnJvbQorIyB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJpb3Ig d3JpdHRlbiBwZXJtaXNzaW9uLgorIworIyBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRI RSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisjICJBUyBJUyIgQU5EIEFOWSBF WFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UCisjIExJTUlU RUQgVE8sIFRIRSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRO RVNTIEZPUgorIyBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZF TlQgU0hBTEwgVEhFIENPUFlSSUdIVAorIyBPV05FUiBPUiBDT05UUklCVVRPUlMgQkUgTElBQkxF IEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwKKyMgU1BFQ0lBTCwgRVhFTVBM QVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1J VEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NT IE9GIFVTRSwKKyMgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZCisjIFRIRU9SWSBPRiBMSUFCSUxJVFksIFdIRVRIRVIg SU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQKKyMgKElOQ0xVRElORyBORUdM SUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisj IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0Yg U1VDSCBEQU1BR0UuCisKK2lmIFtbICQjIC1uZSAxIF1dO3RoZW4KK2VjaG8gIlVzYWdlOiBidWls ZC1jb21taXQtcXVldWUuc2ggQk9UX05VTUJFUiIKK2V4aXQgMQorZmkKKworUVVFVUVfVFlQRT1j b21taXQtcXVldWUKK0JPVF9JRD1nY2UtY3EtJDEKK0JVR1pJTExBX1VTRVJOQU1FPXdlYmtpdC5y ZXZpZXcuYm90QGdtYWlsLmNvbQorcmVhZCAtcyAtcCAiQnVnemlsbGEgUGFzc3dvcmQ6ICIgQlVH WklMTEFfUEFTU1dPUkQgJiYgZWNobworCitTVk5fVVNFUk5BTUU9Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmcKK3JlYWQgLXMgLXAgIlN1YnZlcnNpb24gUGFzc3dvcmQ6ICIgU1ZOX1BBU1NXT1JEICYm IGVjaG8KKworIyBGSVhNRTogV2Ugc2hvdWxkIHVzZSBnY3V0aWwgdG8gZmluZCBhIHpvbmUgdGhh dCdzIGFjdHVhbGx5IHVwLgorWk9ORT11cy1lYXN0LWIKK0lNQUdFPXByb2plY3RzL2dvb2dsZS9p bWFnZXMvdWJ1bnR1LTEwLTA0LXYyMDEyMDYyMQorCitnY3V0aWwgYWRkaW5zdGFuY2UgJEJPVF9J RCAtLW1hY2hpbmVfdHlwZT1zdGFuZGFyZC00LWNwdS1lcGhlbWVyYWwtZGlzayAtLWltYWdlPSRJ TUFHRSAtLXpvbmU9JFpPTkUgLS13YWl0X3VudGlsX3J1bm5pbmcKKworZWNobyAiU2xlZXBpbmcg Zm9yIDMwcyB0byBsZXQgdGhlIHNlcnZlciBzcGluIHVwIHNzaC4uLiIKK3NsZWVwIDMwCisKK2dj dXRpbCBzc2ggJEJPVF9JRCAic3VkbyBhcHQtZ2V0IGluc3RhbGwgc3VidmVyc2lvbiAteSAmJiBz dm4gY2hlY2tvdXQgaHR0cDovL3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5r L1Rvb2xzL0VXU1Rvb2xzIHRvb2xzICYmIGNkIHRvb2xzICYmIGJhc2ggY29uZmlndXJlLXN2bi1h dXRoLnNoICRTVk5fVVNFUk5BTUUgJFNWTl9QQVNTV09SRCAmJiBiYXNoIGNvbGQtYm9vdC5zaCAk UVVFVUVfVFlQRSAkQk9UX0lEICRCVUdaSUxMQV9VU0VSTkFNRSAkQlVHWklMTEFfUEFTU1dPUkQi Cg==