91260 2012-07-13 10:00:06 -0700 [chromium] Remove incorrect debug assertion in LayerRendererChromium.cpp 2012-07-13 12:40:51 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh cc-bugs enne jamesr webkit.review.bot oldest_to_newest 669155 0 shawnsingh 2012-07-13 10:00:06 -0700 Bug originally reported in http://code.google.com/p/chromium/issues/detail?id=136017 ... The assertion is being triggered due to anti-aliasing inflation that causes clipping. To our knowledge, this scenario of clipping is actually tolerable, and has not yet caused any known bugs. In addition to fixing the assert, I updated comments that needed to be worded better. Patch coming in a moment 669158 1 152284 shawnsingh 2012-07-13 10:05:38 -0700 Created attachment 152284 Patch 669167 2 152284 enne 2012-07-13 10:13:33 -0700 Comment on attachment 152284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152284&action=review R=me, with comment nits. > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:703 > + // (Note, however, that it may still have perspective components in the 2d parts of the matrix.) I don't know that it's important to add this superfluous comment about perspective here. Somebody modifying this code in the future doesn't need to be made aware of this extra detail just because this comment was wrong in the past. > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:884 > + // (Note, however, that it may still have perspective components in the 2d parts of the matrix.) Same with this perspective comment. > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:-885 > - ASSERT(!clipped); I do think you need a comment about why it's ok that this quad is clipped, since we assert on clipped pretty much everywhere else. 669176 3 152288 shawnsingh 2012-07-13 10:20:52 -0700 Created attachment 152288 Patch for landing 669178 4 shawnsingh 2012-07-13 10:22:15 -0700 Thanks for the review! I'm happy to tweak the comments more if they're not good enough yet, please feel free to cq- it if needed. 669345 5 152288 webkit.review.bot 2012-07-13 12:40:46 -0700 Comment on attachment 152288 Patch for landing Clearing flags on attachment: 152288 Committed r122619: <http://trac.webkit.org/changeset/122619> 669346 6 webkit.review.bot 2012-07-13 12:40:51 -0700 All reviewed patches have been landed. Closing bug. 152284 2012-07-13 10:05:38 -0700 2012-07-13 10:20:48 -0700 Patch bug-91260-20120713100538.patch text/plain 3411 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZlNTM2ZTg1N2RiMjQx MGRiZWYwYWFlZDY0ODE3Nzc4Y2I4NmQ0Ni4uYjJlZWU0ZWU4YTg4NThjODVlNDEyZDlkNTE0N2I2 MmI4NzhhNTY4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA3LTEzICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g UmVtb3ZlIGluY29ycmVjdCBkZWJ1ZyBhc3NlcnRpb24gaW4gTGF5ZXJSZW5kZXJlckNocm9taXVt LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEy NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBU1NF UlQoIWNsaXBwZWQpIHdhcyBiZWluZyB0cmlnZ2VyZWQgYWZ0ZXIgc2tpbm55IGFsbW9zdC1kZWdl bmVyYXRlCisgICAgICAgIHF1YWRzIHdlbnQgdGhyb3VnaCBhbnRpLWFsaWFzaW5nIGluZmxhdGlv biwgYW5kIHRoZW4gd2VyZSBiZWluZworICAgICAgICB0cmFuc2Zvcm1lZCBiYWNrIGZyb20gZGV2 aWNlIHNwYWNlIHRvIGxvY2FsIHNwYWNlLiBJdCB0dXJucyBvdXQKKyAgICAgICAgdGhpcyBhc3Nl cnRpb24gaXMgdG9vIGFnZ3Jlc3NpdmUsIGFuZCB3ZSBkb24ndCB5ZXQgaGF2ZSBhbiBvYnZpb3Vz CisgICAgICAgIG5lZWQgdG8gY2hhbmdlIHRoZSBiZWhhdmlvciBvbiB0aGUgY2xpcHBlZD09dHJ1 ZSBjYXNlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQsIHRoaXMgcGF0Y2ggZml4ZXMg b25seSBjb21tZW50cyBhbmQgZGVidWcgY29kZS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdSZW5kZXJQYXNzUXVhZCk6CisgICAgICAgICAg IGZpeGVkIGEgY29tbWVudC4KKworICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9t aXVtOjpkcmF3VGlsZVF1YWQpOgorICAgICAgICAgICBmaXhlZCBhIHNpbWlsYXIgY29tbWVudCwg cmVtb3ZlZCB1bm5lY2Vzc2FyeSBhc3NlcnRpb24uCisKIDIwMTItMDctMTMgIExhdXJvIE5ldG8g IDxsYXVyby5uZXRvQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgRml4IFF0V2ViS2l0IGJ1aWxk IHdpdGggT3BlbkdMRVMgYWZ0ZXIgR0MzRC9FM0QgcmVmYWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1 bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJl bmRlcmVyQ2hyb21pdW0uY3BwCmluZGV4IDkzZDk4ZWJmNTVhNTM3ZWY2OWUyY2Y3NGQwNGY5ZmNk NTgxMjRlNDMuLmY0OWY5ODBlMDA3ZjFmOGI4NDEwMzQwYjg2N2YwZWM5OWZiNzE3MTcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVu ZGVyZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcApAQCAtNjk5LDcgKzY5OSw4IEBAIHZv aWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3UmVuZGVyUGFzc1F1YWQoY29uc3QgQ0NSZW5k ZXJQYXNzRHJhd1F1YWQqIHF1YWQpCiAgICAgICAgIEdMQyhjb250ZXh0KCksIGNvbnRleHQoKS0+ dW5pZm9ybTNmdihzaGFkZXJFZGdlTG9jYXRpb24sIDgsIGVkZ2UpKTsKICAgICB9CiAKLSAgICAv LyBNYXAgZGV2aWNlIHNwYWNlIHF1YWQgdG8gc3VyZmFjZSBzcGFjZS4gY29udGVudHNEZXZpY2VU cmFuc2Zvcm0gaGFzIG5vIHBlcnNwZWN0aXZlIHNpbmNlIGl0IHdhcyBnZW5lcmF0ZWQgd2l0aCB0 bzJkVHJhbnNmb3JtKCkgc28gd2UgZG9uJ3QgbmVlZCB0byBwcm9qZWN0LgorICAgIC8vIE1hcCBk ZXZpY2Ugc3BhY2UgcXVhZCB0byBzdXJmYWNlIHNwYWNlLiBjb250ZW50c0RldmljZVRyYW5zZm9y bSBoYXMgbm8gM2QgY29tcG9uZW50IHNpbmNlIGl0IHdhcyBnZW5lcmF0ZWQgd2l0aCB0bzJkVHJh bnNmb3JtKCkgc28gd2UgZG9uJ3QgbmVlZCB0byBwcm9qZWN0LgorICAgIC8vIChOb3RlLCBob3dl dmVyLCB0aGF0IGl0IG1heSBzdGlsbCBoYXZlIHBlcnNwZWN0aXZlIGNvbXBvbmVudHMgaW4gdGhl IDJkIHBhcnRzIG9mIHRoZSBtYXRyaXguKQogICAgIEZsb2F0UXVhZCBzdXJmYWNlUXVhZCA9IEND TWF0aFV0aWw6Om1hcFF1YWQoY29udGVudHNEZXZpY2VUcmFuc2Zvcm0uaW52ZXJzZSgpLCBkZXZp Y2VMYXllckVkZ2VzLmZsb2F0UXVhZCgpLCBjbGlwcGVkKTsKICAgICBBU1NFUlQoIWNsaXBwZWQp OwogCkBAIC04NzksMTAgKzg4MCwxMCBAQCB2b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJh d1RpbGVRdWFkKGNvbnN0IENDVGlsZURyYXdRdWFkKiBxdWFkKQogICAgICAgICAvLyBDcmVhdGUg ZGV2aWNlIHNwYWNlIHF1YWQuCiAgICAgICAgIENDTGF5ZXJRdWFkIGRldmljZVF1YWQobGVmdEVk Z2UsIHRvcEVkZ2UsIHJpZ2h0RWRnZSwgYm90dG9tRWRnZSk7CiAKLSAgICAgICAgLy8gTWFwIHF1 YWQgdG8gbGF5ZXIgc3BhY2UuCisgICAgICAgIC8vIE1hcCBkZXZpY2Ugc3BhY2UgcXVhZCB0byBs b2NhbCBzcGFjZS4gY29udGVudHNEZXZpY2VUcmFuc2Zvcm0gaGFzIG5vIDNkIGNvbXBvbmVudCBz aW5jZSBpdCB3YXMgZ2VuZXJhdGVkIHdpdGggdG8yZFRyYW5zZm9ybSgpIHNvIHdlIGRvbid0IG5l ZWQgdG8gcHJvamVjdC4KKyAgICAgICAgLy8gKE5vdGUsIGhvd2V2ZXIsIHRoYXQgaXQgbWF5IHN0 aWxsIGhhdmUgcGVyc3BlY3RpdmUgY29tcG9uZW50cyBpbiB0aGUgMmQgcGFydHMgb2YgdGhlIG1h dHJpeC4pCiAgICAgICAgIFdlYlRyYW5zZm9ybWF0aW9uTWF0cml4IGludmVyc2VEZXZpY2VUcmFu c2Zvcm0gPSBkZXZpY2VUcmFuc2Zvcm0uaW52ZXJzZSgpOwogICAgICAgICBsb2NhbFF1YWQgPSBD Q01hdGhVdGlsOjptYXBRdWFkKGludmVyc2VEZXZpY2VUcmFuc2Zvcm0sIGRldmljZVF1YWQuZmxv YXRRdWFkKCksIGNsaXBwZWQpOwotICAgICAgICBBU1NFUlQoIWNsaXBwZWQpOwogICAgIH0gZWxz ZSB7CiAgICAgICAgIC8vIE1vdmUgZnJhZ21lbnQgc2hhZGVyIHRyYW5zZm9ybSB0byB2ZXJ0ZXgg c2hhZGVyLiBXZSBjYW4gZG8gdGhpcyB3aGlsZQogICAgICAgICAvLyBzdGlsbCBwcm9kdWNpbmcg Y29ycmVjdCByZXN1bHRzIGFzIGZyYWdtZW50VGV4VHJhbnNmb3JtTG9jYXRpb24K 152288 2012-07-13 10:20:52 -0700 2012-07-13 12:40:46 -0700 Patch for landing bug-91260-20120713102052.patch text/plain 3436 shawnsingh U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDZlNTM2ZTg1N2RiMjQx MGRiZWYwYWFlZDY0ODE3Nzc4Y2I4NmQ0Ni4uNzIxMzliMmIwOTAxY2UyODYzODNhM2Y2ZDlhY2E2 MmIyMWJkMmUxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA3LTEzICBTaGF3 biBTaW5naCAgPHNoYXduc2luZ2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0g UmVtb3ZlIGluY29ycmVjdCBkZWJ1ZyBhc3NlcnRpb24gaW4gTGF5ZXJSZW5kZXJlckNocm9taXVt LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEy NjAKKworICAgICAgICBSZXZpZXdlZCBieSBBZHJpZW5uZSBXYWxrZXIuCisKKyAgICAgICAgQVNT RVJUKCFjbGlwcGVkKSB3YXMgYmVpbmcgdHJpZ2dlcmVkIGFmdGVyIHNraW5ueSBhbG1vc3QtZGVn ZW5lcmF0ZQorICAgICAgICBxdWFkcyB3ZW50IHRocm91Z2ggYW50aS1hbGlhc2luZyBpbmZsYXRp b24sIGFuZCB0aGVuIHdlcmUgYmVpbmcKKyAgICAgICAgdHJhbnNmb3JtZWQgYmFjayBmcm9tIGRl dmljZSBzcGFjZSB0byBsb2NhbCBzcGFjZS4gSXQgdHVybnMgb3V0CisgICAgICAgIHRoaXMgYXNz ZXJ0aW9uIGlzIHRvbyBhZ2dyZXNzaXZlLCBhbmQgd2UgZG9uJ3QgeWV0IGhhdmUgYW4gb2J2aW91 cworICAgICAgICBuZWVkIHRvIGNoYW5nZSB0aGUgYmVoYXZpb3Igb24gdGhlIGNsaXBwZWQ9PXRy dWUgY2FzZS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLCB0aGlzIHBhdGNoIGZpeGVz IG9ubHkgY29tbWVudHMgYW5kIGRlYnVnIGNvZGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3UmVuZGVyUGFzc1F1YWQpOgorICAgICAgICAg ICBmaXhlZCBhIGNvbW1lbnQuCisKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJv bWl1bTo6ZHJhd1RpbGVRdWFkKToKKyAgICAgICAgICAgZml4ZWQgYSBzaW1pbGFyIGNvbW1lbnQs IHJlbW92ZWQgdW5uZWNlc3NhcnkgYXNzZXJ0aW9uLgorCiAyMDEyLTA3LTEzICBMYXVybyBOZXRv ICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIEZpeCBRdFdlYktpdCBidWls ZCB3aXRoIE9wZW5HTEVTIGFmdGVyIEdDM0QvRTNEIHJlZmFjdG9yCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21p dW0uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJS ZW5kZXJlckNocm9taXVtLmNwcAppbmRleCA5M2Q5OGViZjU1YTUzN2VmNjllMmNmNzRkMDRmOWZj ZDU4MTI0ZTQzLi5hNzI2NzQxNDBlYWM0MDdhMjcyYjVmNGJkYWQ2NjE1ZTU0YmE1NDFhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJl bmRlcmVyQ2hyb21pdW0uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKQEAgLTY5OSw3ICs2OTksNyBAQCB2 b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd1JlbmRlclBhc3NRdWFkKGNvbnN0IENDUmVu ZGVyUGFzc0RyYXdRdWFkKiBxdWFkKQogICAgICAgICBHTEMoY29udGV4dCgpLCBjb250ZXh0KCkt PnVuaWZvcm0zZnYoc2hhZGVyRWRnZUxvY2F0aW9uLCA4LCBlZGdlKSk7CiAgICAgfQogCi0gICAg Ly8gTWFwIGRldmljZSBzcGFjZSBxdWFkIHRvIHN1cmZhY2Ugc3BhY2UuIGNvbnRlbnRzRGV2aWNl VHJhbnNmb3JtIGhhcyBubyBwZXJzcGVjdGl2ZSBzaW5jZSBpdCB3YXMgZ2VuZXJhdGVkIHdpdGgg dG8yZFRyYW5zZm9ybSgpIHNvIHdlIGRvbid0IG5lZWQgdG8gcHJvamVjdC4KKyAgICAvLyBNYXAg ZGV2aWNlIHNwYWNlIHF1YWQgdG8gc3VyZmFjZSBzcGFjZS4gY29udGVudHNEZXZpY2VUcmFuc2Zv cm0gaGFzIG5vIDNkIGNvbXBvbmVudCBzaW5jZSBpdCB3YXMgZ2VuZXJhdGVkIHdpdGggdG8yZFRy YW5zZm9ybSgpIHNvIHdlIGRvbid0IG5lZWQgdG8gcHJvamVjdC4KICAgICBGbG9hdFF1YWQgc3Vy ZmFjZVF1YWQgPSBDQ01hdGhVdGlsOjptYXBRdWFkKGNvbnRlbnRzRGV2aWNlVHJhbnNmb3JtLmlu dmVyc2UoKSwgZGV2aWNlTGF5ZXJFZGdlcy5mbG9hdFF1YWQoKSwgY2xpcHBlZCk7CiAgICAgQVNT RVJUKCFjbGlwcGVkKTsKIApAQCAtODc5LDEwICs4NzksMTIgQEAgdm9pZCBMYXllclJlbmRlcmVy Q2hyb21pdW06OmRyYXdUaWxlUXVhZChjb25zdCBDQ1RpbGVEcmF3UXVhZCogcXVhZCkKICAgICAg ICAgLy8gQ3JlYXRlIGRldmljZSBzcGFjZSBxdWFkLgogICAgICAgICBDQ0xheWVyUXVhZCBkZXZp Y2VRdWFkKGxlZnRFZGdlLCB0b3BFZGdlLCByaWdodEVkZ2UsIGJvdHRvbUVkZ2UpOwogCi0gICAg ICAgIC8vIE1hcCBxdWFkIHRvIGxheWVyIHNwYWNlLgorICAgICAgICAvLyBNYXAgZGV2aWNlIHNw YWNlIHF1YWQgdG8gbG9jYWwgc3BhY2UuIGNvbnRlbnRzRGV2aWNlVHJhbnNmb3JtIGhhcyBubyAz ZCBjb21wb25lbnQgc2luY2UgaXQgd2FzIGdlbmVyYXRlZCB3aXRoIHRvMmRUcmFuc2Zvcm0oKSBz byB3ZSBkb24ndCBuZWVkIHRvIHByb2plY3QuCiAgICAgICAgIFdlYlRyYW5zZm9ybWF0aW9uTWF0 cml4IGludmVyc2VEZXZpY2VUcmFuc2Zvcm0gPSBkZXZpY2VUcmFuc2Zvcm0uaW52ZXJzZSgpOwog ICAgICAgICBsb2NhbFF1YWQgPSBDQ01hdGhVdGlsOjptYXBRdWFkKGludmVyc2VEZXZpY2VUcmFu c2Zvcm0sIGRldmljZVF1YWQuZmxvYXRRdWFkKCksIGNsaXBwZWQpOwotICAgICAgICBBU1NFUlQo IWNsaXBwZWQpOworCisgICAgICAgIC8vIFdlIHNob3VsZCBub3QgQVNTRVJUKCFjbGlwcGVkKSBo ZXJlLCBiZWNhdXNlIGFudGktYWxpYXNpbmcgaW5mbGF0aW9uIG1heSBjYXVzZSBkZXZpY2VRdWFk IHRvIGJlY29tZQorICAgICAgICAvLyBjbGlwcGVkLiAgVG8gb3VyIGtub3dsZWRnZSB0aGlzIHNj ZW5hcmlvIGRvZXMgbm90IG5lZWQgdG8gYmUgaGFuZGxlZCBkaWZmZXJlbnRseSB0aGFuIHRoZSB1 bmNsaXBwZWQgY2FzZS4KICAgICB9IGVsc2UgewogICAgICAgICAvLyBNb3ZlIGZyYWdtZW50IHNo YWRlciB0cmFuc2Zvcm0gdG8gdmVydGV4IHNoYWRlci4gV2UgY2FuIGRvIHRoaXMgd2hpbGUKICAg ICAgICAgLy8gc3RpbGwgcHJvZHVjaW5nIGNvcnJlY3QgcmVzdWx0cyBhcyBmcmFnbWVudFRleFRy YW5zZm9ybUxvY2F0aW9uCg==