91245 2012-07-13 07:44:59 -0700 webkit_unit_test CCLayerTreeHostImplTest.testRemoveRenderPasses started failing. 2012-07-13 10:55:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 vsevik danakj danakj enne oldest_to_newest 669025 0 vsevik 2012-07-13 07:44:59 -0700 CCLayerTreeHostImplTest.testRemoveRenderPasses fails on Chromium Linux build. Probably caused by: http://trac.webkit.org/changeset/122525 See: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%2032/builds/20930 669028 1 vsevik 2012-07-13 07:49:00 -0700 Skipped: http://trac.webkit.org/changeset/122576 669080 2 danakj 2012-07-13 08:49:34 -0700 A better bot backtrace: base::debug::StackTrace::StackTrace() [0x7fc4cb993592] base::(anonymous namespace)::StackDumpSignalHandler() [0x7fc4cb9f85a5] 0x7fc4c4929af0 WTF::OwnPtr<>::operator->() [0x7fc4cde270a0] (anonymous namespace)::configureRenderPassTestData() [0x7fc4cde1644d] (anonymous namespace)::CCLayerTreeHostImplTest_testRemoveRenderPasses_Test::TestBody() [0x7fc4cde16abc] 669081 3 152270 danakj 2012-07-13 08:49:45 -0700 Created attachment 152270 Patch The test won't crash for me locally. >_< From examing the code, this is the only iffy thing I can see. Do you think it would be a good condidate to fix the problem, enne? 669088 4 enne 2012-07-13 08:53:47 -0700 (In reply to comment #3) > Created an attachment (id=152270) [details] > Patch > > The test won't crash for me locally. >_< > > From examing the code, this is the only iffy thing I can see. Do you think it would be a good condidate to fix the problem, enne? That really doesn't look like it should be null. Is this a debug vs. release issue? Does a try job crash for you, and can you try the patch there? 669157 5 danakj 2012-07-13 10:04:50 -0700 Idk what's up with the trybots but I am unable to apply this change. Even if I remove everything except the "fix". It seems like the trybots are maybe sitting at some version prior to the breaking even occuring. Either way, I think this change is needed, as it is valid for the compiler to release() the pointer before we deref it for the id(). 669159 6 152270 enne 2012-07-13 10:06:48 -0700 Comment on attachment 152270 Patch R=me. I can buy that argument that renderPass could be null here if the args are evaluated right-to-left. Let's give this a try. Please watch the bots when you land this. 669202 7 danakj 2012-07-13 10:29:23 -0700 Committed r122602: <http://trac.webkit.org/changeset/122602> 669237 8 danakj 2012-07-13 10:55:50 -0700 Looks like the bots went green :D 152270 2012-07-13 08:49:45 -0700 2012-07-13 10:28:18 -0700 Patch bug-91245-20120713114944.patch text/plain 1914 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDQzYzJhNzMyZWQ3NWEwMTJjOGZlMGU1ZDRmZDkyN2I3NjQ1OTQwOWUuLmMxNThjMDk0OWI1YmY3 NDQzYzY2MmVmMjFmZjcyYTk4ODU3ZTlkOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDctMTMgIERhbmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgd2Via2l0X3VuaXRfdGVzdCBDQ0xheWVyVHJlZUhvc3RJbXBsVGVz dC50ZXN0UmVtb3ZlUmVuZGVyUGFzc2VzIHN0YXJ0ZWQgZmFpbGluZy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMjQ1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0ZXN0cy9DQ0xheWVyVHJlZUhvc3RJ bXBsVGVzdC5jcHA6CisKIDIwMTItMDctMTMgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCBnYXJkZW5pbmc6IHNraXAgZmFpbGluZyB3 ZWJraXQgdW5pdCB0ZXN0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9DQ0xheWVyVHJlZUhvc3RJbXBsVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL0NDTGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcAppbmRleCAwNWQ2MTBhMTFiZjRiNDhkMjE3 MjM1NzkyMTkwZTgyYTE4MGNlOGVhLi5jYjJiN2YzNmZhNzU0MzkwOWIwMDI4MWQ1ZDliMTU5MjY4 ZDg2NTU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NDTGF5ZXJU cmVlSG9zdEltcGxUZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0ND TGF5ZXJUcmVlSG9zdEltcGxUZXN0LmNwcApAQCAtMzA0Niw3ICszMDQ2LDcgQEAgc3RhdGljIHZv aWQgY29uZmlndXJlUmVuZGVyUGFzc1Rlc3REYXRhKGNvbnN0IGNoYXIqIHRlc3RTY3JpcHQsIFJl bmRlclBhc3NSZW1vdmEKICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICB0ZXN0RGF0 YS5yZW5kZXJQYXNzZXMuaW5zZXJ0KDAsIHJlbmRlclBhc3MuZ2V0KCkpOwotICAgICAgICB0ZXN0 RGF0YS5yZW5kZXJQYXNzZXNCeUlkLmFkZChyZW5kZXJQYXNzLT5pZCgpLCByZW5kZXJQYXNzLnJl bGVhc2UoKSk7CisgICAgICAgIHRlc3REYXRhLnJlbmRlclBhc3Nlc0J5SWQuYWRkKHJlbmRlclBh c3NJZCwgcmVuZGVyUGFzcy5yZWxlYXNlKCkpOwogICAgICAgICBpZiAoKmN1cnJlbnRDaGFyKQog ICAgICAgICAgICAgY3VycmVudENoYXIrKzsKICAgICB9CkBAIC0zMjM0LDcgKzMyMzQsNyBAQCBz dGF0aWMgdm9pZCB2ZXJpZnlSZW5kZXJQYXNzVGVzdERhdGEoVGVzdENhc2UmIHRlc3RDYXNlLCBS ZW5kZXJQYXNzUmVtb3ZhbFRlc3REYQogICAgIEVYUEVDVF9TVFJFUSh0ZXN0Q2FzZS5leHBlY3Rl ZFJlc3VsdCwgYWN0dWFsUmVzdWx0KSA8PCAiSW4gdGVzdCBjYXNlOiAiIDw8IHRlc3RDYXNlLm5h bWU7CiB9CiAKLVRFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgRElTQUJMRURfdGVzdFJl bW92ZVJlbmRlclBhc3NlcykKK1RFU1RfRihDQ0xheWVyVHJlZUhvc3RJbXBsVGVzdCwgdGVzdFJl bW92ZVJlbmRlclBhc3NlcykKIHsKICAgICBPd25QdHI8Q0NHcmFwaGljc0NvbnRleHQ+IGNvbnRl eHQoY3JlYXRlQ29udGV4dCgpKTsKICAgICBXZWJLaXQ6OldlYkdyYXBoaWNzQ29udGV4dDNEKiBj b250ZXh0M2QgPSBjb250ZXh0LT5jb250ZXh0M0QoKTsK