91243 2012-07-13 07:36:35 -0700 [WIN] Fix compilation of JSGlobalData.h with ENABLE(DFG_JIT) 2012-07-19 11:21:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Windows 7 RESOLVED FIXED P2 Normal --- 1 paroga paroga barraclough fpizlo ggaren oliver webkit.review.bot oldest_to_newest 669017 0 paroga 2012-07-13 07:36:35 -0700 [WIN] Fix compilation of JSGlobalData.h with ENABLE(DFG_JIT) 669021 1 152259 paroga 2012-07-13 07:39:43 -0700 Created attachment 152259 Patch 669048 2 152259 buildbot 2012-07-13 08:09:36 -0700 Comment on attachment 152259 Patch Attachment 152259 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13238133 669068 3 152259 webkit-ews 2012-07-13 08:35:25 -0700 Comment on attachment 152259 Patch Attachment 152259 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13221675 669075 4 152259 webkit-ews 2012-07-13 08:41:49 -0700 Comment on attachment 152259 Patch Attachment 152259 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13245067 669082 5 152259 ggaren 2012-07-13 08:50:32 -0700 Comment on attachment 152259 Patch Looks like you need #ifdefs around the #pragma. 669122 6 152277 paroga 2012-07-13 09:23:07 -0700 Created attachment 152277 Patch (In reply to comment #5) > (From update of attachment 152259 [details]) > Looks like you need #ifdefs around the #pragma. Yup. Added. 673276 7 paroga 2012-07-19 01:04:53 -0700 ping? 673688 8 152277 ggaren 2012-07-19 11:00:45 -0700 Comment on attachment 152277 Patch r=me 673716 9 152277 webkit.review.bot 2012-07-19 11:21:06 -0700 Comment on attachment 152277 Patch Clearing flags on attachment: 152277 Committed r123125: <http://trac.webkit.org/changeset/123125> 673717 10 webkit.review.bot 2012-07-19 11:21:11 -0700 All reviewed patches have been landed. Closing bug. 152259 2012-07-13 07:39:43 -0700 2012-07-13 09:23:07 -0700 Patch bug-91243.patch text/plain 1424 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ1ZjJhNDEuLmRiN2VkYzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTEzICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFtXSU5dIEZpeCBjb21waWxhdGlv biBvZiBKU0dsb2JhbERhdGEuaCB3aXRoIEVOQUJMRShERkdfSklUKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEyNDMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlIE1TVkMgd2FybmluZyA0MjAw ICJ6ZXJvLXNpemVkIGFycmF5IGluIHN0cnVjdC91bmlvbiIgZm9yIEpTQzo6U2NyYXRjaEJ1ZmZl ci4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxEYXRhLmg6CisgICAgICAgIChKU0MpOgor CiAyMDEyLTA3LTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg REZHIHByb3BlcnR5IGFjY2VzcyBzdHVicyBzaG91bGQgdXNlIHN0cnVjdHVyZSB0cmFuc2l0aW9u IHdhdGNocG9pbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0dsb2JhbERhdGEuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0 YS5oCmluZGV4IDkwOTI1NzcuLmEwNjYwZDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0YS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTR2xvYmFsRGF0YS5oCkBAIC0xMjksNiArMTI5LDggQEAgbmFtZXNwYWNlIEpTQyB7 CiAjaWYgRU5BQkxFKERGR19KSVQpCiAgICAgY2xhc3MgQ29uc2VydmF0aXZlUm9vdHM7CiAKKyNw cmFnbWEgd2FybmluZyhwdXNoKQorI3ByYWdtYSB3YXJuaW5nKGRpc2FibGU6IDQyMDApIC8vIERp c2FibGUgInplcm8tc2l6ZWQgYXJyYXkgaW4gc3RydWN0L3VuaW9uIiB3YXJuaW5nCiAgICAgc3Ry dWN0IFNjcmF0Y2hCdWZmZXIgewogICAgICAgICBTY3JhdGNoQnVmZmVyKCkKICAgICAgICAgICAg IDogbV9hY3RpdmVMZW5ndGgoMCkKQEAgLTE1MSw2ICsxNTMsNyBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICAgICAgc2l6ZV90IG1fYWN0aXZlTGVuZ3RoOwogICAgICAgICB2b2lkKiBtX2J1ZmZlclsw XTsKICAgICB9OworI3ByYWdtYSB3YXJuaW5nKHBvcCkKICNlbmRpZgogCiAgICAgY2xhc3MgSlNH bG9iYWxEYXRhIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPEpTR2xvYmFsRGF0YT4gewo= 152277 2012-07-13 09:23:07 -0700 2012-07-19 11:21:06 -0700 Patch bug-91243.patch text/plain 1482 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGQ1ZjJhNDEuLmRiN2VkYzEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTEzICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFtXSU5dIEZpeCBjb21waWxhdGlv biBvZiBKU0dsb2JhbERhdGEuaCB3aXRoIEVOQUJMRShERkdfSklUKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTEyNDMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEaXNhYmxlIE1TVkMgd2FybmluZyA0MjAw ICJ6ZXJvLXNpemVkIGFycmF5IGluIHN0cnVjdC91bmlvbiIgZm9yIEpTQzo6U2NyYXRjaEJ1ZmZl ci4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxEYXRhLmg6CisgICAgICAgIChKU0MpOgor CiAyMDEyLTA3LTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg REZHIHByb3BlcnR5IGFjY2VzcyBzdHVicyBzaG91bGQgdXNlIHN0cnVjdHVyZSB0cmFuc2l0aW9u IHdhdGNocG9pbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U0dsb2JhbERhdGEuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0 YS5oCmluZGV4IDkwOTI1NzcuLjU5YTY3MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0YS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTR2xvYmFsRGF0YS5oCkBAIC0xMjksNiArMTI5LDEwIEBAIG5hbWVzcGFjZSBKU0Mg ewogI2lmIEVOQUJMRShERkdfSklUKQogICAgIGNsYXNzIENvbnNlcnZhdGl2ZVJvb3RzOwogCisj aWYgQ09NUElMRVIoTVNWQykKKyNwcmFnbWEgd2FybmluZyhwdXNoKQorI3ByYWdtYSB3YXJuaW5n KGRpc2FibGU6IDQyMDApIC8vIERpc2FibGUgInplcm8tc2l6ZWQgYXJyYXkgaW4gc3RydWN0L3Vu aW9uIiB3YXJuaW5nCisjZW5kaWYKICAgICBzdHJ1Y3QgU2NyYXRjaEJ1ZmZlciB7CiAgICAgICAg IFNjcmF0Y2hCdWZmZXIoKQogICAgICAgICAgICAgOiBtX2FjdGl2ZUxlbmd0aCgwKQpAQCAtMTUx LDYgKzE1NSw5IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICBzaXplX3QgbV9hY3RpdmVMZW5n dGg7CiAgICAgICAgIHZvaWQqIG1fYnVmZmVyWzBdOwogICAgIH07CisjaWYgQ09NUElMRVIoTVNW QykKKyNwcmFnbWEgd2FybmluZyhwb3ApCisjZW5kaWYKICNlbmRpZgogCiAgICAgY2xhc3MgSlNH bG9iYWxEYXRhIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPEpTR2xvYmFsRGF0YT4gewoK