91223 2012-07-13 05:25:56 -0700 [GTK] Silence grep stderr in build-webkit when detecting the current arch 2013-07-12 11:58:33 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 emanuele.aina webkit-unassigned commit-queue dbates eric mrobinson oldest_to_newest 668908 0 152226 emanuele.aina 2012-07-13 05:25:56 -0700 Created attachment 152226 Ignore missing GNUmakefile when detecting previour arch in build-wekit When run on a clean checkout, `build-webkit' complains that no GNUmakefile exists when trying to detect the previously configured architecture, but in this case there's no previous configuration so the warning is pointless. Ignoring the error message by redirecting grep stderr to /dev/null should be safe, patch attached. 693209 1 152226 eric 2012-08-12 03:29:14 -0700 Comment on attachment 152226 Ignore missing GNUmakefile when detecting previour arch in build-wekit OK. But this needs a ChangeLog. 908001 2 206554 emanuele.aina 2013-07-12 10:47:25 -0700 Created attachment 206554 Patch 908003 3 206554 mrobinson 2013-07-12 10:52:07 -0700 Comment on attachment 206554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206554&action=review > Tools/ChangeLog:6 > + Reviewed by Eric Seidel. I think maybe this is a copy and paste error. 908008 4 206556 emanuele.aina 2013-07-12 10:59:13 -0700 Created attachment 206556 Patch Use OOPS to automatically generate a proper 'Reviewed by' line in the ChangeLog 908009 5 206556 mrobinson 2013-07-12 11:01:21 -0700 Comment on attachment 206556 Patch Thanks! 908010 6 emanuele.aina 2013-07-12 11:03:40 -0700 (In reply to comment #3) > > + Reviewed by Eric Seidel. > I think maybe this is a copy and paste error. Erhm, no, since Eric already said OK to the patch and just mentioned the lack of proper ChangeLog entry I assumed it would have been fine to indicate him as reviewer. But since you taught me about the OOPS magic this seems to be a good candidate to try it out. :D However, thanks for the reviews! 908012 7 mrobinson 2013-07-12 11:05:38 -0700 Ah, sorry. Didn't see that. 908029 8 206556 commit-queue 2013-07-12 11:58:31 -0700 Comment on attachment 206556 Patch Clearing flags on attachment: 206556 Committed r152601: <http://trac.webkit.org/changeset/152601> 908030 9 commit-queue 2013-07-12 11:58:33 -0700 All reviewed patches have been landed. Closing bug. 152226 2012-07-13 05:25:56 -0700 2013-07-12 10:47:17 -0700 Ignore missing GNUmakefile when detecting previour arch in build-wekit build-webkit-ignore-grep-missing-file.patch text/plain 623 emanuele.aina ZGlmZiAtLWdpdCBpL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSB3L1Rvb2xzL1NjcmlwdHMv d2Via2l0ZGlycy5wbQppbmRleCAyZGE4NzU1Li5hODY2MWFkIDEwMDc1NQotLS0gaS9Ub29scy9T Y3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIHcvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBA IC0zMTEsNyArMzExLDcgQEAgc3ViIGRldGVybWluZUFyY2hpdGVjdHVyZQogCiAgICAgaWYgKGlz R3RrKCkgfHwgaXNDbHV0dGVyKCkpIHsKICAgICAgICAgZGV0ZXJtaW5lQ29uZmlndXJhdGlvblBy b2R1Y3REaXIoKTsKLSAgICAgICAgbXkgJGhvc3RfdHJpcGxlID0gYGdyZXAgLUUgJ15ob3N0ID0g JyAkY29uZmlndXJhdGlvblByb2R1Y3REaXIvR05VbWFrZWZpbGVgOworICAgICAgICBteSAkaG9z dF90cmlwbGUgPSBgZ3JlcCAtRSAnXmhvc3QgPSAnICRjb25maWd1cmF0aW9uUHJvZHVjdERpci9H TlVtYWtlZmlsZSAyPiAvZGV2L251bGxgOwogICAgICAgICBpZiAoJGhvc3RfdHJpcGxlID1+IG0v Xmhvc3QgPSAoW14tXSspLS8pIHsKICAgICAgICAgICAgICMgV2UgaGF2ZSBhIGNvbmZpZ3VyZWQg YnVpbGQgdHJlZTsgdXNlIGl0LgogICAgICAgICAgICAgJGFyY2hpdGVjdHVyZSA9ICQxOwo= 206554 2013-07-12 10:47:25 -0700 2013-07-12 10:59:06 -0700 Patch bug-91223-20130712174507.patch text/plain 1665 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTcwMzkxMTg3ZTQxOTg3M2I2ZWU1MjZlZjE3OTVlYWMw NmUyODQ0ZS4uOTc1ZDU5ZWYxNjBhM2VlOTg2ZmMxNWFhNWYxY2M1ZTQ2ZTE5ZjdlZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTA3LTEyICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEu Y29tPgorCisgICAgICAgIFtUb29sc10gSWdub3JlIG1pc3NpbmcgR05VbWFrZWZpbGUgd2hlbiBk ZXRlY3RpbmcgcHJldmlvdXMgYXJjaCBpbiBidWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMjIzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgRXJpYyBTZWlkZWwuCisKKyAgICAgICAgV2hlbiBydW4gb24gYSBjbGVhbiBjaGVja291dCwg YGJ1aWxkLXdlYmtpdGAgY29tcGxhaW5zIHRoYXQgbm8KKyAgICAgICAgR05VbWFrZWZpbGUgZXhp c3RzIHdoZW4gdHJ5aW5nIHRvIGRldGVjdCB0aGUgcHJldmlvdXNseSBjb25maWd1cmVkCisgICAg ICAgIGFyY2hpdGVjdHVyZSwgYnV0IGluIHRoaXMgY2FzZSB0aGVyZSdzIG5vIHByZXZpb3VzIGNv bmZpZ3VyYXRpb24gc28KKyAgICAgICAgdGhlIHdhcm5pbmcgaXMgcG9pbnRsZXNzLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZGV0ZXJtaW5lQXJjaGl0ZWN0 dXJlKTogUmVkaXJlY3QgZ3JlcCBzdGRlcnIgdG8gL2Rldi9udWxsLgorCiAyMDEzLTA3LTEwICBT ZXJnaW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAg SGFuZGxlICJsb2FkLHByb3Zpc2lvbmFsLGZhaWxlZCIgd2l0aCB0aGUgb25fZXJyb3IgY2FsbGJh Y2sgb24gRUZMIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNTg5ODBkNzJmNDcwMzE1 ZWUzNGE3ZGFmODY1OGMxZDJhZTBhYmVkYy4uY2MzMGIxNmY1OTYyY2RlZGJiMDAzOTM5OGRiZmJm OTllZGUxZWNiYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjk0LDcgKzI5NCw3IEBAIHN1YiBkZXRl cm1pbmVBcmNoaXRlY3R1cmUKIAogICAgIGlmIChpc0d0aygpKSB7CiAgICAgICAgIGRldGVybWlu ZUNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyKCk7Ci0gICAgICAgIG15ICRob3N0X3RyaXBsZSA9IGBn cmVwIC1FICdeaG9zdCA9ICcgJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyL0dOVW1ha2VmaWxlYDsK KyAgICAgICAgbXkgJGhvc3RfdHJpcGxlID0gYGdyZXAgLUUgJ15ob3N0ID0gJyAkY29uZmlndXJh dGlvblByb2R1Y3REaXIvR05VbWFrZWZpbGUgMj4gL2Rldi9udWxsYDsKICAgICAgICAgaWYgKCRo b3N0X3RyaXBsZSA9fiBtL15ob3N0ID0gKFteLV0rKS0vKSB7CiAgICAgICAgICAgICAjIFdlIGhh dmUgYSBjb25maWd1cmVkIGJ1aWxkIHRyZWU7IHVzZSBpdC4KICAgICAgICAgICAgICRhcmNoaXRl Y3R1cmUgPSAkMTsK 206556 2013-07-12 10:59:13 -0700 2013-07-12 11:58:31 -0700 Patch bug-91223-20130712175655.patch text/plain 1668 emanuele.aina U3VidmVyc2lvbiBSZXZpc2lvbjogMTUyNTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTcwMzkxMTg3ZTQxOTg3M2I2ZWU1MjZlZjE3OTVlYWMw NmUyODQ0ZS4uYzJlYjJlYmM0YmM1YWZhMjZkOTcyYmUxMDAwNGUyZTIwNGNhNjZhYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEzLTA3LTEyICBFbWFudWVsZSBBaW5hICA8ZW1hbnVlbGUuYWluYUBjb2xsYWJvcmEu Y29tPgorCisgICAgICAgIFtUb29sc10gSWdub3JlIG1pc3NpbmcgR05VbWFrZWZpbGUgd2hlbiBk ZXRlY3RpbmcgcHJldmlvdXMgYXJjaCBpbiBidWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMjIzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBydW4gb24gYSBjbGVhbiBjaGVja291 dCwgYGJ1aWxkLXdlYmtpdGAgY29tcGxhaW5zIHRoYXQgbm8KKyAgICAgICAgR05VbWFrZWZpbGUg ZXhpc3RzIHdoZW4gdHJ5aW5nIHRvIGRldGVjdCB0aGUgcHJldmlvdXNseSBjb25maWd1cmVkCisg ICAgICAgIGFyY2hpdGVjdHVyZSwgYnV0IGluIHRoaXMgY2FzZSB0aGVyZSdzIG5vIHByZXZpb3Vz IGNvbmZpZ3VyYXRpb24gc28KKyAgICAgICAgdGhlIHdhcm5pbmcgaXMgcG9pbnRsZXNzLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoZGV0ZXJtaW5lQXJjaGl0 ZWN0dXJlKTogUmVkaXJlY3QgZ3JlcCBzdGRlcnIgdG8gL2Rldi9udWxsLgorCiAyMDEzLTA3LTEw ICBTZXJnaW8gQ29ycmVpYSAgPHNlcmdpby5jb3JyZWlhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAg ICAgSGFuZGxlICJsb2FkLHByb3Zpc2lvbmFsLGZhaWxlZCIgd2l0aCB0aGUgb25fZXJyb3IgY2Fs bGJhY2sgb24gRUZMIE1pbmlCcm93c2VyCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNTg5ODBkNzJmNDcw MzE1ZWUzNGE3ZGFmODY1OGMxZDJhZTBhYmVkYy4uY2MzMGIxNmY1OTYyY2RlZGJiMDAzOTM5OGRi ZmJmOTllZGUxZWNiYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjk0LDcgKzI5NCw3IEBAIHN1YiBk ZXRlcm1pbmVBcmNoaXRlY3R1cmUKIAogICAgIGlmIChpc0d0aygpKSB7CiAgICAgICAgIGRldGVy bWluZUNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyKCk7Ci0gICAgICAgIG15ICRob3N0X3RyaXBsZSA9 IGBncmVwIC1FICdeaG9zdCA9ICcgJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyL0dOVW1ha2VmaWxl YDsKKyAgICAgICAgbXkgJGhvc3RfdHJpcGxlID0gYGdyZXAgLUUgJ15ob3N0ID0gJyAkY29uZmln dXJhdGlvblByb2R1Y3REaXIvR05VbWFrZWZpbGUgMj4gL2Rldi9udWxsYDsKICAgICAgICAgaWYg KCRob3N0X3RyaXBsZSA9fiBtL15ob3N0ID0gKFteLV0rKS0vKSB7CiAgICAgICAgICAgICAjIFdl IGhhdmUgYSBjb25maWd1cmVkIGJ1aWxkIHRyZWU7IHVzZSBpdC4KICAgICAgICAgICAgICRhcmNo aXRlY3R1cmUgPSAkMTsK