91220 2012-07-13 04:32:29 -0700 [GTK] WebKit2 crash when going back/forward 2012-07-17 03:03:48 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Critical --- 91482 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 668871 0 cgarcia 2012-07-13 04:32:29 -0700 I assumed that when load-committed signal is emitted for the main frame, the signals for the main resource had already been fired. That's indeed what happens when the page is normally loaded, but when the page is loaded from the backforward list, we don't even have a main resource when the loadcommitted signal is emitted. 668877 1 152219 cgarcia 2012-07-13 04:41:11 -0700 Created attachment 152219 Patch Patch to fix the crash, I'll file a new bug for the callbacks emisson order issue. 668880 2 webkit.review.bot 2012-07-13 04:44:03 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 668889 3 152219 xan.lopez 2012-07-13 05:00:36 -0700 Comment on attachment 152219 Patch OK. 668895 4 cgarcia 2012-07-13 05:08:19 -0700 Committed r122567: <http://trac.webkit.org/changeset/122567> 152219 2012-07-13 04:41:11 -0700 2012-07-13 05:00:36 -0700 Patch wk2-bf-crash.diff text/plain 2465 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjOTAwODVjLi40OTZiNTgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDctMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYktpdDIgY3Jhc2ggd2hlbiBnb2luZyBiYWNrL2ZvcndhcmQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMjIwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIHNvbWUg cmVhc29uIHdoZW4gYSBwYWdlIGlzIGxvYWRlZCBmcm9tIHRoZSBiYWNrZm9yd2FyZCBsaXN0LAor ICAgICAgICB3aGVuIHRoZSBkaWRDb21taXRMb2FkRm9yRnJhbWUgY2FsbGJhY2sgaXMgY2FsbGVk IGZvciB0aGUgbWFpbgorICAgICAgICBmcmFtZSwgdGhlIGNhbGxiYWNrIGRpZEluaXRpYXRlTG9h ZEZvclJlc291cmNlIGhhc24ndCBiZWVuIGNhbGxlZAorICAgICAgICB5ZXQsIHNvIHdlIGRvbid0 IGV2ZW4gaGF2ZSBhIG1haW4gcmVzb3VyY2UgYXQgdGhhdCBwb2ludC4gV2Ugd2VyZQorICAgICAg ICBhc3N1bWluZyB3ZSBhbHdheXMgaGFkIGEgbWFpbiByZXNvdXJjZSB3aXRoIGEgcmVzcG9uc2Uu IEZvciBub3cgd2UKKyAgICAgICAganVzdCBjaGVjayB3aGV0aGVyIHdlIGhhdmUgYSByZXNvdXJj ZSBiZWZvcmUgdHJ5aW5nIHRvIHNldCB0aGUKKyAgICAgICAgY2VydGlmaWNhdGUgdG8gZml4IHRo ZSBjcmFzaCwgYnV0IHdlIG5lZWQgdG8gZmlndWUgb3V0IHdoeSB0aGlzIGlzCisgICAgICAgIGhh cHBlbmluZyBhbiBob3cgdG8gcHJvcGVybHkgZml4IGl0LgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKGRpZENvbW1pdExvYWRG b3JGcmFtZSk6IENoZWNrIHdoZXRoZXIgd2UgaGF2ZSBhIG1haW4gcmVzb3VyY2UKKyAgICAgICAg YmVmb3JlIHNldHRpbmcgdGhlIGNlcnRpZmljYXRlLgorCiAyMDEyLTA3LTEyICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgQVBJ IHRvIGdldCBIVFRQUyBzdGF0dXMgdG8gV2ViS2l0MiBHVEsrCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0TG9hZGVyQ2xpZW50LmNwcAppbmRleCA0 ZjQwODNkLi44Y2QxNDljIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdExvYWRlckNsaWVudC5jcHAKQEAgLTY2LDggKzY2LDEzIEBAIHN0YXRp YyB2b2lkIGRpZENvbW1pdExvYWRGb3JGcmFtZShXS1BhZ2VSZWYgcGFnZSwgV0tGcmFtZVJlZiBm cmFtZSwgV0tUeXBlUmVmIHVzCiAgICAgICAgIHJldHVybjsKIAogICAgIFdlYktpdFdlYlZpZXcq IHdlYlZpZXcgPSBXRUJLSVRfV0VCX1ZJRVcoY2xpZW50SW5mbyk7Ci0gICAgV2ViS2l0VVJJUmVz cG9uc2UqIHJlc3BvbnNlID0gd2Via2l0X3dlYl9yZXNvdXJjZV9nZXRfcmVzcG9uc2Uod2Via2l0 X3dlYl92aWV3X2dldF9tYWluX3Jlc291cmNlKHdlYlZpZXcpKTsKLSAgICB3ZWJraXRVUklSZXNw b25zZVNldENlcnRpZmljYXRlSW5mbyhyZXNwb25zZSwgV0tGcmFtZUdldENlcnRpZmljYXRlSW5m byhmcmFtZSkpOworICAgIFdlYktpdFdlYlJlc291cmNlKiByZXNvdXJjZSA9IHdlYmtpdF93ZWJf dmlld19nZXRfbWFpbl9yZXNvdXJjZSh3ZWJWaWV3KTsKKyAgICBpZiAocmVzb3VyY2UpIHsKKyAg ICAgICAgLy8gV2UgbWlnaHQgbm90IGhhdmUgYSByZXNvdXJjZSBpZiB0aGlzIGxvYWQgaXMgYSBj b250ZW50IHJlcGxhY2VtZW50LgorICAgICAgICAvLyBGSVhNRTogRm9yIHNvbWUgcmVhc29uLCB3 aGVuIGdvaW5nIGJhY2svZm9yd2FyZCB0aGlzIGNhbGxiYWNrIGlzIGVtaXR0ZWQgZXZlbiBiZWZv cmUKKyAgICAgICAgLy8gZGlkSW5pdGlhdGVMb2FkRm9yUmVzb3VyY2UoKSwgc28gd2UgZG9uJ3Qg aGF2ZSBhIG1haW4gcmVzb3VyY2UgYXQgdGhpcyBwb2ludCBlaXRoZXIuCisgICAgICAgIHdlYmtp dFVSSVJlc3BvbnNlU2V0Q2VydGlmaWNhdGVJbmZvKHdlYmtpdF93ZWJfcmVzb3VyY2VfZ2V0X3Jl c3BvbnNlKHJlc291cmNlKSwgV0tGcmFtZUdldENlcnRpZmljYXRlSW5mbyhmcmFtZSkpOworICAg IH0KIAogICAgIHdlYmtpdFdlYlZpZXdMb2FkQ2hhbmdlZCh3ZWJWaWV3LCBXRUJLSVRfTE9BRF9D T01NSVRURUQpOwogfQo=