91216 2012-07-13 04:20:06 -0700 [GTK] WebKitWebView::mouse-target-changed is not emitted when moved to/from edtiable content 2012-07-13 04:44:33 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 668853 0 cgarcia 2012-07-13 04:20:06 -0700 The problem is that the function to check whether two hit test results are equal doesn't check the editable flag. 668856 1 152214 cgarcia 2012-07-13 04:21:49 -0700 Created attachment 152214 Patch 668861 2 webkit.review.bot 2012-07-13 04:23:55 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 668868 3 152214 xan.lopez 2012-07-13 04:30:06 -0700 Comment on attachment 152214 Patch Looks good. 668881 4 cgarcia 2012-07-13 04:44:33 -0700 Committed r122565: <http://trac.webkit.org/changeset/122565> 152214 2012-07-13 04:21:49 -0700 2012-07-13 04:30:06 -0700 Patch wk2-hit-tests-editable.diff text/plain 1948 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjOTAwODVjLi4wNTJhNDQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFdlYktpdFdlYlZpZXc6Om1vdXNlLXRhcmdldC1jaGFuZ2VkIGlz IG5vdCBlbWl0dGVkIHdoZW4gbW92ZWQgdG8vZnJvbSBlZHRpYWJsZSBjb250ZW50CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTIxNgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRo YXQgdGhlIGZ1bmN0aW9uIHRvIGNoZWNrIHdoZXRoZXIgdHdvIGhpdCB0ZXN0CisgICAgICAgIHJl c3VsdHMgYXJlIGVxdWFsIGRvZXNuJ3QgY2hlY2sgdGhlIGVkaXRhYmxlIGZsYWcuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRIaXRUZXN0UmVzdWx0LmNwcDoKKyAgICAgICAg KHdlYmtpdEhpdFRlc3RSZXN1bHRDb21wYXJlKTogQ2hlY2sgYWxzbyB0aGUgZWRpdGFibGUgZmxh Zy4KKwogMjAxMi0wNy0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS10gQWRkIEFQSSB0byBnZXQgSFRUUFMgc3RhdHVzIHRvIFdlYktp dDIgR1RLKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0SGl0VGVzdFJlc3VsdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRIaXRUZXN0UmVzdWx0LmNwcAppbmRleCAwMzQ3NjhjLi44MTE1ZDYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRIaXRUZXN0UmVzdWx0LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRIaXRUZXN0UmVz dWx0LmNwcApAQCAtMjc3LDcgKzI3Nyw4IEBAIHN0YXRpYyBib29sIHN0cmluZ0lzRXF1YWxUb0NT dHJpbmcoY29uc3QgU3RyaW5nJiBzdHJpbmcsIGNvbnN0IENTdHJpbmcmIGNTdHJpbmcpCiBib29s IHdlYmtpdEhpdFRlc3RSZXN1bHRDb21wYXJlKFdlYktpdEhpdFRlc3RSZXN1bHQqIGhpdFRlc3RS ZXN1bHQsIFdLSGl0VGVzdFJlc3VsdFJlZiB3a0hpdFRlc3RSZXN1bHQpCiB7CiAgICAgV2ViS2l0 SGl0VGVzdFJlc3VsdFByaXZhdGUqIHByaXYgPSBoaXRUZXN0UmVzdWx0LT5wcml2OwotICAgIHJl dHVybiBzdHJpbmdJc0VxdWFsVG9DU3RyaW5nKHRvSW1wbCh3a0hpdFRlc3RSZXN1bHQpLT5hYnNv bHV0ZUxpbmtVUkwoKSwgcHJpdi0+bGlua1VSSSkKKyAgICByZXR1cm4gV0tIaXRUZXN0UmVzdWx0 SXNDb250ZW50RWRpdGFibGUod2tIaXRUZXN0UmVzdWx0KSA9PSB3ZWJraXRfaGl0X3Rlc3RfcmVz dWx0X2NvbnRleHRfaXNfZWRpdGFibGUoaGl0VGVzdFJlc3VsdCkKKyAgICAgICAgJiYgc3RyaW5n SXNFcXVhbFRvQ1N0cmluZyh0b0ltcGwod2tIaXRUZXN0UmVzdWx0KS0+YWJzb2x1dGVMaW5rVVJM KCksIHByaXYtPmxpbmtVUkkpCiAgICAgICAgICYmIHN0cmluZ0lzRXF1YWxUb0NTdHJpbmcodG9J bXBsKHdrSGl0VGVzdFJlc3VsdCktPmxpbmtUaXRsZSgpLCBwcml2LT5saW5rVGl0bGUpCiAgICAg ICAgICYmIHN0cmluZ0lzRXF1YWxUb0NTdHJpbmcodG9JbXBsKHdrSGl0VGVzdFJlc3VsdCktPmxp bmtMYWJlbCgpLCBwcml2LT5saW5rTGFiZWwpCiAgICAgICAgICYmIHN0cmluZ0lzRXF1YWxUb0NT dHJpbmcodG9JbXBsKHdrSGl0VGVzdFJlc3VsdCktPmFic29sdXRlSW1hZ2VVUkwoKSwgcHJpdi0+ aW1hZ2VVUkkpCg==