91198 2012-07-13 00:28:36 -0700 CodeGeneratorJS.pm : SetterExpression should use 'push' rather than 'unshift' 2012-07-13 04:04:29 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Linux RESOLVED INVALID P2 Normal --- 0 dw.im webkit-unassigned abarth haraken japhet jochen tmpsantos webkit.review.bot oldest_to_newest 668679 0 dw.im 2012-07-13 00:28:36 -0700 Regarding CodeGeneratorV8.pm, 'SetterExpression' should 'push' to make arguments, rather than 'unshift'. I'll upload the patch soon. 668688 1 152171 dw.im 2012-07-13 00:40:57 -0700 Created attachment 152171 Patch This is also needed to fix. 668695 2 152171 haraken 2012-07-13 00:48:08 -0700 Comment on attachment 152171 Patch Sounds reasonable. (Although I don't know there is a use case affected by this change.) 668748 3 152171 webkit.review.bot 2012-07-13 02:05:37 -0700 Comment on attachment 152171 Patch Clearing flags on attachment: 152171 Committed r122553: <http://trac.webkit.org/changeset/122553> 668749 4 webkit.review.bot 2012-07-13 02:05:48 -0700 All reviewed patches have been landed. Closing bug. 668814 5 tmpsantos 2012-07-13 03:28:17 -0700 Bindings generation tests are failing after this patch: http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/2751 668838 6 haraken 2012-07-13 04:04:29 -0700 This was a wrong fix. Rolled out at r122553. 152171 2012-07-13 00:40:57 -0700 2012-07-13 02:05:37 -0700 Patch patch_91198_0713.patch text/plain 1663 dw.im ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmOTY2YjM2Li44NTA3YTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMTMgIERvbmd3b28gSW0gIDxkdy5pbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBDb2RlR2VuZXJhdG9ySlMucG0gOiBTZXR0ZXJFeHByZXNzaW9uIHNob3VsZCB1c2UgJ3B1c2gn IHJhdGhlciB0aGFuICd1bnNoaWZ0JworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTExOTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAnU2V0dGVyRXhwcmVzc2lvbicgc2hvdWxkIHVzZSAncHVzaCcgdG8gbWFr ZSBhcmd1bWVudHMsIHJhdGhlciB0aGFuICd1bnNoaWZ0Jy4KKworICAgICAgICBObyBuZXcgdGVz dHMuIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3JKUy5wbToKKyAgICAgICAgKEdlbmVyYXRlSW1wbGVtZW50YXRpb24p OgorCiAyMDEyLTA3LTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJhZGlvTm9kZUxpc3QgaXMgbm90IHVwZGF0ZWQgdXBvbiBpbnB1dCB0eXBlIGNoYW5nZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y SlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w bQppbmRleCA2NzBmYTIxLi5hZjYwNjI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQpAQCAtMjAxOSw3ICsyMDE5LDcgQEAgc3Vi IEdlbmVyYXRlSW1wbGVtZW50YXRpb24KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICRmdW5jdGlvbk5hbWUgPSAiaW1wbC0+JHtmdW5jdGlvbk5hbWV9IjsKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfQogCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHVuc2hpZnQoQGFyZ3VtZW50cywgR2VuZXJhdGVDYWxsV2l0aCgkYXR0cmlidXRlLT5zaWduYXR1 cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDYWxsV2l0aCJ9LCBcQGltcGxDb250ZW50LCAiIikp OworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwdXNoKEBhcmd1bWVudHMsIEdlbmVy YXRlQ2FsbFdpdGgoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsi Q2FsbFdpdGgifSwgXEBpbXBsQ29udGVudCwgIiIpKTsKIAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBwdXNoKEBhcmd1bWVudHMsICJlYyIpIGlmIEB7JGF0dHJpYnV0ZS0+c2V0dGVy RXhjZXB0aW9uc307CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGltcGxD b250ZW50LCAiICAgICR7ZnVuY3Rpb25OYW1lfSgiIC4gam9pbigiLCAiLCBAYXJndW1lbnRzKSAu ICIpO1xuIik7Cg==