<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>91194</bug_id>
          
          <creation_ts>2012-07-12 23:47:30 -0700</creation_ts>
          <short_desc>enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support</short_desc>
          <delta_ts>2012-07-13 20:40:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Android</rep_platform>
          <op_sys>Android</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>88658</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Wei James (wistoch)">james.wei</reporter>
          <assigned_to name="Wei James (wistoch)">james.wei</assigned_to>
          <cc>abarth</cc>
    
    <cc>peter</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>668646</commentid>
    <comment_count>0</comment_count>
    <who name="Wei James (wistoch)">james.wei</who>
    <bug_when>2012-07-12 23:47:30 -0700</bug_when>
    <thetext>enable TestWebKitAPI/webkit_unit_tests apk on x86 android platform by adding abi support</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668647</commentid>
    <comment_count>1</comment_count>
      <attachid>152162</attachid>
    <who name="Wei James (wistoch)">james.wei</who>
    <bug_when>2012-07-12 23:48:29 -0700</bug_when>
    <thetext>Created attachment 152162
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668700</commentid>
    <comment_count>2</comment_count>
    <who name="Wei James (wistoch)">james.wei</who>
    <bug_when>2012-07-13 00:54:08 -0700</bug_when>
    <thetext>by default, the .so will be put into armeabi folder. adding --app-abi option will put the native binary to correct place.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668945</commentid>
    <comment_count>3</comment_count>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-07-13 06:13:12 -0700</bug_when>
    <thetext>LGTM, thank you for doing this!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>669171</commentid>
    <comment_count>4</comment_count>
      <attachid>152162</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-13 10:18:23 -0700</bug_when>
    <thetext>Comment on attachment 152162
Patch

If Peter says this patch is good, that&apos;s enough for me.  :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>669239</commentid>
    <comment_count>5</comment_count>
      <attachid>152162</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-13 10:57:58 -0700</bug_when>
    <thetext>Comment on attachment 152162
Patch

Clearing flags on attachment: 152162

Committed r122606: &lt;http://trac.webkit.org/changeset/122606&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>669240</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-13 10:58:03 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>669700</commentid>
    <comment_count>7</comment_count>
    <who name="Wei James (wistoch)">james.wei</who>
    <bug_when>2012-07-13 20:40:57 -0700</bug_when>
    <thetext>peter, abarth, 

thanks. 

James</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>152162</attachid>
            <date>2012-07-12 23:48:29 -0700</date>
            <delta_ts>2012-07-13 10:57:58 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-91194-20120713144841.patch</filename>
            <type>text/plain</type>
            <size>2811</size>
            <attacher name="Wei James (wistoch)">james.wei</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDgxNTJmMjdlZTQzMGI3ZTQ2YjY4YTNjYTQ4MDg3ODIwNmQ1MjliMzkuLmIzNzdlYzdlOWJkMmEz
YjVjODIyNjE1MmYzYzk0OGVhZjE1NmRiOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTIgQEAKKzIwMTItMDctMTIgIFdlaSBKYW1lcyAgPGphbWVzLndlaUBpbnRlbC5j
b20+CisKKyAgICAgICAgZW5hYmxlIFRlc3RXZWJLaXRBUEkvd2Via2l0X3VuaXRfdGVzdHMgYXBr
IG9uIHg4NiBhbmRyb2lkIHBsYXRmb3JtIGJ5IGFkZGluZyBhYmkgc3VwcG9ydAorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTExOTQKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYktpdFVuaXRUZXN0cy5n
eXA6CisKIDIwMTItMDctMTIgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KIAog
ICAgICAgICBbY2hyb21pdW1dIFJvb3QgaW52YWxpZGF0aW9ucyBmb3IgUlRMIHBhZ2VzIG5lZWQg
dG8gYmUgaW4gdGhlIHJpZ2h0IHNwYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t
aXVtL1dlYktpdFVuaXRUZXN0cy5neXAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdFVu
aXRUZXN0cy5neXAKaW5kZXggMjBjM2Y2ZjM2Y2FiOTI3OWNkNGQ0ZDc1MGJjODQzNDZmM2QzZDBm
Zi4uMDUxYzEzNTI0ZDFlMmViM2QyMjFhNTAxNmU1ZDQzNTA3M2Q3ZTIyYiAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXRVbml0VGVzdHMuZ3lwCisrKyBiL1NvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vV2ViS2l0VW5pdFRlc3RzLmd5cApAQCAtMTczLDcgKzE3Myw5IEBACiAg
ICAgICAgICAgICAgICAgICAgICAgICAnPChQUk9EVUNUX0RJUikvd2Via2l0X3VuaXRfdGVzdHNf
YXBrJywKICAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1hcmdzJywKICAgICAgICAgICAg
ICAgICAgICAgICAgICctRFBST0RVQ1RfRElSPTwoYW50X2J1aWxkX291dCknLAotICAgICAgICAg
ICAgICAgICAgICAgICAgJy0tYW50LWNvbXBpbGUnCisgICAgICAgICAgICAgICAgICAgICAgICAn
LS1hbnQtY29tcGlsZScsCisgICAgICAgICAgICAgICAgICAgICAgICAnLS1hcHBfYWJpJywKKyAg
ICAgICAgICAgICAgICAgICAgICAgICc8KGFuZHJvaWRfYXBwX2FiaSknLAogICAgICAgICAgICAg
ICAgICAgICBdLAogICAgICAgICAgICAgICAgIH1dLAogICAgICAgICAgICAgfV0sCmRpZmYgLS1n
aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTJiZmY2MmYxNDli
N2VlZTIwMGU2MDFlYWFjYTliMWVlMjBhZDU0OC4uYTk1NzBlMTIyZGU0MmMwYzBhYmYxNmU4NTZk
ODUxODc4ZTA3MWQ0NiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0No
YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA3LTEyICBXZWkgSmFtZXMgIDxqYW1lcy53
ZWlAaW50ZWwuY29tPgorCisgICAgICAgIGVuYWJsZSBUZXN0V2ViS2l0QVBJL3dlYmtpdF91bml0
X3Rlc3RzIGFwayBvbiB4ODYgYW5kcm9pZCBwbGF0Zm9ybSBieSBhZGRpbmcgYWJpIHN1cHBvcnQK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMTk0CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2Vi
S2l0QVBJL1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RXZWJLaXRBUEkuZ3lwOgorCiAyMDEyLTA3LTEy
ICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbTmF2
aWdhdGlvbiBUaW1pbmddIEltcG9ydCB0aGUgVzNDIE5hdmlnYXRpb24gVGltaW5nIHRlc3Qgc3Vp
dGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS5neXAvVGVz
dFdlYktpdEFQSS5neXAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkuZ3lwL1Rl
c3RXZWJLaXRBUEkuZ3lwCmluZGV4IDZmNWZiYTJkODI0NWJmZGY0MWIzNDI1MDhkNmMwMWQ4NzU2
MTBlNmMuLmZmMDY0YTAyZDU5NGVjMjNiOWUyMzQ3ZjMxNTUxYzQ5MzFiNDVhMWQgMTAwNjQ0Ci0t
LSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdFdlYktpdEFQSS5neXAvVGVzdFdlYktpdEFQSS5n
eXAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0V2ViS2l0QVBJLmd5cC9UZXN0V2ViS2l0
QVBJLmd5cApAQCAtMTMzLDcgKzEzMyw5IEBACiAgICAgICAgICAgICAgICAgICAgICAgICAnPChQ
Uk9EVUNUX0RJUikvVGVzdFdlYktpdEFQSV9hcGsnLAogICAgICAgICAgICAgICAgICAgICAgICAg
Jy0tYW50LWFyZ3MnLAogICAgICAgICAgICAgICAgICAgICAgICAgJy1EUFJPRFVDVF9ESVI9PChh
bnRfYnVpbGRfb3V0KScsCi0gICAgICAgICAgICAgICAgICAgICAgICAnLS1hbnQtY29tcGlsZScK
KyAgICAgICAgICAgICAgICAgICAgICAgICctLWFudC1jb21waWxlJywKKyAgICAgICAgICAgICAg
ICAgICAgICAgICctLWFwcF9hYmknLAorICAgICAgICAgICAgICAgICAgICAgICAgJzwoYW5kcm9p
ZF9hcHBfYWJpKScsCiAgICAgICAgICAgICAgICAgICAgIF0sCiAgICAgICAgICAgICAgICAgfV0s
CiAgICAgICAgICAgICB9XSwK
</data>

          </attachment>
      

    </bug>

</bugzilla>