91185 2012-07-12 19:52:56 -0700 CodeGeneratorJS.pm need to handle the attribute which has "CallWith=ScriptExecutionContext" option. 2012-07-13 04:05:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Linux RESOLVED INVALID P2 Normal --- 79193 91187 0 dw.im webkit-unassigned abarth ggaren haraken japhet jochen kinuko tony webkit.review.bot oldest_to_newest 668538 0 dw.im 2012-07-12 19:52:56 -0700 When I try to build EFL port with enabling the ENABLE_FILE_SYSTEM flag, I met an build error. In the HTMLInputElementFileSystem.h, webkitEntries is defined as below. - static PassRefPtr<EntryArray> webkitEntries(HTMLInputElement*, ScriptExecutionContext*); But, in the JSHtmlInputElement.cpp, it tries to call webkitEntries(ScriptExecutionContext*, HTMLInputElement*). I think CodeGeneratorJS.pm should be fixed. I will upload the patch soon. 668544 1 152138 dw.im 2012-07-12 20:06:01 -0700 Created attachment 152138 Patch 668633 2 152138 haraken 2012-07-12 23:17:51 -0700 Comment on attachment 152138 Patch Good fix! V8 already uses push(). 668645 3 dw.im 2012-07-12 23:45:10 -0700 (In reply to comment #2) > (From update of attachment 152138 [details]) > Good fix! V8 already uses push(). Dear Kentaro Hara, Thanks for the review! I'm looking for some more points to improve the CodeGeneratorJS.pm. I will refer how V8 does. 668651 4 152138 webkit.review.bot 2012-07-12 23:50:30 -0700 Comment on attachment 152138 Patch Clearing flags on attachment: 152138 Committed r122545: <http://trac.webkit.org/changeset/122545> 668652 5 webkit.review.bot 2012-07-12 23:50:35 -0700 All reviewed patches have been landed. Closing bug. 668836 6 haraken 2012-07-13 04:03:32 -0700 Reverted r122545 for reason: We found that this was a wrong fix Committed r122561: <http://trac.webkit.org/changeset/122561> 668839 7 haraken 2012-07-13 04:05:09 -0700 Per discussion in IRC, this is a wrong fix. 152138 2012-07-12 20:06:01 -0700 2012-07-12 23:50:29 -0700 Patch patch_91185_0713.patch text/plain 1657 dw.im ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMmI4NTVhLi5jZjRkYzg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMTIgIERvbmd3b28gSW0gIDxkdy5pbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBDb2RlR2VuZXJhdG9ySlMucG0gbmVlZCB0byBoYW5kbGUgdGhlIGF0dHJpYnV0ZSB3aGljaCBo YXMgIkNhbGxXaXRoPVNjcmlwdEV4ZWN1dGlvbkNvbnRleHQiIG9wdGlvbi4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMTg1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBhbiBhdHRyaWJ1dGUgaGFz ICJDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0IiBvcHRpb24sICdTY3JpcHRFeGVjdXRp b25Db250ZXh0KicgcGFyYW1ldGVyIHNob3VsZCBiZSB0aGUgbGFzdCBwYXJhbWV0ZXIuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgIChHZW5lcmF0 ZUltcGxlbWVudGF0aW9uKToKKwogMjAxMi0wNy0xMSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBh cHBsZS5jb20+CiAKICAgICAgICAgRmFpbHVyZSB0byBkaXNwYXRjaCBkaWRGaW5pc2hMb2FkRm9y RnJhbWUgaWYgZm9udCBsb2FkIGZhaWxzIHN5bmNocm9ub3VzbHkgCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IDMxYzE2NGIu LjY3MGZhMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCkBAIC0xNzk2LDcgKzE3OTYsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1l bnRhdGlvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICRmdW5jdGlvbk5hbWUgPSAiaW1w bC0+JHtmdW5jdGlvbk5hbWV9IjsKICAgICAgICAgICAgICAgICAgICAgICAgIH0KIAotICAgICAg ICAgICAgICAgICAgICAgICAgdW5zaGlmdChAYXJndW1lbnRzLCBAY2FsbFdpdGhBcmdzKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgIHB1c2goQGFyZ3VtZW50cywgQGNhbGxXaXRoQXJncyk7CiAK ICAgICAgICAgICAgICAgICAgICAgICAgIG15ICRqc1R5cGUgPSBOYXRpdmVUb0pTVmFsdWUoJGF0 dHJpYnV0ZS0+c2lnbmF0dXJlLCAwLCAkaW1wbENsYXNzTmFtZSwgIiR7ZnVuY3Rpb25OYW1lfSgi IC4gam9pbigiLCAiLCBAYXJndW1lbnRzKSAuICIpIiwgImNhc3RlZFRoaXMiKTsKICAgICAgICAg ICAgICAgICAgICAgICAgIHB1c2goQGltcGxDb250ZW50LCAiICAgICRpbXBsQ2xhc3NOYW1lKiBp bXBsID0gc3RhdGljX2Nhc3Q8JGltcGxDbGFzc05hbWUqPihjYXN0ZWRUaGlzLT5pbXBsKCkpO1xu Iik7Cg==