91182 2012-07-12 19:23:05 -0700 test-webkitpy: more class renaming cleanup 2012-07-13 00:39:55 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth ojan webkit.review.bot oldest_to_newest 668518 0 dpranke 2012-07-12 19:23:05 -0700 test-webkitpy: more class renaming cleanup 668524 1 152133 dpranke 2012-07-12 19:34:12 -0700 Created attachment 152133 Patch 668551 2 152133 dpranke 2012-07-12 20:11:37 -0700 Comment on attachment 152133 Patch thanks for the review! 668685 3 152133 webkit.review.bot 2012-07-13 00:39:49 -0700 Comment on attachment 152133 Patch Clearing flags on attachment: 152133 Committed r122548: <http://trac.webkit.org/changeset/122548> 668686 4 webkit.review.bot 2012-07-13 00:39:55 -0700 All reviewed patches have been landed. Closing bug. 152133 2012-07-12 19:34:12 -0700 2012-07-13 00:39:49 -0700 Patch bug-91182-20120712193412.patch text/plain 5744 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTM2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2NlN2JlMjk3MzYzZjk4NDZhYmI1YzYyYjI5NTUzZTY1 NDllZjIzNC4uMmI3NWRmYzI0NjY3MTljYmViM2NmMDMyNjNjZGQ0NmQ4NjZiMGRkMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2 IEBACiAyMDEyLTA3LTEyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIHRlc3Qtd2Via2l0cHk6IG1vcmUgY2xhc3MgcmVuYW1pbmcgY2xlYW51cAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTExODIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb3JlIHJlbW92aW5nIG9m IHRoZSB1bm5lY2Vzc2FyeSAiVGVzdCIgcHJlZml4LgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90ZXN0L2ZpbmRlci5weToKKyAgICAgICAgKF9EaXJlY3RvcnlUcmVlKToKKyAgICAgICAg KEZpbmRlci5hZGRfdHJlZSk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4u cHk6CisgICAgICAgIChUZXN0ZXIuX3J1bl90ZXN0cyk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90ZXN0L3J1bm5lci5weToKKyAgICAgICAgKFJ1bm5lcik6CisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS90ZXN0L3J1bm5lcl91bml0dGVzdC5weToKKyAgICAgICAgKFJ1bm5lclRlc3Qu dGVzdF9yZWd1bGFyKToKKyAgICAgICAgKFJ1bm5lclRlc3QudGVzdF92ZXJib3NlKToKKyAgICAg ICAgKFJ1bm5lclRlc3QudGVzdF90aW1pbmcpOgorCisyMDEyLTA3LTEyICBEaXJrIFByYW5rZSAg PGRwcmFua2VAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIHRlc3Qtd2Via2l0cHk6IHJlbmFtZSB0 ZXN0X2ZpbmRlciB0byBmaW5kZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkxMTc1CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dGVzdC9maW5kZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvZmluZGVyLnB5Cmlu ZGV4IGYwNzgxYzRhZGU3MDU2YzgxZWNmNjdhM2JmYTMwMDZhNTIzNTQ2ZGEuLjEzMjA3MmQ4MjA1 MzhhOGZlOGIxYjJhNjI3ZmY4MWNiZjc0MWU4N2IgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvdGVzdC9maW5kZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0 L2ZpbmRlci5weQpAQCAtMzEsNyArMzEsNyBAQCBpbXBvcnQgc3lzCiBfbG9nID0gbG9nZ2luZy5n ZXRMb2dnZXIoX19uYW1lX18pCiAKIAotY2xhc3MgVGVzdERpcmVjdG9yeVRyZWUob2JqZWN0KToK K2NsYXNzIF9EaXJlY3RvcnlUcmVlKG9iamVjdCk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGZp bGVzeXN0ZW0sIHRvcF9kaXJlY3RvcnksIHN0YXJ0aW5nX3N1YmRpcmVjdG9yeSk6CiAgICAgICAg IHNlbGYuZmlsZXN5c3RlbSA9IGZpbGVzeXN0ZW0KICAgICAgICAgc2VsZi50b3BfZGlyZWN0b3J5 ID0gZmlsZXN5c3RlbS5yZWFscGF0aCh0b3BfZGlyZWN0b3J5KQpAQCAtNzksNyArNzksNyBAQCBj bGFzcyBGaW5kZXIob2JqZWN0KToKICAgICAgICAgc2VsZi50cmVlcyA9IFtdCiAKICAgICBkZWYg YWRkX3RyZWUoc2VsZiwgdG9wX2RpcmVjdG9yeSwgc3RhcnRpbmdfc3ViZGlyZWN0b3J5PU5vbmUp OgotICAgICAgICBzZWxmLnRyZWVzLmFwcGVuZChUZXN0RGlyZWN0b3J5VHJlZShzZWxmLmZpbGVz eXN0ZW0sIHRvcF9kaXJlY3RvcnksIHN0YXJ0aW5nX3N1YmRpcmVjdG9yeSkpCisgICAgICAgIHNl bGYudHJlZXMuYXBwZW5kKF9EaXJlY3RvcnlUcmVlKHNlbGYuZmlsZXN5c3RlbSwgdG9wX2RpcmVj dG9yeSwgc3RhcnRpbmdfc3ViZGlyZWN0b3J5KSkKIAogICAgIGRlZiBhZGRpdGlvbmFsX3BhdGhz KHNlbGYsIHBhdGhzKToKICAgICAgICAgcmV0dXJuIFt0cmVlLnRvcF9kaXJlY3RvcnkgZm9yIHRy ZWUgaW4gc2VsZi50cmVlcyBpZiB0cmVlLnRvcF9kaXJlY3Rvcnkgbm90IGluIHBhdGhzXQpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L21haW4ucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQppbmRleCA1ZjkxMTRiYmUyNjk4NDFmNTI2ZWEwOGYy NTVkYTllZDY1ZTU3MTRiLi4yZDM0YjgwMTA0MDMyMDE4ZThjY2FhMjgzOTM5ODUxYjkwNTMxOGZi IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rlc3QvbWFpbi5weQpAQCAtMzQsNyArMzQsNyBAQCBpbXBv cnQgdW5pdHRlc3QKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5maWxlc3lzdGVtIGltcG9y dCBGaWxlU3lzdGVtCiBmcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0gaW1wb3J0IG91dHB1dGNh cHR1cmUKIGZyb20gd2Via2l0cHkudGVzdC5maW5kZXIgaW1wb3J0IEZpbmRlcgotZnJvbSB3ZWJr aXRweS50ZXN0LnJ1bm5lciBpbXBvcnQgVGVzdFJ1bm5lcgorZnJvbSB3ZWJraXRweS50ZXN0LnJ1 bm5lciBpbXBvcnQgUnVubmVyCiAKIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykK IApAQCAtMTc3LDcgKzE3Nyw3IEBAIGNsYXNzIFRlc3RlcihvYmplY3QpOgogICAgICAgICAgICAg c3VpdGVzLmFwcGVuZChsb2FkZXIubG9hZFRlc3RzRnJvbU5hbWUobmFtZSwgTm9uZSkpCiAKICAg ICAgICAgdGVzdF9zdWl0ZSA9IHVuaXR0ZXN0LlRlc3RTdWl0ZShzdWl0ZXMpCi0gICAgICAgIHRl c3RfcnVubmVyID0gVGVzdFJ1bm5lcihzZWxmLnN0cmVhbSwgc2VsZi5fb3B0aW9ucywgbG9hZGVy KQorICAgICAgICB0ZXN0X3J1bm5lciA9IFJ1bm5lcihzZWxmLnN0cmVhbSwgc2VsZi5fb3B0aW9u cywgbG9hZGVyKQogCiAgICAgICAgIF9sb2cuZGVidWcoIlJ1bm5pbmcgdGhlIHRlc3RzLiIpCiAg ICAgICAgIGlmIHNlbGYuX29wdGlvbnMucGFzc190aHJvdWdoOgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRweS90ZXN0L3J1bm5lci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv dGVzdC9ydW5uZXIucHkKaW5kZXggZTE5MGYyY2Q0NTlkNzlkZmNmMmE2YzVmM2IwNjIwYTFiYjcy ZTc5MC4uMzk0MTRkODZjMzJkMjViYjEwZTk1MmQ3NzAwY2U3NWM4Zjg4ZDBkOSAxMDA2NDQKLS0t IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L3J1bm5lci5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rlc3QvcnVubmVyLnB5CkBAIC0zMSw3ICszMSw3IEBAIGltcG9ydCB1bml0 dGVzdAogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQogCiAKLWNsYXNzIFRlc3RS dW5uZXIob2JqZWN0KToKK2NsYXNzIFJ1bm5lcihvYmplY3QpOgogICAgIGRlZiBfX2luaXRfXyhz ZWxmLCBzdHJlYW0sIG9wdGlvbnMsIGxvYWRlcik6CiAgICAgICAgIHNlbGYub3B0aW9ucyA9IG9w dGlvbnMKICAgICAgICAgc2VsZi5zdHJlYW0gPSBzdHJlYW0KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdGVzdC9ydW5uZXJfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3Rlc3QvcnVubmVyX3VuaXR0ZXN0LnB5CmluZGV4IGUyZWEzMWFhMTA5OGQ0MmYxODBh YjZhMDZlMDI4YmQ4YjU1OWNlZDUuLjIyY2VmODgyMzM1ODk5MWMyOTIxY2EzZTdkODQzMTdmNzdl ODU4MjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdGVzdC9ydW5uZXJfdW5p dHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90ZXN0L3J1bm5lcl91bml0dGVz dC5weQpAQCAtMjUsNyArMjUsNyBAQCBpbXBvcnQgU3RyaW5nSU8KIGltcG9ydCB1bml0dGVzdAog CiBmcm9tIHdlYmtpdHB5LnRvb2wubW9ja3Rvb2wgaW1wb3J0IE1vY2tPcHRpb25zCi1mcm9tIHdl YmtpdHB5LnRlc3QucnVubmVyIGltcG9ydCBUZXN0UnVubmVyCitmcm9tIHdlYmtpdHB5LnRlc3Qu cnVubmVyIGltcG9ydCBSdW5uZXIKIAogCiBjbGFzcyBGYWtlTW9kdWxlU3VpdGUob2JqZWN0KToK QEAgLTc0LDcgKzc0LDcgQEAgY2xhc3MgUnVubmVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAg ICAgICAgIGxvYWRlciA9IEZha2VMb2FkZXIoKCd0ZXN0MSAoRm9vKScsICcuJywgJycpLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICgndGVzdDIgKEZvbyknLCAnRicsICd0ZXN0MlxuZmFp bGVkJyksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCd0ZXN0MyAoRm9vKScsICdFJywg J3Rlc3QzXG5lcnJlZCcpKQotICAgICAgICByZXN1bHQgPSBUZXN0UnVubmVyKHN0cmVhbSwgb3B0 aW9ucywgbG9hZGVyKS5ydW4obG9hZGVyLnRvcF9zdWl0ZSgpKQorICAgICAgICByZXN1bHQgPSBS dW5uZXIoc3RyZWFtLCBvcHRpb25zLCBsb2FkZXIpLnJ1bihsb2FkZXIudG9wX3N1aXRlKCkpCiAg ICAgICAgIHNlbGYuYXNzZXJ0RmFsc2UocmVzdWx0Lndhc1N1Y2Nlc3NmdWwoKSkKICAgICAgICAg c2VsZi5hc3NlcnRFcXVhbHMocmVzdWx0LnRlc3RzUnVuLCAzKQogICAgICAgICBzZWxmLmFzc2Vy dEVxdWFscyhsZW4ocmVzdWx0LmZhaWx1cmVzKSwgMSkKQEAgLTg3LDcgKzg3LDcgQEAgY2xhc3Mg UnVubmVyVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIGxvYWRlciA9IEZha2VMb2Fk ZXIoKCd0ZXN0MSAoRm9vKScsICcuJywgJycpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICgndGVzdDIgKEZvbyknLCAnRicsICd0ZXN0MlxuZmFpbGVkJyksCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKCd0ZXN0MyAoRm9vKScsICdFJywgJ3Rlc3QzXG5lcnJlZCcpKQotICAgICAg ICByZXN1bHQgPSBUZXN0UnVubmVyKHN0cmVhbSwgb3B0aW9ucywgbG9hZGVyKS5ydW4obG9hZGVy LnRvcF9zdWl0ZSgpKQorICAgICAgICByZXN1bHQgPSBSdW5uZXIoc3RyZWFtLCBvcHRpb25zLCBs b2FkZXIpLnJ1bihsb2FkZXIudG9wX3N1aXRlKCkpCiAgICAgICAgIHNlbGYuYXNzZXJ0RmFsc2Uo cmVzdWx0Lndhc1N1Y2Nlc3NmdWwoKSkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMocmVzdWx0 LnRlc3RzUnVuLCAzKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhsZW4ocmVzdWx0LmZhaWx1 cmVzKSwgMSkKQEAgLTEwMCw3ICsxMDAsNyBAQCBjbGFzcyBSdW5uZXJUZXN0KHVuaXR0ZXN0LlRl c3RDYXNlKToKICAgICAgICAgbG9hZGVyID0gRmFrZUxvYWRlcigoJ3Rlc3QxIChGb28pJywgJy4n LCAnJyksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKCd0ZXN0MiAoRm9vKScsICdGJywg J3Rlc3QyXG5mYWlsZWQnKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoJ3Rlc3QzIChG b28pJywgJ0UnLCAndGVzdDNcbmVycmVkJykpCi0gICAgICAgIHJlc3VsdCA9IFRlc3RSdW5uZXIo c3RyZWFtLCBvcHRpb25zLCBsb2FkZXIpLnJ1bihsb2FkZXIudG9wX3N1aXRlKCkpCisgICAgICAg IHJlc3VsdCA9IFJ1bm5lcihzdHJlYW0sIG9wdGlvbnMsIGxvYWRlcikucnVuKGxvYWRlci50b3Bf c3VpdGUoKSkKICAgICAgICAgc2VsZi5hc3NlcnRGYWxzZShyZXN1bHQud2FzU3VjY2Vzc2Z1bCgp KQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhyZXN1bHQudGVzdHNSdW4sIDMpCiAgICAgICAg IHNlbGYuYXNzZXJ0RXF1YWxzKGxlbihyZXN1bHQuZmFpbHVyZXMpLCAxKQo=