91174 2012-07-12 17:38:42 -0700 Comment on WebCore::HTMLMediaElement::childShouldCreateRenderer() should explain why 2012-07-16 17:49:14 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 morrita morrita eric.carlson feature-media-reviews tkent webkit.review.bot oldest_to_newest 668446 0 morrita 2012-07-12 17:38:42 -0700 This is a followup of Bug 91055. 668474 1 152124 morrita 2012-07-12 18:24:04 -0700 Created attachment 152124 Patch 668475 2 152124 shinyak 2012-07-12 18:26:18 -0700 Comment on attachment 152124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152124&action=review > Source/WebCore/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). ? 668553 3 152124 tkent 2012-07-12 20:13:44 -0700 Comment on attachment 152124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152124&action=review > Source/WebCore/html/HTMLMediaElement.cpp:494 > + // be rendered. So this should return true for most of the children. should return false? 668670 4 152168 morrita 2012-07-13 00:24:09 -0700 Created attachment 152168 Patch 668671 5 152124 morrita 2012-07-13 00:25:15 -0700 Comment on attachment 152124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152124&action=review >> Source/WebCore/html/HTMLMediaElement.cpp:494 >> + // be rendered. So this should return true for most of the children. > > should return false? Ooops. Thanks for the catch. Just updated the patch. Tried to clarified the comment/made it wrong (your favorite meme here)... 668745 6 152168 tkent 2012-07-13 01:57:22 -0700 Comment on attachment 152168 Patch Looks ok. 669198 7 152168 eric.carlson 2012-07-13 10:28:12 -0700 Comment on attachment 152168 Patch I get it now, thanks for taking the time to update the comment! 670840 8 152168 webkit.review.bot 2012-07-16 17:49:07 -0700 Comment on attachment 152168 Patch Clearing flags on attachment: 152168 Committed r122786: <http://trac.webkit.org/changeset/122786> 670842 9 webkit.review.bot 2012-07-16 17:49:14 -0700 All reviewed patches have been landed. Closing bug. 152124 2012-07-12 18:24:04 -0700 2012-07-13 00:25:15 -0700 Patch bug-91174-20120713102403.patch text/plain 1926 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGYzOTdkYzU0OWVkNTEx NzUyNjc3ZWY5ZWVkYTUyOWZiNDRkNTc4MS4uZDFjNmMxY2U4MmIxMmEyOTUxYTRiNjI0ZWU3NGRi Y2JkMGM1OGM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTEyICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIENvbW1lbnQgb24gV2Vi Q29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVhdGVSZW5kZXJlcigpIHNob3Vs ZCBleHBsYWluIHdoeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTExNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9mIHRoZSBjaGFuZ2Ugc3VjaCBhcyBhcHByb2Fj aCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1mdW5jdGlvbiBkZXNjcmlwdGlvbnMgYmVsb3cg KE9PUFMhKS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50OjpjaGlsZFNob3VsZENyZWF0ZVJlbmRlcmVyKToK KwogMjAxMi0wNy0xMiAgWGluZ25hbiBXYW5nICA8eGluZ25hbi53YW5nQGludGVsLmNvbT4KIAog ICAgICAgICBbSW5kZXhlZERCXSB1cHBlck9wZW4gc2V0IHRvIHRydWUgaW4gbG93ZXJCb3VuZCgp L2xvd2VyT3BlbiBzZXQgdG8gdHJ1ZSBpbiB1cHBlckJvdW5kKCkKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IGJjMWE5ZTYyZWQ3ZGI1ZGFmOTAyMTI0Mzg5NjQw MTdiYWJmMDAwZTAuLjFkOTQ2MzM4NTA2N2VkNDA4NWNkMDc4Y2NlZmY5NjM1YTQ1MjIzZDAgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtNDkwLDcgKzQ5MCwx MCBAQCBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OmNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVyZXIoY29u c3QgTm9kZVJlbmRlcmluZ0NvbnRleHQmIGNoaQogewogICAgIGlmICghaGFzTWVkaWFDb250cm9s cygpKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgLy8gT25seSBhbGxvd3Mgbm9kZXMgZnJv bSB0aGUgY29udHJvbHMgc2hhZG93IHN1YnRyZWUuCisgICAgLy8gPG1lZGlhPiBkb2Vzbid0IGFs bG93IGl0cyBjb250ZW50LCBpbmNsdWRpbmcgc2hhZG93IHN1YnRyZWUsIHRvCisgICAgLy8gYmUg cmVuZGVyZWQuIFNvIHRoaXMgc2hvdWxkIHJldHVybiB0cnVlIGZvciBtb3N0IG9mIHRoZSBjaGls ZHJlbi4KKyAgICAvLyBPbmUgZXhjZXB0aW9uIGlzIGEgc2hhZG93IHRyZWUgYnVpbHQgZm9yIHJl bmRlcmluZyBjb250cm9scyB3aGljaCBzaG91bGQgYmUgdmlzaWJsZS4KKyAgICAvLyBTbyB3ZSBs ZXQgdGhlbSBnbyBoZXJlIGJ5IGNvbXBhcmluZyBpdHMgc3VidHJlZSByb290IHdpdGggb25lIG9m IHRoZSBjb250cm9scy4KICAgICByZXR1cm4gKG1lZGlhQ29udHJvbHMoKS0+dHJlZVNjb3BlKCkg PT0gY2hpbGRDb250ZXh0Lm5vZGUoKS0+dHJlZVNjb3BlKCkKICAgICAgICAgICAgICYmIGNoaWxk Q29udGV4dC5pc09uVXBwZXJFbmNhcHN1bGF0aW9uQm91bmRhcnkoKSAmJiBIVE1MRWxlbWVudDo6 Y2hpbGRTaG91bGRDcmVhdGVSZW5kZXJlcihjaGlsZENvbnRleHQpKTsKIH0K 152168 2012-07-13 00:24:09 -0700 2012-07-16 17:49:07 -0700 Patch bug-91174-20120713162408.patch text/plain 1841 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmY0YmYzZmZlOTE2MzNj NzhjYTQyYzc5N2YwYjkwZDc2ZTI5NzhjOS4uNDlmYmFkNWI3ZGVlMzA0OTE3ZWM5MjVjODQyZmE4 NTZiNzYyOWEwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTEyICBNT1JJ VEEgSGFqaW1lICA8bW9ycml0YUBnb29nbGUuY29tPgorCisgICAgICAgIENvbW1lbnQgb24gV2Vi Q29yZTo6SFRNTE1lZGlhRWxlbWVudDo6Y2hpbGRTaG91bGRDcmVhdGVSZW5kZXJlcigpIHNob3Vs ZCBleHBsYWluIHdoeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTExNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBDbGFyaWZpZWQgdGhlIGV4cGxhbmF0aW9uLgorCisgICAgICAgICogaHRtbC9IVE1MTWVk aWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmNoaWxk U2hvdWxkQ3JlYXRlUmVuZGVyZXIpOgorCiAyMDEyLTA3LTEyICBEb25nd29vIEltICA8ZHcuaW1A c2Ftc3VuZy5jb20+CiAKICAgICAgICAgQ29kZUdlbmVyYXRvckpTLnBtIG5lZWQgdG8gaGFuZGxl IHRoZSBhdHRyaWJ1dGUgd2hpY2ggaGFzICJDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0 IiBvcHRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCBi YzFhOWU2MmVkN2RiNWRhZjkwMjEyNDM4OTY0MDE3YmFiZjAwMGUwLi40YzExZDA4MDJiNTBlMTUw ZjEwMTM0ZDgwZGEwZjZmMThhY2E1YzlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAKQEAgLTQ5MCw3ICs0OTAsMTAgQEAgYm9vbCBIVE1MTWVkaWFFbGVtZW50Ojpj aGlsZFNob3VsZENyZWF0ZVJlbmRlcmVyKGNvbnN0IE5vZGVSZW5kZXJpbmdDb250ZXh0JiBjaGkK IHsKICAgICBpZiAoIWhhc01lZGlhQ29udHJvbHMoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwot ICAgIC8vIE9ubHkgYWxsb3dzIG5vZGVzIGZyb20gdGhlIGNvbnRyb2xzIHNoYWRvdyBzdWJ0cmVl LgorICAgIC8vIDxtZWRpYT4gZG9lc24ndCBhbGxvdyBpdHMgY29udGVudCwgaW5jbHVkaW5nIHNo YWRvdyBzdWJ0cmVlLCB0bworICAgIC8vIGJlIHJlbmRlcmVkLiBTbyB0aGlzIHNob3VsZCByZXR1 cm4gZmFsc2UgZm9yIG1vc3Qgb2YgdGhlIGNoaWxkcmVuLgorICAgIC8vIE9uZSBleGNlcHRpb24g aXMgYSBzaGFkb3cgdHJlZSBidWlsdCBmb3IgcmVuZGVyaW5nIGNvbnRyb2xzIHdoaWNoIHNob3Vs ZCBiZSB2aXNpYmxlLgorICAgIC8vIFNvIHdlIGxldCB0aGVtIGdvIGhlcmUgYnkgY29tcGFyaW5n IGl0cyBzdWJ0cmVlIHJvb3Qgd2l0aCBvbmUgb2YgdGhlIGNvbnRyb2xzLgogICAgIHJldHVybiAo bWVkaWFDb250cm9scygpLT50cmVlU2NvcGUoKSA9PSBjaGlsZENvbnRleHQubm9kZSgpLT50cmVl U2NvcGUoKQogICAgICAgICAgICAgJiYgY2hpbGRDb250ZXh0LmlzT25VcHBlckVuY2Fwc3VsYXRp b25Cb3VuZGFyeSgpICYmIEhUTUxFbGVtZW50OjpjaGlsZFNob3VsZENyZWF0ZVJlbmRlcmVyKGNo aWxkQ29udGV4dCkpOwogfQo=