91170 2012-07-12 17:32:21 -0700 webkitpy: make worker.start() and worker.stop() optional in the messagepool 2012-07-13 12:11:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke abarth ojan webkit.review.bot oldest_to_newest 668437 0 dpranke 2012-07-12 17:32:21 -0700 webkitpy: make worker.start() and worker.stop() optional in the messagepool 668445 1 152109 dpranke 2012-07-12 17:37:55 -0700 Created attachment 152109 Patch 669131 2 152109 ojan 2012-07-13 09:31:24 -0700 Comment on attachment 152109 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review > Tools/Scripts/webkitpy/common/message_pool.py:212 > + if hasattr(self._worker, 'stop'): Does "if self.worker.stop" throw an undefined error or something? 669153 3 dpranke 2012-07-13 09:58:46 -0700 (In reply to comment #2) > (From update of attachment 152109 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152109&action=review > > > Tools/Scripts/webkitpy/common/message_pool.py:212 > > + if hasattr(self._worker, 'stop'): > > Does "if self.worker.stop" throw an undefined error or something? Yes. 669329 4 dpranke 2012-07-13 12:11:42 -0700 Committed r122618: <http://trac.webkit.org/changeset/122618> 152109 2012-07-12 17:37:55 -0700 2012-07-13 09:31:23 -0700 Patch bug-91170-20120712173754.patch text/plain 2372 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTJiZmY2MmYxNDliN2VlZTIwMGU2MDFlYWFjYTliMWVl MjBhZDU0OC4uNWJlMjc4YzViNTgwOWU4MjE5ZDMyZGI1YzYzZDc5ZWUwMGIzNGY3NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA3LTEyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIHdlYmtpdHB5OiBtYWtlIHdvcmtlci5zdGFydCgpIGFuZCB3b3JrZXIuc3RvcCgpIG9w dGlvbmFsIGluIHRoZSBtZXNzYWdlcG9vbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTExNzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICB0ZXN0LXdlYmtpdHB5IHdpbGwgdXNlIG1lc3NhZ2Vwb29sIHdvcmtl cnMgdGhhdCBkb24ndCBhY3R1YWxseQorICAgICAgICBoYXZlIGFueSBwZXItd29ya2VyIHN0YXRl LCBzbyB0aGV5IGRvbid0IG5lZWQgc3RhcnQoKSBhbmQgc3RvcCgpCisgICAgICAgIG1ldGhvZHMu IE5vdyB3ZSB3aWxsIG9ubHkgY2FsbCB0aGUgbWV0aG9kcyBpZiB0aGV5IGV4aXN0OyB0aGlzCisg ICAgICAgIG1lYW5zIHRoYXQgd29ya2VycyBvbmx5IG5lZWQgdG8gZXhwb3NlIGEgaGFuZGxlKCkg bWV0aG9kLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbWVzc2FnZV9wb29s LnB5OgorICAgICAgICAoX1dvcmtlci50ZXJtaW5hdGUpOgorICAgICAgICAoX1dvcmtlci5ydW4p OgorCiAyMDEyLTA3LTEyICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbTmF2aWdhdGlvbiBUaW1pbmddIEltcG9ydCB0aGUgVzNDIE5hdmlnYXRpb24g VGltaW5nIHRlc3Qgc3VpdGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL21lc3NhZ2VfcG9vbC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL21lc3Nh Z2VfcG9vbC5weQppbmRleCA0MWViZTdkNTE5ZDY5ZTNhOTNiOTA1Mjk5YjBhYWE5NWEyNjcyY2Zh Li4xZTA4YzAyZGJhZmFjYjhiNTg0ZTJlYjlkZTkwY2U3M2FiMGRkN2JjIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9tZXNzYWdlX3Bvb2wucHkKKysrIGIvVG9vbHMv U2NyaXB0cy93ZWJraXRweS9jb21tb24vbWVzc2FnZV9wb29sLnB5CkBAIC0yMDksNyArMjA5LDgg QEAgY2xhc3MgX1dvcmtlcihtdWx0aXByb2Nlc3NpbmcuUHJvY2Vzcyk6CiAKICAgICBkZWYgdGVy bWluYXRlKHNlbGYpOgogICAgICAgICBpZiBzZWxmLl93b3JrZXI6Ci0gICAgICAgICAgICBzZWxm Ll93b3JrZXIuc3RvcCgpCisgICAgICAgICAgICBpZiBoYXNhdHRyKHNlbGYuX3dvcmtlciwgJ3N0 b3AnKToKKyAgICAgICAgICAgICAgICBzZWxmLl93b3JrZXIuc3RvcCgpCiAgICAgICAgICAgICBz ZWxmLl93b3JrZXIgPSBOb25lCiAgICAgICAgIGlmIHNlbGYuaXNfYWxpdmUoKToKICAgICAgICAg ICAgIHN1cGVyKF9Xb3JrZXIsIHNlbGYpLnRlcm1pbmF0ZSgpCkBAIC0yMzUsNyArMjM2LDggQEAg Y2xhc3MgX1dvcmtlcihtdWx0aXByb2Nlc3NpbmcuUHJvY2Vzcyk6CiAgICAgICAgIF9sb2cuZGVi dWcoIiVzIHN0YXJ0aW5nIiAlIHNlbGYubmFtZSkKIAogICAgICAgICB0cnk6Ci0gICAgICAgICAg ICB3b3JrZXIuc3RhcnQoKQorICAgICAgICAgICAgaWYgaGFzYXR0cih3b3JrZXIsICdzdGFydCcp OgorICAgICAgICAgICAgICAgIHdvcmtlci5zdGFydCgpCiAgICAgICAgICAgICB3aGlsZSBUcnVl OgogICAgICAgICAgICAgICAgIG1lc3NhZ2UgPSBzZWxmLl9tZXNzYWdlc190b193b3JrZXIuZ2V0 KCkKICAgICAgICAgICAgICAgICBpZiBtZXNzYWdlLmZyb21fdXNlcjoKQEAgLTI2MSw3ICsyNjMs OCBAQCBjbGFzcyBfV29ya2VyKG11bHRpcHJvY2Vzc2luZy5Qcm9jZXNzKToKICAgICAgICAgZmlu YWxseToKICAgICAgICAgICAgIF9sb2cuZGVidWcoIiVzIGV4aXRpbmclcyIgJSAoc2VsZi5uYW1l LCBleGNlcHRpb25fbXNnKSkKICAgICAgICAgICAgIHRyeToKLSAgICAgICAgICAgICAgICB3b3Jr ZXIuc3RvcCgpCisgICAgICAgICAgICAgICAgaWYgaGFzYXR0cih3b3JrZXIsICdzdG9wJyk6Cisg ICAgICAgICAgICAgICAgICAgIHdvcmtlci5zdG9wKCkKICAgICAgICAgICAgIGZpbmFsbHk6CiAg ICAgICAgICAgICAgICAgc2VsZi5fcG9zdChuYW1lPSdkb25lJywgYXJncz0oKSwgZnJvbV91c2Vy PUZhbHNlKQogICAgICAgICAgICAgc2VsZi5fY2xvc2UoKQo=