9113 2006-05-25 11:08:58 -0700 REGRESSION (14581): XMLHttpRequest never calls onreadystatechange with a readystate == 4 2006-06-02 10:30:49 -0700 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED Regression P1 Normal --- 8370 1 oster ggaren a.bob ap ggaren mitz oldest_to_newest 43561 0 oster 2006-05-25 11:08:58 -0700 Regression: 14581 XMLHttpRequest never calls onreadystatechange with a readystate == 4 When I make a POST XMLHttpRequest, my handler, assigned to onreadystatechange is never called with readystate == 4 /* 4 means "loaded" */ 14555 performed correctly. 43562 1 oster 2006-05-25 11:28:00 -0700 One place to see this bug: http://google.com/calendar Note the red box with the white text "Loading..." at the upper right of the page never goes away, only in this version of webKit. 44259 2 oster 2006-06-01 10:05:54 -0700 The bug always happens trying to load the main window of Google Calendar. My callback gets called with state==1, then never gets called again. The bug doesn't happen using the simple example on http://developer.apple.com/internet/webcontent/xmlhttpreq.html. (Uses 'GET') The bug doesn't happen using a custom cgi I wrote, which uses POST, and issues two requests operating in parallel (modeling what Google Calendar is doing). (I've also tried it with just a single outstanding request.) 44272 3 oster 2006-06-01 11:46:59 -0700 My guess is it needs to have a server that sends a redirect. Still trying to track it down. 44279 4 mitz 2006-06-01 12:13:30 -0700 The regression happened between r14566 and r14569, probably in r14569 (fix <rdar://problem/4557926>) due to the following: Also removed XMLHttpRequest from the DOM object cache because XMLHttpRequest objects aren't accessed through the DOM. 44280 5 8649 mitz 2006-06-01 12:24:05 -0700 Created attachment 8649 Undo the XMLHttpRequest change from r14569 Undoing the XMLHttpRequest part of r14569 fixes the regression, but I have no understanding of the DOM object cache. 44281 6 oster 2006-06-01 12:45:14 -0700 Thank you! It looks like, in my case, where the server redirects, that XMLHttpRequest->m_doc->m_view->m_frame becomes nil, sometime between the request's send() has been called. The fix you made possibly keeps the frame from being improperly garbage collected. 44289 7 ddkilzer 2006-06-01 13:24:37 -0700 (In reply to comment #3) > My guess is it needs to have a server that sends a redirect. Still trying to > track it down. Note that the LayoutTests now support "http" tests that run as CGI scripts on an Apache web server, so it should be possible to write a test case for this. I think it's safe to confirm this bug now, too. 44295 8 8652 ggaren 2006-06-01 14:45:07 -0700 Created attachment 8652 Mitz's patch w/changelog and layout test Uploading for posterity. 44297 9 ggaren 2006-06-01 14:47:23 -0700 Committed revision 14671. 44397 10 oster 2006-06-02 10:30:49 -0700 Verified. This fixes my problem with Google Calendar. Thanks guys! 8649 2006-06-01 12:24:05 -0700 2006-06-01 14:45:07 -0700 Undo the XMLHttpRequest change from r14569 9113_r0.patch text/plain 736 mitz SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvSlNYTUxIdHRwUmVxdWVzdC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0LmNwcAkocmV2aXNpb24g MTQ2NjcpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3QuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNTQsMTIgKzE1NCwxNCBAQCBKU1hNTEh0dHBSZXF1ZXN0OjpKU1hNTEh0 dHBSZXF1ZXN0KEV4ZWNTCiAgIDogbV9pbXBsKG5ldyBYTUxIdHRwUmVxdWVzdChkKSkKIHsKICAg c2V0UHJvdG90eXBlKEpTWE1MSHR0cFJlcXVlc3RQcm90bzo6c2VsZihleGVjKSk7CisgIFNjcmlw dEludGVycHJldGVyOjpwdXRET01PYmplY3QobV9pbXBsLmdldCgpLCB0aGlzKTsKIH0KIAogSlNY TUxIdHRwUmVxdWVzdDo6fkpTWE1MSHR0cFJlcXVlc3QoKQogewogICBtX2ltcGwtPnNldE9uUmVh ZHlTdGF0ZUNoYW5nZUxpc3RlbmVyKDApOwogICBtX2ltcGwtPnNldE9uTG9hZExpc3RlbmVyKDAp OworICBTY3JpcHRJbnRlcnByZXRlcjo6Zm9yZ2V0RE9NT2JqZWN0KG1faW1wbC5nZXQoKSk7CiB9 CiAKIEpTVmFsdWUqIEpTWE1MSHR0cFJlcXVlc3RQcm90b0Z1bmM6OmNhbGxBc0Z1bmN0aW9uKEV4 ZWNTdGF0ZSAqZXhlYywgSlNPYmplY3QqIHRoaXNPYmosIGNvbnN0IExpc3QmIGFyZ3MpCg== 8652 2006-06-01 14:45:07 -0700 2006-06-01 14:45:07 -0700 Mitz's patch w/changelog and layout test patch-xmlttprequest.txt text/plain 4959 ggaren SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0NjY5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDYtMDYtMDEgIEdlb2ZmcmV5IEdhcmVuICA8 Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICAtIFRlc3QgZm9yIGh0dHA6Ly9idWd6aWxsYS5v cGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTExMworICAgICAgICBSRUdSRVNTSU9OICgx NDU4MSk6IFhNTEh0dHBSZXF1ZXN0IG5ldmVyIGNhbGxzIG9ucmVhZHlzdGF0ZWNoYW5nZSB3aXRo IAorICAgICAgICBhIHJlYWR5c3RhdGUgPT0gNAorCisgICAgICAgICogaHR0cC90ZXN0cy94bWxo dHRwcmVxdWVzdC9ldmVudC1saXN0ZW5lci1nYy5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBodHRw L3Rlc3RzL3htbGh0dHByZXF1ZXN0L2V2ZW50LWxpc3RlbmVyLWdjLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisKIDIwMDYtMDYtMDEgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rl c3RzL3htbGh0dHByZXF1ZXN0L2V2ZW50LWxpc3RlbmVyLWdjLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9ldmVudC1saXN0ZW5lci1nYy5o dG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVxdWVz dC9ldmVudC1saXN0ZW5lci1nYy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUxIEBACis8 aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHdyaXRlKHMpCit7CisgICAgZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoJ3ByZScpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHRO b2RlKHMpKTsKK30KKwordmFyIGRpZENvbGxlY3QgPSBmYWxzZTsKK2Z1bmN0aW9uIGNvbGxlY3Qo KQoreworICAgIGRpZENvbGxlY3QgPSB0cnVlOworICAgIGlmICh3aW5kb3cuR0NDb250cm9sbGVy KQorICAgICAgICBHQ0NvbnRyb2xsZXIuY29sbGVjdCgpOworICAgIGVsc2UKKyAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCAxMDAwMDsgaSsrKSAvLyA+CisgICAgICAgICAgICBuZXcgU3RyaW5n KCIiKTsKK30KKworZnVuY3Rpb24gcHJvY2Vzc1N0YXRlQ2hhbmdlKCkKK3sKKyAgICBpZiAoZGlk Q29sbGVjdCkKKyAgICAgICAgd3JpdGUoIlBBU1M6IGV2ZW50IGhhbmRsZXIgZmlyZWQgYWZ0ZXIg Z2FyYmFnZSBjb2xsZWN0aW9uLlxuIik7Cit9CisKK2Z1bmN0aW9uIHRlc3QoKSAKK3sKKyAgICBp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgIAorICAgIHZhciByZXF1ZXN0ID0gbmV3IFhNTEh0 dHBSZXF1ZXN0KCk7CisgICAgcmVxdWVzdC5vbnJlYWR5c3RhdGVjaGFuZ2UgPSBwcm9jZXNzU3Rh dGVDaGFuZ2U7CisgICAgcmVxdWVzdC5vcGVuKCJHRVQiLCAicHJpbnQtY29udGVudC10eXBlLmNn aSIsIHRydWUpOworICAgIHJlcXVlc3Quc2VuZChudWxsKTsKKyAgICAKKyAgICBzZXRUaW1lb3V0 KCdjb2xsZWN0KCk7JywgMCk7IC8vIHRpbWVvdXQgZW5zdXJlcyBzdGFjayByZWZlcmVuY2VzIHRv IHJlcXVlc3QgYXJlIGNsZWFyZWQgd2hlbiB3ZSBjb2xsZWN0Cit9Cis8L3NjcmlwdD4KKzwvaGVh ZD4KKworPGJvZHkgb25sb2FkPSJ0ZXN0KCk7Ij4KKzxwPlRoaXMgdGVzdCBjaGVja3Mgd2hldGhl ciBldmVudCBoYW5kbGVycyBmb3Igb3V0c3RhbmRpbmcgWE1MSHR0cFJlcXVlc3RzIHN1cnZpdmUg Z2FyYmFnZSBjb2xsZWN0aW9uLjwvcD4KKzxwPlNlZSBodHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTkxMTMgUkVHUkVTU0lPTiAoMTQ1ODEpOiAKK1hNTEh0dHBS ZXF1ZXN0IG5ldmVyIGNhbGxzIG9ucmVhZHlzdGF0ZWNoYW5nZSB3aXRoIGEgcmVhZHlzdGF0ZSA9 PSA0PC9wPgorPHA+SWYgdGhlIHRlc3QgcGFzc2VzLCB5b3UnbGwgc2VlIGEgc2VyaWVzIG9mICdQ QVNTJyBtZXNzYWdlcyBiZWxvdy48L3A+Cis8aHI+CisKKzxwcmUgaWQ9J3ByZSc+PC9wcmU+CisK KzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJl cXVlc3QvZXZlbnQtbGlzdGVuZXItZ2MtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2h0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvZXZlbnQtbGlzdGVuZXItZ2MtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy94bWxodHRwcmVx dWVzdC9ldmVudC1saXN0ZW5lci1nYy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTAgQEAKK1RoaXMgdGVzdCBjaGVja3Mgd2hldGhlciBldmVudCBoYW5kbGVycyBmb3Igb3V0 c3RhbmRpbmcgWE1MSHR0cFJlcXVlc3RzIHN1cnZpdmUgZ2FyYmFnZSBjb2xsZWN0aW9uLgorCitT ZWUgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05MTEzIFJF R1JFU1NJT04gKDE0NTgxKTogWE1MSHR0cFJlcXVlc3QgbmV2ZXIgY2FsbHMgb25yZWFkeXN0YXRl Y2hhbmdlIHdpdGggYSByZWFkeXN0YXRlID09IDQKKworSWYgdGhlIHRlc3QgcGFzc2VzLCB5b3Un bGwgc2VlIGEgc2VyaWVzIG9mICdQQVNTJyBtZXNzYWdlcyBiZWxvdy4KKworUEFTUzogZXZlbnQg aGFuZGxlciBmaXJlZCBhZnRlciBnYXJiYWdlIGNvbGxlY3Rpb24uCitQQVNTOiBldmVudCBoYW5k bGVyIGZpcmVkIGFmdGVyIGdhcmJhZ2UgY29sbGVjdGlvbi4KK1BBU1M6IGV2ZW50IGhhbmRsZXIg ZmlyZWQgYWZ0ZXIgZ2FyYmFnZSBjb2xsZWN0aW9uLgorCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdz L2pzL0pTWE1MSHR0cFJlcXVlc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mv anMvSlNYTUxIdHRwUmVxdWVzdC5jcHAJKHJldmlzaW9uIDE0NjQ4KQorKysgV2ViQ29yZS9iaW5k aW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0LDEyICsx NTQsMTQgQEAgSlNYTUxIdHRwUmVxdWVzdDo6SlNYTUxIdHRwUmVxdWVzdChFeGVjUwogICA6IG1f aW1wbChuZXcgWE1MSHR0cFJlcXVlc3QoZCkpCiB7CiAgIHNldFByb3RvdHlwZShKU1hNTEh0dHBS ZXF1ZXN0UHJvdG86OnNlbGYoZXhlYykpOworICBTY3JpcHRJbnRlcnByZXRlcjo6cHV0RE9NT2Jq ZWN0KG1faW1wbC5nZXQoKSwgdGhpcyk7CiB9CiAKIEpTWE1MSHR0cFJlcXVlc3Q6On5KU1hNTEh0 dHBSZXF1ZXN0KCkKIHsKICAgbV9pbXBsLT5zZXRPblJlYWR5U3RhdGVDaGFuZ2VMaXN0ZW5lcigw KTsKICAgbV9pbXBsLT5zZXRPbkxvYWRMaXN0ZW5lcigwKTsKKyAgU2NyaXB0SW50ZXJwcmV0ZXI6 OmZvcmdldERPTU9iamVjdChtX2ltcGwuZ2V0KCkpOwogfQogCiBKU1ZhbHVlKiBKU1hNTEh0dHBS ZXF1ZXN0UHJvdG9GdW5jOjpjYWxsQXNGdW5jdGlvbihFeGVjU3RhdGUgKmV4ZWMsIEpTT2JqZWN0 KiB0aGlzT2JqLCBjb25zdCBMaXN0JiBhcmdzKQpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0NjY4KQorKysgV2ViQ29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMyBAQAorMjAwNi0wNi0wMSAg R2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBieSBNaXR6 LiBSZXZpZXdlZCwgdHdlYWtlZCwgdGVzdGVkLCBsYW5kZWQgYnkgbWUuCisKKyAgICAgICAgLSBG aXhlZCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTkxMTMK KyAgICAgICAgUkVHUkVTU0lPTiAoMTQ1ODEpOiBYTUxIdHRwUmVxdWVzdCBuZXZlciBjYWxscyBv bnJlYWR5c3RhdGVjaGFuZ2Ugd2l0aCAKKyAgICAgICAgYSByZWFkeXN0YXRlID09IDQKKyAgICAg ICAgCisgICAgICAgIEFuIFhNTEh0dHBSZXF1ZXN0IG11c3QgYmUgYWRkZWQgdG8gdGhlIERPTU9i amVjdCBjYWNoZSBzbyB0aGF0IGl0cworICAgICAgICBET00gaW1wbGVtZW50YXRpb24gb2JqZWN0 IGNhbiBwcm90ZWN0IGl0LCBhbmQgYnkgZXh0ZW5zaW9uLCBpdHMgZXZlbnQKKyAgICAgICAgbGlz dGVuZXJzLgorICAgICAgICAKKyAgICAgICAgVGhpcyBkZXNpZ24gc2VlbXMgc2xpZ2h0bHkgYmFj a3dhcmRzIHRvIG1lIC0tIHRoZSBiaW5kaW5ncyBzaG91bGQga25vdworICAgICAgICBhYm91dCB0 aGUgRE9NLCBub3QgdGhlIG90aGVyIHdheSBhcm91bmQgLS0gYnV0IEknbSByZXN0b3JpbmcgaXQg Zm9yCisgICAgICAgIG5vdyB0byBmaXggdGhlIHJlZ3Jlc3Npb24uCisgICAgICAgIAorICAgICAg ICAqIGJpbmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3QuY3BwOgorICAgICAgICAoS0pTOjpKU1hN TEh0dHBSZXF1ZXN0OjpKU1hNTEh0dHBSZXF1ZXN0KToKKyAgICAgICAgKEtKUzo6SlNYTUxIdHRw UmVxdWVzdDo6fkpTWE1MSHR0cFJlcXVlc3QpOgorCiAyMDA2LTA2LTAxICBBbmRlcnMgQ2FybHNz b24gIDxhY2FybHNzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llai4K