91129 2012-07-12 11:50:16 -0700 NRWT doesn't print exceptions 2012-07-16 03:45:24 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91370 1 wangxianzhu dpranke abarth dpranke ojan tmpsantos tony webkit.review.bot oldest_to_newest 668047 0 wangxianzhu 2012-07-12 11:50:16 -0700 On exception occurred in the main program, NRWT just exits with status EXCEPTIONAL_EXIT_STATUS but doesn't print the exception, making it difficult to debug the issue. To test: 1. Create a syntax error in port/webkit.py 2. Run NRWT Actual result: NRWT just exists without any error message Expected result: NRWT should print the error. In addition, if some worker raises some exception, NRWT just print the stack trace without the type and message of the exception. 668495 1 152129 dpranke 2012-07-12 18:53:30 -0700 Created attachment 152129 Patch 668498 2 webkit.review.bot 2012-07-12 18:56:06 -0700 Attachment 152129 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/common/message_pool.py:277: deprecated form of raising exception [pep8/W602] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 668500 3 dpranke 2012-07-12 18:57:35 -0700 (In reply to comment #2) > Attachment 152129 [details] did not pass style-queue: > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 > Tools/Scripts/webkitpy/common/message_pool.py:277: deprecated form of raising exception [pep8/W602] [5] > Total errors found: 1 in 4 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. This style error is unavoidable and can be ignored. 669130 4 152129 ojan 2012-07-13 09:29:50 -0700 Comment on attachment 152129 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=152129&action=review > Tools/Scripts/webkitpy/common/message_pool.py:284 > + _log.error("%s: %s('%s') raised:" % ( > + self.name, exception_value.__class__.__name__, str(exception_value))) Nit: I think this would be easier to read on one long line. 669323 5 dpranke 2012-07-13 12:07:19 -0700 (In reply to comment #4) > (From update of attachment 152129 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=152129&action=review > > > Tools/Scripts/webkitpy/common/message_pool.py:284 > > + _log.error("%s: %s('%s') raised:" % ( > > + self.name, exception_value.__class__.__name__, str(exception_value))) > > Nit: I think this would be easier to read on one long line. You're right. Done. 669324 6 dpranke 2012-07-13 12:08:36 -0700 Committed r122615: <http://trac.webkit.org/changeset/122615> 670225 7 tmpsantos 2012-07-16 03:45:24 -0700 This patch makes the runner returns a error code when it succeeds. I have a fix for it at bug 91370. 152129 2012-07-12 18:53:30 -0700 2012-07-13 09:29:50 -0700 Patch bug-91129-20120712185329.patch text/plain 6819 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNTI5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTJiZmY2MmYxNDliN2VlZTIwMGU2MDFlYWFjYTliMWVl MjBhZDU0OC4uZTlmNjJjZjUxY2UwNTZhNmVhNWMxZDk0YjZkZTc1MDVjMzk0ZWQwOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDEyLTA3LTEyICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIE5SV1QgZG9lc24ndCBwcmludCBleGNlcHRpb25zCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTEyOQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsdGhvdWdoIHdlIHByaW50ZWQgZXhjZXB0aW9u cyBpbiBtb3N0IGNhc2VzLCBpZiBhbiB1bmV4cGVjdGVkCisgICAgICAgIGV4Y2VwdGlvbiAobGlr ZSBhIHJ1bnRpbWUgZXJyb3IpIHdhcyByYWlzZWQgd2hlbiBjcmVhdGluZyBhCisgICAgICAgIHBv cnQsIHdlIHdvdWxkbid0LiBUaGlzIHBhdGNoIGZpeGVzIHRoYXQsIGFuZCBhbHNvIGNsZWFucyB1 cAorICAgICAgICBob3cgd2Ugd2VyZSBsb2dnaW5nIGV4Y2VwdGlvbnMgZnJvbSB0aGUgd29ya2Vy cyB0byBiZSBsZXNzCisgICAgICAgIHZlcmJvc2UuCisKKyAgICAgICAgQmVjYXVzZSBvZiB0aGUg Y29ybmVyIGNhc2VzIHdoZXJlIHRoZXNlIGVycm9ycyBhcmUgb2NjdXJyaW5nLAorICAgICAgICBp dCdzIGRpZmZpY3VsdCB0byB3cml0ZSBhdXRvbWF0ZWQgdW5pdCB0ZXN0cyBmb3IgdGhlbS4gSSd2 ZQorICAgICAgICB0ZXN0ZWQgaXQgcXVpdGUgYSBiaXQgYnkgaGFuZCwgdGhvdWdoLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vbWVzc2FnZV9wb29sLnB5OgorICAgICAgICAo X01lc3NhZ2VQb29sLl9jbG9zZSk6CisgICAgICAgIChfTWVzc2FnZVBvb2wuX2hhbmRsZV93b3Jr ZXJfZXhjZXB0aW9uKToKKyAgICAgICAgKF9Xb3JrZXIucnVuKToKKyAgICAgICAgKF9Xb3JrZXIu X3JhaXNlKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9s bGVycy9tYW5hZ2VyLnB5OgorICAgICAgICAoTWFuYWdlci5fcnVuX3Rlc3RzKToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5OgorICAg ICAgICAobWFpbik6CisKIDIwMTItMDctMTIgIEphbWVzIFNpbW9uc2VuICA8c2ltb25qYW1AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtOYXZpZ2F0aW9uIFRpbWluZ10gSW1wb3J0IHRoZSBXM0Mg TmF2aWdhdGlvbiBUaW1pbmcgdGVzdCBzdWl0ZQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9jb21tb24vbWVzc2FnZV9wb29sLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vbWVzc2FnZV9wb29sLnB5CmluZGV4IDQxZWJlN2Q1MTlkNjllM2E5M2I5MDUyOTliMGFh YTk1YTI2NzJjZmEuLjQ1NDE3YThlYTVlODkwYmQ5YzY3NDZmNTE0M2VlOTMzNWE1ZjhiNmMgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL21lc3NhZ2VfcG9vbC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9tZXNzYWdlX3Bvb2wucHkKQEAgLTEy OCw2ICsxMjgsOCBAQCBjbGFzcyBfTWVzc2FnZVBvb2wob2JqZWN0KToKICAgICAgICAgICAgICAg ICB3b3JrZXIuam9pbigpCiAgICAgICAgIHNlbGYuX3dvcmtlcnMgPSBbXQogICAgICAgICBpZiBu b3Qgc2VsZi5fcnVubmluZ19pbmxpbmU6CisgICAgICAgICAgICAjIEZJWE1FOiBUaGlzIGlzIGEg aGFjayB0byBnZXQgbXVsdGlwcm9jZXNzaW5nIHRvIG5vdCBsb2cgdHJhY2ViYWNrcyBkdXJpbmcg c2h1dGRvd24gOiguCisgICAgICAgICAgICBtdWx0aXByb2Nlc3NpbmcudXRpbC5fZXhpdGluZyA9 IFRydWUKICAgICAgICAgICAgIGlmIHNlbGYuX21lc3NhZ2VzX3RvX3dvcmtlcjoKICAgICAgICAg ICAgICAgICBzZWxmLl9tZXNzYWdlc190b193b3JrZXIuY2xvc2UoKQogICAgICAgICAgICAgICAg IHNlbGYuX21lc3NhZ2VzX3RvX3dvcmtlciA9IE5vbmUKQEAgLTE0Niw4ICsxNDgsNiBAQCBjbGFz cyBfTWVzc2FnZVBvb2wob2JqZWN0KToKICAgICBkZWYgX2hhbmRsZV93b3JrZXJfZXhjZXB0aW9u KHNvdXJjZSwgZXhjZXB0aW9uX3R5cGUsIGV4Y2VwdGlvbl92YWx1ZSwgXyk6CiAgICAgICAgIGlm IGV4Y2VwdGlvbl90eXBlID09IEtleWJvYXJkSW50ZXJydXB0OgogICAgICAgICAgICAgcmFpc2Ug ZXhjZXB0aW9uX3R5cGUoZXhjZXB0aW9uX3ZhbHVlKQotICAgICAgICBfbG9nLmVycm9yKCIlcyBy YWlzZWQgJXMoJyVzJyk6IiAlICgKLSAgICAgICAgICAgICAgICAgICBzb3VyY2UsIGV4Y2VwdGlv bl92YWx1ZS5fX2NsYXNzX18uX19uYW1lX18sIHN0cihleGNlcHRpb25fdmFsdWUpKSkKICAgICAg ICAgcmFpc2UgV29ya2VyRXhjZXB0aW9uKHN0cihleGNlcHRpb25fdmFsdWUpKQogCiAgICAgZGVm IF9jYW5fcGlja2xlKHNlbGYsIGhvc3QpOgpAQCAtMjQ1LDIxICsyNDUsMTQgQEAgY2xhc3MgX1dv cmtlcihtdWx0aXByb2Nlc3NpbmcuUHJvY2Vzcyk6CiAgICAgICAgICAgICAgICAgICAgIGFzc2Vy dCBtZXNzYWdlLm5hbWUgPT0gJ3N0b3AnLCAnYmFkIG1lc3NhZ2UgJXMnICUgcmVwcihtZXNzYWdl KQogICAgICAgICAgICAgICAgICAgICBicmVhawogCisgICAgICAgICAgICBfbG9nLmRlYnVnKCIl cyBleGl0aW5nIiAlIHNlbGYubmFtZSkKICAgICAgICAgZXhjZXB0IFF1ZXVlLkVtcHR5OgogICAg ICAgICAgICAgYXNzZXJ0IEZhbHNlLCAnJXM6IHJhbiBvdXQgb2YgbWVzc2FnZXMgaW4gd29ya2Vy IHF1ZXVlLicgJSBzZWxmLm5hbWUKICAgICAgICAgZXhjZXB0IEtleWJvYXJkSW50ZXJydXB0LCBl OgotICAgICAgICAgICAgZXhjZXB0aW9uX21zZyA9ICIsIGludGVycnVwdGVkIgotICAgICAgICAg ICAgaWYgbm90IHNlbGYuX3J1bm5pbmdfaW5saW5lOgotICAgICAgICAgICAgICAgIF9sb2cud2Fy bmluZygnd29ya2VyIGV4Y2VwdGlvbicpCi0gICAgICAgICAgICAgICAgc2VsZi5fcmFpc2Uoc3lz LmV4Y19pbmZvKCkpCi0gICAgICAgICAgICByYWlzZQorICAgICAgICAgICAgc2VsZi5fcmFpc2Uo c3lzLmV4Y19pbmZvKCkpCiAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24sIGU6Ci0gICAgICAgICAg ICBleGNlcHRpb25fbXNnID0gIiwgZXhjZXB0aW9uIHJhaXNlZDogJXMiICUgc3RyKGUpCi0gICAg ICAgICAgICBpZiBub3Qgc2VsZi5fcnVubmluZ19pbmxpbmU6Ci0gICAgICAgICAgICAgICAgc2Vs Zi5fcmFpc2Uoc3lzLmV4Y19pbmZvKCkpCi0gICAgICAgICAgICByYWlzZQorICAgICAgICAgICAg c2VsZi5fcmFpc2Uoc3lzLmV4Y19pbmZvKCkpCiAgICAgICAgIGZpbmFsbHk6Ci0gICAgICAgICAg ICBfbG9nLmRlYnVnKCIlcyBleGl0aW5nJXMiICUgKHNlbGYubmFtZSwgZXhjZXB0aW9uX21zZykp CiAgICAgICAgICAgICB0cnk6CiAgICAgICAgICAgICAgICAgd29ya2VyLnN0b3AoKQogICAgICAg ICAgICAgZmluYWxseToKQEAgLTI3OSw5ICsyNzIsMTggQEAgY2xhc3MgX1dvcmtlcihtdWx0aXBy b2Nlc3NpbmcuUHJvY2Vzcyk6CiAgICAgICAgIHNlbGYuX21lc3NhZ2VzX3RvX21hbmFnZXIucHV0 KF9NZXNzYWdlKHNlbGYubmFtZSwgbmFtZSwgYXJncywgZnJvbV91c2VyLCBsb2dfbWVzc2FnZXMp KQogCiAgICAgZGVmIF9yYWlzZShzZWxmLCBleGNfaW5mbyk6Ci0gICAgICAgICMgU2luY2UgdHJh Y2ViYWNrcyBhcmVuJ3QgcGlja2xhYmxlLCBzZW5kIHRoZSBleHRyYWN0ZWQgc3RhY2sgaW5zdGVh ZC4KICAgICAgICAgZXhjZXB0aW9uX3R5cGUsIGV4Y2VwdGlvbl92YWx1ZSwgZXhjZXB0aW9uX3Ry YWNlYmFjayA9IGV4Y19pbmZvCi0gICAgICAgIHN0YWNrX3V0aWxzLmxvZ190cmFjZWJhY2soX2xv Zy5lcnJvciwgZXhjZXB0aW9uX3RyYWNlYmFjaykKKyAgICAgICAgaWYgc2VsZi5fcnVubmluZ19p bmxpbmU6CisgICAgICAgICAgICByYWlzZSBleGNlcHRpb25fdHlwZSwgZXhjZXB0aW9uX3ZhbHVl LCBleGNlcHRpb25fdHJhY2ViYWNrCisKKyAgICAgICAgaWYgZXhjZXB0aW9uX3R5cGUgPT0gS2V5 Ym9hcmRJbnRlcnJ1cHQ6CisgICAgICAgICAgICBfbG9nLmRlYnVnKCIlczogaW50ZXJydXB0ZWQs IGV4aXRpbmciICUgc2VsZi5uYW1lKQorICAgICAgICAgICAgc3RhY2tfdXRpbHMubG9nX3RyYWNl YmFjayhfbG9nLmRlYnVnLCBleGNlcHRpb25fdHJhY2ViYWNrKQorICAgICAgICBlbHNlOgorICAg ICAgICAgICAgX2xvZy5lcnJvcigiJXM6ICVzKCclcycpIHJhaXNlZDoiICUgKAorICAgICAgICAg ICAgICAgICAgICBzZWxmLm5hbWUsIGV4Y2VwdGlvbl92YWx1ZS5fX2NsYXNzX18uX19uYW1lX18s IHN0cihleGNlcHRpb25fdmFsdWUpKSkKKyAgICAgICAgICAgIHN0YWNrX3V0aWxzLmxvZ190cmFj ZWJhY2soX2xvZy5lcnJvciwgZXhjZXB0aW9uX3RyYWNlYmFjaykKKyAgICAgICAgIyBTaW5jZSB0 cmFjZWJhY2tzIGFyZW4ndCBwaWNrbGFibGUsIHNlbmQgdGhlIGV4dHJhY3RlZCBzdGFjayBpbnN0 ZWFkLgogICAgICAgICBzdGFjayA9IHRyYWNlYmFjay5leHRyYWN0X3RiKGV4Y2VwdGlvbl90cmFj ZWJhY2spCiAgICAgICAgIHNlbGYuX3Bvc3QobmFtZT0nd29ya2VyX2V4Y2VwdGlvbicsIGFyZ3M9 KGV4Y2VwdGlvbl90eXBlLCBleGNlcHRpb25fdmFsdWUsIHN0YWNrKSwgZnJvbV91c2VyPUZhbHNl KQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250 cm9sbGVycy9tYW5hZ2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMv Y29udHJvbGxlcnMvbWFuYWdlci5weQppbmRleCA1NTAwYzFhYmI3MjhiN2M3NDA2YzRkZDQxYzMz M2RjMjM3MTc4NDA0Li4xMTY5NGUyNmE4MGQ3NGQ4ZWU5ZGE4NTg5MTU1ODU3YmVjZTA1MGJmIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVy cy9tYW5hZ2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2Nv bnRyb2xsZXJzL21hbmFnZXIucHkKQEAgLTc4Miw4ICs3ODIsOCBAQCBjbGFzcyBNYW5hZ2VyKG9i amVjdCk6CiAgICAgICAgIGV4Y2VwdCBUZXN0UnVuSW50ZXJydXB0ZWRFeGNlcHRpb24sIGU6CiAg ICAgICAgICAgICBfbG9nLndhcm5pbmcoZS5yZWFzb24pCiAgICAgICAgICAgICBpbnRlcnJ1cHRl ZCA9IFRydWUKLSAgICAgICAgZXhjZXB0OgotICAgICAgICAgICAgX2xvZy5lcnJvcigiRXhjZXB0 aW9uIHJhaXNlZCwgZXhpdGluZyIpCisgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24sIGU6CisgICAg ICAgICAgICBfbG9nLmRlYnVnKCclcygiJXMiKSByYWlzZWQsIGV4aXRpbmcnICUgKGUuX19jbGFz c19fLl9fbmFtZV9fLCBzdHIoZSkpKQogICAgICAgICAgICAgcmFpc2UKICAgICAgICAgZmluYWxs eToKICAgICAgICAgICAgIHNlbGYuc3RvcF9zZXJ2ZXJzX3dpdGhfbG9jaygpCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5w eQppbmRleCBlM2ExM2MyMGZlMDhiNzQyZGJhNTY5M2IyODRjMzdmZDYzYzUxZGVmLi43YTUzMzlm MDMyNmFiZDAxYjhhNDBmNGE3NzMyZTY4ZDY4NTg3YTNjIDEwMDc1NQotLS0gYS9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKQEAgLTM1 LDYgKzM1LDcgQEAgaW1wb3J0IG9wdHBhcnNlCiBpbXBvcnQgb3MKIGltcG9ydCBzaWduYWwKIGlt cG9ydCBzeXMKK2ltcG9ydCB0cmFjZWJhY2sKIAogZnJvbSB3ZWJraXRweS5jb21tb24uaG9zdCBp bXBvcnQgSG9zdAogZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtIGltcG9ydCBzdGFja191dGls cwpAQCAtNDY0LDYgKzQ2NSw5IEBAIGRlZiBtYWluKGFyZ3Y9Tm9uZSk6CiAgICAgICAgICMgRklY TUU6IGlzIHRoaXMgdGhlIGJlc3Qgd2F5IHRvIGhhbmRsZSB1bnN1cHBvcnRlZCBwb3J0IG5hbWVz PwogICAgICAgICBwcmludCA+PiBzeXMuc3RkZXJyLCBzdHIoZSkKICAgICAgICAgcmV0dXJuIEVY Q0VQVElPTkFMX0VYSVRfU1RBVFVTCisgICAgZXhjZXB0OgorICAgICAgICB0cmFjZWJhY2sucHJp bnRfZXhjKGZpbGU9c3lzLnN0ZGVycikKKyAgICAgICAgcmFpc2UKIAogICAgIGxvZ2dpbmcuZ2V0 TG9nZ2VyKCkuc2V0TGV2ZWwobG9nZ2luZy5ERUJVRyBpZiBvcHRpb25zLnZlcmJvc2UgZWxzZSBs b2dnaW5nLklORk8pCiAgICAgcmV0dXJuIHJ1bihwb3J0LCBvcHRpb25zLCBhcmdzKQpAQCAtNDcy LDcgKzQ3Niw3IEBAIGRlZiBtYWluKGFyZ3Y9Tm9uZSk6CiBpZiAnX19tYWluX18nID09IF9fbmFt ZV9fOgogICAgIHRyeToKICAgICAgICAgc3lzLmV4aXQobWFpbigpKQotICAgIGV4Y2VwdCBFeGNl cHRpb24sIGU6CisgICAgZXhjZXB0IEJhc2VFeGNlcHRpb24sIGU6CiAgICAgICAgIGlmIGUuX19j bGFzc19fIGluIChLZXlib2FyZEludGVycnVwdCwgVGVzdFJ1bkludGVycnVwdGVkRXhjZXB0aW9u KToKICAgICAgICAgICAgIHN5cy5leGl0KElOVEVSUlVQVEVEX0VYSVRfU1RBVFVTKQogICAgICAg ICBzeXMuZXhpdChFWENFUFRJT05BTF9FWElUX1NUQVRVUykK