91112 2012-07-12 09:52:42 -0700 REGRESSION (r122450?): Layout Test fast/dom/attribute-empty-value-no-children.html is failing 2012-07-30 04:03:38 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 wjmaclean kling andersca ap cmarcelo kling koivisto rniwa vsevik webkit.review.bot oldest_to_newest 667895 0 wjmaclean 2012-07-12 09:52:42 -0700 The following layout test is failing on Linux/Windows Debug fast/dom/attribute-empty-value-no-children.html Probable cause: http://trac.webkit.org/changeset/122450 668911 1 kling 2012-07-13 05:29:43 -0700 Hum. I can't reproduce this problem. Can I see this failure (diff/stacktrace/something else?) on the web somewhere? 668986 2 wjmaclean 2012-07-13 07:04:39 -0700 (In reply to comment #1) > Hum. I can't reproduce this problem. Can I see this failure (diff/stacktrace/something else?) on the web somewhere? It's failing pretty consistently on the WebKit Linux (dbg) and WebKit Win (dbg)(1) test bots: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fdom%2Fattribute-empty-value-no-children.html 669032 3 152262 kling 2012-07-13 07:51:22 -0700 Created attachment 152262 Patch 669096 4 kling 2012-07-13 08:59:01 -0700 *** Bug 91254 has been marked as a duplicate of this bug. *** 669100 5 vsevik 2012-07-13 09:01:56 -0700 Skipped: http://trac.webkit.org/changeset/122588 Please unskip before landing. 681844 6 kling 2012-07-30 04:03:38 -0700 (In reply to comment #5) > Skipped: http://trac.webkit.org/changeset/122588 > > Please unskip before landing. It was unskipped already, and the patch that caused the regression was rolled out. 152262 2012-07-13 07:51:22 -0700 2012-07-13 09:44:40 -0700 Patch bug-91112.diff text/plain 1576 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYzY5M2NmLi5mMzNlZGExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDctMTMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIxMjI0NTA/KTogTGF5b3V0IFRlc3QgZmFzdC9kb20vYXR0cmlidXRl LWVtcHR5LXZhbHVlLW5vLWNoaWxkcmVuLmh0bWwgaXMgZmFpbGluZy4KKyAgICAgICAgPGh0dHA6 Ly93ZWJraXQub3JnL2IvOTExMTI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTWFrZSBET00gQXR0ciBtdXRhdGlvbiBjb252ZXJ0IHRoZSB1bmRlcmx5 aW5nIEVsZW1lbnQncyBFbGVtZW50QXR0cmlidXRlRGF0YSB0byBhIG11dGFibGUKKyAgICAgICAg b2JqZWN0IGlmIG5lY2Vzc2FyeS4KKworICAgICAgICAqIGRvbS9BdHRyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkF0dHI6OmVsZW1lbnRBdHRyaWJ1dGUpOgorICAgICAgICAoV2ViQ29yZTo6QXR0 cjo6ZGV0YWNoRnJvbUVsZW1lbnRXaXRoVmFsdWUpOgorCiAyMDEyLTA3LTEzICBEb21pbmljIE1h enpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIFNob3VsZCBiZSBwb3NzaWJs ZSB0byBmb2N1cyBlbGVtZW50cyB3aXRoaW4gY2FudmFzIGZhbGxiYWNrIGNvbnRlbnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9BdHRyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9B dHRyLmNwcAppbmRleCBkZTllNGZmLi41YjUzNmFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vQXR0ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0F0dHIuY3BwCkBAIC0yMTEs MTQgKzIxMSwxNCBAQCBBdHRyaWJ1dGUmIEF0dHI6OmVsZW1lbnRBdHRyaWJ1dGUoKQogewogICAg IEFTU0VSVChtX2VsZW1lbnQpOwogICAgIEFTU0VSVChtX2VsZW1lbnQtPmF0dHJpYnV0ZURhdGEo KSk7Ci0gICAgcmV0dXJuICptX2VsZW1lbnQtPmdldEF0dHJpYnV0ZUl0ZW0ocXVhbGlmaWVkTmFt ZSgpKTsKKyAgICByZXR1cm4gKm1fZWxlbWVudC0+bXV0YWJsZUF0dHJpYnV0ZURhdGEoKS0+Z2V0 QXR0cmlidXRlSXRlbShxdWFsaWZpZWROYW1lKCkpOwogfQogCiB2b2lkIEF0dHI6OmRldGFjaEZy b21FbGVtZW50V2l0aFZhbHVlKGNvbnN0IEF0b21pY1N0cmluZyYgdmFsdWUpCiB7CiAgICAgQVNT RVJUKG1fZWxlbWVudCk7CiAgICAgQVNTRVJUKG1fc3RhbmRhbG9uZVZhbHVlLmlzTnVsbCgpKTsK LSAgICBtX2VsZW1lbnQtPmF0dHJpYnV0ZURhdGEoKS0+cmVtb3ZlQXR0cihtX2VsZW1lbnQsIHF1 YWxpZmllZE5hbWUoKSk7CisgICAgbV9lbGVtZW50LT5tdXRhYmxlQXR0cmlidXRlRGF0YSgpLT5y ZW1vdmVBdHRyKG1fZWxlbWVudCwgcXVhbGlmaWVkTmFtZSgpKTsKICAgICBtX3N0YW5kYWxvbmVW YWx1ZSA9IHZhbHVlOwogICAgIG1fZWxlbWVudCA9IDA7CiB9Cg==