<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>91110</bug_id>
          
          <creation_ts>2012-07-12 09:49:18 -0700</creation_ts>
          <short_desc>[Chromium] Call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.</short_desc>
          <delta_ts>2012-09-06 01:58:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>95952</dependson>
          <blocked>66687</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="John Mellor">johnme</reporter>
          <assigned_to name="Adam Barth">abarth</assigned_to>
          <cc>abarth</cc>
    
    <cc>aelias</cc>
    
    <cc>darin</cc>
    
    <cc>fsamuel</cc>
    
    <cc>peter</cc>
    
    <cc>skyostil</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>667886</commentid>
    <comment_count>0</comment_count>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-07-12 09:49:18 -0700</bug_when>
    <thetext>Chromium should call restrictScaleFactorToInitialScaleIfNotUserScalable unless/until userScalable is supported directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667901</commentid>
    <comment_count>1</comment_count>
      <attachid>151981</attachid>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-07-12 09:58:08 -0700</bug_when>
    <thetext>Created attachment 151981
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667918</commentid>
    <comment_count>2</comment_count>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-07-12 10:11:06 -0700</bug_when>
    <thetext>In bug 70609 comment 19 Fady factored out the following line from computeViewportAttributes:

    if (!args.userScalable) result.maximumScale = result.minimumScale = result.initialScale;

into a separate function, restrictScaleFactorToInitialScaleIfNotUserScalable, which wasn&apos;t called on Chromium. Instead at least on Android we used to handle userScalable separately. However Android dropped that separate handling in https://gerrit-int.chromium.org/12197 when it synchronized with upstream, and current upstream seems to completely ignore the value of userScalable!

This patch fixes the immediate issue, that we completely ignore user-scalable=no. But I seem to remember there was some subtle reason for not overwriting mininum-scale/maximum-scale with the initial-scale, and that it was better to handle it separately. Fady, can you remember what this was? And do any of you remember why we stopped handling userScalable separately? Was it just a casualty of upstreaming?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667930</commentid>
    <comment_count>3</comment_count>
      <attachid>151981</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-12 10:16:51 -0700</bug_when>
    <thetext>Comment on attachment 151981
Patch

You should be able to write a test for this along the lines of WebFrameTest.CanOverrideMaximumScaleFactor in http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/tests/WebViewTest.cpp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668760</commentid>
    <comment_count>4</comment_count>
      <attachid>151981</attachid>
    <who name="Peter Beverloo">peter</who>
    <bug_when>2012-07-13 02:22:58 -0700</bug_when>
    <thetext>Comment on attachment 151981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=151981&amp;action=review

&gt; Source/WebKit/chromium/ChangeLog:6
&gt; +        Since https://gerrit-int.chromium.org/12197 the chromium-android port

We shouldn&apos;t refer to internal URLs in ChangeLog messages. They&apos;re meant to be informative for all parties, and this way only Googlers can get access to the context.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682210</commentid>
    <comment_count>5</comment_count>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-07-30 11:17:04 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; But I seem to remember there was some subtle reason for not overwriting mininum-scale/maximum-scale with the initial-scale, and that it was better to handle it separately.

Ah yes - suppose the viewport tag doesn&apos;t have a min/max-scale, but does have user-scalable=no. The initial-scale computed at this point assumes that we will use the viewport width as our initial containing block [1]. But if the page has a CSS min-width larger than the viewport width, and the viewport tag didn&apos;t specify any scale information, we might later choose to set the initial containing block such that the entire page fits within it, and end up with a smaller initial-scale (I can&apos;t remember whether or not this is fully spec-compliant, but OTH some major browsers do it anyway). If we implement user-scalable by overwriting min/max-scale with our initial viewport-based guess at the initial-scale, then if we later do want to adjust the initial-scale, we can no longer tell whether we were banned from doing so (because of an explicit min/max-scale), or we are actually allowed to do so (because there was only a user-scalable directive).

Nevertheless, I still think this patch is useful in the short term, as it&apos;s better than not supporting user-scalable at all!

A test would be useful. I probably won&apos;t get round to that for a little while.

[1]: http://www.w3.org/TR/2004/CR-CSS21-20040225/visudet.html#containing-block-details</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682226</commentid>
    <comment_count>6</comment_count>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-07-30 11:38:44 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 151981 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=151981&amp;action=review
&gt; 
&gt; &gt; Source/WebKit/chromium/ChangeLog:6
&gt; &gt; +        Since https://gerrit-int.chromium.org/12197 the chromium-android port
&gt; 
&gt; We shouldn&apos;t refer to internal URLs in ChangeLog messages. They&apos;re meant to be informative for all parties, and this way only Googlers can get access to the context.

$ git grep -n &apos;rdar&apos; -- &apos;*ChangeLog*&apos; | wc -l
13464

I agree in principle, but this is the chromium ChangeLog and there&apos;s no publicly accessible equivalent way of referencing our downstream history, so it seems worth keeping this useful piece of context...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682268</commentid>
    <comment_count>7</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-30 12:08:35 -0700</bug_when>
    <thetext>(In reply to comment #6)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 151981 [details] [details])
&gt; &gt; View in context: https://bugs.webkit.org/attachment.cgi?id=151981&amp;action=review
&gt; &gt; 
&gt; &gt; &gt; Source/WebKit/chromium/ChangeLog:6
&gt; &gt; &gt; +        Since https://gerrit-int.chromium.org/12197 the chromium-android port
&gt; &gt; 
&gt; &gt; We shouldn&apos;t refer to internal URLs in ChangeLog messages. They&apos;re meant to be informative for all parties, and this way only Googlers can get access to the context.
&gt; 
&gt; $ git grep -n &apos;rdar&apos; -- &apos;*ChangeLog*&apos; | wc -l
&gt; 13464
&gt; 
&gt; I agree in principle, but this is the chromium ChangeLog and there&apos;s no publicly accessible equivalent way of referencing our downstream history, so it seems worth keeping this useful piece of context...

As a contributor to the project, I often become sad when my search for the &quot;why&quot; behind a piece of code ends in an rdar link.  I appreciate that you&apos;ve taken the time to write a descriptive ChangeLog for this patch, which is very helpful and mitigates this issue to a large extent.

Unfortunately, any value that&apos;s added by the gerrit-int is only enjoyed by the small number of folks who can follow that link.  If that&apos;s a large amount of value, then the majority of the contributors to the project are missing out.  If it&apos;s a small amount of value, then it&apos;s probably not worth making the rest of the contributors feel sad that they can&apos;t follow the link</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682271</commentid>
    <comment_count>8</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-30 12:09:26 -0700</bug_when>
    <thetext>&gt; A test would be useful. I probably won&apos;t get round to that for a little while.

I can try writing one for you.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682289</commentid>
    <comment_count>9</comment_count>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-07-30 12:34:02 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; &gt; A test would be useful. I probably won&apos;t get round to that for a little while.
&gt; 
&gt; I can try writing one for you.

Thanks Adam!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682419</commentid>
    <comment_count>10</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-30 14:52:35 -0700</bug_when>
    <thetext>Turns out we can test this using a simple LayoutTest.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682422</commentid>
    <comment_count>11</comment_count>
      <attachid>155372</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-30 14:57:28 -0700</bug_when>
    <thetext>Created attachment 155372
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682432</commentid>
    <comment_count>12</comment_count>
      <attachid>155372</attachid>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-07-30 15:06:17 -0700</bug_when>
    <thetext>Comment on attachment 155372
Patch

Test looks good (though possibly a little implementation-specific?).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>682448</commentid>
    <comment_count>13</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-30 15:15:15 -0700</bug_when>
    <thetext>&gt; Test looks good (though possibly a little implementation-specific?).

Yeah, that&apos;s a general problem with these fast/viewport tests.  However, as far as I can tell, this is the implementation used by the other ports that implement viewport in WebKit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>712371</commentid>
    <comment_count>14</comment_count>
    <who name="John Mellor">johnme</who>
    <bug_when>2012-09-05 11:40:36 -0700</bug_when>
    <thetext>Shall we try to get this landed then?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>712450</commentid>
    <comment_count>15</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-05 13:05:42 -0700</bug_when>
    <thetext>Sorry, this fell off my radar.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>712452</commentid>
    <comment_count>16</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-05 13:06:55 -0700</bug_when>
    <thetext>@tony: Would you be willing to review this patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>712460</commentid>
    <comment_count>17</comment_count>
      <attachid>155372</attachid>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-09-05 13:13:55 -0700</bug_when>
    <thetext>Comment on attachment 155372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=155372&amp;action=review

&gt; LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale-control.html:7
&gt; +                alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352));

Nit: It would be nice if the test said PASS or something so random people gardening can quickly tell if the test is correct or not.

&gt; LayoutTests/fast/viewport/viewport-limits-adjusted-for-no-user-scale.html:7
&gt; +                alert(internals.configurationForViewport(document, 1, 320, 480, 320, 352));

Ditto.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>712469</commentid>
    <comment_count>18</comment_count>
      <attachid>155372</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-05 13:22:20 -0700</bug_when>
    <thetext>Comment on attachment 155372
Patch

Thanks!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>712480</commentid>
    <comment_count>19</comment_count>
      <attachid>162320</attachid>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-05 13:35:27 -0700</bug_when>
    <thetext>Created attachment 162320
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>712964</commentid>
    <comment_count>20</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-09-06 00:35:12 -0700</bug_when>
    <thetext>Committed r127704: &lt;http://trac.webkit.org/changeset/127704&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>151981</attachid>
            <date>2012-07-12 09:58:08 -0700</date>
            <delta_ts>2012-07-30 14:57:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-91110-20120712175806.patch</filename>
            <type>text/plain</type>
            <size>2154</size>
            <attacher name="John Mellor">johnme</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDE3M2EyNzc4OGU2YzBlZWJiYzU0OTQzMGRiYWNlMDhlZjIyMWJiZjQuLjA1MTBmNDE0OWQ4N2M2
YTVjZDI3ZWQwOGE4MDRiMDNjZjIwNGM0ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMjEgQEAKKzIwMTItMDctMTIgIEpvaG4gTWVsbG9yICA8am9obm1lQGNocm9taXVt
Lm9yZz4KKworICAgICAgICBDaHJvbWl1bSBzaG91bGQgY2FsbCByZXN0cmljdFNjYWxlRmFjdG9y
VG9Jbml0aWFsU2NhbGVJZk5vdFVzZXJTY2FsYWJsZSB1bmxlc3MvdW50aWwgdXNlclNjYWxhYmxl
IGlzIHN1cHBvcnRlZCBkaXJlY3RseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTkxMTEwCisKKyAgICAgICAgU2luY2UgaHR0cHM6Ly9nZXJyaXQtaW50
LmNocm9taXVtLm9yZy8xMjE5NyB0aGUgY2hyb21pdW0tYW5kcm9pZCBwb3J0CisgICAgICAgIGhh
cyBhcHBhcmVudGx5IGlnbm9yZWQgdGhlIHVzZXItc2NhbGFibGUgcHJvcGVydHkgb2Ygdmlld3Bv
cnQgbWV0YSB0YWdzLgorICAgICAgICBUaGlzIHBhdGNoIHByb3ZpZGVzIGEgcXVpY2sgZml4IGJ5
IGNhbGxpbmcKKyAgICAgICAgcmVzdHJpY3RTY2FsZUZhY3RvclRvSW5pdGlhbFNjYWxlSWZOb3RV
c2VyU2NhbGFibGUgd2hpY2ggaW1wbGVtZW50cworICAgICAgICB1c2VyLXNjYWxhYmxlIGJ5IGFk
anVzdGluZyB0aGUgdmFsdWVzIG9mIG1pbmltdW0tc2NhbGUgYW5kCisgICAgICAgIG1heGltdW0t
c2NhbGUuIFRoaXMgaXMgYSBzaWduaWZpY2FudCBpbXByb3ZlbWVudCwgdGhvdWdoIG5vdCBuZWNl
c3NhcmlseQorICAgICAgICBwZXJmZWN0OiBzZWUgZGlzY3Vzc2lvbiBvbiBodHRwOi8vd2Via2l0
Lm9yZy9iLzcwNjA5LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgICogc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpDaHJv
bWVDbGllbnRJbXBsOjpkaXNwYXRjaFZpZXdwb3J0UHJvcGVydGllc0RpZENoYW5nZSk6CisKIDIw
MTItMDctMDkgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAg
ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjIxMDcuCmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJL
aXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCmluZGV4IDM0OTczMzkxOTRjZjA0
NGM1NTEzMDNkNTA2OTQzZjdlMjA2YzRlMzQuLmMyODhlODkyZTA0MjYyOTNkOTRmNzJhZmRhNDJj
NzU0OTI3NzY2OWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9t
ZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNs
aWVudEltcGwuY3BwCkBAIC02NTcsNiArNjU3LDggQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBsOjpk
aXNwYXRjaFZpZXdwb3J0UHJvcGVydGllc0RpZENoYW5nZShjb25zdCBWaWV3cG9ydEFyZ3VtZW4K
ICAgICAgICAgYXJncywgc2V0dGluZ3MtPmxheW91dEZhbGxiYWNrV2lkdGgoKSwgZGV2aWNlUmVj
dC53aWR0aCwgZGV2aWNlUmVjdC5oZWlnaHQsCiAgICAgICAgIGRwaSAvIFZpZXdwb3J0QXJndW1l
bnRzOjpkZXByZWNhdGVkVGFyZ2V0RFBJLCBJbnRTaXplKGRldmljZVJlY3Qud2lkdGgsIGRldmlj
ZVJlY3QuaGVpZ2h0KSk7CiAKKyAgICByZXN0cmljdFNjYWxlRmFjdG9yVG9Jbml0aWFsU2NhbGVJ
Zk5vdFVzZXJTY2FsYWJsZShjb21wdXRlZCk7CisKICAgICBpZiAobV93ZWJWaWV3LT5pZ25vcmVW
aWV3cG9ydFRhZ01heGltdW1TY2FsZSgpKSB7CiAgICAgICAgIGNvbXB1dGVkLm1heGltdW1TY2Fs
ZSA9IG1heChjb21wdXRlZC5tYXhpbXVtU2NhbGUsIG1fd2ViVmlldy0+bWF4UGFnZVNjYWxlRmFj
dG9yKTsKICAgICAgICAgY29tcHV0ZWQudXNlclNjYWxhYmxlID0gdHJ1ZTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>155372</attachid>
            <date>2012-07-30 14:57:28 -0700</date>
            <delta_ts>2012-09-05 13:35:25 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-91110-20120730145712.patch</filename>
            <type>text/plain</type>
            <size>5803</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDJjOWQxZjI2YzdjZDllODcyYWViZDJiNDYxMjVjNGVlMDlmNWY4MDIuLjBkYzFiYWZjZGM0ZDEy
YWQyNzAzYjQ1MDE5MmE1M2YxNmIzZWJlMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMjIgQEAKKzIwMTItMDctMzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y
Zz4KKworICAgICAgICBDaHJvbWl1bSBzaG91bGQgY2FsbCByZXN0cmljdFNjYWxlRmFjdG9yVG9J
bml0aWFsU2NhbGVJZk5vdFVzZXJTY2FsYWJsZSB1bmxlc3MvdW50aWwgdXNlclNjYWxhYmxlIGlz
IHN1cHBvcnRlZCBkaXJlY3RseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTkxMTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgUHJpb3IgdG8gdGhpcyBwYXRjaCwgd2Ugd2VyZSBpZ25vcmluZyB0aGUgdXNl
ci1zY2FsYWJsZSBwcm9wZXJ0eSBvZgorICAgICAgICB2aWV3cG9ydCBtZXRhIHRhZ3MuIFRoaXMg
cGF0Y2ggZW5mb3JjZXMgdGhlIHVzZXItc2NhbGFibGUgcHJvcGVydHkgYnkKKyAgICAgICAgY2xh
bWluZyB0aGUgbWluaW11bS1zY2FsZSBhbmQgbWF4aW11bS1zY2FsZSB2YWx1ZXMsIGVmZmVjdGl2
ZWx5CisgICAgICAgIHByZXZlbnRpbmcgdXNlciBzY2FsaW5nLiBUaGlzIGFwcHJvYWNoIGlzbid0
IHBlcmZlY3QsIGFzIGRpc2N1c3NlZCBpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NzA2MDksIGJ1dCBpdCBpcyBhbiBpbXByb3ZlbWVudAorICAgICAg
ICBvdmVyIHRoZSBzdGF0dXMgcXVvLgorCisgICAgICAgIFRoaXMgYXBwcm9hY2ggaXMgYWxzbyB1
c2VkIGJ5IEVGTCwgR1RLLCBhbmQgUXQuCisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1w
bC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNocm9tZUNsaWVudEltcGw6OmRpc3BhdGNoVmlld3Bv
cnRQcm9wZXJ0aWVzRGlkQ2hhbmdlKToKKwogMjAxMi0wNy0zMCAgU2hlcmlmZiBCb3QgIDx3ZWJr
aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv
dXQgcjEyNDAyNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9t
ZUNsaWVudEltcGwuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50
SW1wbC5jcHAKaW5kZXggZjdjYjk0YmJjZGFjNmIwN2I1ZWRlYjJiMDI5NWViNGMzNzkxMzc3MS4u
OTY4NjFhMzU0YjA2ZTdhZjcwYWI5YTc2NzcyNDIxNDY4OGRmYmJjMCAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNl
L1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAgLTY1NSw2ICs2NTUs
OCBAQCB2b2lkIENocm9tZUNsaWVudEltcGw6OmRpc3BhdGNoVmlld3BvcnRQcm9wZXJ0aWVzRGlk
Q2hhbmdlKGNvbnN0IFZpZXdwb3J0QXJndW1lbgogICAgICAgICBhcmdzLCBzZXR0aW5ncy0+bGF5
b3V0RmFsbGJhY2tXaWR0aCgpLCBkZXZpY2VSZWN0LndpZHRoLCBkZXZpY2VSZWN0LmhlaWdodCwK
ICAgICAgICAgZHBpIC8gVmlld3BvcnRBcmd1bWVudHM6OmRlcHJlY2F0ZWRUYXJnZXREUEksIElu
dFNpemUoZGV2aWNlUmVjdC53aWR0aCwgZGV2aWNlUmVjdC5oZWlnaHQpKTsKIAorICAgIHJlc3Ry
aWN0U2NhbGVGYWN0b3JUb0luaXRpYWxTY2FsZUlmTm90VXNlclNjYWxhYmxlKGNvbXB1dGVkKTsK
KwogICAgIGlmIChtX3dlYlZpZXctPmlnbm9yZVZpZXdwb3J0VGFnTWF4aW11bVNjYWxlKCkpIHsK
ICAgICAgICAgY29tcHV0ZWQubWF4aW11bVNjYWxlID0gbWF4KGNvbXB1dGVkLm1heGltdW1TY2Fs
ZSwgbV93ZWJWaWV3LT5tYXhQYWdlU2NhbGVGYWN0b3IpOwogICAgICAgICBjb21wdXRlZC51c2Vy
U2NhbGFibGUgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE0MjUzNjQ3Nzc3NmI2MDUxMTg3YWI4N2MxZDg2Yjkw
ZTU4YjVjNzcuLmFlNWM4MDExM2UwYmFjNjAxMTNmMTAwZjBkODA0OWI1OTdkZmNmZmIgMTAwNjQ0
Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK
QEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNy0zMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu
b3JnPgorCisgICAgICAgIENocm9taXVtIHNob3VsZCBjYWxsIHJlc3RyaWN0U2NhbGVGYWN0b3JU
b0luaXRpYWxTY2FsZUlmTm90VXNlclNjYWxhYmxlIHVubGVzcy91bnRpbCB1c2VyU2NhbGFibGUg
aXMgc3VwcG9ydGVkIGRpcmVjdGx5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9OTExMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBUZXN0IHRoYXQgdGhlIHNjYWxlIGxpbWl0cyBhcmUgY2xhbXBlZCB3aGVu
IHVzZXItc2NhbGFibGUgaXMgc2V0IHRvIG5vLgorCisgICAgICAgICogZmFzdC92aWV3cG9ydC92
aWV3cG9ydC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUtY29udHJvbC1leHBlY3Rl
ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGltaXRzLWFk
anVzdGVkLWZvci1uby11c2VyLXNjYWxlLWNvbnRyb2wuaHRtbDogQWRkZWQuCisgICAgICAgICog
ZmFzdC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUt
ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxp
bWl0cy1hZGp1c3RlZC1mb3Itbm8tdXNlci1zY2FsZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wNy0z
MCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0g
VW5yZXZpZXdlZCBnYXJkZW5pbmcuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdw
b3J0L3ZpZXdwb3J0LWxpbWl0cy1hZGp1c3RlZC1mb3Itbm8tdXNlci1zY2FsZS1jb250cm9sLWV4
cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGltaXRzLWFk
anVzdGVkLWZvci1uby11c2VyLXNjYWxlLWNvbnRyb2wtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v
ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu
LjU4N2FjM2EyNDk1YWZkMTE2Njk2OTQ5OWM2NmQ5ZTA4Njk5NGRhYTcKLS0tIC9kZXYvbnVsbAor
KysgYi9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxpbWl0cy1hZGp1c3RlZC1m
b3Itbm8tdXNlci1zY2FsZS1jb250cm9sLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK0FM
RVJUOiB2aWV3cG9ydCBzaXplIDMyMHgzNTIgc2NhbGUgMSB3aXRoIGxpbWl0cyBbMSwgM10gYW5k
IHVzZXJTY2FsYWJsZSB0cnVlCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvdmlld3Bv
cnQvdmlld3BvcnQtbGltaXRzLWFkanVzdGVkLWZvci1uby11c2VyLXNjYWxlLWNvbnRyb2wuaHRt
bCBiL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGltaXRzLWFkanVzdGVkLWZv
ci1uby11c2VyLXNjYWxlLWNvbnRyb2wuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iNzBlNDJmNTIxNDVmZTI3
YzQ4OTQ3Y2EwZGUxNmFiOWUxZjJmZDZiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv
ZmFzdC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUt
Y29udHJvbC5odG1sCkBAIC0wLDAgKzEsMTIgQEAKKzxoZWFkPgorICAgIDxtZXRhIG5hbWU9InZp
ZXdwb3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIHVzZXItc2NhbGFibGU9eWVzLCBt
YXhpbXVtLXNjYWxlPTMsIG1pbmltdW0tc2NhbGU9MSI+CisgICAgPHNjcmlwdD4KKyAgICAgICAg
ZnVuY3Rpb24gdGVzdCgpIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRy
b2xsZXIpIHsKKyAgICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0
KCk7CisgICAgICAgICAgICAgICAgYWxlcnQoaW50ZXJuYWxzLmNvbmZpZ3VyYXRpb25Gb3JWaWV3
cG9ydChkb2N1bWVudCwgMSwgMzIwLCA0ODAsIDMyMCwgMzUyKSk7CisgICAgICAgICAgICB9Cisg
ICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpOyI+
CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxpbWl0cy1h
ZGp1c3RlZC1mb3Itbm8tdXNlci1zY2FsZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0
L3ZpZXdwb3J0L3ZpZXdwb3J0LWxpbWl0cy1hZGp1c3RlZC1mb3Itbm8tdXNlci1zY2FsZS1leHBl
Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMC4uZDM4ZGY0MjY4Mjc5NTZmODI5YzVmMmQ4NGVlMWE1Y2NlM2E3
ZDIxZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3Bv
cnQtbGltaXRzLWFkanVzdGVkLWZvci1uby11c2VyLXNjYWxlLWV4cGVjdGVkLnR4dApAQCAtMCww
ICsxLDIgQEAKK0FMRVJUOiB2aWV3cG9ydCBzaXplIDMyMHgzNTIgc2NhbGUgMSB3aXRoIGxpbWl0
cyBbMSwgMV0gYW5kIHVzZXJTY2FsYWJsZSBmYWxzZQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0
cy9mYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxpbWl0cy1hZGp1c3RlZC1mb3Itbm8tdXNlci1zY2Fs
ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMtYWRqdXN0
ZWQtZm9yLW5vLXVzZXItc2NhbGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42Nzg5ODAyYjQzY2MyY2ZmYWNi
MTVjZGJkY2RhMzE4Y2MyN2RiYjBkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz
dC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUuaHRt
bApAQCAtMCwwICsxLDEyIEBACis8aGVhZD4KKyAgICA8bWV0YSBuYW1lPSJ2aWV3cG9ydCIgY29u
dGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoLCB1c2VyLXNjYWxhYmxlPW5vLCBtYXhpbXVtLXNjYWxl
PTMsIG1pbmltdW0tc2NhbGU9MSI+CisgICAgPHNjcmlwdD4KKyAgICAgICAgZnVuY3Rpb24gdGVz
dCgpIHsKKyAgICAgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAg
ICAgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAg
ICAgICAgICAgYWxlcnQoaW50ZXJuYWxzLmNvbmZpZ3VyYXRpb25Gb3JWaWV3cG9ydChkb2N1bWVu
dCwgMSwgMzIwLCA0ODAsIDMyMCwgMzUyKSk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAg
ICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVzdCgpOyI+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>162320</attachid>
            <date>2012-09-05 13:35:27 -0700</date>
            <delta_ts>2012-09-05 13:35:27 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-91110-20120905133509.patch</filename>
            <type>text/plain</type>
            <size>6163</size>
            <attacher name="Adam Barth">abarth</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IDFiNGJmNGY5MmU3ZjE5ZDVhOGFmNDkyZTMwMWY5ZDcwYmYwY2RhMTQuLjVkZTMxZTRkMzljZmUz
YzU4ZmZiYmUwMTk4MzM0M2NhNzhkY2FhODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMjIgQEAKKzIwMTItMDktMDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y
Zz4KKworICAgICAgICBDaHJvbWl1bSBzaG91bGQgY2FsbCByZXN0cmljdFNjYWxlRmFjdG9yVG9J
bml0aWFsU2NhbGVJZk5vdFVzZXJTY2FsYWJsZSB1bmxlc3MvdW50aWwgdXNlclNjYWxhYmxlIGlz
IHN1cHBvcnRlZCBkaXJlY3RseS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTkxMTEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKwor
ICAgICAgICBQcmlvciB0byB0aGlzIHBhdGNoLCB3ZSB3ZXJlIGlnbm9yaW5nIHRoZSB1c2VyLXNj
YWxhYmxlIHByb3BlcnR5IG9mCisgICAgICAgIHZpZXdwb3J0IG1ldGEgdGFncy4gVGhpcyBwYXRj
aCBlbmZvcmNlcyB0aGUgdXNlci1zY2FsYWJsZSBwcm9wZXJ0eSBieQorICAgICAgICBjbGFtaW5n
IHRoZSBtaW5pbXVtLXNjYWxlIGFuZCBtYXhpbXVtLXNjYWxlIHZhbHVlcywgZWZmZWN0aXZlbHkK
KyAgICAgICAgcHJldmVudGluZyB1c2VyIHNjYWxpbmcuIFRoaXMgYXBwcm9hY2ggaXNuJ3QgcGVy
ZmVjdCwgYXMgZGlzY3Vzc2VkIGluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD03MDYwOSwgYnV0IGl0IGlzIGFuIGltcHJvdmVtZW50CisgICAgICAgIG92
ZXIgdGhlIHN0YXR1cyBxdW8uCisKKyAgICAgICAgVGhpcyBhcHByb2FjaCBpcyBhbHNvIHVzZWQg
YnkgRUZMLCBHVEssIGFuZCBRdC4KKworICAgICAgICAqIHNyYy9DaHJvbWVDbGllbnRJbXBsLmNw
cDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50SW1wbDo6ZGlzcGF0Y2hWaWV3cG9ydFBy
b3BlcnRpZXNEaWRDaGFuZ2UpOgorCiAyMDEyLTA5LTA1ICBTYW1pIEt5b3N0aWxhICA8c2t5b3N0
aWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gV2lyZSB1cCBzY3JvbGxhYmxl
IHN1YmxheWVycyBpbiBTY3JvbGxpbmdDb29yZGluYXRvckNocm9taXVtCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9X
ZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCmluZGV4IDg3M2Q1ZTJhZTMw
NWM0MTAzMGNiZmE5OWJlZmZmNDJkMmM0NDUwZTUuLjk4NTc1Nzc4MzEzZjIwYzM1ZDUwNjYwOTBj
NmQxYTdjMDE4NTYwMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0No
cm9tZUNsaWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9t
ZUNsaWVudEltcGwuY3BwCkBAIC02NTMsNiArNjUzLDggQEAgdm9pZCBDaHJvbWVDbGllbnRJbXBs
OjpkaXNwYXRjaFZpZXdwb3J0UHJvcGVydGllc0RpZENoYW5nZShjb25zdCBWaWV3cG9ydEFyZ3Vt
ZW4KICAgICAgICAgYXJncywgc2V0dGluZ3MtPmxheW91dEZhbGxiYWNrV2lkdGgoKSwgZGV2aWNl
UmVjdC53aWR0aCwgZGV2aWNlUmVjdC5oZWlnaHQsCiAgICAgICAgIGRwaSAvIFZpZXdwb3J0QXJn
dW1lbnRzOjpkZXByZWNhdGVkVGFyZ2V0RFBJLCBJbnRTaXplKGRldmljZVJlY3Qud2lkdGgsIGRl
dmljZVJlY3QuaGVpZ2h0KSk7CiAKKyAgICByZXN0cmljdFNjYWxlRmFjdG9yVG9Jbml0aWFsU2Nh
bGVJZk5vdFVzZXJTY2FsYWJsZShjb21wdXRlZCk7CisKICAgICBpZiAobV93ZWJWaWV3LT5pZ25v
cmVWaWV3cG9ydFRhZ01heGltdW1TY2FsZSgpKSB7CiAgICAgICAgIGNvbXB1dGVkLm1heGltdW1T
Y2FsZSA9IG1heChjb21wdXRlZC5tYXhpbXVtU2NhbGUsIG1fd2ViVmlldy0+bWF4UGFnZVNjYWxl
RmFjdG9yKTsKICAgICAgICAgY29tcHV0ZWQudXNlclNjYWxhYmxlID0gdHJ1ZTsKZGlmZiAtLWdp
dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1
OGUyZDI5ODM2MjA5Zjk4NzEyYWE4MzMzODBmNjk1M2UwZmFhNDkzLi41MmU5YWVmNzI1ZDU5MzNi
MmFlMjBlMWRiODljOTExYmY0NGNhYzFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM
b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDkt
MDUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBDaHJvbWl1bSBz
aG91bGQgY2FsbCByZXN0cmljdFNjYWxlRmFjdG9yVG9Jbml0aWFsU2NhbGVJZk5vdFVzZXJTY2Fs
YWJsZSB1bmxlc3MvdW50aWwgdXNlclNjYWxhYmxlIGlzIHN1cHBvcnRlZCBkaXJlY3RseS4KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMTEwCisKKyAg
ICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICBUZXN0IHRoYXQgdGhlIHNj
YWxlIGxpbWl0cyBhcmUgY2xhbXBlZCB3aGVuIHVzZXItc2NhbGFibGUgaXMgc2V0IHRvIG5vLgor
CisgICAgICAgICogZmFzdC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5v
LXVzZXItc2NhbGUtY29udHJvbC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv
dmlld3BvcnQvdmlld3BvcnQtbGltaXRzLWFkanVzdGVkLWZvci1uby11c2VyLXNjYWxlLWNvbnRy
b2wuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMt
YWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg
KiBmYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxpbWl0cy1hZGp1c3RlZC1mb3Itbm8tdXNlci1zY2Fs
ZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wOS0wNSAgVmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hy
b21pdW0ub3JnPgogCiAgICAgICAgIHdlYmtpdFBvaW50ZXJMb2NrRWxlbWVudCByZXR1cm5zIG51
bGwgd2hlbiBwb2ludGVyIGxvY2sgcmVxdWVzdCBpcyBwZW5kaW5nLgpkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5vLXVz
ZXItc2NhbGUtY29udHJvbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0
L3ZpZXdwb3J0LWxpbWl0cy1hZGp1c3RlZC1mb3Itbm8tdXNlci1zY2FsZS1jb250cm9sLWV4cGVj
dGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwLi45YzcwMzIxMTg4OWE4OWZlOTA4MmI5OThhNGRjZWU3M2RhNzdh
Y2QyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9y
dC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUtY29udHJvbC1leHBlY3RlZC50eHQK
QEAgLTAsMCArMSwyIEBACitBTEVSVDogUEFTUworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m
YXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxpbWl0cy1hZGp1c3RlZC1mb3Itbm8tdXNlci1zY2FsZS1j
b250cm9sLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LWxpbWl0cy1h
ZGp1c3RlZC1mb3Itbm8tdXNlci1zY2FsZS1jb250cm9sLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2
NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMjFhZjNm
OWU4ODViZmU3MjNjOWVhOGQxY2NiOGQ3MTNjMTNjNWYwNAotLS0gL2Rldi9udWxsCisrKyBiL0xh
eW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGltaXRzLWFkanVzdGVkLWZvci1uby11
c2VyLXNjYWxlLWNvbnRyb2wuaHRtbApAQCAtMCwwICsxLDE2IEBACis8aGVhZD4KKyAgICA8bWV0
YSBuYW1lPSJ2aWV3cG9ydCIgY29udGVudD0id2lkdGg9ZGV2aWNlLXdpZHRoLCB1c2VyLXNjYWxh
YmxlPXllcywgbWF4aW11bS1zY2FsZT0zLCBtaW5pbXVtLXNjYWxlPTEiPgorICAgIDxzY3JpcHQ+
CisgICAgICAgIGZ1bmN0aW9uIHRlc3QoKSB7CisgICAgICAgICAgICBpZiAod2luZG93LmxheW91
dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIu
ZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgICAgIHZhciB2aWV3cG9ydENvbmZpZ3VhdGlvbiA9
IGludGVybmFscy5jb25maWd1cmF0aW9uRm9yVmlld3BvcnQoZG9jdW1lbnQsIDEsIDMyMCwgNDgw
LCAzMjAsIDM1Mik7CisgICAgICAgICAgICAgICAgaWYgKC91c2VyU2NhbGFibGUgdHJ1ZS8udGVz
dCh2aWV3cG9ydENvbmZpZ3VhdGlvbikpCisgICAgICAgICAgICAgICAgICAgIGFsZXJ0KCJQQVNT
Iik7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAgICAgICBhbGVydCgiRkFJ
TDogIiArIHZpZXdwb3J0Q29uZmlndWF0aW9uKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQor
ICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJ0ZXN0KCk7Ij4KZGlmZiAtLWdp
dCBhL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGltaXRzLWFkanVzdGVkLWZv
ci1uby11c2VyLXNjYWxlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQv
dmlld3BvcnQtbGltaXRzLWFkanVzdGVkLWZvci1uby11c2VyLXNjYWxlLWV4cGVjdGVkLnR4dApu
ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwLi45YzcwMzIxMTg4OWE4OWZlOTA4MmI5OThhNGRjZWU3M2RhNzdhY2QyCi0tLSAv
ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9ydC1saW1pdHMt
YWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAor
QUxFUlQ6IFBBU1MKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3
cG9ydC1saW1pdHMtYWRqdXN0ZWQtZm9yLW5vLXVzZXItc2NhbGUuaHRtbCBiL0xheW91dFRlc3Rz
L2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtbGltaXRzLWFkanVzdGVkLWZvci1uby11c2VyLXNjYWxl
Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMC4uODIzY2U3YmY3NzAyZDE4NTA2MDJiZmIzYzZjZGM5MDgyMmU0ODM2
NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQt
bGltaXRzLWFkanVzdGVkLWZvci1uby11c2VyLXNjYWxlLmh0bWwKQEAgLTAsMCArMSwxNiBAQAor
PGhlYWQ+CisgICAgPG1ldGEgbmFtZT0idmlld3BvcnQiIGNvbnRlbnQ9IndpZHRoPWRldmljZS13
aWR0aCwgdXNlci1zY2FsYWJsZT1ubywgbWF4aW11bS1zY2FsZT0zLCBtaW5pbXVtLXNjYWxlPTEi
PgorICAgIDxzY3JpcHQ+CisgICAgICAgIGZ1bmN0aW9uIHRlc3QoKSB7CisgICAgICAgICAgICBp
ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAgICAgICAgICAgbGF5b3V0
VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICAgICAgICAgIHZhciB2aWV3cG9y
dENvbmZpZ3VhdGlvbiA9IGludGVybmFscy5jb25maWd1cmF0aW9uRm9yVmlld3BvcnQoZG9jdW1l
bnQsIDEsIDMyMCwgNDgwLCAzMjAsIDM1Mik7CisgICAgICAgICAgICAgICAgaWYgKC91c2VyU2Nh
bGFibGUgZmFsc2UvLnRlc3Qodmlld3BvcnRDb25maWd1YXRpb24pKQorICAgICAgICAgICAgICAg
ICAgICBhbGVydCgiUEFTUyIpOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAg
ICAgICAgYWxlcnQoIkZBSUw6ICIgKyB2aWV3cG9ydENvbmZpZ3VhdGlvbik7CisgICAgICAgICAg
ICB9CisgICAgICAgIH0KKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD0idGVz
dCgpOyI+Cg==
</data>
<flag name="commit-queue"
          id="173398"
          type_id="3"
          status="+"
          setter="abarth"
    />
          </attachment>
      

    </bug>

</bugzilla>