<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>91103</bug_id>
          
          <creation_ts>2012-07-12 09:15:55 -0700</creation_ts>
          <short_desc>[chromium][Mac] r122400 broke 10.6 build</short_desc>
          <delta_ts>2012-07-12 13:19:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>OS X 10.6</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Robert Sesek">rsesek</reporter>
          <assigned_to name="Robert Sesek">rsesek</assigned_to>
          <cc>abarth</cc>
    
    <cc>mark</cc>
    
    <cc>tony</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>667848</commentid>
    <comment_count>0</comment_count>
    <who name="Robert Sesek">rsesek</who>
    <bug_when>2012-07-12 09:15:55 -0700</bug_when>
    <thetext>Regression from https://bugs.webkit.org/show_bug.cgi?id=91015

You get the following error messages when building ToT Chromium with the 10.6 SDK (soon to be our default SDK). It looks like the availability macros used are incorrect.

../../third_party/WebKit/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:64:5: error: redefinition of enumerator &apos;NSEventTypeBeginGesture&apos;
    NSEventTypeBeginGesture     = 19,
    ^
/Applications/Xcode44-DP7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:51:5: note: previous definition is here
    NSEventTypeBeginGesture     = 19,
    ^
../../third_party/WebKit/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:65:5: error: redefinition of enumerator &apos;NSEventTypeEndGesture&apos;
    NSEventTypeEndGesture       = 20
    ^
/Applications/Xcode44-DP7.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSEvent.h:52:5: note: previous definition is here
    NSEventTypeEndGesture       = 20
    ^
../../third_party/WebKit/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:63:1: error: declaration does not declare anything [-Werror,-Wmissing-declarations]
enum {
^~~~
3 errors generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667856</commentid>
    <comment_count>1</comment_count>
      <attachid>151971</attachid>
    <who name="Robert Sesek">rsesek</who>
    <bug_when>2012-07-12 09:24:31 -0700</bug_when>
    <thetext>Created attachment 151971
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667857</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-12 09:27:51 -0700</bug_when>
    <thetext>Attachment 151971 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/WebKit/chromium/ChangeLog&apos;, u&apos;Sourc...&quot; exit_code: 1
Source/WebKit/chromium/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667864</commentid>
    <comment_count>3</comment_count>
      <attachid>151973</attachid>
    <who name="Robert Sesek">rsesek</who>
    <bug_when>2012-07-12 09:30:21 -0700</bug_when>
    <thetext>Created attachment 151973
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667865</commentid>
    <comment_count>4</comment_count>
    <who name="Robert Sesek">rsesek</who>
    <bug_when>2012-07-12 09:30:42 -0700</bug_when>
    <thetext>Please review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667883</commentid>
    <comment_count>5</comment_count>
      <attachid>151973</attachid>
    <who name="Mark Mentovai">mark</who>
    <bug_when>2012-07-12 09:46:05 -0700</bug_when>
    <thetext>Comment on attachment 151973
Patch

LGTM. It’s optional to #include &lt;Availability.h&gt; because the ApplicationServices and Cocoa #includes will definitely have brought it in.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667907</commentid>
    <comment_count>6</comment_count>
    <who name="Mark Mentovai">mark</who>
    <bug_when>2012-07-12 10:00:47 -0700</bug_when>
    <thetext>*** Bug 91113 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667922</commentid>
    <comment_count>7</comment_count>
      <attachid>151973</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-12 10:12:01 -0700</bug_when>
    <thetext>Comment on attachment 151973
Patch

Clearing flags on attachment: 151973

Committed r122477: &lt;http://trac.webkit.org/changeset/122477&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667924</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-12 10:12:15 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667941</commentid>
    <comment_count>9</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-07-12 10:26:28 -0700</bug_when>
    <thetext>This appears to have broken the Chromium Mac Release build:
http://build.webkit.org/builders/Chromium%20Mac%20Release/builds/39757/steps/compile-webkit/logs/stdio

CompileC ./xcodebuild/WebKit.build/Release/webkit.build/Objects-normal/i386/WebInputEventFactory.o src/mac/WebInputEventFactory.mm normal i386 objective-c++ com.apple.compilers.llvmgcc42
    cd /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium
    setenv LANG en_US.US-ASCII
    /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/third_party/llvm-build/Release+Asserts/bin/clang -x objective-c++ -arch i386 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -O3 -Werror -Wnewline-eof -DCHROMIUM_BUILD -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DENABLE_GPU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -DENABLE_TASK_MANAGER=1 -DENABLE_WEB_INTENTS=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PROTECTOR_SERVICE=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_BACKGROUND=1 -DENABLE_PROMO_RESOURCE_SERVICE=1 -DENABLE_AUTOMATION=1 -DENABLE_PRINTING=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DWEBKIT_IMPLEMENTATION=1 -DENABLE_3D_PLUGIN=1 -DENABLE_BATTERY_STATUS=0 -DENABLE_BLOB=1 -DENABLE_BLOB_SLICE=1 -DENABLE_CHANNEL_MESSAGING=1 -DENABLE_CSP_NEXT=1 -DENABLE_CSS3_FLEXBOX=1 -DENABLE_CSS_BOX_DECORATION_BREAK=1 -DENABLE_CSS_EXCLUSIONS=1 -DENABLE_CSS_FILTERS=1 -DENABLE_CSS_IMAGE_SET=1 -DENABLE_CSS_IMAGE_RESOLUTION=0 -DENABLE_CSS_REGIONS=1 -DENABLE_CSS_SHADERS=1 -DENABLE_CSS_VARIABLES=0 -DENABLE_CUSTOM_SCHEME_HANDLER=0 -DENABLE_DATALIST=1 -DENABLE_DASHBOARD_SUPPORT=0 -DENABLE_DATA_TRANSFER_ITEMS=1 -DENABLE_DETAILS=1 -DENABLE_DEVICE_ORIENTATION=1 -DENABLE_DIALOG_ELEMENT=1 -DENABLE_DIRECTORY_UPLOAD=1 -DENABLE_DOWNLOAD_ATTRIBUTE=1 -DENABLE_ENCRYPTED_MEDIA=1 -DENABLE_FILE_SYSTEM=1 -DENABLE_FILTERS=1 -DENABLE_FULLSCREEN_API=1 -DENABLE_GAMEPAD=1 -DENABLE_GEOLOCATION=1 -DENABLE_GESTURE_EVENTS=1 -DENABLE_ICONDATABASE=0 -DENABLE_IFRAME_SEAMLESS=1 -DENABLE_INDEXED_DATABASE=1 -DENABLE_INPUT_TYPE_DATE=1 -DENABLE_JAVASCRIPT_DEBUGGER=1 -DENABLE_LEGACY_CSS_VENDOR_PREFIXES=0 -DENABLE_LEGACY_VIEWPORT_ADAPTION=1 -DENABLE_LEGACY_WEBKIT_BLOB_BUILDER=1 -DENABLE_LINK_PREFETCH=1 -DENABLE_LINK_PRERENDER=1 -DENABLE_MEDIA_SOURCE=1 -DENABLE_MEDIA_STATISTICS=1 -DENABLE_METER_TAG=1 -DENABLE_MHTML=1 -DENABLE_MICRODATA=0 -DENABLE_MUTATION_OBSERVERS=1 -DENABLE_PAGE_VISIBILITY_API=1 -DENABLE_POINTER_LOCK=1 -DENABLE_PROGRESS_TAG=1 -DENABLE_QUOTA=1 -DENABLE_REGISTER_PROTOCOL_HANDLER=1 -DENABLE_REQUEST_ANIMATION_FRAME=1 -DENABLE_RUBY=1 -DENABLE_SANDBOX=1 -DENABLE_SCRIPTED_SPEECH=1 -DENABLE_SHADOW_DOM=1 -DENABLE_SMOOTH_SCROLLING=1 -DENABLE_SQL_DATABASE=1 -DENABLE_STYLE_SCOPED=1 -DENABLE_SVG=1 -DENABLE_SVG_FONTS=1 -DENABLE_TEXT_AUTOSIZING=1 -DENABLE_TOUCH_ADJUSTMENT=1 -DENABLE_TOUCH_EVENTS=1 -DENABLE_TOUCH_ICON_LOADING=0 -DENABLE_TOUCH_SLIDER=1 -DENABLE_V8_SCRIPT_DEBUG_SERVER=1 -DENABLE_VIDEO=1 -DENABLE_VIDEO_TRACK=1 -DENABLE_VIEWPORT=1 -DENABLE_WEBGL=1 -DENABLE_WEB_SOCKETS=1 -DENABLE_WEB_TIMING=1 -DENABLE_WORKERS=1 -DENABLE_XHR_RESPONSE_BLOB=1 -DENABLE_XSLT=1 -DWTF_USE_LEVELDB=1 -DWTF_USE_BUILTIN_UTF8_CODEC=1 -DWTF_USE_OPENTYPE_SANITIZER=1 -DWTF_USE_RTL_SCROLLBAR=1 -DWTF_USE_SKIA_TEXT=1 -DWTF_USE_WEBP=1 -DWTF_USE_WEBKIT_IMAGE_DECODERS=1 -DENABLE_CALENDAR_PICKER=1 -DENABLE_INPUT_SPEECH=1 -DENABLE_INPUT_TYPE_COLOR=1 -DENABLE_JAVASCRIPT_I18N_API=1 -DENABLE_LEGACY_NOTIFICATIONS=1 -DENABLE_MEDIA_CAPTURE=0 -DENABLE_MEDIA_STREAM=1 -DENABLE_NOTIFICATIONS=1 -DENABLE_ORIENTATION_EVENTS=0 -DENABLE_OVERFLOW_SCROLLING=0 -DENABLE_PAGE_POPUP=1 -DENABLE_SHARED_WORKERS=1 -DENABLE_WEB_AUDIO=1 -DENABLE_3D_RENDERING=1 -DENABLE_ACCELERATED_2D_CANVAS=1 -DWTF_USE_ACCELERATED_COMPOSITING=1 -DENABLE_RUBBER_BANDING=1 -DWTF_USE_SKIA_ON_MAC_CHROMIUM=1 -DBUILDING_CHROMIUM__=1 -DUSE_SYSTEM_MALLOC=1 -DWTF_USE_NEW_THEME=1 -DU_USING_ICU_NAMESPACE=0 -DSK_BUILD_NO_IMAGE_ENCODE -DGR_GL_CUSTOM_SETUP_HEADER=&quot;GrGLConfig_chrome.h&quot; -DGR_AGGRESSIVE_SHADER_OPTS=1 -DU_STATIC_IMPLEMENTATION -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -isysroot /Developer/SDKs/MacOSX10.5.sdk -fvisibility=hidden -fvisibility-inlines-hidden -fno-threadsafe-statics -mmacosx-version-min=10.5 -gdwarf-2 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene -Wno-char-subscripts -Wno-unused-function -Wno-unnamed-type-template-args -Wno-c++11-extensions -Wno-covered-switch-default -Wglobal-constructors -Wexit-time-destructors -F/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/xcodebuild/Release -I/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/xcodebuild/Release/include -Ithird_party/icu/public/common -Ithird_party/icu/public/i18n -Ipublic -Isrc -I../../WebKit/chromium/third_party/angle/include -I../../WebKit/chromium/third_party/skia/include/utils -Ipublic/mac -Ithird_party/khronos -I. -I../../WebCore -I../.. -I../../WebCore/Modules/battery -I../../WebCore/Modules/filesystem -I../../WebCore/Modules/filesystem/chromium -I../../WebCore/Modules/gamepad -I../../WebCore/Modules/geolocation -I../../WebCore/Modules/intents -I../../WebCore/Modules/indexeddb -I../../WebCore/Modules/mediastream -I../../WebCore/Modules/notifications -I../../WebCore/Modules/protocolhandler -I../../WebCore/Modules/quota -I../../WebCore/Modules/speech -I../../WebCore/Modules/webaudio -I../../WebCore/Modules/webdatabase -I../../WebCore/Modules/webdatabase/chromium -I../../WebCore/Modules/websockets -I../../WebCore/accessibility -I../../WebCore/accessibility/chromium -I../../WebCore/bindings -I../../WebCore/bindings/generic -I../../WebCore/bindings/v8 -I../../WebCore/bindings/v8/custom -I../../WebCore/bindings/v8/specialization -I../../WebCore/bridge -I../../WebCore/bridge/jni -I../../WebCore/bridge/jni/v8 -I../../WebCore/css -I../../WebCore/dom -I../../WebCore/dom/default -I../../WebCore/editing -I../../WebCore/fileapi -I../../WebCore/history -I../../WebCore/html -I../../WebCore/html/canvas -I../../WebCore/html/parser -I../../WebCore/html/shadow -I../../WebCore/html/track -I../../WebCore/inspector -I../../WebCore/loader -I../../WebCore/loader/appcache -I../../WebCore/loader/archive -I../../WebCore/loader/archive/cf -I../../WebCore/loader/archive/mhtml -I../../WebCore/loader/cache -I../../WebCore/loader/icon -I../../WebCore/mathml -I../../WebCore/page -I../../WebCore/page/animation -I../../WebCore/page/chromium -I../../WebCore/page/scrolling -I../../WebCore/platform -I../../WebCore/platform/animation -I../../WebCore/platform/audio -I../../WebCore/platform/audio/chromium -I../../WebCore/platform/chromium -I../../WebCore/platform/chromium/support -I../../WebCore/platform/graphics -I../../WebCore/platform/graphics/chromium -I../../WebCore/platform/graphics/filters -I../../WebCore/platform/graphics/filters/arm -I../../WebCore/platform/graphics/gpu -I../../WebCore/platform/graphics/opentype -I../../WebCore/platform/graphics/skia -I../../WebCore/platform/graphics/transforms -I../../WebCore/platform/image-decoders -I../../WebCore/platform/image-decoders/bmp -I../../WebCore/platform/image-decoders/gif -I../../WebCore/platform/image-decoders/ico -I../../WebCore/platform/image-decoders/jpeg -I../../WebCore/platform/image-decoders/png -I../../WebCore/platform/image-decoders/skia -I../../WebCore/platform/image-decoders/webp -I../../WebCore/platform/image-encoders/skia -I../../WebCore/platform/leveldb -I../../WebCore/platform/mediastream -I../../WebCore/platform/mediastream/chromium -I../../WebCore/platform/mock -I../../WebCore/platform/network -I../../WebCore/platform/network/chromium -I../../WebCore/platform/sql -I../../WebCore/platform/text -I../../WebCore/platform/text/transcoder -I../../WebCore/plugins -I../../WebCore/plugins/chromium -I../../WebCore/rendering -I../../WebCore/rendering/style -I../../WebCore/rendering/svg -I../../WebCore/storage -I../../WebCore/storage/chromium -I../../WebCore/svg -I../../WebCore/svg/animation -I../../WebCore/svg/graphics -I../../WebCore/svg/graphics/filters -I../../WebCore/svg/properties -I../../ThirdParty/glu -I../../WebCore/workers -I../../WebCore/xml -I../../WebCore/xml/parser -I../../WebCore/platform/audio/mac -I../../WebCore/platform/cocoa -I../../WebCore/platform/graphics/cg -I../../WebCore/platform/graphics/cocoa -I../../WebCore/platform/graphics/mac -I../../WebCore/platform/mac -I../../WebCore/platform/text/mac -I../../WebCore/platform/graphics/harfbuzz -I../../WebCore/platform/graphics/harfbuzz/ng -I../../WebKit/chromium/third_party/apple_webkit -I../../WebKit/mac/WebCoreSupport -I/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/xcodebuild/DerivedSources/Release/webkit -I/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/xcodebuild/DerivedSources/Release/webkit/bindings -I../../WTF -I../../JavaScriptCore -Ithird_party/qcms/src -I../../Platform/chromium -I/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/xcodebuild/DerivedSources/Release/webcore_headers -Iskia/config -Ithird_party/skia/include/config -Ithird_party/skia/include/core -Ithird_party/skia/include/effects -Ithird_party/skia/include/pdf -Ithird_party/skia/include/gpu -Ithird_party/skia/include/gpu/gl -Ithird_party/skia/include/ports -Ithird_party/skia/include/utils -Iskia/ext -Ithird_party/skia/include/utils/mac -Ithird_party/npapi -Ithird_party/npapi/bindings -Iv8/include -I/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/./xcodebuild/WebKit.build/Release/webkit.build/DerivedSources/i386 -I/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/./xcodebuild/WebKit.build/Release/webkit.build/DerivedSources -fno-strict-aliasing -c /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm -o /Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/./xcodebuild/WebKit.build/Release/webkit.build/Objects-normal/i386/WebInputEventFactory.o

/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:188:10: error: use of undeclared identifier &apos;NSEventTypeBeginGesture&apos;
    case NSEventTypeBeginGesture:
         ^
/Volumes/data/b/WebKit-BuildSlave/chromium-mac-release/build/Source/WebKit/chromium/src/mac/WebInputEventFactory.mm:190:10: error: use of undeclared identifier &apos;NSEventTypeEndGesture&apos;
    case NSEventTypeEndGesture:
         ^
2 errors generated.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667947</commentid>
    <comment_count>10</comment_count>
    <who name="Tony Chang">tony</who>
    <bug_when>2012-07-12 10:29:55 -0700</bug_when>
    <thetext>Reverted r122477 for reason:

Broke Chromium Mac build

Committed r122479: &lt;http://trac.webkit.org/changeset/122479&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668025</commentid>
    <comment_count>11</comment_count>
    <who name="Mark Mentovai">mark</who>
    <bug_when>2012-07-12 11:31:11 -0700</bug_when>
    <thetext>Robert, at least for this patch, please use MAC_OS_X_VERSION_MAX_ALLOWED (without the two leading underscores) from &lt;AvailabilityMacros.h&gt; when testing for the 10.5 SDK. __MAC_OS_X_VERSION_MAX_ALLOWED (with the two leading underscores) is defined incorrectly in this SDK. See http://lists.webkit.org/pipermail/webkit-dev/2012-July/021442.html.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668050</commentid>
    <comment_count>12</comment_count>
      <attachid>152014</attachid>
    <who name="Robert Sesek">rsesek</who>
    <bug_when>2012-07-12 11:53:20 -0700</bug_when>
    <thetext>Created attachment 152014
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668052</commentid>
    <comment_count>13</comment_count>
    <who name="Robert Sesek">rsesek</who>
    <bug_when>2012-07-12 11:54:07 -0700</bug_when>
    <thetext>Okay, updated patch uploaded, per comment 12. Also removed unnecessary #include.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668142</commentid>
    <comment_count>14</comment_count>
      <attachid>152014</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-12 13:19:20 -0700</bug_when>
    <thetext>Comment on attachment 152014
Patch

Clearing flags on attachment: 152014

Committed r122496: &lt;http://trac.webkit.org/changeset/122496&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>668144</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-07-12 13:19:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>151971</attachid>
            <date>2012-07-12 09:24:31 -0700</date>
            <delta_ts>2012-07-12 09:30:16 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-91103-20120712122430.patch</filename>
            <type>text/plain</type>
            <size>2149</size>
            <attacher name="Robert Sesek">rsesek</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IGU3M2VjOTU0YmMxOWM1ZWE0NTA2MmRkYmM1ZGQ1NDkwNjRjZDhlNDAuLjExZGI0MzIyOTVkNDZh
NmQ3ZDBjMTJmMTlkNjBkZjUxMGUyYzc2MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTIgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXVtNYWNdIHIxMjI0MDAgYnJva2UgMTAuNiBidWls
ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTExMDMK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhl
IHJpZ2h0IGF2YWlsYWJpbGl0eSBtYWNyb3MgZm9yIGZvcndhcmQtZGVjbGFyaW5nIG1ldGhvZHMg
YW5kCisJZGVmaW5pbmcgY29uc3RhbnRzLgorCisgICAgICAgICogc3JjL21hYy9XZWJJbnB1dEV2
ZW50RmFjdG9yeS5tbToKKwogMjAxMi0wNy0xMSAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29t
PgogCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzkxMDE1PiBSZW1vdmUgQlVJTERJTkdf
T04gLyBUQVJHRVRJTkcgbWFjcm9zIGluIGZhdm9yIG9mIHN5c3RlbSBhdmFpbGFiaWxpdHkgbWFj
cm9zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2ViSW5wdXRF
dmVudEZhY3RvcnkubW0gYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2ViSW5wdXRF
dmVudEZhY3RvcnkubW0KaW5kZXggZjU0MWVmNjZmYjM2MTY2Yzc2ZmU5YjNjZGQyYTI5YWI1N2Iz
Mzk3OS4uMzVlNDY0MWFkMTQ3MmE2OWM5OTY0NWVkZTA4NjczOTA4ZGM0MTc1NyAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYklucHV0RXZlbnRGYWN0b3J5Lm1t
CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJJbnB1dEV2ZW50RmFjdG9y
eS5tbQpAQCAtMjgsMTMgKzI4LDE0IEBACiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudEZhY3Rvcnku
aCIKIAogI2luY2x1ZGUgPEFwcGxpY2F0aW9uU2VydmljZXMvQXBwbGljYXRpb25TZXJ2aWNlcy5o
PgorI2luY2x1ZGUgPEF2YWlsYWJpbGl0eS5oPgogI2ltcG9ydCA8Q29jb2EvQ29jb2EuaD4KIAog
I2ltcG9ydCAiS2V5RXZlbnRDb2NvYS5oIgogI2luY2x1ZGUgIldlYklucHV0RXZlbnQuaCIKICNp
bmNsdWRlIDx3dGYvQVNDSUlDVHlwZS5oPgogCi0jaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S
RVFVSVJFRCA8PSAxMDYwCisjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEIDwgMTA3
MAogCiAvLyBBZGRpdGlvbmFsIExpb24gQVBJcy4KIGVudW0gewpAQCAtNTMsOSArNTQsOSBAQCB0
eXBlZGVmIE5TVUludGVnZXIgTlNFdmVudFBoYXNlOwogLSAoTlNFdmVudFBoYXNlKW1vbWVudHVt
UGhhc2U7CiBAZW5kCiAKLSNlbmRpZiAgLy8gX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJF
RCA8PSAxMDYwCisjZW5kaWYgIC8vIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA8IDEw
NzAKIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPT0gMTA1MAorI2lmIF9f
TUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA8PSAxMDUwCiAKIC8vIFRoZXNlIGFyZSBub3Qg
ZGVmaW5lZCBpbiB0aGUgMTAuNSBTREsgYnV0IGFyZSBkZWZpbmVkIGluIGxhdGVyIFNES3MgaW5z
aWRlCiAvLyBhIE1BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gTUFDX09TX1hfVkVSU0lP
Tl8xMF81ICNpZmRlZi4KQEAgLTY0LDcgKzY1LDcgQEAgZW51bSB7CiAgICAgTlNFdmVudFR5cGVF
bmRHZXN0dXJlICAgICAgID0gMjAKIH07CiAKLSNlbmRpZiAgLy8gX19NQUNfT1NfWF9WRVJTSU9O
X01JTl9SRVFVSVJFRCA9PSAxMDUwCisjZW5kaWYgIC8vIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhf
QUxMT1dFRCA8PSAxMDUwCiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>151973</attachid>
            <date>2012-07-12 09:30:21 -0700</date>
            <delta_ts>2012-07-12 11:53:14 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-91103-20120712123020.patch</filename>
            <type>text/plain</type>
            <size>2156</size>
            <attacher name="Robert Sesek">rsesek</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IGU3M2VjOTU0YmMxOWM1ZWE0NTA2MmRkYmM1ZGQ1NDkwNjRjZDhlNDAuLjViNWJkYmJhZmIyNmIx
MGViMDg3NTU4YjczNGFlZjMwZmQ5N2MzYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTIgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXVtNYWNdIHIxMjI0MDAgYnJva2UgMTAuNiBidWls
ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTExMDMK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhl
IHJpZ2h0IGF2YWlsYWJpbGl0eSBtYWNyb3MgZm9yIGZvcndhcmQtZGVjbGFyaW5nIG1ldGhvZHMg
YW5kCisgICAgICAgIGRlZmluaW5nIGNvbnN0YW50cy4KKworICAgICAgICAqIHNyYy9tYWMvV2Vi
SW5wdXRFdmVudEZhY3RvcnkubW06CisKIDIwMTItMDctMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFw
cGxlLmNvbT4KIAogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi85MTAxNT4gUmVtb3ZlIEJV
SUxESU5HX09OIC8gVEFSR0VUSU5HIG1hY3JvcyBpbiBmYXZvciBvZiBzeXN0ZW0gYXZhaWxhYmls
aXR5IG1hY3JvcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dl
YklucHV0RXZlbnRGYWN0b3J5Lm1tIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dl
YklucHV0RXZlbnRGYWN0b3J5Lm1tCmluZGV4IGY1NDFlZjY2ZmIzNjE2NmM3NmZlOWIzY2RkMmEy
OWFiNTdiMzM5NzkuLjM1ZTQ2NDFhZDE0NzJhNjljOTk2NDVlZGUwODY3MzkwOGRjNDE3NTcgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJJbnB1dEV2ZW50RmFj
dG9yeS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2ViSW5wdXRFdmVu
dEZhY3RvcnkubW0KQEAgLTI4LDEzICsyOCwxNCBAQAogI2luY2x1ZGUgIldlYklucHV0RXZlbnRG
YWN0b3J5LmgiCiAKICNpbmNsdWRlIDxBcHBsaWNhdGlvblNlcnZpY2VzL0FwcGxpY2F0aW9uU2Vy
dmljZXMuaD4KKyNpbmNsdWRlIDxBdmFpbGFiaWxpdHkuaD4KICNpbXBvcnQgPENvY29hL0NvY29h
Lmg+CiAKICNpbXBvcnQgIktleUV2ZW50Q29jb2EuaCIKICNpbmNsdWRlICJXZWJJbnB1dEV2ZW50
LmgiCiAjaW5jbHVkZSA8d3RmL0FTQ0lJQ1R5cGUuaD4KIAotI2lmIF9fTUFDX09TX1hfVkVSU0lP
Tl9NSU5fUkVRVUlSRUQgPD0gMTA2MAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dF
RCA8IDEwNzAKIAogLy8gQWRkaXRpb25hbCBMaW9uIEFQSXMuCiBlbnVtIHsKQEAgLTUzLDkgKzU0
LDkgQEAgdHlwZWRlZiBOU1VJbnRlZ2VyIE5TRXZlbnRQaGFzZTsKIC0gKE5TRXZlbnRQaGFzZSlt
b21lbnR1bVBoYXNlOwogQGVuZAogCi0jZW5kaWYgIC8vIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f
UkVRVUlSRUQgPD0gMTA2MAorI2VuZGlmICAvLyBfX01BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9X
RUQgPCAxMDcwCiAKLSNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID09IDEwNTAK
KyNpZiBfX01BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPD0gMTA1MAogCiAvLyBUaGVzZSBh
cmUgbm90IGRlZmluZWQgaW4gdGhlIDEwLjUgU0RLIGJ1dCBhcmUgZGVmaW5lZCBpbiBsYXRlciBT
REtzIGluc2lkZQogLy8gYSBNQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEID49IE1BQ19PU19Y
X1ZFUlNJT05fMTBfNSAjaWZkZWYuCkBAIC02NCw3ICs2NSw3IEBAIGVudW0gewogICAgIE5TRXZl
bnRUeXBlRW5kR2VzdHVyZSAgICAgICA9IDIwCiB9OwogCi0jZW5kaWYgIC8vIF9fTUFDX09TX1hf
VkVSU0lPTl9NSU5fUkVRVUlSRUQgPT0gMTA1MAorI2VuZGlmICAvLyBfX01BQ19PU19YX1ZFUlNJ
T05fTUFYX0FMTE9XRUQgPD0gMTA1MAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>152014</attachid>
            <date>2012-07-12 11:53:20 -0700</date>
            <delta_ts>2012-07-12 13:19:20 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-91103-20120712145318.patch</filename>
            <type>text/plain</type>
            <size>2138</size>
            <attacher name="Robert Sesek">rsesek</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No
cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4
IGU3M2VjOTU0YmMxOWM1ZWE0NTA2MmRkYmM1ZGQ1NDkwNjRjZDhlNDAuLjViNWJkYmJhZmIyNmIx
MGViMDg3NTU4YjczNGFlZjMwZmQ5N2MzYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy
b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA
IC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTIgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1
bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXVtNYWNdIHIxMjI0MDAgYnJva2UgMTAuNiBidWls
ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTExMDMK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhl
IHJpZ2h0IGF2YWlsYWJpbGl0eSBtYWNyb3MgZm9yIGZvcndhcmQtZGVjbGFyaW5nIG1ldGhvZHMg
YW5kCisgICAgICAgIGRlZmluaW5nIGNvbnN0YW50cy4KKworICAgICAgICAqIHNyYy9tYWMvV2Vi
SW5wdXRFdmVudEZhY3RvcnkubW06CisKIDIwMTItMDctMTEgIE1hcmsgUm93ZSAgPG1yb3dlQGFw
cGxlLmNvbT4KIAogICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi85MTAxNT4gUmVtb3ZlIEJV
SUxESU5HX09OIC8gVEFSR0VUSU5HIG1hY3JvcyBpbiBmYXZvciBvZiBzeXN0ZW0gYXZhaWxhYmls
aXR5IG1hY3JvcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dl
YklucHV0RXZlbnRGYWN0b3J5Lm1tIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dl
YklucHV0RXZlbnRGYWN0b3J5Lm1tCmluZGV4IGY1NDFlZjY2ZmIzNjE2NmM3NmZlOWIzY2RkMmEy
OWFiNTdiMzM5NzkuLmUxYjk0YTY0MDQyN2NmM2ViYzgzYzY3Nzc4MmYxMDhlOTlmMzM4MjkgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJJbnB1dEV2ZW50RmFj
dG9yeS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2ViSW5wdXRFdmVu
dEZhY3RvcnkubW0KQEAgLTM0LDcgKzM0LDcgQEAKICNpbmNsdWRlICJXZWJJbnB1dEV2ZW50Lmgi
CiAjaW5jbHVkZSA8d3RmL0FTQ0lJQ1R5cGUuaD4KIAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9N
SU5fUkVRVUlSRUQgPD0gMTA2MAorI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NQVhfQUxMT1dFRCA8
IDEwNzAKIAogLy8gQWRkaXRpb25hbCBMaW9uIEFQSXMuCiBlbnVtIHsKQEAgLTUzLDkgKzUzLDEx
IEBAIHR5cGVkZWYgTlNVSW50ZWdlciBOU0V2ZW50UGhhc2U7CiAtIChOU0V2ZW50UGhhc2UpbW9t
ZW50dW1QaGFzZTsKIEBlbmQKIAotI2VuZGlmICAvLyBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JF
UVVJUkVEIDw9IDEwNjAKKyNlbmRpZiAgLy8gX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VE
IDwgMTA3MAogCi0jaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA9PSAxMDUwCisv
LyBEbyBub3QgX19NQUNfT1NfWF9WRVJTSU9OX01BWF9BTExPV0VEIGhlcmUgYmVjYXVzZSBvZiBh
IGJ1ZyBpbiB0aGUgMTAuNSBTREssCisvLyBzZWUgPGh0dHA6Ly9saXN0cy53ZWJraXQub3JnL3Bp
cGVybWFpbC93ZWJraXQtZGV2LzIwMTItSnVseS8wMjE0NDIuaHRtbD4uCisjaWYgTUFDX09TX1hf
VkVSU0lPTl9NQVhfQUxMT1dFRCA8PSAxMDUwCiAKIC8vIFRoZXNlIGFyZSBub3QgZGVmaW5lZCBp
biB0aGUgMTAuNSBTREsgYnV0IGFyZSBkZWZpbmVkIGluIGxhdGVyIFNES3MgaW5zaWRlCiAvLyBh
IE1BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPj0gTUFDX09TX1hfVkVSU0lPTl8xMF81ICNp
ZmRlZi4KQEAgLTY0LDcgKzY2LDcgQEAgZW51bSB7CiAgICAgTlNFdmVudFR5cGVFbmRHZXN0dXJl
ICAgICAgID0gMjAKIH07CiAKLSNlbmRpZiAgLy8gX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV
SVJFRCA9PSAxMDUwCisjZW5kaWYgIC8vIE1BQ19PU19YX1ZFUlNJT05fTUFYX0FMTE9XRUQgPD0g
MTA1MAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>