<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>91102</bug_id>
          
          <creation_ts>2012-07-12 09:10:43 -0700</creation_ts>
          <short_desc>[Chromium] Support running Android-specific layout tests</short_desc>
          <delta_ts>2012-08-13 05:24:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>66687</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Leandro Graciá Gil">leandrogracia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>leandrogracia</cc>
    
    <cc>peter</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>667845</commentid>
    <comment_count>0</comment_count>
    <who name="Leandro Graciá Gil">leandrogracia</who>
    <bug_when>2012-07-12 09:10:43 -0700</bug_when>
    <thetext>Perform the required changes to support the chromium-android platform in the test infrastructure so we can run Android-specific layout tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667863</commentid>
    <comment_count>1</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-12 09:29:55 -0700</bug_when>
    <thetext>Can you give an example of an Android-specific LayoutTest?  Typically, we&apos;d just put the LayoutTest in the http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-android directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667866</commentid>
    <comment_count>2</comment_count>
    <who name="Leandro Graciá Gil">leandrogracia</who>
    <bug_when>2012-07-12 09:35:07 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; Can you give an example of an Android-specific LayoutTest?  Typically, we&apos;d just put the LayoutTest in the http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-android directory.

I&apos;m afraid I don&apos;t have anything ready to be uploaded yet, but I mean any layout tests that work with WebKit API features that are guarded by the ANDROID macro.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>667873</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-07-12 09:40:33 -0700</bug_when>
    <thetext>&gt; I&apos;m afraid I don&apos;t have anything ready to be uploaded yet, but I mean any layout tests that work with WebKit API features that are guarded by the ANDROID macro.

Typically, LayoutTests don&apos;t work with the WebKit API, they work with the web platform API.  Also, we generally don&apos;t guard things in the Chromium WebKit API with OS-specific macros.

I&apos;m happy to look in the chromium-android branch if there are examples there that aren&apos;t ready to be uploaded yet.  I should be clear that I&apos;m not opposed to this idea.  I&apos;m just seeking to understand the motivation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>693562</commentid>
    <comment_count>4</comment_count>
    <who name="Leandro Graciá Gil">leandrogracia</who>
    <bug_when>2012-08-13 05:24:54 -0700</bug_when>
    <thetext>It seems that this was not required after all. Instead of layout tests WebKit unit tests have been used for the case I was considering (bug 93111).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>