91098 2012-07-12 08:28:02 -0700 [BlackBerry] WebPage::executeJavaScriptFunction crashes when there is an exception 2012-07-12 10:11:24 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ben webkit-unassigned manyoso mifenton tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 667801 0 ben 2012-07-12 08:28:02 -0700 When there is an exception currently the code tries to get the string of the exception via JSValueToStringCopy to pass back, but this cases a crash inside JavaScriptCore, so change it to simply return false and not set the return value with the exception string. 667843 1 151968 ben 2012-07-12 09:07:36 -0700 Created attachment 151968 patch 667849 2 ben 2012-07-12 09:18:09 -0700 For the curious, here is the BT for the crash #0 isString (this=0x0) at /home/bmeyer/git/qnx/webkit/Source/JavaScriptCore/runtime/JSCell.cpp:215 #1 JSC::JSCell::toPrimitive (this=0x0, exec=0x82bfcb0, preferredType=JSC::PreferString) at /home/bmeyer/git/qnx/webkit/Source/JavaScriptCore/runtime/JSCell.cpp:138 #2 0xbb3139be in JSC::JSValue::toStringSlowCase (this=0x7bc1c84, exec=0x82bfcb0) at /home/bmeyer/git/qnx/webkit/Source/JavaScriptCore/runtime/JSValue.cpp:279 #3 0xbb291d36 in toString (exec=0x82bfcb0, this=0x7bc1c84) at /home/bmeyer/git/qnx/webkit/Source/JavaScriptCore/runtime/JSString.h:495 #4 JSValueToStringCopy (ctx=0x82bfcb0, value=0x0, exception=0x0) at /home/bmeyer/git/qnx/webkit/Source/JavaScriptCore/API/JSValueRef.cpp:296 #5 0xb9db1d8e in BlackBerry::WebKit::WebPage::executeJavaScriptFunction (this=0x81e6e90, function=..., args=..., returnType=@0x7bc1d5c: BlackBerry::WebKit::JSException, returnValue=...) 667920 3 151968 webkit.review.bot 2012-07-12 10:11:15 -0700 Comment on attachment 151968 patch Clearing flags on attachment: 151968 Committed r122476: <http://trac.webkit.org/changeset/122476> 667921 4 webkit.review.bot 2012-07-12 10:11:24 -0700 All reviewed patches have been landed. Closing bug. 151968 2012-07-12 09:07:36 -0700 2012-07-12 10:11:15 -0700 patch 0001-2012-07-12-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 3241 ben RnJvbSBiNmFhYmJiYzg3MjhmMjgzYmFhODQ5Mzk2YjRmZTQ2YWYwMzhiMTc3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogVGh1LCAxMiBKdWwgMjAxMiAxMToyODowMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTIt MDctMTIgIEJlbmphbWluIEMgTWV5ZXIgIDxibWV5ZXJAcmltLmNvbT4KCiAgICAgICAgV2ViUGFn ZTo6ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbiBjcmFzaGVzIHdoZW4gdGhlcmUgaXMgYW4gZXhj ZXB0aW9uCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkx MDk4CiAgICAgICAgUklNIFBSICMxNDkyOTQKCiAgICAgICAgV2hlbiB0aGVyZSBpcyBhbiBleGNl cHRpb24gY3VycmVudGx5IHRoZSBjb2RlIHRyaWVzIHRvIGdldCB0aGUgc3RyaW5nIG9mCiAgICAg ICAgdGhlIGV4Y2VwdGlvbiB2aWEgSlNWYWx1ZVRvU3RyaW5nQ29weSB0byBwYXNzIGJhY2ssIGJ1 dCB0aGlzIGNhc2VzIGEKICAgICAgICBjcmFzaCBpbnNpZGUgSmF2YVNjcmlwdENvcmUsIHNvIGNo YW5nZSBpdCB0byBzaW1wbHkgcmV0dXJuIGZhbHNlIGFuZCBub3QKICAgICAgICBzZXQgdGhlIHJl dHVybiB2YWx1ZSB3aXRoIHRoZSBleGNlcHRpb24gc3RyaW5nLgoKICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CiAgICAgICAgKEJs YWNrQmVycnk6OldlYktpdDo6V2ViUGFnZTo6ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbik6Ci0t LQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCB8ICAgIDggKy0tLS0t LS0KIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgfCAgIDE2ICsrKysr KysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2Uu Y3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCA3NDk0 NDE5Li4xYTc4MGI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAK QEAgLTg5Nyw5ICs4OTcsOCBAQCBib29sIFdlYlBhZ2U6OmV4ZWN1dGVKYXZhU2NyaXB0RnVuY3Rp b24oY29uc3Qgc3RkOjp2ZWN0b3I8c3RkOjpzdHJpbmc+ICZmdW5jdGlvbgogCiAgICAgSlNPYmpl Y3RSZWYgZnVuY3Rpb25PYmplY3QgPSBvYmo7CiAgICAgSlNWYWx1ZVJlZiByZXN1bHQgPSAwOwot ICAgIEpTVmFsdWVSZWYgZXhjZXB0aW9uOwogICAgIGlmIChmdW5jdGlvbk9iamVjdCAmJiB0aGlz T2JqZWN0KQotICAgICAgICByZXN1bHQgPSBKU09iamVjdENhbGxBc0Z1bmN0aW9uKGN0eCwgZnVu Y3Rpb25PYmplY3QsIHRoaXNPYmplY3QsIGFyZ3Muc2l6ZSgpLCBhcmdMaXN0UmVmLmRhdGEoKSwg JmV4Y2VwdGlvbik7CisgICAgICAgIHJlc3VsdCA9IEpTT2JqZWN0Q2FsbEFzRnVuY3Rpb24oY3R4 LCBmdW5jdGlvbk9iamVjdCwgdGhpc09iamVjdCwgYXJncy5zaXplKCksIGFyZ0xpc3RSZWYuZGF0 YSgpLCAwKTsKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBhcmdzLnNpemUoKTsgKytp KQogICAgICAgICBKU1N0cmluZ1JlbGVhc2UoYXJnTGlzdFtpXSk7CkBAIC05MDgsMTEgKzkwNyw2 IEBAIGJvb2wgV2ViUGFnZTo6ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbihjb25zdCBzdGQ6OnZl Y3RvcjxzdGQ6OnN0cmluZz4gJmZ1bmN0aW9uCiAKICAgICBpZiAoIXZhbHVlKSB7CiAgICAgICAg IHJldHVyblR5cGUgPSBKU0V4Y2VwdGlvbjsKLSAgICAgICAgSlNTdHJpbmdSZWYgc3RyaW5nUmVm ID0gSlNWYWx1ZVRvU3RyaW5nQ29weShjdHgsIGV4Y2VwdGlvbiwgMCk7Ci0gICAgICAgIHNpemVf dCBidWZmZXJTaXplID0gSlNTdHJpbmdHZXRNYXhpbXVtVVRGOENTdHJpbmdTaXplKHN0cmluZ1Jl Zik7Ci0gICAgICAgIFdURjo6VmVjdG9yPGNoYXI+IGJ1ZmZlcihidWZmZXJTaXplKTsKLSAgICAg ICAgSlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhzdHJpbmdSZWYsIGJ1ZmZlci5kYXRhKCksIGJ1ZmZl clNpemUpOwotICAgICAgICByZXR1cm5WYWx1ZSA9IFdlYlN0cmluZzo6ZnJvbVV0ZjgoYnVmZmVy LmRhdGEoKSk7CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvQ2hhbmdlTG9nCmluZGV4IDdlZTUzMTkuLmI2NjAyMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA3LTEyICBCZW5qYW1pbiBDIE1leWVy ICA8Ym1leWVyQHJpbS5jb20+CisKKyAgICAgICAgV2ViUGFnZTo6ZXhlY3V0ZUphdmFTY3JpcHRG dW5jdGlvbiBjcmFzaGVzIHdoZW4gdGhlcmUgaXMgYW4gZXhjZXB0aW9uCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTA5OAorICAgICAgICBSSU0gUFIg IzE0OTI5NAorCisgICAgICAgIFdoZW4gdGhlcmUgaXMgYW4gZXhjZXB0aW9uIGN1cnJlbnRseSB0 aGUgY29kZSB0cmllcyB0byBnZXQgdGhlIHN0cmluZyBvZgorICAgICAgICB0aGUgZXhjZXB0aW9u IHZpYSBKU1ZhbHVlVG9TdHJpbmdDb3B5IHRvIHBhc3MgYmFjaywgYnV0IHRoaXMgY2FzZXMgYQor ICAgICAgICBjcmFzaCBpbnNpZGUgSmF2YVNjcmlwdENvcmUsIHNvIGNoYW5nZSBpdCB0byBzaW1w bHkgcmV0dXJuIGZhbHNlIGFuZCBub3QKKyAgICAgICAgc2V0IHRoZSByZXR1cm4gdmFsdWUgd2l0 aCB0aGUgZXhjZXB0aW9uIHN0cmluZy4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6 OldlYktpdDo6V2ViUGFnZTo6ZXhlY3V0ZUphdmFTY3JpcHRGdW5jdGlvbik6CisKIDIwMTItMDct MDQgIEhhbm5hIE1hICA8SGFubWFAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gSW1w bGVtZW50IGRldmljZSBtZXRyaWNzIGZvciBibGFja2JlcnJ5LgotLSAKMS43LjEKCg==