9109 2006-05-25 10:16:47 -0700 Remove bogus assertion in RenderBlock::tabWidth 2006-05-31 23:25:12 -0700 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mitz webkit-unassigned oldest_to_newest 43548 0 mitz 2006-05-25 10:16:47 -0700 If the font's space width is 0 (which can happen with a very small font) then it's OK for the tab width to also be 0. See attachment 8485 (bug 9062). Since 0 is a valid value, the uninitialized value should be something else. 43549 1 8541 mitz 2006-05-25 10:19:27 -0700 Created attachment 8541 Remove the assert and change the uninitialized value to -1 No layout test since DumpRenderTree forces a minimum font size. 43564 2 8541 ggaren 2006-05-25 11:44:36 -0700 Comment on attachment 8541 Remove the assert and change the uninitialized value to -1 r=me 8541 2006-05-25 10:19:27 -0700 2006-05-25 11:44:36 -0700 Remove the assert and change the uninitialized value to -1 9109_r1.patch text/plain 2185 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNDU4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDYtIyMtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdA bWl0enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgLSBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lk PTkxMDkKKyAgICAgICAgICBSZW1vdmUgYm9ndXMgYXNzZXJ0aW9uIGluIFJlbmRlckJsb2NrOjp0 YWJXaWR0aAorCisgICAgICAgIENoYW5nZWQgdGhlIHVuaW5pdGlhbGl6ZWQgdmFsdWUgb2YgbV90 YWJXaWR0aCB0byAtMSBhbmQgcmVtb3ZlZCB0aGUKKyAgICAgICAgYXNzZXJ0aW9uIHRoYXQgaXQg Y2Fubm90IGJlIDAuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwOgorICAg ICAgICAoV2ViQ29yZTo6OlJlbmRlckJsb2NrOjpSZW5kZXJCbG9jayk6CisgICAgICAgIChXZWJD b3JlOjpSZW5kZXJCbG9jazo6c2V0U3R5bGUpOgorICAgICAgICAqIHJlbmRlcmluZy9iaWRpLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjp0YWJXaWR0aCk6CisKIDIwMDYtMDUt MjQgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBm b250IGFsaWFzaW5nIG9mIGZhbWlseSBuYW1lcyBmb3IgQ291cmllci9Db3VyaWVyIE5ldywKSW5k ZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHJldmlzaW9uIDE0NTg0KQorKysgV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MSw3ICs5MSw3 IEBAIFJlbmRlckJsb2NrOjpSZW5kZXJCbG9jayhXZWJDb3JlOjpOb2RlKiAKICAgICBtX3RvcE1h cmdpblF1aXJrID0gbV9ib3R0b21NYXJnaW5RdWlyayA9IGZhbHNlOwogICAgIG1fb3ZlcmZsb3dI ZWlnaHQgPSBtX292ZXJmbG93V2lkdGggPSAwOwogICAgIG1fb3ZlcmZsb3dMZWZ0ID0gbV9vdmVy Zmxvd1RvcCA9IDA7Ci0gICAgbV90YWJXaWR0aCA9IDA7CisgICAgbV90YWJXaWR0aCA9IC0xOwog fQogCiBSZW5kZXJCbG9jazo6flJlbmRlckJsb2NrKCkKQEAgLTEyMiw3ICsxMjIsNyBAQCB2b2lk IFJlbmRlckJsb2NrOjpzZXRTdHlsZShSZW5kZXJTdHlsZSogCiAgICAgfQogCiAgICAgbV9saW5l SGVpZ2h0ID0gLTE7Ci0gICAgbV90YWJXaWR0aCA9IDA7CisgICAgbV90YWJXaWR0aCA9IC0xOwog CiAgICAgLy8gVXBkYXRlIHBzZXVkb3MgZm9yIDpiZWZvcmUgYW5kIDphZnRlciBub3cuCiAgICAg UmVuZGVyT2JqZWN0KiBmaXJzdCA9IGZpcnN0Q2hpbGQoKTsKSW5kZXg6IFdlYkNvcmUvcmVuZGVy aW5nL2JpZGkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL2JpZGkuY3BwCShy ZXZpc2lvbiAxNDU4NCkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL2JpZGkuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC04NDMsMTIgKzg0MywxMSBAQCBpbnQgUmVuZGVyQmxvY2s6OnRhYldpZHRoKGJvb2wg aXNXaGl0ZXNwCiAgICAgaWYgKCFpc1doaXRlc3BhY2VQcmUpCiAgICAgICAgIHJldHVybiAwOwog Ci0gICAgaWYgKCFtX3RhYldpZHRoKSB7CisgICAgaWYgKG1fdGFiV2lkdGggPT0gLTEpIHsKICAg ICAgICAgY29uc3QgVUNoYXIgc3BhY2VDaGFyID0gJyAnOwogICAgICAgICBjb25zdCBGb250JiBm b250ID0gc3R5bGUoKS0+Zm9udCgpOwogICAgICAgICBpbnQgc3BhY2VXaWR0aCA9IGZvbnQud2lk dGgoVGV4dFJ1bigmc3BhY2VDaGFyLCAxKSk7CiAgICAgICAgIG1fdGFiV2lkdGggPSBzcGFjZVdp ZHRoICogODsKLSAgICAgICAgYXNzZXJ0KG1fdGFiV2lkdGggIT0gMCk7CiAgICAgfQogCiAgICAg cmV0dXJuIG1fdGFiV2lkdGg7Cg==