91067 2012-07-12 03:15:54 -0700 [Chromium] Remove unrequired API in WebSurroundingText 2012-07-12 08:31:22 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 leandrogracia leandrogracia abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 667583 0 leandrogracia 2012-07-12 03:15:54 -0700 Currently WebSurroundingText provides two different but very similar initialize methods. The first was used by Chromium, which recently moved to the second one (changeset 146154). Consequently, both layout tests and Chromium now use the same API (2nd) and the old one (1st) can be safely removed. 667625 1 151909 leandrogracia 2012-07-12 04:34:26 -0700 Created attachment 151909 Patch 667628 2 webkit.review.bot 2012-07-12 04:36:34 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 667806 3 151909 webkit.review.bot 2012-07-12 08:31:12 -0700 Comment on attachment 151909 Patch Clearing flags on attachment: 151909 Committed r122461: <http://trac.webkit.org/changeset/122461> 667807 4 webkit.review.bot 2012-07-12 08:31:22 -0700 All reviewed patches have been landed. Closing bug. 151909 2012-07-12 04:34:26 -0700 2012-07-12 08:31:12 -0700 Patch bug-91067-20120712123421.patch text/plain 2849 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGU3M2VjOTU0YmMxOWM1ZWE0NTA2MmRkYmM1ZGQ1NDkwNjRjZDhlNDAuLjcxNGYzYWFlOTRkMGMw NTg5Yzc1NmRmZDE4ODMxMGU5YjhhMmJiYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDctMTIgIExlYW5kcm8gR3JhY2lhIEdpbCAgPGxlYW5kcm9n cmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gUmVtb3ZlIHVucmVxdWly ZWQgQVBJIGluIFdlYlN1cnJvdW5kaW5nVGV4dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkxMDY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHRoZSB1bnVzZWQgZmlyc3QgaW5pdGlhbGl6ZSBt ZXRob2QgZnJvbSBXZWJTdXJyb3VuZGluZ1RleHQuCisgICAgICAgIE5vdyBib3RoIENocm9taXVt IGFuZCBMYXlvdXRUZXN0Q29udHJvbGxlciB1c2UgdGhlIHNlY29uZCBtZXRob2QuCisKKyAgICAg ICAgKiBwdWJsaWMvV2ViU3Vycm91bmRpbmdUZXh0Lmg6CisgICAgICAgIChXZWJTdXJyb3VuZGlu Z1RleHQpOgorICAgICAgICAqIHNyYy9XZWJTdXJyb3VuZGluZ1RleHQuY3BwOgorCiAyMDEyLTA3 LTExICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgPGh0dHA6Ly93ZWJr aXQub3JnL2IvOTEwMTU+IFJlbW92ZSBCVUlMRElOR19PTiAvIFRBUkdFVElORyBtYWNyb3MgaW4g ZmF2b3Igb2Ygc3lzdGVtIGF2YWlsYWJpbGl0eSBtYWNyb3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlN1cnJvdW5kaW5nVGV4dC5oIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS9wdWJsaWMvV2ViU3Vycm91bmRpbmdUZXh0LmgKaW5kZXggNzE2ZmU0ZjBjYjM4 NmY1MTQxYWM5MTdiMDk4MTNkMzE1MzE3ODA2OC4uZmE4YzUyZmYwZGQzMjAwZmJhNTAxNTE0YWI4 MTllNDgzZGE1ZTI0YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViU3Vycm91bmRpbmdUZXh0LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViU3Vycm91bmRpbmdUZXh0LmgKQEAgLTQ4LDEwICs0OCw2IEBAIHB1YmxpYzoKICAgICBXRUJL SVRfRVhQT1JUIGJvb2wgaXNOdWxsKCkgY29uc3Q7CiAgICAgV0VCS0lUX0VYUE9SVCB2b2lkIHJl c2V0KCk7CiAKLSAgICAvLyBJbml0aWFsaXplcyB0aGUgb2JqZWN0IGdvIGdldCB0aGUgc3Vycm91 bmRpbmcgdGV4dCBjZW50ZXJlZCBpbiB0aGUgcG9zaXRpb24gZGVzY3JpYmVkIGJ5IHRoZSBoaXQg dGVzdC4KLSAgICAvLyBUaGUgbWF4aW11bSBsZW5ndGggb2YgdGhlIGNvbnRlbnRzIHJldHJpZXZl ZCBpcyBkZWZpbmVkIGJ5IG1heExlbmd0aC4KLSAgICBXRUJLSVRfRVhQT1JUIHZvaWQgaW5pdGlh bGl6ZShjb25zdCBXZWJIaXRUZXN0UmVzdWx0Jiwgc2l6ZV90IG1heExlbmd0aCk7Ci0KICAgICAv LyBJbml0aWFsaXplcyB0aGUgb2JqZWN0IHRvIGdldCB0aGUgc3Vycm91bmRpbmcgdGV4dCBjZW50 ZXJlZCBpbiB0aGUgcG9zaXRpb24gcmVsYXRpdmUgdG8gYSBwcm92aWRlZCBub2RlLgogICAgIC8v IFRoZSBtYXhpbXVtIGxlbmd0aCBvZiB0aGUgY29udGVudHMgcmV0cmlldmVkIGlzIGRlZmluZWQg YnkgbWF4TGVuZ3RoLgogICAgIFdFQktJVF9FWFBPUlQgdm9pZCBpbml0aWFsaXplKGNvbnN0IFdl Yk5vZGUmLCBjb25zdCBXZWJQb2ludCYsIHNpemVfdCBtYXhMZW5ndGgpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViU3Vycm91bmRpbmdUZXh0LmNwcCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlN1cnJvdW5kaW5nVGV4dC5jcHAKaW5kZXggZjg4MDY3 NmFlYWVhYjk0YWI4YzQ0Y2U4ZWY3ZmM5ZjdjYzgwOGYwMy4uNDVkYjNkMWJkMTA2ZjA3YTkxZmQ0 NjZjZWU1NjYxY2U2YTViYzIzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViU3Vycm91bmRpbmdUZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJTdXJyb3VuZGluZ1RleHQuY3BwCkBAIC00MCwxNSArNDAsNiBAQCB1c2luZyBuYW1lc3Bh Y2UgV2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLXZvaWQgV2ViU3Vycm91bmRpbmdU ZXh0Ojppbml0aWFsaXplKGNvbnN0IFdlYkhpdFRlc3RSZXN1bHQmIGhpdFRlc3RSZXN1bHQsIHNp emVfdCBtYXhMZW5ndGgpCi17Ci0gICAgTm9kZSogbm9kZSA9IGhpdFRlc3RSZXN1bHQubm9kZSgp LnVud3JhcDxOb2RlPigpOwotICAgIGlmICghbm9kZSB8fCAhbm9kZS0+cmVuZGVyZXIoKSkKLSAg ICAgICAgcmV0dXJuOwotCi0gICAgbV9wcml2YXRlLnJlc2V0KG5ldyBTdXJyb3VuZGluZ1RleHQo VmlzaWJsZVBvc2l0aW9uKG5vZGUtPnJlbmRlcmVyKCktPnBvc2l0aW9uRm9yUG9pbnQoc3RhdGlj X2Nhc3Q8SW50UG9pbnQ+KGhpdFRlc3RSZXN1bHQubG9jYWxQb2ludCgpKSkpLCBtYXhMZW5ndGgp KTsKLX0KLQogdm9pZCBXZWJTdXJyb3VuZGluZ1RleHQ6OmluaXRpYWxpemUoY29uc3QgV2ViTm9k ZSYgd2ViTm9kZSwgY29uc3QgV2ViUG9pbnQmIG5vZGVQb2ludCwgc2l6ZV90IG1heExlbmd0aCkK IHsKICAgICBjb25zdCBOb2RlKiBub2RlID0gd2ViTm9kZS5jb25zdFVud3JhcDxOb2RlPigpOwo=